wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-24 10:48:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not pass Message object to …DismissibleMessageWidget

Browse source 
I wanted to change this for quite a while now. It was discussed
again in Iff1d2c0.

Change-Id: Iaaac9bf91d9b11557ab068d2c719084c46b3ecb2
This commit is contained in:
Thiemo Kreuz 2021-09-02 11:03:16 +02:00 committed by WMDE-Fisch
parent fcffa07c2d
commit 3ee7a1f1ed
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
View file

@ -77,7 +77,7 @@ ve.ui.MWTemplatePlaceholderPage = function VeUiMWTemplatePlaceholderPage( placeh
// Temporary feedback message when templateSearchImprovements is true T284560
// TODO: remove when templateSearchImprovements are out of beta
var feedbackMessage = new ve.ui.MWDismissibleMessageWidget( {
message: mw.message( 'visualeditor-dialog-transclusion-feedback-message' )
messageKey: 'visualeditor-dialog-transclusion-feedback-message'
} )
.connect( this, { close: 'focus' } );

8
modules/ve-mw/ui/widgets/ve.ui.MWDismissibleMessageWidget.js
View file

@ -11,10 +11,11 @@
*
* @constructor
* @param {Object} config Configuration options
* @cfg {mw.Message} message Message to display
* @cfg {string} messageKey
*/
ve.ui.MWDismissibleMessageWidget = function VeUiMWDismissibleMessageWidget( config ) {
config.label = config.message.parseDom();
// eslint-disable-next-line mediawiki/msg-doc
config.label = mw.message( config.messageKey ).parseDom();
// Parent constructor
ve.ui.MWDismissibleMessageWidget.super.call( this, config );
@ -22,8 +23,7 @@ ve.ui.MWDismissibleMessageWidget = function VeUiMWDismissibleMessageWidget( conf
ve.targetLinksToNewWindow( this.$label[ 0 ] );
// Properties
this.messageKey = config.message.key;
delete config.message;
this.messageKey = config.messageKey;
var dismissButton = new OO.ui.ButtonWidget( {
icon: 'close',