wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-30 00:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
1809 commits 13 branches 17 tags 198 MiB
Commit graph

1809 commits

This branch
This branch
All branches
Author SHA1 Message Date
Catrope f83cdc4eaa Hack around Parsoid bug in link handling 
Parsoid ignores sHref when converting back to wikitext, so we have to
set the href attribute to "/$title"

Change-Id: I1068116c0be72197619d0df3b4d1231a3879fa14
 2012-06-13 18:53:13 -07:00
Catrope 9c939047be Fix return value of ve.ui.LinkInspector.getSelectedLinkAnnotations() 
Was returning a single annotation, but all callers were expecting an
object.

Change-Id: I55be083e5451f4ace5e54dfecb904ae53041054b
 2012-06-13 18:49:38 -07:00
Catrope 9d9c06f4e2 Merge branch 'dmrewrite' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor into dmrewrite 2012-06-13 18:31:05 -07:00
Catrope d0adb112c0 Needs copyArray instead of copyObject, d'oh 
Change-Id: Ic185d328a87579262458fe24fd01539c495f09a2
 2012-06-13 18:30:50 -07:00
Trevor Parscal 75ac5b03e6 Improved appearance of activating and deactivating editor 
Also prevented double-initializing

Change-Id: I9e64eb1f331489f6acee469fdab64133d817e7b1
 2012-06-13 18:26:21 -07:00
Trevor Parscal 31a2a0243a Removed duplicate update event on length change and cleaned up some methods that were being called by symbolic operation name 
Change-Id: Ica623d1c5619b8268eb97f631e09f9e2f5b67bf0
 2012-06-13 17:16:04 -07:00
Trevor Parscal e266905b94 Moved history tracking into a startable/stoppable service 
And made it not start on it's own, but be started by ve.Surface - this makes it so it's not polling in the unit tests, for instance

Change-Id: I940df04d392fd134d18847949efe0e2232328323
 2012-06-13 17:16:04 -07:00
Catrope efa93c24be Copy objects in newFromWrap() to prevent reference pollution 
Change-Id: Ia1f71341342bea44f6ca08088a1276d54187b22a
 2012-06-13 16:56:51 -07:00
Catrope 7dd65cda91 Add newFromWrap(), ported 98% verbatim from the old code 
Change-Id: I81fc74b1d23bc6b60e476bfefbae4d7d9a9bf5f6
 2012-06-13 16:17:23 -07:00
Catrope 0bc1693998 Fix partial undo of ab0c37 in 2ea103 
Change-Id: I42225802c45b3867a2aafd40e6941754b1b415b4
 2012-06-13 16:16:07 -07:00
Trevor Parscal 429225fb57 Whitespace fixes (jshint was tweaking out) 
Change-Id: Id75a097ae4958029caf0a0315343c2fab9c99b89
 2012-06-13 16:06:21 -07:00
Trevor Parscal 56c0f597cd Fixed use of "pre", "preformatted" is the correct symbolic name 
Change-Id: Ifc7e8e3291b8dd29a7fa4c42529bb4fd36a6ed9a
 2012-06-13 15:15:05 -07:00
Trevor Parscal 8cb5cbf75d Merge branch 'refs/heads/master' into dmrewrite 2012-06-13 15:00:44 -07:00
Trevor Parscal 84ce839ce5 Removed context menus on tear down of surface 
There needs to be a proper tear down system for ve at some point

Change-Id: I6454423ab96a15932695fbc5429d9e731acc9071
 2012-06-13 15:00:13 -07:00
Trevor Parscal 1628038bdb Using wikiLink instead of internal to match actual documents 
Change-Id: I24b9c0a5f27ed8f4a7861090ab4049c4614cea78
 2012-06-13 14:48:29 -07:00
Trevor Parscal 95c601c8e9 Make save dialog initially hidden 
Change-Id: I8fc4bd67f16266d9355fe639487728ad91ad6ede
 2012-06-13 14:44:39 -07:00
Trevor Parscal 169b7e754d Cleaned up toolbar annotation updates 
Change-Id: I8cefd6c871ed6d1ad71f64eb66236de1b8b719b5
 2012-06-13 14:31:46 -07:00
Rob Moen 26e0f6ed5f Real cross browser fix for invisible iframe bug. 
Change-Id: Ia2d3c83562542aaaddf0b81dfeaef9aa408aaed3
 2012-06-13 13:29:18 -07:00
Subramanya Sastry 51958e4c6a Removed unused parser pipeline construction 
Change-Id: Id2a7dde895b7c3fbf776a2035009686afd4301df
 2012-06-13 15:08:13 -05:00
Subramanya Sastry bf0f5d1b7e Minor code cleanup 
Change-Id: Ic5d99b6c483841310b0c295c1c30246f907455b4
 2012-06-13 13:47:26 -05:00
Subramanya Sastry 23ec054013 Fixed round-tripping of interwiki links. 
Change-Id: If0427b9865b3e9cf8c0ad0b4efaebc9f9f7fb865
 2012-06-13 13:39:18 -05:00
Subramanya Sastry 445780b4d3 Revert default tokenization result from null to '' 
* As part of an earlier fix, I had changed default value of 'res'
  to null instead of ''.  But, this was potentially buggy because
  the previous check was (res !== '') which could be triggered
  by return values of handlers.  By changing the check to null,
  I was effectively changing the code paths for those handlers that
  returned ''.

Change-Id: I2302023be7422ce4fb384ff5a50fe53fa7732855
 2012-06-13 11:53:05 -05:00
Subramanya Sastry cfe94eed1f Minor code refactoring 
Change-Id: Iec3cb4d83d16174371f0b1f3f23b1056aeed458e
 2012-06-13 09:46:34 -05:00
Catrope 6bf79475e4 Add suggested development configuration in comments 
Change-Id: I3ec8c5326faced6d4b5c878f26f37a281b03bd95
 2012-06-12 19:19:48 -07:00
Rob Moen a991cefbe7 Fix inspector close bug where iframe was blocking editor below 
Fix Inspector bug which prevented applying a link annotation to data
already containing annotations.

Change-Id: I6f315d50805c8c71f2155f955ea5674a7ce98656
 2012-06-12 13:52:42 -07:00
Rob Moen b843762d9e rewrite comment 
Change-Id: Ibc8aab4843ecc0211149aa673d312384e9bd668e
 2012-06-12 13:29:13 -07:00
Rob Moen 75e9b2cb2d On transact, redraw selection 
Change-Id: Ia2f82dd1516113a3c6e77377fec19047fcbd32d0
 2012-06-12 13:27:23 -07:00
Catrope c9605066cd Merge remote-tracking branch 'origin/master' into dmrewrite 2012-06-12 11:57:32 -07:00
Subramanya Sastry e00cfdbc16 Merge "Remove a few entries we now care about from the whitelist" 2012-06-12 18:57:17 +00:00
Subramanya Sastry f882a65153 Fix serialization of <pre> tags 
Change-Id: I7ae95e7ec06167d0c1bfdaba3d0c67d941043299
 2012-06-12 13:54:35 -05:00
Rob Moen bf5b682809 Fix clearButtonTool 
Change-Id: I92e55efb9c82f4d2ef55a71bea318cdc7495c2ea
 2012-06-12 11:43:56 -07:00
Rob Moen bf08347922 Fix js error 
Change-Id: I3424f205649345a97a7f4d28c4c040c3c3bb6aa7
 2012-06-12 11:17:46 -07:00
Rob Moen 2ea1030ab4 Rewrite document annotation getters to return collection objects 
vs arrays

Change-Id: Ib48a39fff501cdb769f5b9b9fc7717805b74236e
 2012-06-12 11:10:29 -07:00
Rob Moen da3e366758 Updating tools on transactions. Working towards finishing clear 
button

Change-Id: I7b6f8cae04fc181b7c8c61d4977e42480e608829
 2012-06-12 10:44:58 -07:00
Trevor Parscal 722c30466d Got rid of wrapping whitespace (like \n and \t) in a span that made text white 
This was causing some issues when you started typing there, and it's not clear that the white text is really the best way to go anyways

Change-Id: I8a9d6571ea204603729e96b7ff77184279a31a95
 2012-06-12 10:40:44 -07:00
Trevor Parscal 9b9dcca6e2 Made save page button only work when an edit is made 
Also added confirmation dialog for abandoning unsaved changes

Change-Id: I3388a8f7def9bee5eda32b97ef78e9565a7e33ea
 2012-06-12 10:32:19 -07:00
Trevor Parscal cd3cf1d856 Changed use of getSurfaceModel to getModel and surfaceModel to model 
Also cleaned up other stuff that was a little wonky

Change-Id: I6769b0cb53adb9fd4a9411937084efb03a6e3029
 2012-06-12 10:32:18 -07:00
Christian Williams 05ee4e7dac Binding to 'before paste' for IE only 
Change-Id: I3e3125d2faf75ea79e7f4c4d86fa1ccd666074b6
 2012-06-12 10:23:58 -07:00
Christian Williams 1e4c52237c Enter key handling 
Change-Id: I1b5f901a542328c3ae7c19a5cd816112dcac4042
 2012-06-11 19:40:09 -07:00
Trevor Parscal 77853609ed Merge branch 'refs/heads/master' into dmrewrite 
Conflicts:
	.gitignore

Change-Id: I73ff881ef3beef702748a2bfffee9e1661004f86
 2012-06-11 18:36:46 -07:00
Trevor Parscal 70234d2507 Fixed missing arg, kept stuff from saving 
Change-Id: I6c02b2a009f03b2d9e293591166819743fe7ee24
 2012-06-11 18:35:24 -07:00
Trevor Parscal 4cc88b9850 Fixed some minor-ish UI stuff 
Change-Id: Ibc3fa2fb7ce9193703263ab708ce18f6aefe5b09
 2012-06-11 18:21:41 -07:00
Trevor Parscal f0ef6bda70 Fixed drop-down arrow placement 
Change-Id: Ia9ce735a7938c2db0bad28b44384cf7d206a2023
 2012-06-11 18:21:40 -07:00
Catrope 92d715df92 Fix some comment typos 
Change-Id: I58e21bb4cb75580369b89a10cf324c100ed15724
 2012-06-11 18:19:12 -07:00
Catrope 44af6bdb18 Factor out redundant getNodeFromOffset() call 
Change-Id: Ie01282447fab589466554f7c637515289cf570af
 2012-06-11 18:10:09 -07:00
Catrope ab0c37def9 Rip out the offset map 
The offset map was broken from the start because it wasn't updated when
adjusting the length of a text node, and if we fix that bug it's
doubtful whether the costs of updating the offset map outweigh the
benefits, especially considering that adjusting the length of a text
node is something we do for almost every keypress. If it turns out
having an offset map does make sense, we can always reintroduce it
later.

Change-Id: I59e8bc154f7d07aa1bab2f473c13ff466d0e463f
 2012-06-11 18:10:08 -07:00
Catrope 77e923e323 Update tests for Parsoid workarounds 
Change-Id: Ifc7e7dc53eafa62af5652a2dba6cdc1fad199b4c
 2012-06-11 18:10:07 -07:00
Catrope 407ea15373 Make the LinkAnnotation code a bit more robust 
Change-Id: I42603788cf112541df67811858bd8854dd224b24
 2012-06-11 18:10:06 -07:00
Catrope 48abc8e30a Terrible hacks to work around Parsoid bugs 
This makes my test document round-trip cleanly though, yay!
 2012-06-11 17:32:58 -07:00
Rob Moen dcf104428f Clear button tool now properly clearning selection annotations. 
Create method to return matched annotations button tool pattern.

Change-Id: I5ba2369f1ec81a74570bcfeb1ee86bb7ef07e691
 2012-06-11 16:29:09 -07:00