Commit graph

18143 commits

Author SHA1 Message Date
Bartosz Dziewoński 7f1c9ac7c0 Update VE core submodule to master (63e87da8e)
New changes:
e117cd238 Call contextItemFactory.lookup, not contextItemFactory.registry.lookup
2b81a0b7b Deactivate selection on mobile while in read-only mode
e9a8ff887 Actually handle inTargetWidget config

Bug: T281771
Bug: T282194
Bug: T283445
Change-Id: Ied3e94bc3ebd2b390d9832215a94893fce64a5d3
2021-05-24 23:22:06 +02:00
jenkins-bot f40bf5e3df Merge "Don't apply min-height hacks to TargetWidget surfaces" 2021-05-24 21:11:55 +00:00
jenkins-bot 539dc5ddba Merge "Remove unused 'inTargetWidget' config" 2021-05-24 21:11:53 +00:00
Bartosz Dziewoński 34ffaa99de Update VE core submodule to master (f7d2ac280)
New changes:
0d0965b2f ve.dm.Document: Move var declarations inline
eb1fe6cfd ve.dm.TreeModifier: Move var declarations inline
101fa6749 ve.dm.SurfaceFragment: Move var declarations inline
08f379651 ve.dm.Surface: Move var declarations inline
d0ded7f28 ve.ce files: Move var statements inline
453e4ae33 keydownhandlers: Move var statements inline
1d80e69e6 ce.nodes/selections: Move var statements inline

Change-Id: I5bb07a8c0da0b99d09f3c632cf51ba789b005063
2021-05-24 22:27:30 +02:00
Bartosz Dziewoński d84a2b7b69 Update VE core submodule to master (d1af2fd53)
New changes:
adb902514 Localisation updates from https://translatewiki.net.
d1af2fd53 Dist: Update language lists

Change-Id: I7c32537d3387c4d542842d9f10832db774573b6c
2021-05-24 21:56:30 +02:00
jenkins-bot 028658a4e1 Merge "Remove/fix a few small pieces of unused code" 2021-05-24 13:23:53 +00:00
Translation updater bot 31e883c07f Localisation updates from https://translatewiki.net.
Change-Id: I0648c6030d181236092d9e7306da820fe3c03bc5
2021-05-24 09:56:01 +02:00
Ed Sanders a71dd4f797 Ensure correct classes are added to surfaces
* Create getSurfaceClasses method.
* Pass surfaceClasses to target widgets.

This ensures that the 'content' class is passed to mobile
target widgets, and the 'mw-body-content' class is added
in a less hacky way.

Change-Id: Ibce6d1a1d0fda63cca354761f1b91f808858e95b
2021-05-23 20:04:28 +01:00
Bartosz Dziewoński 1f6466e93b Use the edited page's title for magic words in API error messages
Bug: T247661
Depends-On: Ic3d70efc23744ef6e90abc445f3babebf45c4697
Change-Id: I565c5391b0d3f0b5fae2366e06ad5e1a2a18301c
2021-05-21 18:04:01 +02:00
jenkins-bot 1afe7c9b0b Merge "Update VE core submodule to master (0c024f431)" 2021-05-21 15:40:06 +00:00
jenkins-bot 915a39064e Merge "Add star to template search term only when it's possible" 2021-05-21 14:31:23 +00:00
Thiemo Kreuz 8f045a7155 Remove/fix a few small pieces of unused code
I found these thanks to PHPStorm.

Change-Id: Ieb30a95debb58d3a454ac3c6f0546e5dbbe77ed4
2021-05-21 11:43:45 +00:00
Thiemo Kreuz b15455ec3d Fix duplication bug in MWTemplateTitleInputWidget
Template names sometimes show up twice when searching for a
template in the "Add a template" dialog.

This is a bit hard to test. The code responsible for this
is not in a single place. The feature is in the upstream
TitleWidget class. It's not broken. It makes sense to
provide e.g. "foo" and "Foo" as two separate options when
the user typed "foo", but the page is named "Foo". Both are
valid, and the feature allows the user to pick either.

But the VE widget does it's own normalization. Both entries
are normalized to "Foo". Both do the same. The additional
one is pointless.

You can try this on the actual enwiki: Open VE, insert a
template, search for "Template:nHLE".

Change-Id: I65e706c4d131a2f8c605d7979a02ea56f831bf03
2021-05-21 11:43:31 +00:00
jenkins-bot c2b7b7afcb Merge "Update the delete button's feature flag in the tranclusion context menu" 2021-05-21 10:20:44 +00:00
Translation updater bot 873f8203fc Localisation updates from https://translatewiki.net.
Change-Id: Ief871354eb9dd8c7c40cf093c7948dde70bf2288
2021-05-21 12:10:43 +02:00
Thiemo Kreuz b7043d6f24 Fix object vs. array initialization in template search
The "redirects" part in a prefixsearch query is always an
array, no matter if formatversion 1 or 2 is used.

The "pages" part is an object with formatversion 1, and an
array with formatversion 2.

As of now this always uses formatversion 1. This is
hard-coded in the upstream TitleWidget class.

Change-Id: I8cde8e104f8a288015da745db41016f6639b453b
2021-05-21 11:24:48 +02:00
Andrew Kostka 2fe6094099 Update the delete button's feature flag in the tranclusion context menu
Bug: T274263
Change-Id: If805ce9dfc44be34e07ec79179837f12898e626e
2021-05-21 09:24:14 +00:00
jenkins-bot 4f0c564fbc Merge "Remove empty translations that cause CI errors" 2021-05-21 09:23:01 +00:00
Thiemo Kreuz (WMDE) dab0f32cef Remove empty translations that cause CI errors
This reverts parts of commit
b72459409c.

Reason for revert: A user emptied several translations,
causing CI errors. The bogus edits are already reverted on
translatewiki.net.

Change-Id: I6600cb901953f99d363e14d2f41978ce9a447658
2021-05-21 11:03:48 +02:00
Translation updater bot 1811893632 Localisation updates from https://translatewiki.net.
Change-Id: Ib05124e2d7e1d387b94227db2e75cd0af7933610
2021-05-21 08:34:55 +02:00
Translation updater bot b72459409c Localisation updates from https://translatewiki.net.
Change-Id: I33b268a7bc43a75eb77455b1d82ae1b83fc6d69b
2021-05-20 09:11:55 +02:00
Translation updater bot ded166fdfd Localisation updates from https://translatewiki.net.
Change-Id: Ib0bf518f5134037f485566f0da86844cc70e94d5
2021-05-19 08:44:42 +02:00
Translation updater bot 04e468e5d3 Localisation updates from https://translatewiki.net.
Change-Id: I1772bfc3d8a05789bf5126180a7a8bd81960c321
2021-05-18 08:48:10 +02:00
jenkins-bot 13f8d7db67 Merge "Remove obsolete vendor prefixed properties" 2021-05-18 01:25:08 +00:00
James D. Forrester cce248ce01 Update VE core submodule to master (0c024f431)
New changes:
5866b762f build: Re-enable Firefox testing
501e8354e ve.dm.Converter: Remove unused branch
84086e60f Localisation updates from https://translatewiki.net.
e1eb88ea2 Unify `list-style` CSS
d8eae968d ve.dm.Converter: Move var declarations inline
a26ff5fa6 ve.ce.Surface: Move var declarations inline
47a2d36f3 Localisation updates from https://translatewiki.net.
cf97b4938 build: Merge eslint main and html tasks back together
381ade44c build: Updating grunt to 1.4.0
d98f7995a Localisation updates from https://translatewiki.net.
c6bc154d2 Check if alien context item is registered before using
e645b06af Localisation updates from https://translatewiki.net.
58830c0dd build: Updating postcss to 8.2.15
f7b193a7e Localisation updates from https://translatewiki.net.
9730bd748 Update OOjs to v6.0.0

Bug: T240955
Bug: T282194
Change-Id: I7a26365a24103ac4e4b1279fda3b74ac6e4a9497
2021-05-17 17:35:37 -07:00
jdlrobson 2a40996cb7 Add mw-body-content to surface element
VisualEditor recreates the mw-body-content element. The element
with mw-parser-output already exists as a child. All skins now
consistently follow this pattern.

To limit the impact to the editor, we use ArticleTarget and add the class
to the surface, which corresponds to the mw-body-content element of a skin.
This avoids unrelated regressions in experiences such as DiscussionTools.

Bug: T283014
Change-Id: I4833d1ca9fda4fc0bd433760e47fe7010f00db05
2021-05-17 19:06:54 +00:00
jenkins-bot a01b56bcf1 Merge "Invert template search result highlighting" 2021-05-17 12:30:49 +00:00
Adam Wight 9cac71676e Invert template search result highlighting
Bug: T275048
Change-Id: I50fc7407b4357e2cea9d5421d0de46a81d39c69d
2021-05-17 14:12:02 +02:00
Andrew Kostka b2aa35a90a Show a warning before resetting the transclusion dialog
Bug: T272355
Change-Id: Id97190a149ed7642eda82300eeee623e0debf528
2021-05-17 13:27:37 +02:00
Adam Wight f444610fbc Support isEmpty on transclusion dialog elements
Returns true if there is no meaningful user input yet.

Will be used in the next patch.

Bug: T272355
Change-Id: I4f88ce31662bbc46755f78d574c46b907581d438
2021-05-17 13:26:11 +02:00
Andrew Kostka b2c9b225bd Add back button to the transclusion dialog
Bug: T272354
Change-Id: I08c4a7db6239b485439bf547e3e8b4d6f7aeede8
2021-05-17 13:18:14 +02:00
Andrew Kostka e0bbf0b979 Show a delete button only in the transclusion context menu
Bug: T274263
Change-Id: Ifd81994c212cd03c1318c5fd762251ce828d9195
2021-05-17 12:26:37 +02:00
Adam Wight 85f45fd49d Introduce feature flag for template dialog sidebar changes
Bug: T274263
Change-Id: If274efa94474c3de79c5917b76c1a290f93172e1
2021-05-17 12:25:46 +02:00
Translation updater bot 9ff35ae7c9 Localisation updates from https://translatewiki.net.
Change-Id: I70a074440574e9d28c2b1b2722e7d11a3b91fb37
2021-05-17 08:44:17 +02:00
libraryupgrader 1d300c3d54 build: Updating npm dependencies
* hosted-git-info: 2.8.8 → 3.0.8
  * https://npmjs.com/advisories/1677 (CVE-2021-23362)
* postcss: 7.0.35 → 8.2.15
  * https://npmjs.com/advisories/1693 (CVE-2021-23368)

Change-Id: I62b12274213389625fed11a27d32694e4946f8b3
2021-05-15 09:59:29 +00:00
jenkins-bot 71a4ad4f8e Merge "Template dialog bigger size uses "larger" preset" 2021-05-14 11:27:44 +00:00
jenkins-bot c3dd0115f8 Merge "Use add template when adding a new transclusion part" 2021-05-14 10:14:48 +00:00
Translation updater bot c35c2bb022 Localisation updates from https://translatewiki.net.
Change-Id: I23d807cbf884e0c72acfdd28b757bb1e50615920
2021-05-14 08:45:57 +02:00
Ed Sanders ea9ea1d17f NWE: Always paste rich text as plain, and show context item to convert
Bug: T282789
Change-Id: I1bc32c9e16140190baef9bcb08d49b4b21896883
2021-05-13 15:56:19 +01:00
Adam Wight 9607cb3ed0 Template dialog bigger size uses "larger" preset
Rather than invent our own size, we'll reuse the "larger" format and
tweak the dialog height to 90%.

Bug: T273971
Change-Id: Ibef85c1912267b14d83396b089b81934751a8328
2021-05-12 11:31:40 +02:00
Translation updater bot c34f64ba04 Localisation updates from https://translatewiki.net.
Change-Id: I4b8eb213599997af1cfe70ff0c3a2398363f4ec3
2021-05-12 09:23:45 +02:00
Thiemo Kreuz 333cadd5d4 Add star to template search term only when it's possible
Discussed in T274903#7077957. Note this might not be the
"perfect" solution. We are still experimenting, and this is
all hidden behind a feature flag. This is the change with the
most minimal impact. Actively trimming the input is another
solution, but with a bigger impact we might want to discuss
first.

Bug: T274903
Change-Id: I2ed06c04bb96c7b61bd7e87ad001e639ea6d06a2
2021-05-11 16:31:42 +00:00
WMDE-Fisch 42b557ff80 Use add template when adding a new transclusion part
We have two cases now that we want to cover here:
- Either we're inserting a new template and start a "fresh"
  transclusion, then we want to use "search" in the headlines
- Or we're adding a new template to an exsisting
  transclusion, then we want to use "add" in the headlines

Bug: T277028
Change-Id: I9fa294cf732598d58f848c75b353d2e1742eb4e8
2021-05-11 13:13:44 +02:00
Translation updater bot 03c277e96a Localisation updates from https://translatewiki.net.
Change-Id: I0e8507be3cf38c993020e5ea05144b6a53eeba33
2021-05-11 09:08:30 +02:00
WMDE-Fisch 3b38ecf690 Use sentence case for template search label
Bug: T277028
Change-Id: I4be6ab078053a50d33a6d67f7b5702d4051d4ef1
2021-05-10 17:34:39 +02:00
Svantje Lilienthal 2665734b10 Renaming temporary config variable and splitting it from cirrus search lookup
This allows using the config variable independendly from the cirrus search extension.
This way it can be used for all subtickets of T271802.

Bug: T277028
Change-Id: I1b3bdda5fa6fbfe5c531c3b51c2c8e2a28ed1faf
2021-05-10 14:47:31 +02:00
Adam Wight f89301bedf Optional verbose template search
Renames "Add a template" to "Template Search" in most cases and
provides inline help for the workflow.

Bug: T277028
Change-Id: I3fee87cb89b5044e785596e71ef3f1a18f2694ce
2021-05-10 12:45:12 +00:00
Andrew Kostka c1d36072ea Add collapsible descriptions to the transclusion dialog
Bug: T273426
Change-Id: I793a66f5c5877451b70058e9388dd86b3fcaadd7
2021-05-10 11:18:17 +00:00
Translation updater bot 752cc487e2 Localisation updates from https://translatewiki.net.
Change-Id: Ie07dc3f2354dadbb464c60706a11c8339c1653e4
2021-05-10 08:54:22 +02:00
libraryupgrader e6ad9eddff build: Updating npm dependencies
* grunt: 1.3.0 → 1.4.0
* hosted-git-info: 2.8.8 → 3.0.8
  * https://npmjs.com/advisories/1677 (CVE-2021-23362)

Change-Id: Ibbb79989dd9c92a9f5ac6c14d537de0cd0c9cd47
2021-05-07 21:18:30 +00:00