wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
12943 commits 161 branches 1 tag 190 MiB
Commit graph

128 commits

Author SHA1 Message Date
David Lynch 9e86d17260 MediaDialog: flag caption widget as being in a dialog 
This means that cmd+enter won't add a newline when it closes the dialog.

Bug: T161555
Change-Id: I738c9acf8cce437ce6bc4c8db29f28d1fff3d2c9
 2017-03-28 11:43:59 -05:00
Bartosz Dziewoński 22df25c108 Pass $overlay to FieldsetLayout and FieldLayout in various places 
We now use dialog's overlay in every case where we have a FieldsetLayout
or a FieldLayout with a help popup inside a dialog.

Bug: T100571
Change-Id: I8bd0ed430637feca63ec0f13cb7e1e1c659391a5
 2017-02-16 02:56:03 +01:00
jenkins-bot d816492ca1 Merge "rm stray fileRepoPromise property from media dialog" 2017-01-03 20:24:34 +00:00
James D. Forrester 122f49b2dd build: Bump file copyright notices for 2017 
Change-Id: I3c20809e71cc0da58123e1b5f29c4f3aac945496
 2017-01-03 08:58:33 -08:00
Alex Monk d7cf29f1c0 rm stray fileRepoPromise property from media dialog 
seems to have gone upstream to core's mw.widgets.APIResultsQueue

Change-Id: I3c2a6dbdca60ceadc9e7175e5f8ad83b7fc4b7a0
 2016-12-24 18:59:48 +01:00
jenkins-bot 745e919f97 Merge "Update VE core submodule to master (9625e8f)" 2016-11-29 20:46:54 +00:00
Ed Sanders aeafa6afca Update VE core submodule to master (9625e8f) 
New changes:
f1297b8 [BREAKING CHANGE] Allow target widgets to be re-used

Local changes:
Re-use target widgets

Change-Id: I5decb918f398704d4b6c108a16fbc1cc073ef077
 2016-11-29 11:48:15 -08:00
Ed Sanders 2ee9e62a4d Use upstream media search widget from core 
Bug: T140166
Depends-On: If53ef7f4b62c7a5d4da565c14dd2a353778694e5
Change-Id: I28845e9c143e78d3a377f067606c62da212e3bf1
 2016-11-29 17:19:14 +00:00
James D. Forrester 36befda61c build: Replace jscs and jshint with eslint 
It's new, it's fresh, it's amazing, it's here.

Change-Id: I5dc784411f704685ed5cc763a2b2b1c5d3e5a610
 2016-10-28 18:33:15 +00:00
Matthias Mullie 2b4948b0b6 Change mid-upload 'cancel' button to 'back' 
Bug: T114938
Change-Id: I964708e1267223b181630b9bea5b19e2bdf242be
 2016-09-22 16:13:57 +02:00
Ed Sanders 35c0a0dc69 Use cloneWithData 
Change-Id: I7ffe3c7ab20d5f785a6642c8293f271f4dc08ff8
 2016-05-30 21:40:07 +01:00
Ed Sanders c516d897d2 Remove icon properties from windows 
Windows stopped supporting icons a while ago.

Change-Id: I8a63152282a5968dcd17675330e31bd1ebe4b68b
 2016-03-29 12:33:42 +01:00
Ed Sanders 67c207a6f5 Use abstract target widget creation 
Change-Id: Ic7e43e80f4f48df99842cee702963d54205e5055
Depends-On: I6a667a641540b347052ea0c645af4e1e59cf333a
 2016-03-03 11:49:44 -08:00
David Lynch 7486f74c6f MWMediaDialog: Only cache relevant information 
Trim the cached image data from the media dialog down so that it only caches
the same information that would have been fetched for a non-uploaded image.
Consistency!

Bug: T126081
Change-Id: I0f057c111b66f29c6360e27f97256384f5320b75
 2016-02-29 10:16:34 -06:00
jenkins-bot 74b2489276 Merge "Link to file description pages in media dialog" 2016-02-22 21:07:43 +00:00
Ed Sanders deb676e73d MediaDialog: Use CC logo from upstream (ooui-icons-wikimedia) 
Change-Id: I4fabf5f8d87b9b21623883203b9d6965a0ff33a0
 2016-02-21 18:20:30 +00:00
Alex Monk ca5cab52af Link to file description pages in media dialog 
Bug: T125227
Change-Id: I243f5479ab27ab098d41db08ff4a53195d382577
 2016-02-21 03:45:37 +00:00
Ed Sanders abb094babd MWTargetWidget: Add missing indent commands to blacklists 
Bug: T124619
Change-Id: If2a5d98673db6e2d29fe49f1e7f5307437ba3866
 2016-01-26 23:46:12 +00:00
James D. Forrester ada58df361 build: Bump file copyright notices for 2016 
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
 2016-01-03 14:57:25 -08:00
Bartosz Dziewoński ca81362afd ve.ui.MWMediaDialog: Make the dialog higher (600px) 
Avoids a scrollbar for option 4 of the A/B test from T120867.

Change-Id: I3eacb560117219febd6e08066599e2d4d42df219
 2015-12-14 20:53:32 +01:00
Ed Sanders ae26eefb05 Fix typos 
Add some common ones to typos.json

Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
 2015-12-09 16:47:13 +00:00
Ed Sanders 557eb4fe84 MediaDialog: Remove useless empty object arg to media size widget 
Change-Id: Id85498616f80147cd856d4d12bf5a0e58ad66029
 2015-12-07 14:12:56 +00:00
James D. Forrester 3c9a361da0 MWMediaDialog: Add a margin back to the border checkbox 
This was removed upstream in OOUI as unecessary in general, but clearly
this was the place for which the rule had been designed. :-)

Bug: T119547
Change-Id: I46a1df1141c337b436e66872f1a8cdae026816cd
 2015-12-02 18:28:18 -08:00
James D. Forrester b68e34fdeb MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one 
Depends on If4ec151a in OOUI.

Bug: T111100
Change-Id: I90af27a7ba881c588b8a432f1cc1e54ab4c80f79
 2015-11-24 18:40:13 -08:00
Ed Sanders e1d14099e0 Image/gallery icons: Rename and use new upstream versions 
Depends on oojs-ui > 0.13.2.

Change-Id: Iee4cc52b998626e829fd92346d5ee1295c08f26f
 2015-11-18 01:49:31 +00:00
Bartosz Dziewoński 0238c53262 ve.ui.MWMediaDialog: Wait for upload booklet to initialize when setting up 
Depends on I65a92e3915a6844056fb7b3a2758a168eb12e6b8 in MediaWiki core.

Change-Id: If59979f30315c7a2164457108362803544431615
 2015-10-28 22:31:45 +01:00
Bartosz Dziewoński cf6178f3a1 ve.ui.MWMediaDialog: Reset upload booklet when done uploading 
Bug: T115380
Change-Id: I7c252a08cc2f09385102650e4d437e74d3919e59
 2015-10-22 20:30:44 +02:00
jenkins-bot 9e74b26c41 Merge "ve.ui.MWMediaDialog: Correct harmless typo in method name" 2015-10-22 18:26:15 +00:00
Bartosz Dziewoński 777fc0445e ve.ui.MWMediaDialog: Correct harmless typo in method name 
Change-Id: Ibeb037896123349edac6bc74ab0d9541a2a63e93
 2015-10-22 20:18:43 +02:00
Bartosz Dziewoński c5434b2db8 ve.ui.MWMediaDialog: Only disable 'upload' and 'save' actions on setup, not on tab switch 
When the tab is switched, we already set a mode that doesn't allow
using these actions.

Bug: T116299
Change-Id: Ib3ba50f578face3d49bcd14e41afe01a3b3d15af
 2015-10-22 20:12:03 +02:00
Bartosz Dziewoński bc9487cc8e ve.ui.MWMediaDialog: Move upload booklet init further up 
The first time this is called, it will try to switch panels, so it has
to be done before we switch to the right panel.

Bug: T116217
Bug: T116219
Change-Id: I22411024995e22ae65bde1e6418748aedf026b1b
 2015-10-22 19:44:39 +02:00
Prateek Saxena d1bf196f68 Media upload: Initialize booklet before setting file on drag drop 
Calling initialize will clear all fields including the
OO.ui.SelectFileWidget that was just set.

Follows up I521909d27c390faad7d62f717f2b97b7676e5a63.

Bug: T40031
Change-Id: Ibc7ddafae9cb7718372520245a356938f4731479
 2015-10-14 12:49:31 +00:00
Ed Sanders 7f2d9d0042 Media upload: Use new setFile method 
Depends on I30ec98be0 in MW core.

Change-Id: Ied82ac8fd25a1c4b9818029429231ce2f39916d4
 2015-10-13 18:25:09 +00:00
Ed Sanders 557340426f Media upload: Initiate upload process on image drop 
Bug: T40031
Change-Id: I521909d27c390faad7d62f717f2b97b7676e5a63
 2015-10-13 11:24:34 -07:00
Ed Sanders d5766c2d5f Media upload: Hide tabs after first stage of upload booklet 
Change-Id: Ie0cd0fe7761b3937de685ed18b96cc95b8ca4d4f
 2015-10-10 16:52:35 +01:00
Ed Sanders aa5f0c2faf Media upload: Only reset upload booklet on dialog setup 
Bug: T115059
Change-Id: I4ee9b408624ee3b0dfc3079f02ebbaf2e66f3fa3
 2015-10-10 16:52:25 +01:00
Ed Sanders afb556813a MediaDialog: Rename bookletLayout to mediaSettingsBooklet 
Change-Id: I04dbdfd14daedf614e8a47992231d48d72f7ff33
 2015-10-10 16:26:40 +01:00
Ed Sanders fcc9be4fa4 Fix typo in MWMediaDialog 
Change-Id: Id8133f9eee523a7cd237d4ca2814b29bce02fa0d
 2015-10-07 19:34:21 +01:00
Ed Sanders 97ddc8af2b Add image upload tab to media dialog 
Uses the ForeignStructuredUpload BookletLayout.

Bug: T40030
Change-Id: I103044210e714d99350a28a48619beacefb43eaa
 2015-10-06 18:40:19 -07:00
Roan Kattouw e4d2d4785e ve.dm.MWImageModel: Require parent document 
Add a parentDoc parameter to the MWImageModel constructor and use
it to inherit language, direction and HTML document. Remove
getLang(), setLang(), getDir() and setDir() whose only purpose
was to propagate the language and direction from the parent document
in a hacky way.

Also add a parentDoc parameter to newFromImageAttributes(), replacing
the lang and dir parameters. Remove the unused and ill-conceived
caption parameter.

This causes caption documents to always have an HTML document
for URL resolution. Previously, this worked when editing existing
images because a document generated by cloneFromRange() (which
propagates the HTML document) was passed into setCaptionDocument(),
but it didn't work when creating new images.

Bug: T109599
Change-Id: Ida36862092cd779ffc2f04c0ecbc1164f8d71453
 2015-08-27 00:09:21 -07:00
Ed Sanders 6e44d8a7c0 Use mw.Title to localise file: prefix on new images 
Bug: T110104
Change-Id: I25e28367bf4b00a0447c941b7359ebff5fe59147
 2015-08-25 17:17:49 +01:00
James D. Forrester 00d3226be1 build: Enable jscs jsDoc rule 'checkParamNames' and make pass 
Change-Id: Ifcd3f67524c32148ff3591263d6374b31ee57d3b
 2015-08-19 11:33:59 -07:00
James D. Forrester 85f91f394e build: Enable jscs jsDoc rule 'requireNewlineAfterDescription' and make pass 
Change-Id: I7c0fabc93834d19198caea8f5dd1834e9e473d0a
 2015-08-19 11:21:01 -07:00
James D. Forrester f5c6f61163 build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass 
Change-Id: I846d36c15e1b1f810d2ef7fd422f8412790bcb0f
 2015-08-19 10:33:02 -07:00
jenkins-bot 788788f11d Merge "Don't error when we try to close a reference/media dialog with inspectors still open" 2015-08-11 19:01:41 +00:00
Bartosz Dziewoński 7bef835dfb ve.ui.MWMediaDialog: Remove dead code with 'HACK' comments 
I am unable to find any trace of a .oo-ui-dialog-content-footless
CSS class anywhere.

Change-Id: I9a363c1305ca8f5ce25b8684daf0cb6d6c79bf73
 2015-08-11 00:07:52 +02:00
Bartosz Dziewoński bfb5ba34ad ve.ui.MWMediaDialog: Remove weird spinner relicts 
This seems to be dead code.

* ve.ui.MWMediaSearchWidget does not have a #$spinner property.
* .ve-specialchar-spinner class does not have any styles defined.

Change-Id: I6fd35274bc1444303b67f8138ab875f0c6da7e4a
 2015-08-10 23:47:20 +02:00
Ed Sanders f579ce52a2 *Dialog: Flag back/cancel actions 
Change-Id: If3772863078a020eba9b9b43f58044a5aacb7296
 2015-08-06 21:51:32 +00:00
Ed Sanders 322d1f54c6 MWMediaDialog: Remove redundant check of this.imageModel existence 
The fact it has to exist for the two previous statements to
not fatal is a bit of a clue. I assume this made sense at
some point in the past.

Change-Id: Ic9c04395408301f514ff7e9a224b8e2c30d64896
 2015-08-03 01:09:03 +00:00
Alex Monk d6306d8a16 Don't error when we try to close a reference/media dialog with inspectors still open 
Bug: T96630
Change-Id: Ie148149c9681a883116df12a23ae6e4c3b470daa
 2015-08-01 22:44:34 +01:00