wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-24 18:58:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use cloneWithData

Browse source 
Change-Id: I7ffe3c7ab20d5f785a6642c8293f271f4dc08ff8
This commit is contained in:
Ed Sanders 2016-05-30 21:40:07 +01:00
parent eb9c346221
commit 35c0a0dc69
3 changed files with 10 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
modules/ve-mw/dm/models/ve.dm.MWImageModel.js
View file

@ -821,26 +821,12 @@ ve.dm.MWImageModel.prototype.getCurrentDimensions = function () {
*/
ve.dm.MWImageModel.prototype.getCaptionDocument = function () {
if ( !this.captionDoc ) {
this.captionDoc = new ve.dm.Document(
[
{ type: 'paragraph', internal: { generated: 'wrapper' } },
{ type: '/paragraph' },
{ type: 'internalList' },
{ type: '/internalList' }
],
// htmlDocument
this.parentDoc.getHtmlDocument(),
// parentDocument
null,
// internalList
null,
// innerWhitespace
null,
// lang
this.parentDoc.getLang(),
// dir
this.parentDoc.getDir()
);
this.captionDoc = this.parentDoc.cloneWithData( [
{ type: 'paragraph', internal: { generated: 'wrapper' } },
{ type: '/paragraph' },
{ type: 'internalList' },
{ type: '/internalList' }
] );
}
return this.captionDoc;
};

3
modules/ve-mw/ui/dialogs/ve.ui.MWExtensionPreviewDialog.js
View file

@ -55,7 +55,8 @@ ve.ui.MWExtensionPreviewDialog.prototype.getSetupProcess = function ( data ) {
doc = this.selectedNode.getDocument().cloneFromRange( this.selectedNode.getOuterRange() );
} else {
element = this.getNewElement();
doc = new ve.dm.Document( [
// We assume that WindowAction pass
doc = data.fragment.getDocument().cloneWithData( [
element,
{ type: '/' + element.type },
{ type: 'internalList' },

9
modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
View file

@ -1271,17 +1271,12 @@ ve.ui.MWMediaDialog.prototype.resetCaption = function () {
if ( this.imageModel ) {
captionDocument = this.imageModel.getCaptionDocument();
} else {
captionDocument = new ve.dm.Document( [
captionDocument = doc.cloneWithData( [
{ type: 'paragraph', internal: { generated: 'wrapper' } },
{ type: '/paragraph' },
{ type: 'internalList' },
{ type: '/internalList' }
],
// The ve.dm.Document constructor expects
// ( data, htmlDocument, parentDocument, internalList, innerWhitespace, lang, dir )
// as parameters. We are only interested in setting up language, hence the
// multiple 'null' values.
null, null, null, null, doc.getLang(), doc.getDir() );
] );
}
this.store = doc.getStore();