Commit graph

9496 commits

Author SHA1 Message Date
jenkins-bot 69b7a262ec Merge "Follow-up 51dd790 & c40070b: Drop T135171 debug tracking" 2016-09-01 19:26:14 +00:00
jenkins-bot b656f3d5f1 Merge "Use super property to call parent methods" 2016-09-01 17:04:39 +00:00
jenkins-bot dcbb8e2e90 Merge "Fix restoration of redirect HTML after exiting without saving" 2016-09-01 16:12:05 +00:00
Alex Monk d907e973fd DesktopWikitextArticleTarget#switchToVisualEditor: Use correct revision ID property
So we ensure we send the actual revision ID, not potentially undefined, to the
method. If we send undefined, it'll give us an etag for revision number 0...
And that will cause issues when we later attempt (in a future editor switch) to
pass an etag for revision 0 along with the correct revision.

Bug: T143920
Change-Id: I0c27956abdd26ae4f5f1b91010a5eab8ee0354ab
2016-09-01 02:45:22 +01:00
Translation updater bot 355f16e0b9 Localisation updates from https://translatewiki.net.
Change-Id: I4211dc8f05263175d5dbdd4a031c050f08505c14
2016-08-31 22:39:03 +02:00
jenkins-bot 572e7375d7 Merge "Preserve data when switching from NWE to VE" 2016-08-30 23:33:43 +00:00
Translation updater bot 9151afca86 Localisation updates from https://translatewiki.net.
Change-Id: I3ddd0d7432427ef021cf30e44a9750b4fd5dcabb
2016-08-30 23:05:20 +02:00
Translation updater bot aa3dcd35b3 Localisation updates from https://translatewiki.net.
Change-Id: I3b0565e6b6690091bdacf4b6759f4aa43530f64b
2016-08-29 22:41:25 +02:00
James D. Forrester ba4532aa9d Rename EditButtonPublishNotSave to EditSubmitButtonLabelPublish
Depends-On: I4fbe54876095378a476399bf5e336c8df3e91e14
Change-Id: Iface24f77775216a0ab9eb464e7e10624af7719d
2016-08-29 10:46:49 -07:00
Translation updater bot fb16967972 Localisation updates from https://translatewiki.net.
Change-Id: Ie985146be37405dd3a37e91f321b35f49446c44f
2016-08-28 22:43:43 +02:00
Translation updater bot 0559a1ba4e Localisation updates from https://translatewiki.net.
Change-Id: I1dece529d19466a72af1dffdbaa0954a38bc93d9
2016-08-27 23:29:02 +02:00
Translation updater bot 990ce5b345 Localisation updates from https://translatewiki.net.
Change-Id: I57242c6dd7e6da74bf5753b3e5441c3094b04a17
2016-08-26 22:35:15 +02:00
Ed Sanders 56c56e81fe Move image-paste blocking to transfer handler match function
By not matching, we allow other types of paste to happen, e.g. HTML/plain text.

Bug: T142622
Change-Id: I3a2224ab23b5073eb7b031134ecc3170ccc782c0
2016-08-26 00:54:39 +00:00
jenkins-bot f071b0380d Merge "Vary the 'save' labels to 'publish' for public wikis" 2016-08-25 21:36:41 +00:00
Translation updater bot 5af089bc13 Localisation updates from https://translatewiki.net.
Change-Id: Ieb87b5a04ece4b7931a8e9def6b5c8da3e1e5043
2016-08-25 22:40:56 +02:00
jenkins-bot 3063a9f23e Merge "init: Discard attempts to activate while we're already activating" 2016-08-25 20:12:45 +00:00
Ed Sanders 134b62eb09 Preserve data when switching from NWE to VE
Bug: T143917
Change-Id: I910e731914bd71fdb131dae79d233d4306facc5d
2016-08-25 11:06:40 -07:00
jenkins-bot d27863587a Merge "Show a different label for buttons on create vs. modify" 2016-08-25 16:40:21 +00:00
James D. Forrester deef47414a Vary the 'save' labels to 'publish' for public wikis
Bug: T131132
Change-Id: I4a497265661d5ce0f6144988b514509dfa1bddfd
Depends-On: I56634ed223778a0650cf36ac7256151b13c494f1
2016-08-25 09:37:52 -07:00
David Lynch c1a065295f init: Discard attempts to activate while we're already activating
Perhaps in the future we could enhance this so that clicking a different edit
link queues that up for after the current activation finishes / aborts the
current activation cleanly.

Also, error-checking on setting an invalid progress state when loading.

Bug: T143160
Change-Id: I6c78cb19953df6fb564c06bac807e6897b63df19
2016-08-24 19:57:47 -05:00
James D. Forrester b7c7d06968 Show a different label for buttons on create vs. modify
To align with the linked patch in MediaWiki core. Taking advantage of
the opportunity to use core's messages for these, and remove some dead
wood old messages that were never used like "restore" items in mobile.

Bug: T139033
Depends-On: Ie81b5edd275963a965cd44d0fd325cae9ee2f1a6
Change-Id: Ie00e94cc77cb750a7e8d1104366bb3dad65af8a4
2016-08-24 16:01:11 -07:00
jenkins-bot e433326b1b Merge "Fix insertion annotation for wikitext link inspector" 2016-08-24 20:46:58 +00:00
Translation updater bot da737c7854 Localisation updates from https://translatewiki.net.
Change-Id: I340323ac24871f3c4e30e011e0397dcb800eda60
2016-08-24 22:39:02 +02:00
Ed Sanders 5788340b49 Update VE core submodule to master (632f0a9)
New changes:
14b5fbc [BREAKING CHANGE] Move originalDomElements to the IV store and use MD5
c5d21f0 Provide methods to (de)serialize transactions

Local changes to move originalDomElements to IV store

Depends-On: I8a71c1a40ec35108d0a9a388da6f75632f8dc53c
Depends-On: I32c9b5f984fcf96e3354841ecfcd444149e8f159
Change-Id: I0fbb6324eede94558426178cbdad6b5daf0f8318
2016-08-24 18:14:14 +00:00
Željko Filipin 59d771e1ac Fix failing Selenium tests
There were a couple of pieces of language screenshots related Ruby code
left that was breaking Selenium tests.

Bug: T139613
Change-Id: I3d327b3cfd5f52e60fee07095eefdd8feecaba98
2016-08-24 16:47:14 +00:00
Željko Filipin 2fb5c18ced Upload language screenshot files using commons_upload Ruby gem
Use the latest version of commons_upload. Delete no longer needed files
from previous Ruby implementation.

Bug: T143563
Change-Id: I7c0ca64aeea54501c51eb56a950143d5af251cf7
2016-08-24 14:47:45 +00:00
Translation updater bot 6eded3baa0 Localisation updates from https://translatewiki.net.
Change-Id: I13d00f33fb7fa329889ed42381ba1c02d7980434
2016-08-24 10:38:15 +02:00
Ed Sanders 62bdaac13b Use super property to call parent methods
Change-Id: I76982b844cf2871d7583463def4393e5bdc33aa2
2016-08-23 11:56:47 -07:00
jenkins-bot 086202c540 Merge "init: port in isUnModifiedLeftClick without any VE core dependencies" 2016-08-23 00:01:52 +00:00
Ed Sanders 370ac2808a Restore parent method call in ce.MWHeadingNode#onUpdate
Bug: T143604
Change-Id: Ia4f01d4b901404660fbb1f9755feea36b076b71c
2016-08-22 21:28:48 +00:00
David Lynch 11a4e4e6b9 init: port in isUnModifiedLeftClick without any VE core dependencies
Bug: T143467
Change-Id: I4c0ecf80ecfff04472e136801264d50dafe39575
2016-08-22 14:40:34 -05:00
James D. Forrester 1993c51a49 Follow-up 51dd790 & c40070b: Drop T135171 debug tracking
Apparently this is now fixed, so no need to keep this.

Bug: T135171
Change-Id: Ie5c0f9140c6de4bb73770276011adce23fa69f9e
2016-08-22 11:28:22 -07:00
Ed Sanders 1d6746e89d Fix insertion annotation for wikitext link inspector
Change-Id: Ib769e371743438b530f150fcb8104292288c35f9
2016-08-22 10:59:55 -07:00
jenkins-bot d21bc1868b Merge "Remove Ruby implementation of language screenshots" 2016-08-22 10:38:09 +00:00
Željko Filipin cbccba89a0 Remove Ruby implementation of language screenshots
It is now implemented in JavaScript/Node.js.

Bug: T132574
Change-Id: I299332ac4f849b951ba24564bd0282ca0e25afd2
2016-08-22 12:19:21 +02:00
Translation updater bot cb8c2ebec7 Localisation updates from https://translatewiki.net.
Change-Id: Ic4a9b04c553eebc67df75b158614c09ac4b20aa7
2016-08-21 22:56:05 +02:00
Translation updater bot 6c06d056d3 Localisation updates from https://translatewiki.net.
Change-Id: Ic43cc7b3097d55d6c3d89013e97f3ee3a8c9f414
2016-08-20 22:43:13 +02:00
Translation updater bot cba27d7b4a Localisation updates from https://translatewiki.net.
Change-Id: Ib526d0ed028f4cdd7d96106c700b2f639ce634ef
2016-08-19 22:43:40 +02:00
Alex Monk 166588c726 Fix insertion of templates, media, and various other things into wikitext surface
Pretty much fix everything on the insert menu... RB doesn't like it when you
try to specify both title and revision ID, but don't provide an ETag.

Change-Id: Ib25d023309d984ed8848f67b349b23231f27a957
2016-08-17 21:12:00 -07:00
Alex Monk d24fd1e389 Don't show unsaved-changes warning if user has already saved in wikitext dialog
Add an extra surface check - makes sure it's attached.

Change-Id: I1720ba18b5966549fefb839013776ac9dfe0468a
2016-08-17 21:12:00 -07:00
Translation updater bot 7660980ab5 Localisation updates from https://translatewiki.net.
Change-Id: I75f5c71990c63b2a21c85ae9217476101b384cc5
2016-08-17 22:42:44 +02:00
jenkins-bot 12e169c9af Merge "i18n: Reduce 'visualeditor-beta-warning' to just an invite to report issues" 2016-08-17 17:38:00 +00:00
jenkins-bot 02dc269447 Merge "Fix name of mweditmodeve-tool message" 2016-08-17 16:56:44 +00:00
James D. Forrester 557873447c i18n: Reduce 'visualeditor-beta-warning' to just an invite to report issues
The switch notice isn't as urgent now.

Change-Id: Ie2e534d9ab41f2217ff98a669e40cf3fd7863498
2016-08-17 09:55:04 -07:00
Alex Monk f60730a580 Fix name of mweditmodeve-tool message
Change-Id: Ib48a61b4ea56221808d96efd5cf4a5c13b8aeb0c
2016-08-17 06:21:56 +01:00
Translation updater bot ba2c2ed44e Localisation updates from https://translatewiki.net.
Change-Id: If3311510499f1aa9ea006b86ee31e82c154985de
2016-08-16 22:46:32 +02:00
Translation updater bot a55424dd80 Localisation updates from https://translatewiki.net.
Change-Id: Ife0e4911d0d7bcd58c248fd38ee3ea3d57b846bd
2016-08-15 23:03:18 +02:00
Translation updater bot 0c2f2981ce Localisation updates from https://translatewiki.net.
Change-Id: I1be5f7bf479705830f250968b5f6957708a6857e
2016-08-14 22:30:35 +02:00
Translation updater bot 64fb43836a Localisation updates from https://translatewiki.net.
Change-Id: Id89d44abfc5abf2a77e836d8642112945f9857d9
2016-08-13 22:33:28 +02:00
Translation updater bot 8e0eedb51c Localisation updates from https://translatewiki.net.
Change-Id: Ia9359b5ace4cdeaf5c2f6e1682475eeb265f811b
2016-08-12 23:17:05 +02:00
Ed Sanders c452e134cc Wikitext surface alpha feature
Edit wikitext with the VE interace.

Bug: T104479
Bug: T142138
Change-Id: Ic95b47e0dd378578555c4a2342ca9c87064ed1d5
2016-08-12 18:37:29 +00:00
jenkins-bot e92b37a700 Merge "Centralize some checks for unmodified left clicks" 2016-08-11 23:24:30 +00:00
Translation updater bot 567bc298c5 Localisation updates from https://translatewiki.net.
Change-Id: I77aca2aafa920a83a17af3e67e686f591c38c93a
2016-08-11 23:59:28 +02:00
David Lynch 87ea771ae6 Centralize some checks for unmodified left clicks
Change-Id: I59cee4da9bbca4c8a29eaf9d52cb00ab6e70b670
Depends-On: I4f164f7cf1d755c3662571b2a1a8371d9fe756f9
2016-08-11 13:33:26 -07:00
Translation updater bot 8e2eea4ba9 Localisation updates from https://translatewiki.net.
Change-Id: I89b98e1377eb41691c1197857994b4410a7b70c7
2016-08-10 22:40:32 +02:00
Alex Monk 96421b283c Fix restoration of redirect HTML after exiting without saving
This feels like it's getting far more complicated than it should be.

Bug: T140032
Change-Id: Id951400cead61da37b8bdfa05cf8add6c115547d
2016-08-09 22:43:25 +01:00
Translation updater bot 1bb72c1dba Localisation updates from https://translatewiki.net.
Change-Id: Icc1218a5ad574ba676969cf3f4618935daac1d42
2016-08-09 22:34:08 +02:00
jenkins-bot 4cc08e64ba Merge "Gemfile: Bump mediawiki_api from 1.7.1 to 1.7.2" 2016-08-09 15:48:41 +00:00
jenkins-bot 5d2a08ac11 Merge "Take link fragments into account" 2016-08-08 23:26:04 +00:00
jenkins-bot 1fe827197d Merge "Add titles to category input menu's items" 2016-08-08 21:56:43 +00:00
Translation updater bot dfef8c3865 Localisation updates from https://translatewiki.net.
Change-Id: I05610d6618a6f7c30b3097365df88f6643784f28
2016-08-08 22:37:27 +02:00
Alex Monk 071291d624 Add titles to category input menu's items
To match where they point to.

Bug: T139189
Change-Id: I46454cc9cd90920dc5e445200598a4706a8639c9
2016-08-08 21:09:36 +01:00
James D. Forrester cad4066bc9 Gemfile: Bump mediawiki_api from 1.7.1 to 1.7.2
Bug: T129483
Change-Id: Ief831d41df9352a824f4bd7a2a030cc4681950a2
2016-08-08 10:54:21 -07:00
Translation updater bot ffe086695f Localisation updates from https://translatewiki.net.
Change-Id: If723d65fed4f0c848c249edab18b41bf35320ee0
2016-08-07 22:46:02 +02:00
Alex Monk 818c6e4928 Take link fragments into account
TODO: Do we need to do anything special here to handle multiple hash symbols in a URL?

Bug: T112898
Change-Id: I4773cb04ae2533e8125bc55d9ebb606d63b3bf48
2016-08-06 01:20:24 +01:00
jenkins-bot cf4c2d41b3 Merge "Rewrite TOCWidget based on Linker::generateTOC" 2016-08-05 22:18:22 +00:00
jenkins-bot f908b7cad9 Merge "Make ArticleTarget#goToHeading work at all times" 2016-08-05 22:16:15 +00:00
jenkins-bot c813e5e5a2 Merge "Fix check for non-template-namespace transclusions" 2016-08-05 21:51:30 +00:00
jenkins-bot 89a529edc1 Merge "Fetch default options for gallery dialog" 2016-08-05 21:20:00 +00:00
Ed Sanders bb7b38575f Rewrite TOCWidget based on Linker::generateTOC
Use the new node cache to find headings.

Change-Id: I5eb75c5db5ca466fd6f16a57c693c2a4458cff7c
2016-08-05 14:11:15 -07:00
Thalia d156af59aa Fetch default options for gallery dialog
Fetch default options for mode, image heights and image widths
rather than hard-coding them.

Bug: T139632
Change-Id: I1adc7987fdeb1258ee87ce46acbab469ea18116e
2016-08-05 14:08:20 -07:00
Ed Sanders 3970288c8c Make ArticleTarget#goToHeading work at all times
Was previously written to work on initialise when the surface
isn't focused. If the surface is focused, run immediately.

Change-Id: Ie7accd63a4ca3e18448914d34609fe0418f15b4e
2016-08-05 14:00:41 -07:00
jenkins-bot 557ffff7ee Merge "Update VE core submodule to master (4408c13)" 2016-08-05 20:50:16 +00:00
Translation updater bot 94f32072e5 Localisation updates from https://translatewiki.net.
Change-Id: I4bcbfc42151afa8f7fc865c802ff5cf4783a67ec
2016-08-05 22:35:16 +02:00
Ed Sanders 34ff174b85 Update VE core submodule to master (4408c13)
New changes:
e7cb202 Mark context wrappers as wrappers
20b75af Localisation updates from https://translatewiki.net.
a4dde9f Annotate pasted external text
8148301 Always preserve leading whitespace when converting for clipboard
82a35b7 TransactionProcessor: Apply annotations to ranges at the highest uniform offset
21fc1eb Restore previous selection when annotation inspector is dismissed
358181c Preserve prior valid DOM selections in showModelSelection
a0f7dba build: Bump various devDependencies to latest
0ae0f7e Follow-up Iabec6a6: Fix typo in mousemove selection update code
d69a4df Provide tools to make text bigger or smaller

Local changes for big/small tools

Change-Id: If418a1a47276cc1e1530c4a3ad6784136d8d14f8
2016-08-05 11:54:52 -07:00
jenkins-bot dbf3cbb264 Merge "Make image list keyboard accessible in gallery dialog" 2016-08-05 17:07:51 +00:00
Alex Monk 8855ebf586 Fix check for non-template-namespace transclusions
These are not just titles beginning with ':'

Change-Id: I9d7063c221561a0e582deb6944eaab6d9ab4e3f7
2016-08-05 03:25:31 +01:00
Thalia 7d4864729b Make image list keyboard accessible in gallery dialog
Bug: T140874
Change-Id: I0f00f1ddb397fb8f543a04d62b94fc5db32180f6
2016-08-04 16:34:12 -07:00
Timo Tijhof c2897b5a92 mw.ArticleTarget: Fix FancyCaptcha reload button
Follows-up 843620632a in ConfirmEdit which now expects a specific class
on one of the image parent elements.

Without this the refresh link is broken as fancyCapatcha.js is
unable to find the image otherwise.

Change-Id: Iad7c8e8c77f58092ca4dbb5cbb3527cacff10f03
2016-08-04 15:40:41 -07:00
Translation updater bot 35f6c7d5da Localisation updates from https://translatewiki.net.
Change-Id: Iaf26584da2b9c63e071eb811bda5f3c0bbfc15fb
2016-08-04 23:31:28 +02:00
jenkins-bot aac64e6068 Merge "Use .textSelection( 'getContents' ) instead of .val() to get the value of #wpTextbox1" 2016-08-04 16:26:39 +00:00
Translation updater bot 31004d8e3d Localisation updates from https://translatewiki.net.
Change-Id: Ia724279eced3f0df76cbbafb1cd4a908098e6f24
2016-08-03 22:41:51 +02:00
Ed Sanders 4ae7bc6a31 Show name of template for invisible templates
Soft dependency on Id842389d in core.

Bug: T141861
Change-Id: I24f100dde387549a735ebd93e1c9a21f59f52170
2016-08-03 18:52:20 +00:00
Translation updater bot 530d911dd5 Localisation updates from https://translatewiki.net.
Change-Id: I17eb6510ad35f8e60f892b10b4430432601b08ec
2016-08-02 22:47:12 +02:00
Translation updater bot a27b270255 Localisation updates from https://translatewiki.net.
Change-Id: I7df748d430e3d52796e3af6677bf7e8060375df1
2016-08-01 22:37:52 +02:00
jenkins-bot af13aae426 Merge "Fix z-index issue on floating toolbar dialog" 2016-08-01 16:42:16 +00:00
Ed Sanders 8d17509031 Blacklist <time> annotation pasting in MW targets
Change-Id: Idef20f604023efa767c7510ed768c6f80e472559
2016-08-01 15:53:56 +01:00
Alex Monk 7f39d4e75d Use .textSelection( 'getContents' ) instead of .val() to get the value of #wpTextbox1
To allow gadgets like wikEd to use textSelection to return the latest value.

Bug: T135747
Change-Id: Ie353cf547dea6c100c5f01ab56c9b415be1ffdb8
2016-07-31 21:58:51 +01:00
Translation updater bot 84503e0a81 Localisation updates from https://translatewiki.net.
Change-Id: Ie71b6de35192c13339a0dec1aaa2a63d7cb753f4
2016-07-31 22:27:57 +02:00
Translation updater bot 981e878b5d Localisation updates from https://translatewiki.net.
Change-Id: If757b58ee8fff6962e1e5fc3fe338107103fbc95
2016-07-30 22:33:35 +02:00
David Lynch 53ad07ed72 MWLinkAnnotationInspector: change where auto switch to external occurs
OnInternalLinkChange happened post-validation, and received an already title-
normalized version of the href. Thus `file://` would become `:File://`. As
such, hook up to the raw internal link input change event, and judge what the
user actually entered.

Bug: T138956
Change-Id: I0f9f3de3b7bf6e5430e55fa69626522b0c74296a
2016-07-28 11:00:36 -05:00
jenkins-bot 11695a8528 Merge "MWLinkAnnotationInspector: switch to external tab on any schema" 2016-07-28 03:35:18 +00:00
David Lynch a95e6cab08 MWLinkAnnotationInspector: switch to external tab on any schema
Currently the switch only happens if it's a valid schema. Instead, switch if
any schema at all is detected, so we can tell the user it's invalid. If they
really meant to link to an internal wiki-page that just happens to start with
a "schema://", they can switch back to the internal tab to force it.

Bug: T138956
Change-Id: Icfd74157fd8439920668a417661265ddd52c9a21
2016-07-27 17:10:52 -05:00
Translation updater bot 2871ef41bc Localisation updates from https://translatewiki.net.
Change-Id: I73b1a6f72561397b8cacf798b7b877f09ba0bfb4
2016-07-27 22:40:42 +02:00
Translation updater bot e7e1ce91e9 Localisation updates from https://translatewiki.net.
Change-Id: Ib0e0dc671cdb6ada07657429ebcac1fa31a321b8
2016-07-26 22:57:37 +02:00
Ed Sanders 6064eb3dc4 Fix preview to use a valid document slice
An inline content node must exist inside a content branch node (paragraph).

Bug: T141306
Change-Id: I6bf2f99938940c1a5e34db16fbe582b15991a7c6
2016-07-26 16:06:07 +01:00
Roan Kattouw 5483b25657 Reduce mayhem caused by ?oldid=currentRevId
If you viewed a page with an ?oldid= query parameter set to the ID
of the current revision, some parts of VE would believe we were
in oldid mode (because there's an oldid present), but others
wouldn't (because the revid we're editing equals the newest revid).
This caused bugs when opening the editor a second time after saving
(which is normally impossible to do after an oldid-mode edit, because
we navigate to a new page after an oldid save, but we don't do that
in this case).

Ensure that:
* The internal state of DesktopArticleTarget is updated correctly
  after saving in this case
* The ?oldid= parameter is removed from the URL after saving
* DesktopArticleTarget.init doesn't preload the article HTML
  on a second/subsequent editor load: this causes issues because
  it caches the oldid, and generally speaking the Target's internal
  state is not considered

Bug: T141330
Change-Id: I74034328797c59f7249f1f6f4f53a92ee1c26334
2016-07-25 20:04:47 -07:00
Translation updater bot 519cdb2c34 Localisation updates from https://translatewiki.net.
Change-Id: I70c9b99aec2170e4634b369348f0b9bc668bd5e6
2016-07-25 22:26:36 +02:00
Ed Sanders d86bdccf89 Only apply font fix to global overlay
Bug: T141262
Change-Id: I6a99eefc683bb72c79bf13de2a1f89c37c443310
2016-07-25 14:48:49 +01:00
Translation updater bot a8dfd811ac Localisation updates from https://translatewiki.net.
Change-Id: I4282b43db782928122f4562cd3f9d07e284a4c56
2016-07-24 22:26:36 +02:00