Commit graph

15228 commits

Author SHA1 Message Date
Ed Sanders f2ac575ee2 Move save error messages above save footer
Keeps the more important information higher up the page.

Bug: T72266
Change-Id: Iaf29a5190af5f72c88eb1bfdacce199cd046eee4
2018-12-12 12:53:55 +00:00
Ed Sanders a9aa4d6c15 Fix save dialog error message transition
Element must be hidden for $.slideDown to work.

Also speed up animation to OOUI default 250ms.

Change-Id: I0616c156f1893688abd80f9e47c1a88e9237d085
2018-12-12 12:20:24 +00:00
Volker E 3949712ec0 TransclusionDialog: Fix removeButton position
Change-Id: I886c64f51fe54483d24c6cfa925b698db7bf4e7e
2018-12-11 16:05:33 -08:00
Translation updater bot 3327489556 Localisation updates from https://translatewiki.net.
Change-Id: Id3cd0300d1abec73d90a5bfd767588ad880c8d81
2018-12-11 22:40:12 +01:00
jenkins-bot 7fe951e5e1 Merge "Exclude deprecated params from search list" 2018-12-11 21:01:56 +00:00
jenkins-bot a5be866ba3 Merge "Allow trackdebug to work independently of debug" 2018-12-11 16:44:45 +00:00
jenkins-bot c306244744 Merge "Bring back 'alert' indicator" 2018-12-11 16:29:28 +00:00
Ed Sanders 3e10592ab7 Allow trackdebug to work independently of debug
Bug: T211698
Change-Id: I28f4fa4d516195e5459484c5d3df1b0566357a25
2018-12-11 16:13:06 +00:00
Ed Sanders ec42733225 Rewrite DOM junk filter as array concatenation
Avoids regressions like If399319b2675ac8c.

Change-Id: I43851931e3b9ee461abd0cfce0627bfb6a2bd041
2018-12-11 15:23:37 +00:00
Ed Sanders ae1095d313 Exclude deprecated params from search list
Only show param info if the exact field name/alias is entered

Bug: T207897
Change-Id: Ic5be8b8cd7698b88ab89d771769f2e9ba407dfa9
2018-12-11 14:59:54 +00:00
Ed Sanders 85974b171c Bring back 'alert' indicator
Was removed upstream in OOUI, but we require it to
show that parameters are deprecated.

Resize to fit new 12x12 size for indicators.

Change-Id: I2356de0754a2ccf09b87b152f3023282f2e37f41
2018-12-11 14:25:48 +00:00
Bartosz Dziewoński 27fdbe0581 Fix filtering out .donut-container again
Follow-up to a5c5176333.

Bug: T189148
Bug: T209619
Change-Id: Ibcf3c93e5b1121f8168ab3280a41917e8f7baa7d
2018-12-11 01:12:35 +01:00
James D. Forrester 12e45c1416 Update VE core submodule to master (f2fc6d05d)
New changes:
a6d7b4da9 Localisation updates from https://translatewiki.net.
2a820d0c4 Fix paste issue for nested lists from macOS Notes app
1b9e09687 build: Update devDependencies

Bug: T211516
Change-Id: Ia836f80d65d3ea60bce4019613e416ce7e2097dc
2018-12-10 08:42:47 -08:00
Translation updater bot 4e4efb10eb Localisation updates from https://translatewiki.net.
Change-Id: I2bdfc04602d6b67ccedd1fa72f5e3385a1686007
2018-12-09 22:39:24 +01:00
Alangi Derick ca84615538 Fix incorrect return PHPDoc annotation VisualEditorHooks.php
onDiffViewHeader() method returns a void per "return;" which is valid
from PHP 7.1 and above. This method doesn't return bool per it's definition.

Change-Id: Ifee65dfce3af104d89ba3c91602501da6bbbc20c
2018-12-09 16:26:30 +01:00
Translation updater bot 08f5bb021f Localisation updates from https://translatewiki.net.
Change-Id: I3aec0023f5edc6d6e4c3fc5a5f776bf04b82db0c
2018-12-07 22:21:55 +01:00
jenkins-bot e0edd25855 Merge "Drop EducationProgram hacks, now that it's undeployed" 2018-12-07 19:50:21 +00:00
Bartosz Dziewoński 0f05dafa6f Make SaveErrorHandler receive entire API response
Previously we passed either data.visualeditoredit.edit or data.error,
which was mostly okay since they are mutually exclusive, but it could
still theoretically conflict if both objects had identical properties
(and receiving different things could make debugging errors harder).

Change-Id: I818d916275b8451af6910ddaa7cd4d7c653085ee
2018-12-07 14:17:16 -05:00
jenkins-bot ceed727a3a Merge "Remove TitleBlacklist handling code" 2018-12-07 19:03:49 +00:00
jenkins-bot 349b93f733 Merge "Pass error data to SaveErrorHandler on error" 2018-12-07 19:02:47 +00:00
James D. Forrester d1bd119d2a Update VE core submodule to master (860f28129)
New changes:
860f28129 Update OOUI to v0.29.6

Change-Id: I0e7147627efdeb4b23e050758c42cbdc5647467b
2018-12-06 14:12:08 -08:00
James D. Forrester dab9c26c4d Drop EducationProgram hacks, now that it's undeployed
Change-Id: I65030e3e1b5ce006a458cfbe65a97e738a00a4c3
2018-12-06 12:14:03 -08:00
Ed Sanders 278789e27d Remove TitleBlacklist handling code
This has been moved to the TitleBlacklist extension.

Bug: T211242
Change-Id: Ia15c2619e6c642b3ceb567c28f77b50ccf41731a
Depends-On: Ibaf8a37f1aaef510923bde5ed9114f1f00fff461
2018-12-06 15:00:06 -05:00
Ed Sanders be548979fe Pass error data to SaveErrorHandler on error
Change-Id: I9d7efbecfd954acff86f279f75aa80a9fcc10c89
2018-12-06 14:59:30 -05:00
jenkins-bot 1740eed0cf Merge "Change rules when displaying block log extract" 2018-12-05 23:55:28 +00:00
jenkins-bot 1684f2ef0c Merge "ve.init.mw.SaveErrorHandler: Correct code comments" 2018-12-05 22:24:35 +00:00
Bartosz Dziewoński 9177974c28 ve.init.mw.SaveErrorHandler: Correct code comments
Change-Id: I6e3a883b8c2600953da038aa4ad3601258e1d87d
2018-12-05 16:37:13 -05:00
Translation updater bot 68c14881d9 Localisation updates from https://translatewiki.net.
Change-Id: Iee8ba24c3e4c527dafe28ddcd93e0ad57d68e687
2018-12-05 22:30:33 +01:00
Ed Sanders be9c6800ad Audit target hooks
* Move (de)activationComplete up to ArticleTarget
* Mark (de)activate to be deprecated in the future
* Fix some properties to ensure target.edited is boolean

Change-Id: Ie34139cb68f90f34eb243f1bb964ef578e90dfb2
2018-12-05 15:45:19 -05:00
jenkins-bot d8cbff898b Merge "Guard against Target#teardown being called twice" 2018-12-05 17:49:26 +00:00
Ed Sanders a89908d58a Guard against Target#teardown being called twice
Change-Id: Ifa8328ee865fadd6ddaf6b35b5ee34284068b620
Depends-On: Icef5b34abd40bfd21aac71a705ef21f6277d21a5
2018-12-05 11:11:09 -05:00
Dayllan Maza ee02653eaf Change rules when displaying block log extract
Show log extract if the user is sitewide blocked or is partially
blocked and not allowed to edit their user page or user talk page.

The check on the block type is being added to keep it in sync with
what it is currently being done on core.

Bug: T203171
Change-Id: I00ebb5cbcb1ec14e778c2936187cbcebc0829163
2018-12-05 00:35:38 -05:00
James D. Forrester 6855c75089 Update VE core submodule to master (0d3e1acfe)
New changes:
6f390c623 Localisation updates from https://translatewiki.net.
e82ceff49 ve.ce.TableNode: Fix infinite loop when extending linear selection to table
0d3e1acfe Enable jQuery/no-extend rule

Bug: T210798
Change-Id: I8c658825a2b30e3d738c30addddedb2b67f2fef0
2018-12-04 15:52:02 -08:00
jenkins-bot f583a0fb6a Merge "Move ve.init.mw.saveErrorHandlerFactory and fix documentation" 2018-12-04 23:34:05 +00:00
jenkins-bot a6b64b6b46 Merge "Remove AbuseFilter & SpamBlacklist code" 2018-12-04 23:03:29 +00:00
Ed Sanders 1ee9a739a1 Move ve.init.mw.saveErrorHandlerFactory and fix documentation
Change-Id: Icc8a4d1daf17a1a4cd0d7b2ad97f61916f2a222e
2018-12-04 17:55:35 -05:00
Translation updater bot 3de231288b Localisation updates from https://translatewiki.net.
Change-Id: I946eec28c40c13ba4e4dd8a2419ee7359ea3a093
2018-12-04 22:14:43 +01:00
jenkins-bot 710aaced4b Merge "build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass" 2018-12-04 14:59:06 +00:00
jenkins-bot df125c3303 Merge "trackSubscriber: Set timing property to a number, not an object" 2018-12-04 00:07:53 +00:00
Roan Kattouw 611d9ca6c5 trackSubscriber: Set timing property to a number, not an object
The timing variable is a private closure variable containing an object
that tracks the timestamps of different events in the current cycle. The
duration variable is the result of using that information to compute the
difference between the current timestamp and the relevant anchor
timestamp. For the '_timing' property in the EventLogging data, duration
is the correct value, not timing.

(This is confusing and we should probably rename the timing variable.)

Change-Id: Iff78eb0ab83c84b73ad5c8f3eb85b1c7f120ebef
Follows-Up: Ifc2135d99f4bec917dac60992098958b72c37fc6
2018-12-03 15:33:18 -08:00
Translation updater bot 6ff740e758 Localisation updates from https://translatewiki.net.
Change-Id: Ifb437de9423b68550458ce0850ba5f89e8fe5c59
2018-12-03 22:35:40 +01:00
James D. Forrester 309d05cb38 build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass
Change-Id: I4c547757ed5a32ff98b1cf2670010db302bd8467
2018-12-03 13:06:59 -08:00
Translation updater bot 7cb3e042c2 Localisation updates from https://translatewiki.net.
Change-Id: Ie63d71f5527ea719347a7126295b2b557a016680
2018-12-02 22:15:10 +01:00
Ed Sanders 103a34bb75 Remove AbuseFilter & SpamBlacklist code
Moved to their respective extensions

Change-Id: If463068a862cfde15ab4d250a1424c88a5229176
Depends-On: Ib1354f0404209a15194895026ff9d179d16b1900
Depends-On: I1807a5d3d99ecab2bf4545a1bab3aa3f2ae64da8
2018-12-01 14:03:11 +00:00
James D. Forrester 84ce7f1c4f Update VE core submodule to master (52b89a9db)
New changes:
ac8b90baa Use ve.dm.SurfaceFragment#hasMatchingAncestor where possible
3008ac425 ve.ui.FormatTool: Remove unused property
bae540ab3 eslint: Drop 'dot-notation' rule
0df7b6921 build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass
b1e836eac Localisation updates from https://translatewiki.net.
48b1be92d ve.dm.Change: Fix guessing selection for internal-list-only transactions
5722bab84 Enable jquery/no-(show/hide/toggle) rules
ed14182e0 Guard against Target#teardown being called twice

Bug: T208914
Bug: T210552
Change-Id: I0ba709bec3399e3d595ea830fe44e6ede1c6c2e6
2018-11-30 15:35:56 -08:00
jenkins-bot 7927a8e395 Merge "Create SaveErrorHandler class to better define structure" 2018-11-30 23:06:11 +00:00
Translation updater bot 85e4bc7846 Localisation updates from https://translatewiki.net.
Change-Id: I9844de6eb5a64d9c72d6a7f62e6f37ec55a39367
2018-11-30 22:50:13 +01:00
jenkins-bot cb5608693a Merge "Enable jquery/no-(show/hide/toggle) rules" 2018-11-30 19:38:49 +00:00
jenkins-bot 685533c86f Merge "ve.ui.MWTransclusionDialog: Remove unneeded code re-setting insert label" 2018-11-30 17:12:40 +00:00
Ed Sanders 5801273cbb Enable jquery/no-(show/hide/toggle) rules
Change-Id: I1ab177467fb9e8d0319c02d7770704b16456751d
2018-11-30 12:27:29 +00:00