Commit graph

7131 commits

Author SHA1 Message Date
Roan Kattouw 2598fe8088 Use apiRequest() function in MWMediaEditDialog
Change-Id: I4fbc3f2080660b217beb502c6cf3007197627a14
2014-02-06 22:37:04 +00:00
Trevor Parscal d487b44dd0 Auto-select first auto-added required param and fix param order
Symptoms:
* When adding a template with required parameters, the last parameter
  is initially focused
* Parameters and parts appear out of order, and adding/remove/moving
  them shows them in almost random placement

Diagnoses:
* Parameters are auto-focused when added, and parameters are auto-added
  in forward order
* TransclusionModel's process method had a bug in which the code to
  derive an offset from the item being removed would not be reachable
  due to an inverted logic statement

Prognosis:
* Fatal, with a 10% chance of survival

Treatment:
* Set focus on the first parameter after auto-adding required
  parameters to a template
* Invert the logic in TransclusionModel's process method, so that if
  the index IS undefined we will proceed to define it

Change-Id: I299053b63045ec933747831f1b4aa63493760f8b
2014-02-06 13:21:14 -08:00
Roan Kattouw b49adadcc7 Fix crashes in onLoadError()
The jqXHR parameter is optional, so handle the case where it's null
gracefully.

Also fix the documentation for this method, it was full of lies.

Change-Id: I6ab799846a4d4b0d10cc5fd4d8c47264b1845bdf
2014-02-06 21:17:23 +00:00
Translation updater bot b26716156c Localisation updates from https://translatewiki.net.
Change-Id: I05aa543201d657fc883f81a0c0ad58748b8104a0
2014-02-06 20:43:25 +00:00
jenkins-bot 5ae8976ac1 Merge "[Browser test] Reintroduce headless browser test support" 2014-02-06 16:28:30 +00:00
Ed Sanders 0d0b7b2e46 Always show 'File:' in content language for gallery placeholder
Requires extending placeholder text to use a getter, rather than
a simple message name.

Change-Id: I712aae40bf89fc14fb03530b2a1c2bdf183ab19d
2014-02-06 04:15:11 +00:00
Ed Sanders 406e54036d Don't allow extensions to have no content by default
Change-Id: I5788de6d39aedb1f40842fa1e218374e330c9f6c
2014-02-06 04:14:58 +00:00
jenkins-bot a1d4acca0f Merge "Adding position setting to media edit dialog" 2014-02-06 03:02:41 +00:00
jenkins-bot 78680bb527 Merge "Adding alternate text to media edit dialog" 2014-02-06 02:59:21 +00:00
Jeff Hall 8e8525dea9 [Browser test] Reintroduce headless browser test support
Change-Id: Ie9a908a40ad9210fb0df6bdb20f0c6a35ce548d8
2014-02-05 17:38:35 -08:00
Roan Kattouw d8c9c30999 Update VE core submodule to master (08083de)
New changes:
116dec8 Localisation updates from https://translatewiki.net.
a241e46 Make globalOverlay really global

Change-Id: Ic288779c99a30157e1b20f37bb8aed973b1e9afc
2014-02-05 17:27:57 -08:00
jenkins-bot 5c8627dbc7 Merge "Implement SVGMaxSize" 2014-02-06 01:06:41 +00:00
jenkins-bot 6c42b762c3 Merge "Rebuild .docs/eg-iframe.html" 2014-02-06 01:04:28 +00:00
Ed Sanders d169108eeb Implement SVGMaxSize
wgSVGMaxSize sets the maximum size for the shortest edge of a
vector image. Pass this through to MWImageNodes.

Change-Id: I6410e7cda137cf4828d12280cb1e5cfc27805859
2014-02-06 00:59:25 +00:00
Roan Kattouw d2df039af2 Rebuild .docs/eg-iframe.html
Change-Id: I010eb7fc1d043494c34cb9f6d1c17af501bf8a68
2014-02-06 00:58:51 +00:00
Ed Sanders 5aafc1256f Hide automatic reference names
Anything which matches :[0-9]+ is not particularly helpful
to display.

Bug: 57875
Change-Id: I63e7c6fffe275f7869adeafb35390de4b85d0c1b
2014-02-06 00:57:41 +00:00
jenkins-bot 20d6df9a65 Merge "Only generate transclusion contents for clipboard" 2014-02-05 23:02:28 +00:00
jenkins-bot 8f435960a9 Merge "The great image scaling rewrite of 2014 (MW)" 2014-02-05 23:01:15 +00:00
jenkins-bot 64fad7695b Merge "Move image info API call to media node" 2014-02-05 23:00:13 +00:00
jenkins-bot 10fec23d04 Merge "Update VE core submodule to master (b9598c6)" 2014-02-05 22:59:23 +00:00
Translation updater bot 85fa839839 Localisation updates from https://translatewiki.net.
Change-Id: I02d167bb6ad9cb716b1e91f50a6ff23c9030fbd6
2014-02-05 21:44:25 +00:00
Jeff Hall 90d46cb15c [Browser test] Get transclusion test back to working with Chrome
Getting rid of a pesky comment that sneaked in somehow...

Change-Id: I4d06ea8f038d3b176d5340897b50b921fa5d8918
2014-02-05 13:12:59 -08:00
Moriel Schottlender b522994344 Adding position setting to media edit dialog
This adds an image position/alignment to the media edit dialog.

Bug: 51293
Change-Id: I15fbd1ed0998a9093fa039b76624395d661af05b
2014-02-05 20:56:37 +00:00
Moriel Schottlender e8205a7133 Adding alternate text to media edit dialog
Adding an option to add or edit alt text to images in the media edit
dialog.

Bug: 38129
Change-Id: I6d339781822175c40c66a4689ec6e1a873cb081d
2014-02-05 20:56:30 +00:00
Ed Sanders fb4f7d3e24 The great image scaling rewrite of 2014 (MW)
Implement new logic in ve.Scalable from I5b4f0f91b.

Also update VE core submodule to master (57ed8d3).

New changes:
59a0afe The great image scaling rewrite of 2014

Change-Id: I24a2976036310d3814cc7d1853a68745e0499bd5
2014-02-05 12:55:11 -08:00
Ed Sanders 61d010df2f Move image info API call to media node
As other widgets may be interested in the image info, this should
be part of the DM node, which the media edit dialog then fetches
and uses to populate the MediaSizeWidget.

Other fixes:
* Remove spinner, not really necessary as the orignal size button is
  disabled if the orignal dimensions aren't set.
* Don't wait until image info call to resolve to initialise size
  widget values. These should always be available instantly from the
  attributes.

Depends on I9530ed4257e88b in core.

Change-Id: I394f49941b621059bc08c8a8f79471b2fe16c7d8
2014-02-05 12:48:31 -08:00
Ed Sanders 13eb918087 Only generate transclusion contents for clipboard
Parsoid doesn't care about the transclusion contents and it can
cause bugs if not removed properly. Remove the about group attribute
as that was for Parsoid's benefit.

Depends on Ib29972472d in core.

Bug: 60897
Change-Id: I907b2113c257baff5c022ff0749dca9dbb1fba5f
2014-02-05 12:45:55 -08:00
Roan Kattouw ba45289fb8 Update VE core submodule to master (b9598c6)
New changes:
0612b31 Allow style attributes to be pasted from other VE instances
aa02be3 Add 'forClipboard' mode to converter

Change-Id: I525584f06be4c13db0373d6d6e94a8f532a888fe
2014-02-05 12:41:00 -08:00
Ed Sanders 425d6fee54 Exclude galleries from reference/caption surface tools
Because putting galleries in either would just be silly.

Change-Id: I03013607f3caae0053661c3c47d46b888ab5fde0
2014-02-05 19:45:56 +00:00
Ed Sanders d7e9564d22 Hide structure tools in MWReferences
Technically these are possible to render (although there's currently
a Parsoid bug preventing it) but really references should just contain
one single paragraph.

Change-Id: I405d75a0935d3f4610e10b942b48fa0fa2679a20
2014-02-05 19:39:39 +00:00
Ed Sanders 1e6daf1ee6 Implement surface paste rules for media/ref dialogs
Extend default paste rules to prevent lists/tables/references/headings
as applicable.

Also update submodule to master (76ff210).

New changes:
f1a927f Internal paste rules and type conversions

Bug: 59603
Change-Id: I952f98477219a55d25a2bd817344bde58a4862d4
2014-02-05 11:17:33 -08:00
Roan Kattouw db2661d020 Update VE core submodule to master (bb8d19c)
New changes:
9e674cb Add paste rules to surface widget config
57a1825 Localisation updates from https://translatewiki.net.
e3d279b Localisation updates from https://translatewiki.net.

Change-Id: I17539f856589e9c50c60ee737c8b16da63a41d6b
2014-02-05 10:52:58 -08:00
jenkins-bot ef111afe02 Merge "Set wfUseMW down to MW 1.22" 2014-02-05 18:19:08 +00:00
James D. Forrester 9a2fb3cfe1 Set wfUseMW down to MW 1.22
Our only dependency on MW was backported from MW 1.23wmf2 to 1.22 before
it was released, so this has been unnecessary.

Change-Id: I6652e6a0a783d33fc8a10eff62128e87923c2510
2014-02-05 08:46:11 -08:00
Translation updater bot 8e4fe35f87 Localisation updates from https://translatewiki.net.
Change-Id: I9fb62c00efa3cb6e72dfe312b1e5c7a1ab32d227
2014-02-04 21:06:47 +00:00
Ed Sanders 047d6bf6cc Fix usage of '$' in MWReferenceSearchWidget
Easier to just use native getAttribute.

Change-Id: Ibd72eb457bb82b3b134d1eb29c4c33b3b9a7242f
2014-02-04 16:09:38 +00:00
Ed Sanders c528a0ffea Fix 'use existing reference' list rendering
Got broken by mass $ -> $element conversion in If3d870124ab8d1

Bug: 57209
Change-Id: Iada098d0fa361f4a825a4c87aa8a7493386855e4
2014-02-04 15:55:04 +00:00
James D. Forrester 4cd9ab2b88 Update VE core submodule to master (54ab0cd)
New changes:
256fa43 A better label for the original size button

Change-Id: I828025ac0718f1908089d59a948e1a779da7b915
2014-02-03 20:50:31 -08:00
jenkins-bot dbe8441557 Merge "Add placeholder for gallery editor" 2014-02-03 22:18:46 +00:00
James D. Forrester 87dd841150 Add placeholder for gallery editor
Change-Id: Id351cea8614282924eb9b1644693f7cd71fd9fa4
2014-02-03 14:05:49 -08:00
Translation updater bot 5fa1c98299 Localisation updates from https://translatewiki.net.
Change-Id: Iaf6b92dcac5199872caba55bbafe6178e7159731
2014-02-03 21:23:58 +00:00
James D. Forrester 7b54c6d7a2 Update VE core submodule to master (5092503)
New changes:
2bd4437 Check target container is attached to ownerDocument
9620ea1 Localisation updates from https://translatewiki.net.
816e5df Update oojs to v1.0.7
975183e Upgrade UnicodeJS to Unicode 6.3 spec
0eedc9b Localisation updates from https://translatewiki.net.
1fc0d04 unicodejs: Make tool executable, fix path
5092503 Use new jscs options, disable deprecated JSHint checkstyle options

Change-Id: Ic549221c86a83c88c2c15c49ec969abe30e2dd17
2014-02-01 19:35:17 -08:00
Roan Kattouw 74242c790a Add updateSubmodule.sh script
Generates a commit that updates the VE core submodule to
master (or a specified version)

Change-Id: I54c5fa18e9f9d7bb65a490415c5c139fd6072925
2014-02-01 19:03:55 -08:00
Translation updater bot 84433d6deb Localisation updates from https://translatewiki.net.
Change-Id: I99af5d06b49085353cb3641b32abfa80b2eb5916
2014-02-01 19:48:00 +00:00
jenkins-bot 4ec405342c Merge "Fix search results when $wgDebugToolbar is enabled" 2014-01-31 02:37:18 +00:00
Krenair fc56562364 Fix search results when $wgDebugToolbar is enabled
When $wgDebugToolbar is enabled, a debuginfo key is always returned from the
API.
Unfortunately that broke the ve.isArray check on the result, breaking the
opensearch calls by the linker.

Change-Id: I907ef6fc2589581cf7333af3968b63b483af65a9
2014-01-31 02:34:39 +00:00
jenkins-bot 8960cc252b Merge "Revert "Make it possible to run VisualEditor tests in headless mode"" 2014-01-31 02:05:42 +00:00
Jhall 26a4623ddd Revert "Make it possible to run VisualEditor tests in headless mode"
This reverts commit 9a20fc03b7.

This change appears to have completely broken the VisualEditor browser tests :(

Change-Id: Ia2753f0718ccc5ac5ce7b726bd89040171feae7c
2014-01-31 02:02:56 +00:00
jenkins-bot 92f62d3261 Merge "[browser test] cucumber.yml is no longer needed" 2014-01-30 18:38:46 +00:00
Zeljko Filipin 9a20fc03b7 Make it possible to run VisualEditor tests in headless mode
Bug: 60584
Change-Id: I63782af45610d4e5fcbbea73d7f8d68035faee1a
2014-01-30 17:32:38 +01:00