.test() is the dedicated syntax for a boolean "does match? yes/no?"
check. .match() returns an array of matches, or null. This is just not
needed in these situations.
Change-Id: Ibb996ab843d1a6c7d7af98d6a112990665d543b2
Also invert logic and rename variables to make tests in tryTeardown
and switchToWikitextSection identical.
Bug: T294463
Change-Id: Icb86a676c3f315e4a3d229f46eb383dcd7959973
We ended mixing two concepts in a single method:
* We need a method that allows us to create the parameter list widget
when it's needed, even if it's empty. This is relevant when a template
is entirely empty, and the first parameter is added. This wasn't
working. Instead the parameter list was created with all parameters.
* On initialization we either want all parameters to be shown, or only
used ones. But this code is only needed once, on initialization. I
ended inlining this code in this patch.
Bug: T300640
Bug: T304046
Change-Id: I6620a870e4420dcb8fecf522b3274458eeec891d
A class, mw-broken-media, was added in
I92359048b42d32fe8a0f2cb79cd348cf5f2c56cc
Bug: T304010
Bug: T270150
Change-Id: I542d7d879868c9030ce00b2686cdfd0077e49491
A better assertion if the VisualEditor is opened would be to check for
editing toolbar instead of checking for a notices popup.
Bug: T296187
Change-Id: Ide816646254bc856b44725490c25b2b9962188c9
These two lines forcefully enabled the review/preview buttons, even
when the review/preview panel is already active.
Bug: T300448
Change-Id: I6dbe6ee88728a65233a455b768f17bff668fe3a8
In the mobile view, parameters don't have left padding so some styles
should only be applied to the desktop stylesheet.
Bug: T304167
Change-Id: I1846512c21aae36f212fe142b7d96ac91e46854b
Currently in VE desktop, items which can be deleted with
delete/backspace do not have this button. If that situation is
considered a problem it sould be solved consitently for all
focusable nodes as part of a wider fix.
Adding a delete button to template contexts makes them inconsistent
with other focusable nodes.
Bug: T274263
Change-Id: I2f7508a605852274ba8f40b2afd1dfd56600aa36
"Author" is used on Commons and in various places in
MultimediaViewer. Artist is not used in these places.
Bug: T267501
Change-Id: Iccd2d926537a7d4147e6cc8b5c2c9c1ecf4d6b27
This fixes a styling issue with inline descriptions, for the scenario
when the inline description feature is enabled but the new sidebar is
disabled.
Bug: T304167
Change-Id: Ida4da4605da5143de2a27725d87d5876aea7065c
New changes:
3206d66bb Use $.parseHTML() in tests where appropriate
c99d63f66 Localisation updates from https://translatewiki.net.
cd5798146 Update OOUI to v0.43.2
98c7288fd Fix margin wrapper paragraphs in placeholders too
639d81bd1 FocusableNode: Documentation typo fix
23daa81a0 Localisation updates from https://translatewiki.net.
e84c40a5d ve.ui.Sequence: Put optional arguments in a config object
c79dcf48f Add backtick sequence for <code> formatting
Bug: T299817
Change-Id: I56b77aae31b80e2fdef113d3431740340419d2f0
The Apex skin (not to be confused with the Apex OOUI theme)
is abandonware. Keeping files around that pretend to support it
is just maintenance debt.
Change-Id: I176e4e25307ab8ca4166a6e9b55e3bec4f058d05