Commit graph

145 commits

Author SHA1 Message Date
jenkins-bot 2e24426fdf Merge "[BrowserTest] Fix the lists and indentation screenshot scenario" 2015-05-15 13:35:47 +00:00
Amir E. Aharoni 462315f16f [BrowserTest] Fix the lists and indentation screenshot scenario
* The element's class name changed.
* Zooming is removed - it was breaking the test and
  it's not needed anyway.
* Fix another element with the same class.

Change-Id: I46a867619ed49936c3868f6b1b15e773bdb6f6b1
2015-05-15 15:02:34 +03:00
Amir E. Aharoni e471860536 [BrowserTest] Fix the special character button screenshot
The element moved out of the Insert menu to the toolbar.

Change-Id: I7c563af858a37f360bd2e4b4ba2e8a7098bc94e6
2015-05-15 13:56:47 +03:00
Amir E. Aharoni 8cb387a269 [BrowserTest] Redefine the Apply changes element for language screenshot
Redefine the element to include the full button
and remove the padding, which is now not needed.

Change-Id: I1ac244bc97b38c9d8b47ddd778a653783a748a49
2015-03-27 14:16:48 +03:00
Amir E. Aharoni d941263d33 [BrowserTest] Add padding to some more screenshots
Change-Id: If103488927e3309479b7b5f9f380135052c7ac9d
2015-03-27 14:11:14 +03:00
Amir E. Aharoni 0745d38a72 [BrowserTest] Add padding to the "Apply changes" button screenshot
Change-Id: I1a7aaca8013bf671ff39c310d5ad0dd1725b094a
2015-03-27 00:43:49 +02:00
Amir E. Aharoni 0cd5797a56 [BrowserTest] Add padding to screenshots of the page settings dialog
Change-Id: I460fc82a10ca5172537a97f28f3a50573c784a93
2015-03-27 00:43:01 +02:00
Amir E. Aharoni a1271abae3 [BrowserTest] Add padding to the Edit Links screenshot
Change-Id: Ife795e5f34b69fc6790cd04b217f823205737c0c
2015-03-27 00:41:38 +02:00
Amir E. Aharoni 5795b84d59 [BrowserTest] Add padding to the page settings item screenshot
Change-Id: I38f9d81cbfaa28c51997105bdc2cbaa81ed02783
2015-03-27 00:40:31 +02:00
Amir E. Aharoni fb4212232d [BrowserTest] Show the full Formatting pull-down in the screenshot
The scenario for the Formatting pull-down screenshot didn't click
the "More" element in the bottom. This is now added.
The "More" element itself is redefined to be generic and work with
all pull-down menus - there is supposed to be only
one active menu at a time.

Change-Id: I27122f3192b220919311993ecd9a10d85ef5828d
2015-03-27 00:31:11 +02:00
jenkins-bot c3ac0f0dd1 Merge "[BrowserTest] Add padding to the Formatting menu screenshot" 2015-03-26 14:28:45 +00:00
jenkins-bot cc4ac9c327 Merge "[BrowserTest] Add the toolbar to the special chars screenshot" 2015-03-26 14:28:39 +00:00
Amir E. Aharoni 0631a42735 [BrowserTest] Add the toolbar to the special chars screenshot
This makes it clearer which button opens the special character tool.

Change-Id: I34a2ba182af0bdce164c4b21f97ee1bb13152593
2015-03-26 16:20:19 +02:00
jenkins-bot b669d5a95d Merge "[BrowserTest] Add padding to editing tabs screenshot" 2015-03-26 14:17:22 +00:00
Amir E. Aharoni 96a2aad660 [BrowserTest] Add padding to the lists and indentation screenshot
Change-Id: I7ef7f1b0bbf3a0a7b56cb7051677a0df3ff8a41b
2015-03-26 15:59:44 +02:00
Amir E. Aharoni f7c2edf886 [BrowserTest] Fix the lists and indentation screenshot
Capture the whole button and menu.

Change-Id: I035109916a90efbd12e5f3ddb58b98a53b8e57d3
2015-03-26 15:57:42 +02:00
Amir E. Aharoni ef5bd83e55 [BrowserTest] Add padding to the Formatting menu screenshot
Change-Id: I606678381a9d291342b3c5d9cba67aef125725ee
2015-03-26 15:40:47 +02:00
Amir E. Aharoni d7926f460c [BrowserTest] Add padding to editing tabs screenshot
Change-Id: I60b915f470a751c041718bf339fa5bd27d5291ef
2015-03-26 15:38:00 +02:00
Amir E. Aharoni 8eb5ca1536 [BrowserTest] Add padding to Insert button screenshots
Change-Id: Ic79942bddf811b7f219424c9ae317c7664f9a193
2015-03-26 15:23:49 +02:00
Amir E. Aharoni b62be2355e [BrowserTest] Capture the whole Insert button in the screenshot
Change-Id: I7551914d57adace5ceb385f16cc93e146e4774a7
2015-03-26 15:13:47 +02:00
Amir E. Aharoni 1d1ffac74e [BrowserTest] Capture the whole formatting button in the screenshot
This makes the screenshot nicer and more complete.

Change-Id: I0dd9efd2978ff5468ab6101b11b7e6fdd3b0da30
2015-03-24 12:34:42 +02:00
Amir E. Aharoni cbed069984 [BrowserTest] Rename headings dropdown scenario
Change-Id: Ib59cf24ad30823ddfcf1d31a9eb2c45efd0199fc
2015-03-24 10:45:22 +02:00
Amir E. Aharoni 8c48b3055f [BrowserTest] Add padding to the Headings dropdown screenshot
Makes it look nicer.

Follow up to
Iff47eaa2c3fe09264501ae82f6ee1bf7044a3556

Change-Id: Ic4d473159942918776b7c5e7107e48b824c228e3
2015-03-24 10:31:50 +02:00
Amir E. Aharoni 47af0b6449 [BrowserTest] Capture the whole dropdown indicator in the screenshot
The Headings menu screenshot started from the arrow-down element:
https://commons.wikimedia.org/w/index.php?title=File:VisualEditor_Toolbar_Headings-en.png&oldid=154425461

Now it captures the whole menu so it will look more complete

Change-Id: Iff47eaa2c3fe09264501ae82f6ee1bf7044a3556
2015-03-24 10:18:33 +02:00
Amir E. Aharoni 065d26e363 [BrowserTest] Add a screenshot for the Page settings menu item
Change-Id: I0ec601dc9559521746fe6e7fbad05f2df8f7497e
2015-03-23 12:38:45 +02:00
Amir E. Aharoni 73523eb5cf [BrowserTest] Add a screenshot for the category item
Change-Id: I3f607e1013dbdac6974b33b557d8a0fffe4d4590
2015-03-23 12:31:00 +02:00
Amir E. Aharoni c4f21ecd03 [BrowserTest] Remove when_not_visible check from 'I click Save page'
The when_not_visible line fails, but it doesn't seem to be needed
in the first place. The when_present line appears to be enough.

Change-Id: I572dabb5d53553d454f6e40c5602fbe3252c3657
2015-03-19 14:54:32 +02:00
Cmcmahon 698f36cdd4 [BrowserTest] update Cite test for new UI
* Access to Cite options changed
* Various target locators also changed

Paired with Rummana for these changes.

Change-Id: Ib7c3fbd1842879745d3d3128c66d90cc2b4f98cb
2015-03-17 15:54:14 -07:00
Cmcmahon e68e3d70fb [BrowserTest] diff view altered slightly.
Since Bug T90654 has not been addressed in two weeks, I would
rather make the test pass, assuming that the slightly altered
diff view is a feature not a bug.

Change-Id: Id2ce34b2838cf56a9411173f9b2e9ad8e5320545
2015-03-10 15:50:33 -07:00
Cmcmahon ac5a38a03d [BrowserTest] fix edit test
This has been failing for a while, for several reasons, originally
because an updated version of Cucumber interpreted an "&"
character in an unexpected way.

Change-Id: Icd79ec9b489557c3259ff7f2c11b2a899c767d0f
2015-03-10 14:27:03 -07:00
Amir E. Aharoni 76b50c5b34 [BrowserTest] Update the Edit tab scenario
Make it clear that this scenario is supposed to test
and take screenshots of the "Edit source" and "Edit" tabs.

Change-Id: Ia480eacb2629553c378ecad52a9b0ed1336cd0f3
2015-02-26 12:59:34 +02:00
Amir E. Aharoni 5a70225a6b [BrowserTest] Fix VisualEditor_More_Settings scenario
The screenshot here is supposed to capture the menu that opens
when the hamburger icon is pressed.

The previous code captured the whole toolbar. This is now fixed.

A sample screenshot is here:
https://commons.wikimedia.org/wiki/File:VisualEditor_More_Settings-en.png

Change-Id: Id9501b8b1b8d41411c2f81bf4d4954a6bb41addc
2015-02-25 00:17:15 +00:00
Amir E. Aharoni acf67c7af2 [BrowserTest] Update the scenario for Cite screenshot
This screenshot only needs the "Cite" button,
and not the whole dropdown menu.

* The clicking step is removed.
* The element is reconfigured.

Change-Id: If4b863e51db611b96186ca6381d0426a335a9a17
2015-02-25 00:16:53 +00:00
Vikas S Yaligar b960e4c999 [BrowserTest] Edited language screenshot steps which had iframe elements
Bug: T89370
Change-Id: If87d30fc23bfc867e6c62a3edefc8b2591c6ce48
2015-02-19 23:46:22 +05:30
Amir E. Aharoni efc8d0bcbd [BrowserTest] Add parentheses to regexp parameters
This fixes the AmbiguousRegexpLiteral Rubocop offenses.

Change-Id: Ief9e5e4904637b2cc863e7fd99404e0630fe0de3
2015-02-17 13:24:59 +02:00
Amir E. Aharoni 26763e7731 [BrowserTest] Fix ParenthesesAsGroupedExpression Rubocop failures
Change-Id: I7a6fbe0aefdd9abe3b0e7c42cc372487255f581b
2015-02-17 13:24:52 +02:00
Amir E. Aharoni c37fe8fe5e [BrowserTest] Move screenshot taking functionality to a gem
* Screenshot taking logic and rspec tests are deleted from this repo
  and moved to
  https://rubygems.org/gems/screenshot
* Dependency on chunky_png is removed from VisualEditor
  (and added to the screenshot gem).
* The method calls are renamed accordingly.

Change-Id: I6a0e2cc770a07f36f63bc536db109b63d38a4fd2
2015-02-17 09:57:44 +00:00
Cmcmahon df1013b7da [BrowserTest] Remove unused steps and locators
No more iframes

Change-Id: I3d6420f2a017a132d5695921daa5efb5117f3176
2015-02-12 11:53:58 -07:00
Cmcmahon 5d03721bb7 [BrowserTest] Update transclusion test for better locator
Also remove unused step and element

Change-Id: If99cde6a3ec1f0fb87628e5d8600a83034e11ee1
2015-02-12 11:27:40 -07:00
Cmcmahon 924e738652 [BrowserTest] Bring references test up to date.
This addresses some old technical debt.

We also shifted the re-use reference test to the cite.feature where
it belongs in the current architecture.

Paired with Rummana for the update

Change-Id: Ie50ac5bffec0d0ab6bcad704c323639f8e8553f0
2015-02-10 15:57:44 -07:00
ryasmeen@wikimedia.org 0245af2047 [BrowserTest] Fix only Media Test
The media test was passing against garbage wikitext markup match.
Fixed the steps so that it fails when it should.

Change-Id: I3d8dbc959c6244968dd9ac58af663b81cb115dc6
2015-02-09 15:41:42 -08:00
Cmcmahon 18679b74ba [BrowserTest] Make media tests pass
Like in the Cite tests, need a sleep to make the tests pass
locally.

Updated a locator also

Change-Id: Idd962e110fd7191325bdac7e641960858de1db9e
2015-02-09 10:24:12 -07:00
Cmcmahon dd671b4843 [BrowserTest] update Cite test to pass
I'm hoping the sleep() calls here are temporary. VE seems to be
loading an intermediate page before showing the diff view, or
sending an invalid onload event or some such.

Also updated the locator for the Basic text input

Change-Id: I73795f6b1ff0da42f8afd92598ab6786c9a0b88b
2015-02-09 10:00:41 -07:00
ryasmeen@wikimedia.org cefb9b265a [BrowserTest] [WIP]Fixing the test media_general_settings.feature
Change-Id: Ic83477f12db08ed25452f19ca3dc410940a8ebf5
2015-02-06 16:16:33 -07:00
Amir E. Aharoni 2e0b191dda [BrowserTest] Refactor offset_element and browser_zoom
offset_element was used for iframes, and now there are no iframes,
so there is no reason to use it.

As for browser_zoom, it makes more sense to do it in a separate function
and not as a parameter to capture_screenshot.

Change-Id: Ibfce33b7a56d883cc1a6c92c19d40c499681fa47
2015-02-05 12:40:28 +02:00
Amir E. Aharoni 4a73b3e4b1 [BrowserTest] Rename iframe to window_frame
It's not an iframe anymore, so the name shouldn't be confusing.

Change-Id: Id93595d56d7d88871ab79ca91e1714d9a70fad17
2015-02-05 10:32:21 +00:00
Amir E. Aharoni 4bab4fd921 [BrowserTest] Restore the formula screenshot scenario
* Restore the Formula editor screenshot scenario, which was disabled in
  I3e892baa9cb2c8c1303fab232a2b1c64ebdd8f26
* Get the 'More' element clicked to show the formula item.
* Fix the definition of the formula editor textarea element.

Change-Id: Ib50d0381f5743db1f6678609cd4eca5a56a8682b
2015-02-05 10:28:37 +00:00
Amir E. Aharoni 8063c6c754 [BrowserTest] Restore page settings language screenshots
* Add classes to elements in the page settings dialog boxes
* Restore the scenario that was disabled in
Id41d1329d22679b6a61201ceafc81eafa222d909

Change-Id: I5636e744daec2adf013d399bfb019e4d47912083
2015-02-05 12:16:48 +02:00
Amir E. Aharoni ae4417e60d [BrowserTest] Click the editable area with .when_present
The editable area sometimes didn't appear, so a .when_present
call is added to check that it's on the screen.

Bug: T88663
Change-Id: I0c5e29a9d7f9d0a22ca8392df9f7a5b857f20d7d
2015-02-05 12:13:15 +02:00
jenkins-bot 130edbfe62 Merge "[BrowserTest] Shorten all capture_screenshot lines" 2015-02-05 09:19:23 +00:00