[BrowserTest] Fix ParenthesesAsGroupedExpression Rubocop failures

Change-Id: I7a6fbe0aefdd9abe3b0e7c42cc372487255f581b
This commit is contained in:
Amir E. Aharoni 2015-02-17 12:28:31 +02:00
parent 5a715d05ad
commit 26763e7731
4 changed files with 6 additions and 10 deletions

View file

@ -9,10 +9,6 @@
Lint/AmbiguousRegexpLiteral:
Enabled: false
# Offense count: 6
Lint/ParenthesesAsGroupedExpression:
Enabled: false
# Offense count: 3
Metrics/AbcSize:
Max: 20

View file

@ -8,7 +8,7 @@ Given(/^I select the image in VisualEditor$/) do
on(VisualEditorPage).media_image_element.when_present.click
end
Given (/^I go to "(.+)" page which has references$/) do |page_title|
Given(/^I go to "(.+)" page which has references$/) do |page_title|
wikitext = 'VisualEditor is a MediaWiki extension.<ref>[http://www.mediawiki.org/wiki/Extension:VisualEditor Extension:VisualEditor]</ref>'
on(APIPage).create page_title, wikitext
step "I go to the #{page_title} page for screenshot"
@ -60,7 +60,7 @@ When(/^I click on the Special character option in Insert menu$/) do
on(VisualEditorPage).special_character_element.when_present.click
end
When (/^I click on list and indentation dropdown$/) do
When(/^I click on list and indentation dropdown$/) do
on(VisualEditorPage).bullet_number_selector_element.when_present.click
end
@ -352,7 +352,7 @@ Then(/^I should see media in VisualEditor$/) do
)
end
Then (/^I should see Cite dropdown menu$/) do
Then(/^I should see Cite dropdown menu$/) do
on(VisualEditorPage).cite_pull_down_element.when_present.should be_visible
Screenshot.capture(
@browser,

View file

@ -18,11 +18,11 @@ When(/^I select an Image$/) do
on(VisualEditorPage).media_select_element.when_present(20).click
end
When (/^I click Use this image/) do
When(/^I click Use this image/) do
on(VisualEditorPage).use_image_button_element.when_present.click
end
When (/^I click Insert$/) do
When(/^I click Insert$/) do
on(VisualEditorPage).media_insert_button_element.when_present.click
end

View file

@ -3,7 +3,7 @@ class DummyPage
include PageObject
include URL
page_url ('http://<%=params[:site]%>/wiki/asdfdgfghlkj?veaction=edit')
page_url('http://<%=params[:site]%>/wiki/asdfdgfghlkj?veaction=edit')
div(:ve_editing_surface, class: 've-ui-surface ve-init-mw-viewPageTarget-surface')
div(:ve_editing_toolbar, class: 'oo-ui-toolbar-bar')