Commit graph

21394 commits

Author SHA1 Message Date
Bartosz Dziewoński 5804e07221 Update VE core submodule to master (65c6a2ff5)
New changes:
65c6a2ff5 Only inspect data when it is actually available

Bug: T321372
Change-Id: Ib45ea11a792fc02d5ce4b63c7d5be77cb276dbf9
2022-10-22 04:38:10 +02:00
Arlo Breault c1afc62040 Bump requested Parsoid HTML version to 2.6.0
Change-Id: I544d31ca6ea6186a4ddaf7ef25fdea899f454c58
2022-10-20 17:01:17 -04:00
Bartosz Dziewoński f69c187d6c Update VE core submodule to master (8fd8d1451)
New changes:
67c844d73 Localisation updates from https://translatewiki.net.
8e850303c Fix typo in unit tests
9d3ed760c Localisation updates from https://translatewiki.net.
ba0714b07 Verify key before removing node from InternalList
4f76184fa Revert "Verify key before removing node from InternalList"
09036aadf Localisation updates from https://translatewiki.net.
8fd8d1451 Add setTimeout to re-focus when opening SpecialCharacterDialog

Bug: T318720
Change-Id: I798445a46852fd03230b0532f2a792f41ee8107c
2022-10-20 21:16:08 +02:00
jenkins-bot 02a4cfa424 Merge "Pick ParsoidClient implementation based on etag." 2022-10-20 18:14:38 +00:00
daniel adc017f73f Pick ParsoidClient implementation based on etag.
When receiving HTML from a VE session, process it with the same kind of
ParsoidClient that was originally used to generate the HTML. If we were
to use a different implementation, the ETag wouldn't match, so we would
fail to find the stashed data-parsoid map, and the edit would fail.

Bug: T320704
Change-Id: I3b73431fccacecb4ad88b82f8f5675b1042e03ce
2022-10-20 08:52:20 +00:00
Translation updater bot fc6c025e02 Localisation updates from https://translatewiki.net.
Change-Id: I5a390dddbdb50fc5a77e7402462c9130d46f7499
2022-10-20 08:32:33 +02:00
Sam Smith ddb5ac3a14 logger: Also log VisualEditorFeatureUsage events via Metrics Platform
The VisualEditorFeatureUsage instrument is a candidate for migration to
the Metrics Platform [0]. The first step of the migration is to log
events both using the Event Platform directly (i.e. via
mw.eventLog.submit()) and using the Metrics Platform client (i.e. via
mw.eventLog.dispatch()).

The Metrics Platform Client can mix in additional information -
so-called context attributes [1] - based on the stream configuration.
The majority of the default values mixed into each event are already
known to the Metrics Platform Client.

Note well that the Metrics Platform client will not log an event without
one or more streams being configured to receive that event. Therefore,
this change is a NOP.

An example stream configuration is given in [2].

[0] https://wikitech.wikimedia.org/wiki/Metrics_Platform
[1] https://gerrit.wikimedia.org/g/mediawiki/libs/metrics-platform/
+/aed6738b845/js/src/StreamConfig.d.ts#31
[2] https://phabricator.wikimedia.org/T309602#7973206

Bug: T309602
Change-Id: If40fcc6cae371788b98365953218300a5c0b3ca1
2022-10-19 22:53:47 +00:00
jenkins-bot 925183f904 Merge "Use wgWMESchemaVisualEditorFeatureUseSamplingRate config variable" 2022-10-19 19:35:14 +00:00
Sam Smith 75dc014db9 Use wgWMESchemaVisualEditorFeatureUseSamplingRate config variable
... for the sampling rate for the VisualEditorFeatureUse schema.

Bug: T312016
Depends-On: I259757db0c4441a3fcfce505d5bc82dcf2acf58c
Change-Id: I4e03b442568ed695a14d280b0e8dd92e22616426
2022-10-19 07:46:18 -06:00
Esther Akinloose b96f0bc411 selenium: Toolbar should open switch editor
Bug: T296187
Change-Id: Ife5b833acc39596b7e40a2c5a5512a6fd61150af
2022-10-19 13:08:55 +00:00
jenkins-bot e49765d418 Merge "selenium: Content editable should insert a table" 2022-10-19 12:53:54 +00:00
Translation updater bot 2130737dde Localisation updates from https://translatewiki.net.
Change-Id: I3bcc180c3fa645ef0da220367ebbd6ffec1ada23
2022-10-19 08:21:15 +02:00
Translation updater bot a763ee7086 Localisation updates from https://translatewiki.net.
Change-Id: I1447ff7962f7a281f3a1680509425ffd200c1ad2
2022-10-18 08:23:39 +02:00
jenkins-bot 6f024f6566 Merge "GalleryContextItem: Only count image node children" 2022-10-17 14:51:26 +00:00
Translation updater bot 59f476dd8e Localisation updates from https://translatewiki.net.
Change-Id: I953297a88dfaede07a41fc1d6ebc7ede0b63fd1f
2022-10-17 08:22:54 +02:00
Ed Sanders 2a4b4f6b96 GalleryContextItem: Only count image node children
Bug: T320874
Change-Id: I524901619820482c7152d7c7b9bc4a2b9f6ee3ca
2022-10-16 00:03:26 +01:00
jenkins-bot bf1bacfce1 Merge "Remove AutoConfig setting" 2022-10-14 15:59:07 +00:00
jenkins-bot 669cbcea37 Merge "Use RevisionLookup methods instead of ApiParsoidTrait methods" 2022-10-14 14:16:46 +00:00
Abijeet a9a4d9eab0 Add HtmlTransformFactory as depdendency for HtmlOutputRendererHelper
Bug: T317019
Depends-On: I5e11452f1c531a757e8d860f9c727b5810406bce
Change-Id: Ib4262e95cc333d008b083f74c88919441095f446
2022-10-14 15:47:31 +05:30
daniel 92e52d0bad Remove AutoConfig setting
AutoConfig was used to set VE to call internal REST API endpoints exposed by the parsoid extension.
With DirectParsoidClient available, this is no longer needed.

NOTE: this causes all wikis that do not have a RESTbase backend
configured to start using DirectParsoidClient. This is true in
particular for officewiki and labswiki.

Bug: T320704
Change-Id: Ia4c6184dd75a653c3202ea160b6605335f36f6eb
2022-10-14 10:55:53 +02:00
Translation updater bot 307f5c376b Localisation updates from https://translatewiki.net.
Change-Id: I66c92f482653fa924ef4d0e9cc18f8944316f377
2022-10-14 08:43:25 +02:00
daniel 07afdba500 Don't try to contact RESTbase directly when in PHP direct mode.
If VE is configured to call parsoid directly in PHP, the client
should not try to fetch HTML from restbase. Doing so will
lead to inconsistencies, and may cause edits to fail.

Bug: T320704
Bug: T320703
Change-Id: I98bfdd305dcd188d91db6a8fe5885156cdeca7db
2022-10-13 11:22:52 +00:00
Translation updater bot 09555e4315 Localisation updates from https://translatewiki.net.
Change-Id: I4834936506b2b9e511a2e4da1a10ef287a201a9b
2022-10-13 08:10:11 +02:00
jenkins-bot a87f9882c0 Merge "Local implementation of ParsoidClient (DirectParsoidClient)" 2022-10-12 20:50:20 +00:00
Željko Filipin e63bedb988 selenium: Content editable should insert a table
Bug: T296187
Change-Id: Ic0395637690a40a9b6f889072f80b56e5f02390c
2022-10-12 16:00:25 +02:00
jenkins-bot a34d75f633 Merge "selenium: Move code to beforeEach and afterEach hooks" 2022-10-12 11:42:23 +00:00
daniel 35cb550747 Local implementation of ParsoidClient (DirectParsoidClient)
* DirectParsoidClient makes use of parsoid directly for performing
transformations on both wikitext and/or HTML contents.

* Also, it's used to fetch HTML from parsoid's parser cache. Before,
this operation was done via RESTBase but now it's being fetched in
core's parsoid parser cache.

* This patch also enables VE clients to transform HTML to
Wikitext when switching from HTML to source mode on. It
makes use of the HtmlInputTransformHelper to perform this
transformation.

* Now, VE client can make use of core code for switching
between HTML to source mode and back without RESTBase.

Change-Id: I5c7cfcc4086d8da7905897194d8601aa07418b59
2022-10-11 18:34:06 +01:00
Bartosz Dziewoński d2e49b16f7 Use RevisionLookup methods instead of ApiParsoidTrait methods
Part of my secret plan to delete ApiParsoidTrait.

* Inject RevisionLookup into ApiVisualEditor
* Use RevisionLookup::getRevisionById instead of ApiParsoidTrait::getValidRevision
* Use RevisionLookup::getRevisionByTitle instead of ApiParsoidTrait::getLatestRevision
* Use standard MediaWiki error messages
* Delete unused ApiParsoidTrait::getValidRevision
* Delete unused ApiParsoidTrait::getLatestRevision

Depends-On: I7244ee4916fb011fad5faa1d9f837e83f6ac2dc1
Change-Id: I8089c0c516d9dba52e931a0a80740c0361216dbd
2022-10-11 14:54:40 +00:00
Translation updater bot 80504b2c03 Localisation updates from https://translatewiki.net.
Change-Id: Ife6a6cf66ded6188dc69455a3ce887105f2b7da9
2022-10-11 09:17:46 +02:00
Esther Akinloose 529f004fc6 selenium: Move code to beforeEach and afterEach hooks
Bug: T296187
Change-Id: Iad8482e432491895eac070692fd3448e6362e4ce
2022-10-10 14:36:33 +01:00
Translation updater bot 7b1a6c987c Localisation updates from https://translatewiki.net.
Change-Id: I3789a38b0117a506953adee06c69cb4af131684d
2022-10-10 10:21:38 +02:00
Daimona Eaytoy 16ae2da19a build: Update mediawiki/mediawiki-phan-config to 0.12.0
Change-Id: Ib527ec60ac7894d28e330b7080f0e3b0a2b3ddfc
2022-10-08 02:45:31 +02:00
Bartosz Dziewoński 2b37b479ea Update VE core submodule to master (5dcc0f107)
New changes:
878ebf301 Localisation updates from https://translatewiki.net.
b56ad2792 Localisation updates from https://translatewiki.net.
a3a861bae Localisation updates from https://translatewiki.net.
754ee73dd Fix transformStyleAttributes tests on Firefox on Windows
5dcc0f107 build: Upgrade various devDependencies to latest and make pass

Bug: T319520
Change-Id: I3fa0175b69b6a97835c7edb856e4ab0af4cb61cc
2022-10-07 11:16:24 +02:00
Translation updater bot 2c7876eeb1 Localisation updates from https://translatewiki.net.
Change-Id: I4614e2bb87d3b372a1816878de707b80e839856b
2022-10-06 08:16:32 +02:00
Translation updater bot 78612067c1 Localisation updates from https://translatewiki.net.
Change-Id: If2ea8076d668f76d00b34da72c6732480ca46e91
2022-10-05 08:25:26 +02:00
daniel 7f9573f994 api-testing: Add assertions to e2e tests
This adds assertions for the return values of the following pactions:
metadata, parse, parsefragment.

It also adds a test that asserts that edits are not possible with
an invalid token.

Change-Id: Idb453d3561a46930afb5366c1a96787895fc8e40
2022-10-04 19:36:39 +00:00
Translation updater bot 1de359e7eb Localisation updates from https://translatewiki.net.
Change-Id: Iab6b37758543ee81cadb6cbc3c39f5431c501e81
2022-10-04 08:30:22 +02:00
Derick Alangi 1746b76129 ApiVisualEditor: Remove parsedoc VE paction
This VE paction was removed in I90d775dd71d5f5a61d651b63d946ab60a27e2ca3
so this code can be deleted per Bartosz, so this patch removes the code.

NOTE: A merged API test that uses this is also removed along side.

Change-Id: I4ff75df57fd58f508ef7212486e52cb11a7cfb57
2022-10-03 14:12:35 +01:00
Translation updater bot 5c5673bc2b Localisation updates from https://translatewiki.net.
Change-Id: I6fc288a7b158f9d5ca463d5b32a279af9f1ae8ef
2022-10-03 09:46:46 +02:00
Translation updater bot a509020bee Localisation updates from https://translatewiki.net.
Change-Id: If9817782dfbd79ec98cde40ee8c7d3069063c30a
2022-09-30 08:55:15 +02:00
Emeka Chukwukere 2749611071
api-testing: Add more visualeditoredit e2e tests
This patch adds more tests covering the `visualeditoredit` action
API.

Change-Id: I3a20afdb4a146672e272a87eafe8203c384e3405
2022-09-30 00:16:28 +01:00
Emeka Chukwukere db6cc66749 api-testing: Add test for creating and saving a page
Testing the visualeditoredit action API for VisualEditor.

Change-Id: I951ecf1c71e2ee66e3d1fc15a29b312b8fe9956e
2022-09-29 21:23:59 +01:00
jenkins-bot 77565dabf3 Merge "De-duplicate replacePageContent methods between desktop and mobile" 2022-09-29 14:00:00 +00:00
jenkins-bot 2cbf2470dd Merge "ve.init.mw.DesktopArticleTarget: Fix double <div class="mw-parser-output"> after saving" 2022-09-29 13:38:40 +00:00
Translation updater bot ba17184845 Localisation updates from https://translatewiki.net.
Change-Id: I459fcd72595dc72c3b38926ca1df46d33882385f
2022-09-29 08:28:30 +02:00
jenkins-bot 9331cf6c38 Merge "ApiParsoidTrait: Remove unused abstract method dieStatus" 2022-09-29 00:50:39 +00:00
Bartosz Dziewoński 78207ee45d Update VE core submodule to master (6b9937c19)
New changes:
945ca158b Localisation updates from https://translatewiki.net.
42ce721c8 build: Update language lists
dfeda8a1a Localisation updates from https://translatewiki.net.
d0d5771cb Localisation updates from https://translatewiki.net.
0b78ead3f build: Update language lists to add 'mrh'
13d8c8d4f Fixup Chromium's native Enter behaviour on Android Gboard
37bdbb860 Localisation updates from https://translatewiki.net.
6b9937c19 Update OOUI to v0.45.0

Bug: T312558
Change-Id: Icfb0c6f4e70ffd53533d3f0e8cf40ca43b3d8663
2022-09-29 01:28:40 +02:00
Ed Sanders 1992281c82 De-duplicate replacePageContent methods between desktop and mobile
Change-Id: Icab82207d516843e7f2e4ba93b8ea4ffea7cad1b
2022-09-29 01:20:55 +02:00
Bartosz Dziewoński db82eb0263 ve.init.mw.DesktopArticleTarget: Fix double <div class="mw-parser-output"> after saving
Follow-up to 327bd736c5. .html()
replaces the inner HTML, .replaceWith() replaces the outer HTML.

Change-Id: I3c963c0a54f5aee4179c37a87466dffceb8c6a87
2022-09-29 01:15:13 +02:00
jenkins-bot d58d1ed036 Merge "Add basic end-to-end tests for action=visualeditor" 2022-09-28 16:48:33 +00:00