Commit graph

12399 commits

Author SHA1 Message Date
Ed Sanders 6f8e0d9699 Replace confirm with OO.ui.confirm
Also enable no-alert eslint rule to prevent alert/confirm/prompt
being used in the future.

Change-Id: I2851e1f58c1861f75dbb20192e5cf6c343da75db
2016-11-11 13:13:58 +00:00
James D. Forrester 25b0a94ee9 Update VE core submodule to master (c532815)
New changes:
e03fbf0 ce.Surface: Tougher check on whether cursorHolders are still in-document
708aa36 Localisation updates from https://translatewiki.net.
c532815 Fix IE hack classes to run on the correct versions

Change-Id: Ie780b0287664f89815482e4632c4aac86843a1dc
2016-11-10 17:19:13 -08:00
jenkins-bot 95a8b8a30e Merge "Use a blank temp document when selection is empty" 2016-11-11 00:29:22 +00:00
Ed Sanders 003c5ac410 Use a blank temp document when selection is empty
shallowCloneFromRange can a broken document if you pass
a collapsed range. That should be fixed upstream but for
now this fixes a major bug (and is faster).

Bug: T150492
Change-Id: I9b539c588d91ef7f22e662c7cae0b3f89b21d33a
2016-11-11 00:08:11 +00:00
Translation updater bot 0b7f19e941 Localisation updates from https://translatewiki.net.
Change-Id: I18ad56399a23642d42db319d9c274c6b687a0513
2016-11-10 23:36:34 +01:00
James D. Forrester 26e7267f02 ArticleTarget: Use an OOUI MessageDialog, not window.alert()
We should avoid using alert()s as much as possible due to their unhealthy
interaction patterns with any other open tabs or user tasks.

Change-Id: Ib6a217c988322ad17bc7e649c3281eb053b54bbc
2016-11-10 12:55:49 -08:00
jenkins-bot 5ac488ba53 Merge "Revert "Temporarily override broken toolbar border colour"" 2016-11-09 21:49:54 +00:00
Translation updater bot aa1cb54a20 Localisation updates from https://translatewiki.net.
Change-Id: I8bb4d91acd719bc94ac20fa0e02220162e880c48
2016-11-09 22:45:52 +01:00
Jforrester dc8171d100 Revert "Temporarily override broken toolbar border colour"
This reverts commit 4c8a97f9e8.

[Pending next OOUI release.]

Change-Id: I890a7081ffa7c015bd32466fa88d61e3f38af4e6
2016-11-09 20:48:58 +00:00
James D. Forrester 20b802cc85 Update VE core submodule to master (5f569e4)
New changes:
66291ea Converter: Remove internal during the main loop
99172f5 Remove unnecessary double-negation cast in if()
349f341 Refactor diff element getChangedNodeHtml
2885ec2 LinkAnnotationWidget: Don't use deprecated TextInputWidget#setRTL
c235d13 LinkAnnotation{Inspector|Widget}: Stop using deprecated TextInputWidget#isValid
5f569e4 Update OOjs UI to v0.18.0

Change-Id: Iba3908fd3aec62c8c770346dd01714c41c7a87a0
2016-11-09 12:35:17 -08:00
jenkins-bot de72f77b1b Merge "Collapse to end after inserting WT signature" 2016-11-09 20:00:05 +00:00
James D. Forrester 79befe3d67 MWExtensionWindow: Use #setDir, not the removed #setRTL
Change-Id: I4090fa0375a93e095a644538b52853fd849b8749
2016-11-09 11:13:09 -08:00
Ed Sanders 1cb4c27378 Collapse to end after inserting WT signature
Bug: T150320
Change-Id: I06a8304499d92d0155c112449678fef34dc98424
2016-11-09 15:26:44 +00:00
jenkins-bot 28787b0f3c Merge "Rename methods used for setting up multiple edit tabs" 2016-11-09 00:45:01 +00:00
Translation updater bot 98fdfb3174 Localisation updates from https://translatewiki.net.
Change-Id: I0d1b052032dda69430e083751ee83934bae616e8
2016-11-08 22:50:21 +01:00
jenkins-bot 45a75047fa Merge "Move save dialog checkbox code up from DAT into ArticleTarget" 2016-11-08 17:14:45 +00:00
jenkins-bot d972d3f4f2 Merge "Hacks to get VE loading on mobile while user has NWE enabled" 2016-11-08 17:14:44 +00:00
jenkins-bot efb4133119 Merge "Use onEditTabClick handler in SingleEditTab" 2016-11-08 17:10:06 +00:00
Ed Sanders 55fcded32e Replace non-standard whitespace in comments
This is required to pass eslint:recommended.

Change-Id: If8c4876a366e5c021c414e54328ed1913b679969
2016-11-08 14:15:12 +00:00
Ed Sanders 2fa4cfef16 Rename methods used for setting up multiple edit tabs
Change-Id: I71d6dd0848e9cc3ee8531b0b914c29219b4697bd
2016-11-08 12:47:30 +00:00
Ed Sanders f6a205d77f Use onEditTabClick handler in SingleEditTab
Gives us extra functionality like  checking for
isUnmodifiedLeftClick which makes CTRL+click on SET
not change the current page, as expected.

Change-Id: Icb37d7383374ee63798443659a2bcb2f1545c8c5
2016-11-08 12:39:15 +00:00
Ed Sanders 526b2c0656 Remove max-width from save summary
Prevents mis-alignment of textbox and checkbox bar
on mobile.

Change-Id: I33d8a2bd4e30d2ed4d61942a7646299f9935bc32
2016-11-08 10:29:03 +00:00
jenkins-bot 8336720a5f Merge "Remove 'vesection' parameter" 2016-11-08 10:26:53 +00:00
James D. Forrester 539974a80b Update VE core submodule to master (88ba26b)
New changes:
e9866f4 Replace reference to current doc with this.newDoc
fa5a575 Add test framework for diffElement
2f6969c Use shallow copy for internal list data inside shallowCloneFromRange
866b2c0 Don't bother testing data on direction key tests
88ba26b Avoid jQuery in PreviewElement and ve.resolveAttributes

Change-Id: I7adb57898fa7cecd6a412183c4ca0726ef1a00ae
2016-11-07 13:51:21 -08:00
Translation updater bot b2a60edf8a Localisation updates from https://translatewiki.net.
Change-Id: If90be9fb65286254cd6b386e931eb5093134e043
2016-11-07 22:40:27 +01:00
jenkins-bot 6f4ff421fc Merge "Clarify wording of __NOINDEX__ option in VisualEditor" 2016-11-07 18:54:10 +00:00
Deskana e4b1b9e4f1 Clarify wording of __NOINDEX__ option in VisualEditor
VisualEditor contains an option in "Advanced options" to add __NOINDEX__ to
the page, stopping external search engines from indexing the page. This does
not affect the in-site search. The current wording is correct, but a little
ambiguous since it just mentions "search engines". This patch clarifies the
wording.

Change-Id: Ide528f3c028fb79d187eee1c64187c2886635d66
2016-11-07 10:39:09 -08:00
jenkins-bot c22739cff0 Merge "Cleanup elements passed to MWImageNode mixin" 2016-11-07 16:51:20 +00:00
Translation updater bot 3efe7cc78f Localisation updates from https://translatewiki.net.
Change-Id: Icb5ee56b1dcb001ad013939335baa72b6c54f128
2016-11-06 22:42:07 +01:00
Ed Sanders 7a0eb09e32 Cleanup elements passed to MWImageNode mixin
Change-Id: Idc736bca6ec7f9cae18d065303364ff5b7828a3b
2016-11-06 15:38:48 +00:00
Translation updater bot b39fec0055 Localisation updates from https://translatewiki.net.
Change-Id: I49c72b1e1bb6a7b6803841b8c4c49fcc50db9cc4
2016-11-05 22:58:37 +01:00
Alex Monk e81c6e5b43 Move save dialog checkbox code up from DAT into ArticleTarget
So it applies to MobileArticleTarget.

This shows the checkboxes on mobile.

Bug: T148914
Change-Id: Ib6559d5601004e58b72903805059e04f42acc85f
2016-11-05 06:24:49 +00:00
Alex Monk 81e32c6a4b Hacks to get VE loading on mobile while user has NWE enabled
* ext.visualEditor.mwwikitext does not have mobile target
* We call mw.libs.ve.setEditorPreference from ArticleTarget

Change-Id: Ifae6e951155c83b13f3111732b0dc500349b1df2
2016-11-05 05:51:26 +00:00
Alex Monk 7c80976f5b Remove 'vesection' parameter
Just use the normal section parameter, haven't been able to figure out why VE
would need to be special about that.

Bug: T149958
Change-Id: I9338d0f1498fbb579fa8c340d6e7274c6d48155b
2016-11-05 02:08:13 +00:00
James D. Forrester 6913a736fd Update VE core submodule to master (e7c5b56)
New changes:
b2970d6 Remove #rebuildTree calls and ensure #getDocumentNode is used
4d3231d Extract DM document from node instead of passing it as argument
5827a4c Update treeDiffer library & remove all but dist, licence & readme
4200362 Fix typo in getModifiedRanges
9a4edb7 Fix behaviour of attribute change in getModifiedRange
c5c7d83 Localisation updates from https://translatewiki.net.
993200a Add includeCollapsed & includeInternalList options to getModifiedRanges
566c7af Add ve.Range#overlapsRange method
4a3afce Remove unused eslint exceptions and old jshint comments
db44a3d Fix splice typo
7a4de14 Fix translateRange bug that expands selections
e7c5b56 Localisation updates from https://translatewiki.net.

Change-Id: I4af5647b9f49525c9c592ab42270f302144d76c9
2016-11-03 17:02:01 -04:00
jenkins-bot 174bef8493 Merge "Factor out getWikitext in ApiVisualEditorEdit" 2016-11-02 23:16:35 +00:00
L10n-bot 4b0f44fece Merge "Localisation updates from https://translatewiki.net." 2016-11-02 21:56:50 +00:00
Translation updater bot fb7fc12747 Localisation updates from https://translatewiki.net.
Change-Id: Ica207b52252d71d2ab18033b625f53f4fb0eb95d
2016-11-02 22:54:28 +01:00
jenkins-bot cacb6d5427 Merge "Store editor preference when switching to NWE" 2016-11-02 21:39:11 +00:00
jenkins-bot b6d3dabfbf Merge "Add binding for when only tab is new wikitext editor" 2016-11-02 21:36:21 +00:00
jenkins-bot 64f85a2ef7 Merge "Cleanup dependency graph" 2016-11-02 21:33:45 +00:00
jenkins-bot f20a40d09f Merge "Keep edit summary when switching between VE and NWE" 2016-11-02 21:09:29 +00:00
jenkins-bot 65236ae67f Merge "Try to make client and server code to get last editor work the same" 2016-11-02 20:07:07 +00:00
jenkins-bot c62e71f44d Merge "ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP" 2016-11-02 20:07:06 +00:00
jenkins-bot 254e77a296 Merge "Set section to null when switching from NWE to VE" 2016-11-02 19:45:14 +00:00
jenkins-bot 51da2379e2 Merge "Ensure max size in not enforced for vectors" 2016-11-02 19:45:12 +00:00
Ed Sanders 2282ee80c1 Store editor preference when switching to NWE
This will also change the label of the single edit tab.

Bug: T149795
Change-Id: I3e1afad61ed60eb6f58aceb023e2fed16f053542
2016-11-02 19:10:29 +00:00
Ed Sanders 3fb757c307 Add binding for when only tab is new wikitext editor
Bug: T149796
Change-Id: I675c5876fbb9ca8427983e9d4252cccda35775f9
2016-11-02 19:10:28 +00:00
Ed Sanders dc0c751100 Ensure max size in not enforced for vectors
Otherwise they can't be scaled up. Also move svgMaxSize code
to comment as it isn't used yet.

Change-Id: I7af2bc91524e832555b66f090a671672cd14f294
2016-11-02 18:12:02 +00:00
Ed Sanders 56679dfb35 Set section to null when switching from NWE to VE
This prevents the discard warning from being shown if the user
switches back to NWE then back to VE, as by this point they
have left section editing.

Change-Id: I734684c54a8900aab3332ed8421cb42f7f845738
2016-11-02 15:53:29 +00:00