Commit graph

9484 commits

Author SHA1 Message Date
Amir E. Aharoni e34aa6aab4 [BrowserTest] Disabling the References list test
The functionality chnaged significantly, so the steps must be changed.
Removing the tag until it's done.

Change-Id: Iacdf78d3b6f00e39cb2bf313b79489035f1c0b62
2015-03-19 14:26:08 +02:00
Amir E. Aharoni 425b53a1e2 [BrowserTest] Revert the definition of the disabled_save_button element
The element is <div>, and using English text doesn't work
in other languages.

Follow up to
Icd79ec9b489557c3259ff7f2c11b2a899c767d0f

Change-Id: I3859c668921a5f3f6abafb2053fc471dbc8d80c7
2015-03-19 12:14:38 +00:00
jenkins-bot e05c842d64 Merge "Fix edit conflicts" 2015-03-19 02:39:28 +00:00
Alex Monk 74cb83d2f8 Fix edit conflicts
When we moved to mw.Api, edit conflict errors stopped going via onSave and
started going to onSaveError instead. So the case to check for them in onSave
would not have worked - instead, they would go through onSaveError and get
picked up by our unknown error code, which just picks out error.info and shows
it, instead of showing our edit conflict screen.

Also return in a couple of other error cases where we probably should've been
(but not necessarily must've been... that didn't necessarily show to the user
if another error emit already caused saveDeferred to be rejected)

Change-Id: Iae7a66a8aa96ee777e9fa780005feeb429129d5f
2015-03-19 02:36:21 +00:00
jenkins-bot cc6f0f4316 Merge "Update VE core submodule to master (91858b5)" 2015-03-19 02:27:44 +00:00
jenkins-bot 230b47979f Merge "Restore async rendering of ReferenceContextItem" 2015-03-19 01:52:37 +00:00
James D. Forrester 2a2ebb39c6 Update VE core submodule to master (91858b5)
New changes:
a9f3539 Avoid miscalculation of monospace text height
10c50a2 Update UnicodeJS to v0.1.4
8ca67ef Add .mailmap file
bc7ffd8 Release more things in destroy methods
7a3eca3 Move click blocking from links to content branches
80d68ea [BREAKING CHANGE] Use Unicode character class to calculate word expansions

Change-Id: I497f5300228add02e4319b2cbb2f7ede054d8c0c
2015-03-18 18:49:18 -07:00
Ori Livneh 94877eb668 Set mwtiming events' target to 'mwTarget', if unset
We're currently rewriting "mwtiming.performance.system.domLoad" to
"timing.ve.undefined.performance.system.domLoad". The "undefined" comes from
the missing targetName property on the event. I'm not sure why it is missing,
but having it default to 'mwTarget' will Do the Right Thing™.

Task: T93156
Change-Id: If70ff601b6c54ec8f95171cbc43c82c87a177508
2015-03-19 00:40:28 +00:00
Trevor Parscal 9f660f9db8 Restore async rendering of ReferenceContextItem
We moved toward serialization, but in the case where we don't have a
rendering yet and it's happening async, we need to use the same DOM
container that will be rendered into.

Bug: T91336
Change-Id: I53920591fde02175d4162b1fe5899b97b10a5b0f
2015-03-18 23:28:24 +00:00
jenkins-bot 26dbc07b98 Merge "Add .mailmap file" 2015-03-18 22:58:40 +00:00
jenkins-bot 1046d309b2 Merge "Handle TitleBlacklist errors" 2015-03-18 22:44:36 +00:00
jenkins-bot e8e58bf058 Merge "Set action.saveFailure.message key in Edit schema" 2015-03-18 22:43:17 +00:00
Roan Kattouw 2d172ad869 Add .mailmap file
For git shortlog and friends.

Change-Id: I3d6882f3e1c0706cf875944d27c2d5adb24eb466
2015-03-18 15:28:51 -07:00
Alex Monk 88088d4ecc Set action.saveFailure.message key in Edit schema
This relies on WikimediaMessages' version of the Edit schema being updated at
the same time.

Change-Id: Iee97fdd2a867f2c252ca7756f2e6341377d9fbb7
2015-03-18 22:24:40 +00:00
Alex Monk c286511f17 Handle TitleBlacklist errors
Relies on I69cf0a88

Using our own new message because TitleBlacklist's own one includes text that
we can't parse on the client and relies on a parameter we don't get from the
API.

This relies on WikimediaMessages' version of the Edit schema being updated at
the same time.

Change-Id: I4c75369b8b97973b72899bfaecbd5a996a440c68
2015-03-18 21:58:51 +00:00
Ed Sanders b83d23c620 Update VE core submodule to master (b57d224)
New changes:
541659f [BREAKING CHANGE] Remove domElements attribute from aliens

Local changes:
* Update alien tests

Change-Id: I26a7ebc709fae9d2365a7f9ce2c4cfdcc10620a2
2015-03-18 14:16:10 -07:00
James D. Forrester 70cff83f68 Update VE core submodule to master (6bd2ea5)
New changes:
44ca3b6 Use store indices in annotate operations
3ebbcce Make range optional in getUsedStoreValuesFromRange
9d03a5e Set originalDomElements whenever a data element is created
4cfffde Simplify annotation hashes
4eeb8bb Add handlers for font annotations
4a6d6f0 Localisation updates from https://translatewiki.net.
05de45e ve.ui.ToolbarDialogTool: Fix documentation
6797d6d Use type from toDataElements when creating annotations
b3a3839 Store reference to DM document in transactions
c073a24 Load special characters in Platform instead of SpecialCharacterDialog

Local changes:
* Add new files to VisualEditor.php
* Re-sort i18n strings in VisualEditor.php
* Re-run extenson.json creation
* Update documentation HTML file
* Update tests for adjacent annotations fix

Change-Id: I7a5e79e68ab8a7aae0e9af42d011943019f7f85f
2015-03-18 12:15:24 -07:00
jenkins-bot 05766564d1 Merge "Remove font tags on import (paste/drop)" 2015-03-18 18:29:57 +00:00
jenkins-bot 275ba972bb Merge "Follow-up f620111b: pass parameters to fallback requestPageData() call" 2015-03-18 18:25:24 +00:00
Ed Sanders ba20a26292 mw.ViewPageTarget: Grey-out body content as soon as edit is clicked
Set 've-activated' as soon as edit is clicked, with a 've-loading' state.

This necessitates moving the relevant styles to mw.ViewPageTarget.init.css.

Change-Id: Ic9757cdbf63a2f72eda0dd03ff5588d79028ba0e
2015-03-18 17:56:28 +00:00
Roan Kattouw 3375411afd Follow-up f620111b: pass parameters to fallback requestPageData() call
Bug: T93036
Change-Id: I84eba70d9c0af63b442993c8c59fee89da45c14f
2015-03-18 16:23:37 +00:00
Translation updater bot c62c5c0df3 Localisation updates from https://translatewiki.net.
Change-Id: Ie0473ffcff8cb171cea78eeedd323dc778a5dc9c
2015-03-18 16:08:45 +01:00
Ed Sanders fbe207fabf Remove font tags on import (paste/drop)
Change-Id: I46c7d4aee2f35ccf8ab6967c0273bc46c5a79347
2015-03-18 08:51:13 +00:00
jenkins-bot ddaee51606 Merge "Insert a new references list immediately, rather than showing a dialog" 2015-03-18 02:28:54 +00:00
jenkins-bot 4ef6eb8010 Merge "Unbreak TargetLoader when ViewPageTarget.init isn't present" 2015-03-18 00:42:10 +00:00
Roan Kattouw 812cb9aa2c Unbreak TargetLoader when ViewPageTarget.init isn't present
By lazy-initializing mw.libs.ve

Change-Id: I2fea8a0935b43b5a25287f68bd7487c448d006b6
2015-03-17 17:38:29 -07:00
James D. Forrester f7c658052c Update VE core submodule to master (95d161f)
New changes:
63496f0 demo: Fix typos
67967ec Don't try to remove stuff we never added
aedeba4 Auto-close inspectors
949aa42 Limit the height of context items
d58e841 Expand annotation beyond a word if it exists

Change-Id: I7032e178a9221bc36323064bfcfd36c09caa9724
2015-03-17 17:15:13 -07:00
jenkins-bot e8a87466b2 Merge "[BrowserTest] update Cite test for new UI" 2015-03-17 22:59:27 +00:00
Cmcmahon 698f36cdd4 [BrowserTest] update Cite test for new UI
* Access to Cite options changed
* Various target locators also changed

Paired with Rummana for these changes.

Change-Id: Ib7c3fbd1842879745d3d3128c66d90cc2b4f98cb
2015-03-17 15:54:14 -07:00
Bartosz Dziewoński 44e47a6e8f Insert a new references list immediately, rather than showing a dialog
If a references list node is selected, open the dialog to edit it.
Otherwise just insert the references list for the default group, since
this is what the user wants to do in 99% of cases.

* Replaced the simple 'referencesList' command (which opened the dialog)
  with a custom implementation in ve.ui.MWReferencesListCommand, which
  inserts the references list or opens the dialog like before.
* Removed the ability to insert a references list from
  ve.ui.MWReferencesListDialog, since it should now never open without
  a references list selected. If it does, throw an error.

I considered the behavior of always showing the dialog if there is at
least one references list already in the document, but I think it would
be confusing if the tool behaved differently depending on the state of
the document (rather than merely current selection).

Bug: T71727
Change-Id: Ifbbfa28548de9c0435c5174fb7762079f59bac54
2015-03-17 15:20:22 -07:00
jenkins-bot 331351703b Merge "Ensure wikitext is treated as such in PST" 2015-03-17 21:58:55 +00:00
Matthew Flaschen 77a5a6cdd5 Ensure wikitext is treated as such in PST
Fixes T92934

Bug: T92934
Change-Id: I9cc75b18ae65ab0a986e9916d0c685fc1bf8b31e
2015-03-17 16:43:03 -04:00
Alex Monk aac31c9c72 Fix action.abort.mechanism value in ViewPageTarget#onUnload
Was causing EventLogging schema validation failures.

Bug: T92869
Change-Id: I6ecdb4b5b39fe05448664316894314492da4379b
2015-03-17 19:02:44 +00:00
Moriel Schottlender 73356c333a Add general citations dialog
Add a dialog to group the possible citation types and allow the
user to choose the right citation dialog for them.

Depends on Ibf29417 in VE-core; useless without I3d9caef in VE-core.

Bug: T62768
Change-Id: I22a64265475b1b4c94b46c5af196bd08331a05e7
2015-03-16 17:20:38 -07:00
Trevor Parscal 7f529a2aeb Update VE core submodule to master (546dbc9)
New changes:
580ce3c Implement ve.init.Platform static functions using $.client
85a3d4a ve.ui.Context: Fix typo: embedable → embeddable
37ac763 [BREAKING CHANGE] Allow access to surface through window manager
978bc22 Localisation updates from https://translatewiki.net.
c30c3ee Localisation updates from https://translatewiki.net.
533a10a Localisation updates from https://translatewiki.net.
dafeb22 Add directionality classes to window manager

Change-Id: I5150173da691bb51c4419447f5250c21ac41e32a
2015-03-16 16:54:31 -07:00
Translation updater bot 96c2e90a9e Localisation updates from https://translatewiki.net.
Change-Id: I21b39cdeb060feb05994dfd4417fd05b03f555bf
2015-03-16 22:01:27 +01:00
Roan Kattouw f620111b9e Send Parsoid API request immediately when user clicks edit
Move requestPageData from mw.Target to TargetLoader, call it
in init init, and pass the promise it returns into load()
via activate().

Bug: T90372
Change-Id: I828b8474e5a76b3d0d7d08735b4d865c29d2f820
2015-03-16 08:56:42 -07:00
Kunal Mehta aeaffaaf28 Unset $wgVisualEditorResourceTemplate after usage, it's not a real global
This should also prevent it from showing up in extension.json

Change-Id: Ifa730211acf0f828d2a63ede20f2ecc15af6cbd9
2015-03-15 17:45:14 -07:00
Kunal Mehta 80bdc3e620 Use ResourceLoader::isModuleRegistered()
Change-Id: I3e26b9b0400251cfb290935f97f28b4860bd1b75
2015-03-15 16:54:51 -07:00
Translation updater bot fa170126f5 Localisation updates from https://translatewiki.net.
Change-Id: I533bd73050276769bf9e898876eb9a83c970280d
2015-03-15 21:54:35 +01:00
Roan Kattouw d371014e5d Load RL modules in one load.php request, rather than in two stages
This introduces TargetLoader, which manages plugins and RL modules
in a slightly more generic fashion so that Targets themselves don't
have to. This allows us to load all RL modules in one load.php
request, rather than first loading ViewPageTarget which then
loads the other modules.

TargetLoader loads in the bottom queue, so it will be loaded
as part of the main load.php request, but in VPT.init.js we
still have to wait for it with using() because it might not
have arrived yet. This also degrades gracefully on cached pages
where TargetLoader isn't in the bottom queue: it'll be loaded
as a separate request instead, which is suboptimal but no
worse that what we were doing before.

Right now TargetLoader is small enough that it could also be in
the top queue, but in the future we want to add things like
the action=visualeditor API request to it, and mw.Api is
relatively big.

Note: this also makes a breaking change to the plugin API:
plugin callbacks no longer receive the target instance
as a parameter, as they're now executed before the target
has been constructed rather than after. In the long term,
if we want to give plugins access to the target instance,
we could give them the target promise somehow. For now,
I've killed this feature because nothing used it and
the change from a direct object reference to a promise
would have been a breaking change anyway.

Also fixed incorrect documentation index for ve.init.mw.ViewPageTarget.init.

Bug: T53569
Change-Id: Ibfa6abbeaf872ae2aadc6ed9d5beba7473ea441a
2015-03-15 03:43:05 +01:00
Translation updater bot 213a5fc862 Localisation updates from https://translatewiki.net.
Change-Id: If34cb51c43d472cc63e8a478fa24b0b94aeff9c7
2015-03-14 21:37:49 +01:00
Translation updater bot 2e614d4f39 Merge "Localisation updates from https://translatewiki.net." 2015-03-14 07:39:14 +00:00
Translation updater bot 859e5de77e Localisation updates from https://translatewiki.net.
Change-Id: I40350143c54f7a165d65bfbc25eb3b498442ad79
2015-03-14 08:36:57 +01:00
Roan Kattouw 25afae342a Move parseWikitext from ApiVisualEditor.php to ApiVisualEditorEdit.php
It's only actually being called in the latter.

Change-Id: Ifbf568738f38aa52878197813ec458c34bee5d5b
2015-03-14 00:27:11 +01:00
Roan Kattouw b52cbc443f Remove basetimestamp/starttimestamp from ApiVisualEditor
These were only used in ApiVisualEditorEdit.php, seem to have
been missed when the split was done.

Change-Id: I60a9152d244100526cef755cf578d7dfd38a96b9
2015-03-14 00:27:03 +01:00
jenkins-bot 9dd64e3f84 Merge "Stringify and parse rendered references" 2015-03-13 11:49:01 +00:00
jenkins-bot 6f0bc8faff Merge "Update VE core submodule to master (792b450)" 2015-03-13 01:39:41 +00:00
Alex Monk 28a293ebaf Don't try to access x-parsoid-performance on restbase cache hits
It doesn't get set

Change-Id: I6695ab0e7d461b7541dd56e392f8d1479998f2b5
2015-03-13 00:53:19 +00:00
James D. Forrester 4f92739310 Update VE core submodule to master (792b450)
New changes:
681804e Only call execCommand() on the surface in Firefox
c9ed5d8 Include editing-core icon pack
792b450 Update OOjs UI to v0.9.2

Change-Id: If75e4993b8c9c7134a69bc5fbffb335beacd8b9e
2015-03-12 17:06:28 -07:00