wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
12721 commits 161 branches 1 tag 190 MiB
Commit graph

1684 commits

Author SHA1 Message Date
Ed Sanders 4d134cfefc Add shortcut for show preview and resolve access key conflicts 
Refactor save dialog setup so logic for canPreview/canReview
is external and passed in.

'Show preview' will show in the VE command help dialog until
I56c1036e6 is merged in core.

Bug: T149914
Change-Id: Id718ad622be43c03df61d12b8688d53462c59f36
 2016-12-16 13:33:57 +00:00
Ed Sanders 9728d78126 Resolve URLs in show preview against correct base 
Bug: T153277
Change-Id: Icaa6de4618de008fb2024d1dd428114688cb1043
 2016-12-15 03:19:16 +00:00
Ed Sanders c92418e4da Fix wikitext handling of DataTransferHandlers when IVStore is used 
Bug: T153269
Change-Id: Ida6ffffac6e6a65784dc84a388d3702680a79db9
 2016-12-14 22:56:18 +00:00
Ed Sanders 1b726dc9bc Fix DataTransferHandlers when loading source editor directly (no etag) 
Bug: T153268
Change-Id: I0b43fd651e26c3d74a5f29e8ed80e5dee28ac399
 2016-12-14 22:56:00 +00:00
jenkins-bot 56927ad512 Merge "SaveDialog: Align colour palette and ensure sufficient contrast" 2016-12-13 19:38:51 +00:00
Volker E 48db1c16f8 SaveDialog: Align colour palette and ensure sufficient contrast 
Align the colors used in the save dialog to OOjs UI's MediaWiki theme,
increasing the contrast of edit summary counter slightly to ensure WCAG
AA accessiblity levels. Also remove unnecessary duplicated CSS
properties, which are already inherited from OOjs UI styles.

Bug: T153086
Change-Id: Iee6b38e0b11f777dd0ffb0f6802d0b3d7349ddee
 2016-12-13 19:26:39 +00:00
Ed Sanders 22f4614eee Show save button on show preview page 
Bug: T151261
Change-Id: If80bb8e4e9e412572ab88d13d07a3f92dd353b31
 2016-12-13 18:10:09 +00:00
jenkins-bot c4dacd9d24 Merge "Don't focus save dialog during setup to avoid scroll jumping" 2016-12-13 15:31:23 +00:00
jenkins-bot a962e7de3b Merge "Support section=new in NWE" 2016-12-13 13:55:33 +00:00
Ed Sanders 4064c91b8e Don't focus save dialog during setup to avoid scroll jumping 
Bug: T153010
Change-Id: Ia535cd5d4ebfc01994f4e440bb5cb7efa5c40802
 2016-12-13 12:57:34 +00:00
Ed Sanders 5a8106773c Support section=new in NWE 
Bug: T150709
Change-Id: I1002b97060d642df0988da15860a36c13712bade
 2016-12-13 12:20:55 +00:00
jenkins-bot 669995c8c2 Merge "Follow-up ae8a2750: Stop passing long-dead second parameter" 2016-12-12 21:20:08 +00:00
Ed Sanders a504aba7c5 MWWikitextLinkAnnotationInspector: Select links after creation 
Change-Id: If23d90dc695546e7dddb3c04637e54df47c6f528
 2016-12-12 20:09:52 +00:00
Alex Monk c843824c97 Batch gallery imageinfo requests via ImageInfoCache subclass 
Also get rid of .join( '|' ) for API request parameters per Bartosz

Bug: T147067
Change-Id: If4444cca300d65e28d6fb9003fcac5e076a5129a
 2016-12-06 22:10:19 +00:00
jenkins-bot 446a4e40c4 Merge "SaveDialog inherits from plain dialog, not FragmentDialog" 2016-12-06 19:37:41 +00:00
jenkins-bot bdd1a1b78c Merge "Scroll highlighted item into view in gallery dialog" 2016-12-06 18:30:22 +00:00
jenkins-bot 9b4bc7a3f2 Merge "Disable heights option in gallery dialog when mode is slideshow" 2016-12-06 18:28:51 +00:00
jenkins-bot a2e4d9fa82 Merge "Decrease height of gallery search results for better fit" 2016-12-06 18:23:38 +00:00
Ed Sanders 4f7bba4de9 SaveDialog inherits from plain dialog, not FragmentDialog 
Change-Id: I934ab41567ea68e58cfa27451faf499febd68bd1
 2016-12-04 11:09:56 +00:00
Thalia 2fd30fb7c5 Decrease height of gallery search results for better fit 
Bug: T151509
Change-Id: I92c812952457df99251fc0b8f1a17d4e55fe52f7
 2016-12-03 16:31:23 +00:00
Thalia 1b4d70324b Disable heights option in gallery dialog when mode is slideshow 
Also disable relevant fields the first time the dialog is
opened, not just when the dropdown is changed.

Bug: T151482
Bug: T151512
Change-Id: Ic511e1832a9fcaaeaed71c1d495aecc65fdd1d3b
 2016-12-03 16:00:32 +00:00
Thalia 0b9228a926 Scroll highlighted item into view in gallery dialog 
Bug: T152053
Change-Id: I6b77f6c27d5629dc18e421f984cf31badfb2ff04
 2016-12-03 15:46:58 +00:00
jenkins-bot e1e55aa730 Merge "Correct class/classes typo in gallery dialog" 2016-12-03 15:20:53 +00:00
Thalia 295dd380de Correct class/classes typo in gallery dialog 
Bug: T152226
Change-Id: I569df87cf82359c13ad61a3ddffacd83f5f03bae
 2016-12-03 13:03:02 +00:00
James D. Forrester f494067dea Follow-up ae8a2750: Stop passing long-dead second parameter 
Change-Id: Ifc43d9009c2057b5a189d3cc161b62dc4ca83a2c
 2016-12-02 14:31:26 -08:00
Ed Sanders 9b5adb8688 Remove WikitextWindowAction, inherits from core 
Depends-On: I2b14cc93bf3c855e157f0b26567337f74992fb96
Change-Id: I3e479c1441f548f62ff8a2f6e7b2ad450262921f
 2016-12-02 11:50:43 -08:00
jenkins-bot 36d976c4c0 Merge "Save Dialog: add shortcut for opening to the review panel" 2016-12-02 00:36:40 +00:00
David Lynch 2bd34cebd4 Save Dialog: add shortcut for opening to the review panel 
Create a new MWSaveDialogAction, which can be hooked up to triggers. Switch
the existing save dialog accesskey to just use the trigger system.
(Maintaining all the accesskey logic, so we don't change the shortcut on
people.)

Bug: T149914
Change-Id: I9b4ef8504148703556f802b266a517dd5098c06b
 2016-12-01 18:16:18 -06:00
Alex Monk 5bd95db994 Use widget.getApi, not this.getApi 
Bug: T152154
Change-Id: Id7e77323ffabf4eeee3e73481cf6bcb9a1e649dc
 2016-12-01 22:48:45 +00:00
jenkins-bot d254436f57 Merge "Use canonical ve.dm.TransactionBuilder.static.newFrom* methods" 2016-12-01 19:44:05 +00:00
jenkins-bot 2b453295ec Merge "ve.ui.MWWikitextTransferRegistry: Just look for '[[' when detecting links" 2016-12-01 19:35:45 +00:00
Ed Sanders 8bca6cc777 Inherit more functionality from core source mode 
Change-Id: Id027681ab5f0c9f4b9ed127b583e45f0fe57ce69
Depends-On: I02f3849027a6652701c2d354d1b77ece9d1a56c1
 2016-12-01 18:44:54 +00:00
James D. Forrester a835f4f9d5 Use canonical ve.dm.TransactionBuilder.static.newFrom* methods 
Change-Id: I082048a677baa2699d94e21548373952d52db61b
 2016-12-01 10:43:10 -08:00
Ed Sanders 218742d806 Update VE core submodule to master (ae30d71) 
New changes:
f58ddea DiffElement: Use document slices with full internal lists
83800c0 DebugBar: Remove hard-coded i18n
b4f89e1 Update OOjs UI to v0.18.1
40c7bf6 Factor out active node functionality from SectionNode for captions
2d967be Move 'mode' property to surface, rename target property to 'defaultMode'
5d8c214 wrapAllNodes in sourcefragment
dd3d9e5 Refactor ve.dm.Transaction
9d61aca Use canonical ve.dm.TransactionBuilder.static.newFrom* methods
df4f72a Make table caption node an active node
b79f72d Core source mode
7533ac4 Localisation updates from https://translatewiki.net.
ae30d71 SourceSurfaceFragment: Check range is not collapsed

Local changes:
Get edit mode from surface where possible

Depends-On: Iec758c1892d518ad4bc2c0d1aaf6ca00fa354323
Change-Id: Ifaf6a26078b2731b374aaad2cb40c08928de9c84
 2016-12-01 10:40:01 -08:00
Thalia 4b9d1bed4f Fix "Add new image" button in the gallery dialog 
Make sure the button is always visible in the
gallery dialog menu by fixing it to the bottom.

Bug: T151506
Change-Id: I560b0dffbaad9e18c6f7f703cb155356470580ee
 2016-11-30 22:38:11 +00:00
Ed Sanders 37910b78ec MWTemplateTitleInputWidget: Use new #getApi method from upstream 
Depends-On: I81811cdd1a0750a8335432eee8f971ab9e0b8ee7
Change-Id: Ic73213df5ede6f82de85df8b69c60dd31f033792
 2016-11-30 19:51:45 +00:00
Bartosz Dziewoński 491ecfe1d6 ve.ui.MWWikitextTransferRegistry: Just look for '[[' when detecting links 
Bug: T151646
Change-Id: I693b190f762d93ffae0aa939ffc9550e567e8e24
 2016-11-30 19:07:50 +01:00
jenkins-bot 745e919f97 Merge "Update VE core submodule to master (9625e8f)" 2016-11-29 20:46:54 +00:00
jenkins-bot 33db54ef28 Merge "Use upstream media search widget from core" 2016-11-29 20:04:46 +00:00
Ed Sanders aeafa6afca Update VE core submodule to master (9625e8f) 
New changes:
f1297b8 [BREAKING CHANGE] Allow target widgets to be re-used

Local changes:
Re-use target widgets

Change-Id: I5decb918f398704d4b6c108a16fbc1cc073ef077
 2016-11-29 11:48:15 -08:00
jenkins-bot 28a4b9f362 Merge "Handle missing pipes in Gallery syntax, and remove them when caption is empty" 2016-11-29 19:27:52 +00:00
Ed Sanders 44fee9b61d Wait until search panel is shown before setting a search query 
Bug: T151659
Change-Id: I3eb3b903a8df1c7732da2a08e4b46b13b162617e
 2016-11-29 11:13:54 -08:00
Ed Sanders 2ee9e62a4d Use upstream media search widget from core 
Bug: T140166
Depends-On: If53ef7f4b62c7a5d4da565c14dd2a353778694e5
Change-Id: I28845e9c143e78d3a377f067606c62da212e3bf1
 2016-11-29 17:19:14 +00:00
Ed Sanders 240ec23113 Handle missing pipes in Gallery syntax, and remove them when caption is empty 
Bug: T146190
Change-Id: I703bcdf68b9631a47d839baf3abb42ff98b36bf2
 2016-11-28 17:36:29 +00:00
jenkins-bot 6bcfed97a5 Merge "Separate out ArticleTarget as a module" 2016-11-26 23:22:32 +00:00
Ed Sanders 4fe6be1f34 Separate out ArticleTarget as a module 
Also move save button command help registration to ArticleTarget.

Bug: T151096
Change-Id: I941d17254a2e20a82aa46fd538abf887d757c0c3
 2016-11-24 12:35:41 +00:00
jenkins-bot 1909c445bb Merge "Allow the gallery dialog to insert duplicate images initially" 2016-11-24 04:13:03 +00:00
Ed Sanders 0334263718 Missing i18n in gallery dialog 
Change-Id: I369d5b9d42a5fd6b4d1afc12508632a282591320
 2016-11-24 00:09:49 +00:00
jenkins-bot fde5c3c2ff Merge "Follow-up I63ab27cb: Get rid of notices tool when there are no notices" 2016-11-23 01:17:42 +00:00
Thalia 003ec7b653 Allow the gallery dialog to insert duplicate images initially 
Change I94f4fadd84cd3e prevents the gallery dialog from inserting
duplicate images into the gallery dialog after one request (e.g.
so double-clicking on an image in the search widget doesn't cause
the image to be inserted twice). However, galleries can
intentionally contain duplicates of the same image, so it is
possible to make a spearate request to insert a duplicate image.

When the dialog is first opened, it requests all the images in
the gallery at once, so the above change was causing the
duplicates in an existing gallery to be dropped. Duplicates
should be allowed to be inserted following this initial request.

Bug: T150894
Change-Id: I34353bc9b8db947488474c4be52292e0a1447705
 2016-11-23 01:02:35 +00:00
jenkins-bot 508b4164bd Merge "Let gallery dialog handle unprefixed filenames" 2016-11-23 00:33:39 +00:00
Alex Monk b89a6ee463 Follow-up I63ab27cb: Get rid of notices tool when there are no notices 
Bug: T151423
Change-Id: I3dd9d2cbfb1fa536490eb8b4b7d630e9c6cfdd48
 2016-11-23 00:30:06 +00:00
Thalia 2364f530a3 Let gallery dialog handle unprefixed filenames 
The namespace prefix before image filenames is optional
in galleries, but the API requires it. If the prefix is
omitted, add the file namespace prefix.

Change-Id: I3d126550c2ad2e84454122f92307ba4bc943780b
 2016-11-23 00:20:32 +00:00
Alex Monk 16e294fba7 Move around code that sets up edit notices to ensure it runs after we receive the notices to display 
Bug: T151236
Change-Id: I63ab27cb236169f300295b2ed4c88e01048092e7
 2016-11-22 19:16:09 +00:00
Ed Sanders 6e64fba2f8 Unbreak education popup 
Tools only setup once now, and that is during the dummy surface
phase, so we have to setup the education popups then.

Change-Id: Idf46fe42c893c0692dc442226297253074ef9bd7
 2016-11-21 15:19:58 +00:00
jenkins-bot 8fd396151c Merge "Migrate DesktopWikitextArticleTarget code upstream" 2016-11-20 03:06:55 +00:00
Ed Sanders e1a887ccf8 Migrate DesktopWikitextArticleTarget code upstream 
Change-Id: Icca4715411737a561302b44b127d91d117e7e29b
 2016-11-20 02:52:14 +00:00
jenkins-bot 3483055c29 Merge "Remove max-width from save summary" 2016-11-16 17:55:35 +00:00
James D. Forrester f24e34de3c build: Bump eslint-config-wikimedia to v0.3.0 and make pass 
Change-Id: I7449c11aa63c50fda667265c32021439cc53471f
 2016-11-15 15:05:05 -08:00
jenkins-bot 65604802ac Merge "Fix attribute.style typo in gallery dialog" 2016-11-15 22:09:57 +00:00
Thalia 97af378bb5 Fix attribute.style typo in gallery dialog 
Change-Id: I71162652df5e09c4d974e0f863ea661c4bd7902e
 2016-11-14 22:26:39 +00:00
Thalia 810202395e Normalise filename after image is chosen in gallery dialog 
Bug: T150638
Change-Id: Iead7d0d3f8aa6c864dc6fba7089bab0767035812
 2016-11-14 22:04:25 +00:00
Ed Sanders 37ccaca2ec eslint: Re-enable wrap-iife and partially enable dot-notation 
Change-Id: I4420d66f528dcb18ebe2b9f63996661b2969f833
 2016-11-12 14:43:43 +00:00
Ed Sanders 003c5ac410 Use a blank temp document when selection is empty 
shallowCloneFromRange can a broken document if you pass
a collapsed range. That should be fixed upstream but for
now this fixes a major bug (and is faster).

Bug: T150492
Change-Id: I9b539c588d91ef7f22e662c7cae0b3f89b21d33a
 2016-11-11 00:08:11 +00:00
jenkins-bot de72f77b1b Merge "Collapse to end after inserting WT signature" 2016-11-09 20:00:05 +00:00
James D. Forrester 79befe3d67 MWExtensionWindow: Use #setDir, not the removed #setRTL 
Change-Id: I4090fa0375a93e095a644538b52853fd849b8749
 2016-11-09 11:13:09 -08:00
Ed Sanders 1cb4c27378 Collapse to end after inserting WT signature 
Bug: T150320
Change-Id: I06a8304499d92d0155c112449678fef34dc98424
 2016-11-09 15:26:44 +00:00
Ed Sanders 55fcded32e Replace non-standard whitespace in comments 
This is required to pass eslint:recommended.

Change-Id: If8c4876a366e5c021c414e54328ed1913b679969
 2016-11-08 14:15:12 +00:00
Ed Sanders 526b2c0656 Remove max-width from save summary 
Prevents mis-alignment of textbox and checkbox bar
on mobile.

Change-Id: I33d8a2bd4e30d2ed4d61942a7646299f9935bc32
 2016-11-08 10:29:03 +00:00
jenkins-bot 5709e89399 Merge "eslint: Remove unused exception and fix documentation errors" 2016-10-28 19:12:19 +00:00
Ed Sanders e655880d14 eslint: Remove unused exception and fix documentation errors 
Don't enable valid-jsdoc yet though, due to @chainable bug.

Change-Id: I4d2a6de19c72c6e4c20733446616d8046419d431
 2016-10-28 12:02:36 -07:00
jenkins-bot bce6aeb92a Merge "build: Replace jscs and jshint with eslint" 2016-10-28 18:43:15 +00:00
James D. Forrester 36befda61c build: Replace jscs and jshint with eslint 
It's new, it's fresh, it's amazing, it's here.

Change-Id: I5dc784411f704685ed5cc763a2b2b1c5d3e5a610
 2016-10-28 18:33:15 +00:00
jenkins-bot 7085796ec3 Merge "Don't allow an image to be inserted into a gallery twice simultaneously" 2016-10-28 02:29:19 +00:00
jenkins-bot db9d2e3cf5 Merge "Make meta dialog tools visibile but disabled in NWE" 2016-10-27 22:14:08 +00:00
Ed Sanders fad3b429c8 Make meta dialog tools visibile but disabled in NWE 
Following our unwritten rule of trying to keep the interface
as consistent as possible.

Change-Id: I58668acb5bac12de73b7b8f52e670f68336c399f
 2016-10-27 14:48:51 -07:00
Ed Sanders 7bc59cd65c Set mode of save dialog after setting size so footer is correct height 
Bug: T149274
Change-Id: Ic88b1c861029495e6098686d847deb181f62288e
 2016-10-26 20:09:21 -07:00
Ed Sanders 6358d9ed6d CSS styleguide fixes 
These will be enforced in future versions of stylelint-config.

Change-Id: I0689cbeee6586d2d3dcb0021a3f613dc2ac73691
 2016-10-25 15:58:10 -07:00
jenkins-bot dd30f86c52 Merge "Make ve-ui-mwGalleryDialog-image-container-highlighted rule more specific to ensure border-color rule takes effect" 2016-10-21 00:01:38 +00:00
Alex Monk 8414490dbf Don't allow an image to be inserted into a gallery twice simultaneously 
One after the other is okay though.
Also fix this so that, if the user is fast enough, two images simultaneously
also works.

Bug: T148558
Change-Id: I94f4fadd84cd3ed97d9676043cadc64f0e09f0b9
 2016-10-20 02:22:34 +01:00
Alex Monk 77629cd374 Make ve-ui-mwGalleryDialog-image-container-highlighted rule more specific to ensure border-color rule takes effect 
Bug: T148041
Change-Id: I39366884d44ea68780c3780042cf82e34408d098
 2016-10-20 00:31:55 +01:00
Derk-Jan Hartman 406e9f8e9c Enable conditional loading of ACE language modes 
require bypasses Ace's internal loadModule() logic which is capable of
on demand loading of Ace modules. Because unloaded modules are not
defined, they cannot be required, and because we don't use RL to preload
all modes (because it's a lot of bytes), currently only very few of the
available language modes were currently available.

Also validate language mode names passed to Ace.

Bug: T148518
Change-Id: I82d278920695be12aa80a79548abf8b8ce5445fd
 2016-10-19 02:23:17 +02:00
jenkins-bot a9240d6f2f Merge "Strip RESTBase IDs from HTML generated when wikitext is pasted" 2016-10-14 00:55:48 +00:00
Alex Monk 25933c09ec Strip RESTBase IDs from HTML generated when wikitext is pasted 
Bug: T146054
Change-Id: I0013673a9e41ea191ea64f3208a06288efb2ecd3
 2016-10-13 17:42:11 -07:00
Ed Sanders 85f8030053 MWMediaSearchWidget: Fix indentation in var 
It is alarming that jscs is not picking this up..

Change-Id: Ibd3b113ebfedede9fa45120c24f00623ec5ea2fb
 2016-10-13 23:45:37 +00:00
Thalia 7ec7acf108 Take only the last part of a URL query in media search widget 
Quick fix to the problem that searching for the file name or
page title currently returns the image, but searching for the
URL does not.

Bug: T121354
Change-Id: I13e665226e5dc15ba626126dc4806ce8f4e0040b
 2016-10-13 21:54:10 +00:00
jenkins-bot 56c5ecb0f1 Merge "Fix sanitizing of query value in media search" 2016-10-13 04:14:10 +00:00
Ed Sanders 972094788c Fix sanitizing of query value in media search 
Always use #getQueryValue which trims whitespace, so we
don't pass whitespace to the API.

Also rename some variables for clarity, and remove some
unused arguments.

Change-Id: I0d27f59488295bc1c398d0fd287e3e16a3f5aaec
 2016-10-13 04:03:57 +00:00
Thalia 91ca88f6e8 Set gallery dialog to larger size when search panel is focused 
Bug: T145246
Change-Id: I49b218f704d31b4f699fe39f414a84abbfffc093
 2016-10-12 17:42:54 -07:00
jenkins-bot eafbe8cf8c Merge "Add big/small support to NWE" 2016-10-08 21:00:35 +00:00
Ebrahim Byagowi e55d1b2a3c i18n: Native digits on 'visualeditor-editnotices-tool' 
Change-Id: I5a802199a9d736d0082775052d5224cfa9580450
 2016-10-08 18:36:36 +00:00
Ed Sanders 2ad4015775 Add big/small support to NWE 
Change-Id: Id42cb7563d7f6d14d0f225edb8a283c8b9eaa8db
 2016-10-07 22:44:52 -04:00
Ed Sanders 31a3f2f0b6 Move editfont class down to surface view, so it doesn't break DebugBar 
Change-Id: I779ab9d581af37ae104acf4ea6a83b86504bb257
 2016-10-07 16:10:58 -04:00
jenkins-bot 1321452197 Merge "New wikitext editor: unwrap lists when changing style" 2016-10-05 19:40:01 +00:00
jenkins-bot 26e235211d Merge "Pass excludeCurrentPage option to TitleSearchWidget in link inspector" 2016-10-04 22:45:10 +00:00
jenkins-bot 9da0eaef03 Merge "Pre-load the article title in gallery dialog search" 2016-10-04 16:24:00 +00:00
Ed Sanders 69c332d1ad New wikitext editor: unwrap lists when changing style 
Bug: T147227
Change-Id: I1a7f86e2a97855be5c44671d8f5918fb87bc70d0
 2016-10-03 16:16:04 -04:00
jenkins-bot 1e89ab7d7a Merge "Remove commented out code" 2016-10-03 19:37:27 +00:00
Ed Sanders 755500b463 Remove commented out code 
Change-Id: Ie3edc36c5d51eb7f6363416594a8aab37dec074c
 2016-10-03 15:08:47 -04:00
jenkins-bot d415a003cd Merge "Apply user preference 'editfont' to NWE" 2016-10-03 17:01:11 +00:00