Commit graph

6527 commits

Author SHA1 Message Date
Timo Tijhof dd9ff827b5 Follow-up 7994eae8c2: Fix uncommitted loader change causing 404
That commit added jquery.uls to the ve-mw repo, and updated
lib/ve to a commit after we removed it from the ve repo and from
modules.json. These changes are being made by grunt-build every
run and should've been comitted to the repo.

See also 1e92abe028.

Change-Id: Ie318643d080e9f5a63793ef60153ef4d82a13d8c
2014-01-29 06:23:50 +00:00
jenkins-bot 4c3da1b017 Merge "[browser test] Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem" 2014-01-28 22:32:15 +00:00
Translation updater bot 0b5d86b6a7 Localisation updates from https://translatewiki.net.
Change-Id: Iea5074baacada1142e6b05427f8bc762db107643
2014-01-28 21:24:43 +00:00
Zeljko Filipin 59e764505a [browser test] Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem
Bug: 56085
Change-Id: Icf9dd875665f13dafb308d2897c857a632ac117a
2014-01-28 17:58:20 +00:00
Roan Kattouw 12e4b41660 Don't throw JS errors when opening MWExtensionInspector on the wrong node type
The setup method just assumed this.node was of the right type, and
would just crash if it wasn't. You could select an image, open the
gallery inspector, and it would happily try to inspect it until
crashing because there was no .mw.extsrc attribute.

Bug: 60502
Change-Id: Idf0e9cf7ccaa37e607374ced150db732926a19f8
2014-01-27 19:21:36 -08:00
jenkins-bot c39d1e63e0 Merge "Simplify toDataElement in MW" 2014-01-28 03:17:41 +00:00
jenkins-bot 641be60aea Merge "Update VE core submodule to master" 2014-01-28 03:16:40 +00:00
jenkins-bot 4b71c52f44 Merge "Fix toolbar margins in vector" 2014-01-28 02:48:56 +00:00
Ed Sanders bdb4a8a149 Simplify toDataElement in MW
As per I54943588c5cc2 in core.

Change-Id: Ia40e7327c4ce07a79d64a6d5b1ff0d7acec55171
2014-01-27 18:43:36 -08:00
Roan Kattouw c768b22bdd Update VE core submodule to master
New changes:
d4a0fef Simplify toDataElement
fc5046d Simplify toDomElements
d81e542 Tests for RDFa attribute preservation
674ab3e Make keyboard shortcuts dialog footless
3282caf Localisation updates from https://translatewiki.net.
9b4354b Fix balancing of data in cloneSliceFromRange
9ea3f42 Attach container to DOM before initialising target in demo
e7f2b68 Only call setOriginalDimensions when non-null values are provided
815d5e9 Localisation updates from https://translatewiki.net.
8834bbb Minor clean up and doc fixes
b6bd0e9 Fix typo in ve.ce.Surface test message
2ea4ca9 Show % scale on ResizableNodes

Change-Id: I1619b9c950ef7ff26e54df6444e61fff405fdef0
2014-01-27 18:39:47 -08:00
jenkins-bot 2c0faa4bb1 Merge "Store original dimensions results in IV store" 2014-01-28 02:33:57 +00:00
jenkins-bot 263b8c04c1 Merge "Add tagName to ve.dm.MWGalleryNode" 2014-01-27 22:34:37 +00:00
Roan Kattouw 4aeb773404 Add tagName to ve.dm.MWGalleryNode
I told James this wasn't needed, but I was wrong. It is null in
the parent class, and DOM throws on document.createElement(null).

Bug: 60307
Change-Id: Iff8fda9acf9f37e537d7d6cf6106a801d6b71338
2014-01-27 14:28:16 -08:00
Roan Kattouw 3acd206a6a Followup 7994eae8c2: fix MWLinkInspector breakage
getAnnotationFromText was renamed to getAnnotationFromFragment,
update MWLinkInspector for this.

Bug: 60374
Bug: 60378
Change-Id: I202a2777f0202dcf42c5968daf8bdf5583b0a11b
2014-01-27 13:11:06 -08:00
Ed Sanders 3612914509 Fix toolbar margins in vector
In HD mode, the left margin was 0.25em off.

In narrow mode, the margins were completely wrong.

Bug: 51000
Change-Id: I7fd9cbc925b828fd780adb9ab2c71bcf15dc7284
2014-01-27 20:11:22 +00:00
Translation updater bot 0e7d5eb397 Localisation updates from https://translatewiki.net.
Change-Id: Idcbcf99348cf8305ec0631f9c220cebb41e6a71d
2014-01-26 16:28:09 +00:00
Ed Sanders f6acb93d5a Store original dimensions results in IV store
* Remove the this.mediaSize custom store object and replace
  with a hash function and the document's IV store.
* Remove this.inputs/this.fieldsets namespaces.
* Calculate this.filename as soon as this.mediaNode is set.
* Rename getMediaSize to getOriginalDimensions

Change-Id: I2030aade5d96555451f6a390d0aa3d44b860841f
2014-01-26 14:26:57 +00:00
Translation updater bot ed7678eb6b Localisation updates from https://translatewiki.net.
Change-Id: I36c11b10b2ad32d68bbca3a7670dbd3a4c9e4dd1
2014-01-24 20:14:28 +00:00
Ed Sanders 5dff7fc7d0 Fix typo in ui.MWCategoryItemWidget
Change-Id: I6270753598bed3179451d17919b445f15db42233
2014-01-24 19:00:11 +00:00
Ed Sanders 06afe0920e Update VE core submodule to master
New changes:
49d2fe6 Fixing ButtonWidget call in MediaSizeWidget
d9f39ee Fix RDFa attribute protection loop

Change-Id: I31e6486e9ec90626164c3920e58ffc484f8b2ae5
2014-01-24 18:42:03 +00:00
jenkins-bot bea2018ea2 Merge "[Browser test] Updated indent/outdent page elements." 2014-01-23 20:49:06 +00:00
Translation updater bot 8aad62944a Localisation updates from https://translatewiki.net.
Change-Id: I8a601b861359c78e4c175171d6bae972112cb669
2014-01-23 20:21:57 +00:00
Jeff Hall c94c67846b [Browser test] Updated indent/outdent page elements.
Change-Id: I686bec668b6e49b3cebf48790398923f13e3e594
2014-01-23 11:02:32 -08:00
jenkins-bot 319fa24061 Merge "ve.dm.MWTransclusionModel: Clean up and fix logic error" 2014-01-23 03:00:55 +00:00
jenkins-bot ee83ec0e1e Merge "Relativise URLs against target document" 2014-01-23 02:58:51 +00:00
Timo Tijhof 7316c6ba3b ve.dm.MWTransclusionModel: Clean up and fix logic error
* Reduce duplication by calling #removePart (equal, line by line)
* Reset `remove` at the start of each iteration, it was leaking
  through to future iterations.
* Minor simplification in property access.

Change-Id: Ie0a83d582804bc50131ca5a8da36b0605dd4a6c3
2014-01-23 02:58:23 +00:00
Ed Sanders bb773e852c Relativise URLs against target document
mw.Uri will just be using window.document, which may have
a different base.

Depends on I86fe6c2f41e549 in core.

Bug: 58136
Change-Id: I320d5d477d97ebf25963ab2dc429931bc871dd17
2014-01-22 18:46:38 -08:00
Moriel Schottlender 8130acebfd Changing image size in MWMediaEditDialog
Adding the ability to edit image size in the media edit dialog.
The size is now a separate widget.

The following changes were made:
* The dialog was changed to a booklet with 'general settings' and
  'advanced settings', in preparation for other edit features.
* The original image maximum size is fetched from the API and cached.
* Maximum size is limited to the image's original maximum size.
* Aspect ratio is kept when changing height or width, using original
  image size to preserve a sane ratio through the MediaSizeWidget.
* If an error is found in the size, the image will retain its previously
  set dimensions.

Depends on MediaSizeWidget: I3d0f9348a52

Bug: 38129
Change-Id: I2946fb21c46ce05583b219f665ef68928188899e
2014-01-22 18:43:45 -08:00
Roan Kattouw 98c101e56d Update VE core submodule to master
New changes:
16eb2e2 Script to update the oojs-ui and oojs distributions
b20be0b Fix exception thrown by findEndOfNode
af4f8f1 Fix Document#selectNodes error documentation
37ace2e Update OOjs to v1.0.6-pre (e284c5fed7)
2eb5927 Add internalList nodes to example data
461deca Fix up result of selectNodes
34fe23e Protect RDFa attributes from obliteration
4d562ec Resolve URLs against correct document when copying.
bc5be2a Adding a MediaSizeWidget

Change-Id: I903cd23a5244766df714ffd3232de1a031472c2a
2014-01-22 18:29:54 -08:00
Trevor Parscal 92746ef3da Implement 'change' events in templates models
This will make generating live previews possible.

Changes:
* Add change events to template model.
* Set up connect/disconnect.

Also:
* Add missing fallback for getParameterLabel (Param#label is
  optional per the TemplateData spec).
* Implement getWikitext, to be used by the UI dialog later
  to create a preview from the wikitext.
* Correctly mark ve.dm.MWTransclusionNode#escapeParameter as
  being a static method.

Change-Id: Ie306ed03babf11568e954b1813ce5324f57d7f0e
2014-01-22 19:03:17 +00:00
cmcmahon 09ed99ef81 Chrome does not always dismiss the beta warning
Change-Id: I48249852d308cfb68ab64cedde6a83f41879ff36
2014-01-22 08:50:15 -07:00
Translation updater bot dabe8ad402 Localisation updates from https://translatewiki.net.
Change-Id: Iacb2d0da11a7bc7970d265ee8a15df0dd6319f70
2014-01-21 19:54:38 +00:00
Jeff Hall 37e90c1a80 [Browsertest] Test maintenance for new DOM elements.
Change-Id: I25c1d98bd5cbee9ccb8d6fd1e2912e3205cf85ac
2014-01-21 10:46:40 -08:00
Ed Sanders fdb4062aec Remove unnecessary strangely written range clone
Probably left over from when the range calculation was more complex.

Change-Id: I59c989bac0d80f4a12e57cbd41bdc6587acd964a
2014-01-21 17:35:45 +00:00
Translation updater bot 22b49f3d5b Localisation updates from https://translatewiki.net.
Change-Id: I718643c6387c2046a5312fcd80b321dbc14220cb
2014-01-20 20:28:16 +00:00
Translation updater bot 718200d7ba Localisation updates from https://translatewiki.net.
Change-Id: I39f011f38c6808a8326eab014a58b3b7b2265b9c
2014-01-18 21:17:33 +00:00
Trevor Parscal 49471fc9b5 Update VE core submodule to master
Also update for indicator changes in Iaf7726150

New changes:
f981943 Fix toolbar indicators in demo
e849941 Update OOjs UI to v0.1.0-pre (11632fcada)

Change-Id: I16c38259ccedbfba8260f8a508b572cee6389517
2014-01-17 18:30:00 -08:00
Trevor Parscal 7994eae8c2 MediaWiki language inspector updates
* Add ULS, which was removed from VE core
* Add experimental mwlanguage module which adds ULS integration
* Hook in ULS to the existing language widget

Also update VE core submodule with changes:
* 1e92abe Generic language inspector

Bug: 47759
Change-Id: I325a4dcc316d0334fadfcaa46ad3acd45c6bf84b
2014-01-18 01:02:23 +00:00
Roan Kattouw 2817094781 Update VE core submodule to eb595b06
New changes:
93e0069 Fix JS error when closing autonumbered link inspector with invalid title
a6eaa05 Prevent newFromAttributeChanges() from creating no-op transactions

Change-Id: I76bff5951153e1645c84e247119aab34bdb8c33b
2014-01-17 16:22:29 -08:00
jenkins-bot 3cdc8e59b4 Merge "Tee tracked events to MediaWiki's mw.track" 2014-01-17 22:49:24 +00:00
Trevor Parscal 0916b68ed5 Remove unused OOUI messages
Change-Id: I0ce895cb7982fa2e320885b22808b857dc59ca47
2014-01-17 12:49:27 -08:00
Translation updater bot 7ef8e0ffc9 Localisation updates from https://translatewiki.net.
Change-Id: I6e85c2b35c7e261884dab13f80ebee1ca1e5bea4
2014-01-17 20:42:25 +00:00
Trevor Parscal f4156bd09f Update VE core submodule to master (e7e2833)
New changes:
* e7e2833 - Update uses of Push/IconButtonWidget to ButtonWidget
* d9d9eb5 - Update OOjs UI to v0.1.0-pre (d9bab13)
  * d9bab13 - The Great Button Refactor of 2014
* 22b93ef - Update OOjs UI build (88b2871)
  * 88b2871 - Fix png transparency on required.png
  * 670c468 - Add i18n

Also:
* Update uses of Push/IconButtonWidget to ButtonWidget as there
  is a breaking change in new OOjs UI version.
  This was separated from commit I325a4dcc316d0.

Change-Id: I82220d15221c52be03feafcfc85c2bd6c12ba462
2014-01-17 16:29:36 +01:00
Translation updater bot 8e2a38cc04 Localisation updates from https://translatewiki.net.
Change-Id: Ib08fc6b50614b3c6737d67b1e7e8158e67b249e8
2014-01-16 23:09:48 +00:00
Ori Livneh 753d87e618 Tee tracked events to MediaWiki's mw.track
When running in the context of MediaWiki, VisualEditor should tee its event
stream to MediaWiki's main event bus, mw.track(), so that MediaWiki event
subscribers have a unified interface for subscribing to events. Each
VisualEditor event topic is prefixed with 've.'

To test this patch, you can use this snippet:

  mw.trackSubscribe( 've', function ( topic, data ) {
    console.log( this, topic, data );
  } );

Change-Id: I6b3f10b0dd0aa7fa47c3b35e2fc554622960ce52
2014-01-16 13:34:20 -08:00
Timo Tijhof 1944b0c6f0 jsduck: Fix script loading issues with eg-iframe in production
It works locally because it can just nagivate to ../lib/ve.

In production however we need docs/ to be standalone so that we
can publish it without needing a subdirectory at:
https://docs.wikimedia.org/VisualEditor/master/.

For local usage this will be a symlink that still points to
the sibling directory (but using a symlink instead of a ../ path).
In production we can then instruct jenkins to replace that symlink
with an actual copy of lib/. As long as the generated path
references in the HTML remain the same.

Follows-up 88c4888872, which broke the publication of the docs in
Jenkins as it changed references from modules/ to ../modules/ for
the eg-iframe. This works locally, but broke in Jenkins as it was relying
on the copying of modules/ to docs/modules/ being enough to make it work).

Change-Id: I10eaa5424d172932b29774a0f03d511d555fd121
2014-01-16 20:41:20 +00:00
Timo Tijhof 8e7a864e90 Clean up and doc fixes
Remove odd comment and move node property to list of properties.

Change-Id: Ife3161bbdbf01075e987e65d9bfef41994efa916
2014-01-16 17:41:08 +00:00
James D. Forrester cab709f590 Update VE core submodule to master (6645b10)
6645b10 Merge "Clean up CONTRIBUTING.md and README.md for VE core"
c10a2b5 ve.init.Target: Fix $document property documentation
0bce7f6 Clean up CONTRIBUTING.md and README.md for VE core

Change-Id: Ib24672d322e90b6264f0cf08855d9ce53a7225fa
2014-01-16 17:37:38 +00:00
Ed Sanders 26392cc1db Fix png transparency on gallery.png
Change-Id: Ia202294e1d27517c5317654e1d2d3410286c1773
2014-01-16 11:45:32 +00:00
Ed Sanders 6f37b4608c Only show non-anchored resize handles for MWBlock/InlineImages
For block images, show the bottom left/right anchor if the image
is right/left aligned, and both if it is centred.

For inline images, show the bottom right anchor unless the page is
RTL.

Change-Id: Icb5b74b954493257c517a5fbac5f0a0a457c544c
2014-01-16 02:41:48 +00:00