Rob Moen
5ac30a2f5f
Apparently every object in FF has a watch() method. Added better
...
Checking for this for when mw.page.watch module is not loaded.
Change-Id: I67688288dba59aa52bba9d538682374a15169285
2012-06-20 18:35:07 -07:00
Inez Korczynski
c1225acb68
Fix method hasSlugAtOffset to return true when length of the element is 0
...
Change-Id: Icf43eb6adfcc45eaf1ae8ff146a029546341ba33
2012-06-20 18:18:49 -07:00
Inez Korczynski
a62e78292f
Add slugs inside empty branch nodes so cursor can be correctly placed.
...
Change-Id: I075a76da50bd4927c3832a660fdf96bbd250e3b0
2012-06-20 18:18:49 -07:00
Trevor Parscal
6fe115a563
Removed trailing whitespace and other cruft
...
Change-Id: I8c439d2a272e01b9e26bfd6b13d9e600d324930b
2012-06-20 17:42:12 -07:00
Catrope
e4ada5296a
Merge "Pressing backspace or delete at boundary of dislike nodes will cause adoption"
2012-06-20 23:53:40 +00:00
Catrope
d92320a670
Merge "Set defaultrebase=0"
2012-06-20 23:30:28 +00:00
Christian Williams
93594d1c22
Pressing backspace or delete at boundary of dislike nodes will cause adoption
...
Change-Id: Idd6cd40c8d4f34081851fc9ea1cc70037915244b
2012-06-20 16:28:13 -07:00
Catrope
7c8ae5ecba
Set defaultrebase=0
...
Change-Id: I2fa95fa141d12068df5e6f8c1a12bf67112123e8
2012-06-20 16:27:40 -07:00
Rob Moen
4b8833942c
If user is anonymous, mw.page.watch is not loaded. Only call
...
method if module is loaded.
Change-Id: Ieb549b701f05f1dab322baa79d59366225f42727
2012-06-20 16:22:10 -07:00
Trevor Parscal
e175292c07
Typo fixes throughout the codebase
...
And a missing semicolon
Change-Id: I8487525ae2a7fa8f58e00c92c7dff600d9bd9520
2012-06-20 16:01:02 -07:00
Trevor Parscal
5968991d25
Broke the grouping functionality of ve.ui.ListButtonTool.list method into ve.Document.getCoveredSiblingGroups
...
Also fixed unlisting to not break when unlisting a range that includes things that are not list nodes
Change-Id: Ib9d4ea851c3ed9bf72a93aa87e470ce40c308453
2012-06-20 15:49:41 -07:00
Inez Korczynski
bbaa17a6c4
* Replace spaces at the beginning and at the end of text node with
...
* Alternate double spaces with  , " " -> " "
Change-Id: Ib4351ed6263e69f0d98957c2d0d8411e040fece7
2012-06-20 15:32:14 -07:00
Translation updater bot
9b170e696e
Localisation updates from http://translatewiki.net .
...
Change-Id: I3ffd8a577c903e11ebe767cd5ae93c0f969b81f6
2012-06-20 22:28:06 +00:00
Rob Moen
8178237c27
Update list tool updateState method so that if you have nodes not
...
contained by a list node the button is off. Button is now only toggled on
if all nodes in selection have a parent list node.
Patchset 2 - cleanup whitespace
Change-Id: Ia9adc39c0d5c75e2e96580f0e172f5b602540ac3
2012-06-20 15:12:08 -07:00
Gabriel Wicke
5ff4aa4c2d
Merge "First attempt at the definition list bug (work in progress)"
2012-06-20 22:03:16 +00:00
Catrope
37600d020c
Add ve.dm.Transaction.translateOffset() and translateRange()
...
Change-Id: I21bde38056862a1de167646f6cf3030e38d3497b
2012-06-20 14:52:44 -07:00
Gabriel Wicke
cf32b34b0a
First attempt at the definition list bug (work in progress)
...
The main issue is that the bullets from dd/dt were not stored on the stack. I
added a separate field for it in each stack entry, which now fixes the basic
indent case without (afaik) breaking anything else.
There are still some newline issues, and the need to handle the single-line
dd/dt vs. the multi-line variant.
Change-Id: I65939c05e2c5dde0789bf8aefd7651161a2f137c
2012-06-20 23:51:39 +02:00
Translation updater bot
1e12f61dd1
Localisation updates from http://translatewiki.net .
...
Change-Id: Id220344eada7ebd6fadc9c44f164888c3f3e3d71
2012-06-20 20:31:27 +00:00
Rob Moen
cc47a4d05c
Add Hook for 'watch' event triggered on MW watch link or icon
...
to update save dialog checkbox with correct watched state.
Call mw.page.watch.updateWatchLink onSave to refresh icon
with watched state.
Patchset 2- updated event name
Change-Id: I23ef1aad9c8ace13df1b9a6bf0bfeddb9d8bcb37
2012-06-20 13:05:56 -07:00
Catrope
3877a0d58d
Merge "Rewrote listification"
2012-06-20 19:39:28 +00:00
Trevor Parscal
5df5d8470a
Rewrote listification
...
Now handles wrapping or converting properly, in any combination
Change-Id: If8b573f576555c9129f8316bc9f06557eda06e85
2012-06-20 12:39:03 -07:00
Trevor Parscal
d429113eb8
Merge "After creating a page, refresh the page rather than going back"
2012-06-20 19:35:42 +00:00
Trevor Parscal
bcf93eb695
Automatically bind and unbind context's window event bindings on documentNode focus and blur
...
Change-Id: Ie43165da49a36a7d0d13a52318d9c5438dad9605
2012-06-20 12:34:20 -07:00
Trevor Parscal
7a1d74fd18
Change state variable so updates work more than once
...
Change-Id: I7c701761b09e96e01e26164080d22cafe43019e0
2012-06-20 12:28:01 -07:00
Catrope
427406a0bc
After creating a page, refresh the page rather than going back
...
We can't go back in this case because the action tabs etc. will be wrong
Change-Id: I8e26c43b7735ea8a2ef010bd4141f0ee8d4b1c68
2012-06-20 12:16:27 -07:00
Gabriel Wicke
e8c517e48e
Merge "Improve preformatted text handling"
2012-06-20 19:08:48 +00:00
Catrope
9f5f43f18a
Fix residual selectNodes() breakage from fc4ba3019a
...
Change-Id: Icc317eab71d4e360905e902a0ae7cc88deab4cbe
2012-06-20 11:39:20 -07:00
Catrope
a22c1870ea
Fix ve2 paths in RL modules and tests
...
Change-Id: I435b9902209348beba83f399ae165d179e954ccb
2012-06-20 10:57:23 -07:00
Catrope
e175670616
Merge "Update JS and CSS references in demo to point to new location - ve instead of ve2"
2012-06-20 17:53:31 +00:00
Rob Moen
b9eb06349f
Switch path from ve2 to ve help with Dmrewrite merge
...
Change-Id: I8fbbfcb3e47a9319398af7262effc1f7cf3df51f
2012-06-20 10:49:00 -07:00
Gabriel Wicke
344fac19b5
Improve preformatted text handling
...
* Don't escape html-syntax pre content for now; Should parse this with a new
pre content production later (which needs to be split out of the regular pre
production in the tokenizer)
* Protect indent-pre content from start-of-line syntax escaping
* Preserve extra leading spaces in the tokenizer
* Two more (now 284) round-trip tests are passing
Change-Id: I199b89c0ee7fae12546df10c1b5117c97caccac5
2012-06-20 19:28:34 +02:00
Gabriel Wicke
6054a4aa14
Clean up serializer newline handling a bit further
...
Queued newlines and new trailing newlines were not cleanly separated so far,
which caused some trailing newlines to be consumed for needed leading
newlines. This change fixes several newline bugs, taking the number of passing
round-trip tests from 276 back up to 282.
Change-Id: Idb4706e15ce71e63085033e3f3f29557915c11a8
2012-06-20 16:31:39 +02:00
Gabriel Wicke
2426901e5b
Fix definition lists with multiple dds
...
Fixed a bug in the list handler for multiple dds in a definition list. Also
fixed a few JSHint warnings.
Change-Id: I3e883786698a9521347fc2a5e6420646318813a7
2012-06-20 15:34:20 +02:00
Gabriel Wicke
c9d3db8f34
Fix a few round-tripping and list issues
...
At least partly fixes some bugs in
http://www.mediawiki.org/wiki/Parsoid/Bug_test_cases . 276 round-trip tests are
passing.
* Fixes
http://www.mediawiki.org/wiki/Parsoid/Bug_test_cases#extra_newline_after_empty_dd ,
except for lost newline in 'working' example before next heading
* Fixes newlines in definition lists
(http://www.mediawiki.org/wiki/Parsoid/Bug_test_cases#dd_indentation etc),
but does not fix missing / incorrect bullets for those
Change-Id: I21f66e265e43e1d1a4c7da70984a9984b8e6d0dd
2012-06-20 13:53:47 +02:00
Inez Korczynski
93b834a688
Update JS and CSS references in demo to point to new location - ve instead of ve2
...
Change-Id: I7d5c7888ec4c0923a42c25cf86799b0d07427acf
2012-06-19 20:53:55 -07:00
Catrope
748b34cc49
ve2 -> ve in the tests directory too
...
Change-Id: I30b56b1c43202d8cb6af397d2813b19b1a71d30e
2012-06-19 18:36:34 -07:00
Catrope
c97d0a5d9e
Merge branch 'dmrewrite'
...
This merges essentially all editor development in the past two months
Change-Id: I2c8653effc4dbb01a6b99a2ac2b87d83fbafa405
2012-06-19 18:28:49 -07:00
Catrope
6afed5e5cc
Move ve2/ back to ve/
...
Change-Id: Ie51d8e48171fb1f84045d1560ee603cee62b91f6
2012-06-19 18:20:28 -07:00
Catrope
fc4ba3019a
Fix selectNodes() bug: empty range at the start of a node returned []
...
Because of the end>=left condition, the loop was exiting right before
hitting the startBefore case, so use end>=left-1 instead.
Fixing this exposed another bug that caused nodeRange and nodeOuterRange
to be off by one: we need to increment left after storing it in
startOffset, not before
Change-Id: I54e18fb2119c8caefb4f7a7f2be43c6129afc4c0
2012-06-19 17:12:36 -07:00
Gabriel Wicke
b94cad47dc
Fix single-line mode for nested lists
...
Known issue: breaks round-tripping of :;;;::. That test is normally disabled
anyway, so we can fix it later.
Change-Id: I7954271311bfb7e71caae59d8177e3f04a9ebbca
2012-06-20 01:48:52 +02:00
Gabriel Wicke
9d25b975ae
Switch back to line-based diff, refineDiff hides some diffs
...
Change-Id: Ia422b67d2a9010d583780f77df60fb19eab18239
2012-06-20 01:31:46 +02:00
Subramanya Sastry
a964e5ac6e
Merge "Revert "Fixed newline stripping in rtve mode.""
2012-06-19 23:26:41 +00:00
Catrope
39dbbf9455
Merge branch 'dmrewrite' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor into dmrewrite
2012-06-19 16:19:00 -07:00
Catrope
dc3be737b4
Merge remote-tracking branch 'origin/master' into dmrewrite
...
Conflicts:
VisualEditor.i18n.php
api/ParserService.js
modules/parser/mediawiki.WikitextSerializer.js
Change-Id: I47b299ff3a6d948dcbeaf53cde5786362b23f66c
2012-06-19 16:16:53 -07:00
Trevor Parscal
babb636058
Cleanup
...
Change-Id: I4af98700e5c4739d749ec95abc111710208d2177
2012-06-19 16:08:14 -07:00
Catrope
61f4a8af78
Update the code to account for the fact that sHref is now a string
...
and update tests to reflect the recent changes in link handling
Change-Id: Ie1a3e409c22c09f104c244b1db4764fd202fc885
2012-06-19 16:04:07 -07:00
Catrope
b6ad91655d
Make external links (mostly) work
...
This handles internal and external links separately, only setting
'title' for the former and only 'href' for the latter.
On the way out, detect external links using a simple regex (needs
improvement). Also don't write sHref any more per Gabriel's request.
Change-Id: Ibc2436d0a12de1d027e116f181db640cbcf3d522
2012-06-19 16:04:07 -07:00
Catrope
a80dcf84c6
Prevent the newline hacks from adding newlines before a link
...
We might be able to get rid of these altogether but I'd rather not touch
this too much for now
Change-Id: I0b55af017df7d9dc023b2d23ecd4f891cb75946b
2012-06-19 16:04:07 -07:00
Catrope
980ae78861
Prevent the converter from creating empty list items
...
Change-Id: Iae7d5d791d09400f7d3d799043efe6b8714465ec
2012-06-19 16:04:07 -07:00
Trevor Parscal
41b6ccf9d3
Fixed ve.dm.Surface tests that broke when setSelection was deprecated
...
Change-Id: I7319067cff0e088f70726c826a0c01be47aec808
2012-06-19 15:56:25 -07:00