Commit graph

18683 commits

Author SHA1 Message Date
jenkins-bot d4bfe21e3d Merge "Improve smooth scroll to section behaviour" 2022-02-16 02:39:24 +00:00
jenkins-bot a56ade0a02 Merge "Remove 'Hook' from new hook's method name" 2022-02-15 17:05:19 +00:00
Ed Sanders 8101b6511e Improve smooth scroll to section behaviour
* Append the toolbar before starting the scroll
* If the toolbar is floating set the anchor to full height
  immediately. This shouldn't cause the content to jump down
  due to scroll anchoring:
  (https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-anchor/Guide_to_scroll_anchoring)
  But add our own logic for it for browsers which don't support that.
* Now the browser only has to deal with the scroll animation,
  and not the height animation of the toolbar anchor at the
  same time, making it smoother and less buggy.

Bug: T301773
Change-Id: I61d533d40758d559b03c858e0006ef2e4f0fcd16
2022-02-15 15:23:47 +00:00
Translation updater bot 13ea85af8d Localisation updates from https://translatewiki.net.
Change-Id: Id4878e24f1ef04f63419b7fde98469b67959a009
2022-02-15 08:18:02 +01:00
Ed Sanders 5f8c5144ca Remove 'Hook' from new hook's method name
Only the class name needs the -Hook suffix.

Change-Id: I8c600ddb24a9d3a33ed78501639032d98e1e575f
2022-02-14 23:26:05 +00:00
Bartosz Dziewoński 89842933af Update VE core submodule to master (71a2d651c)
New changes:
1d8fbde1f Prefer the start of a CBN when selecting first visible offset

Bug: T299112
Change-Id: I49f1032905772b27ed8065f7c5b0068a32a15bf1
2022-02-14 22:07:54 +01:00
jenkins-bot b7a0a690fb Merge "Desktop: Always show loading progress in a toolbar placeholder" 2022-02-14 17:00:08 +00:00
jenkins-bot 23e9f189d6 Merge "Smooth scroll the heading to the right place while target is loading" 2022-02-14 16:59:49 +00:00
Ed Sanders 78decedd47 Desktop: Always show loading progress in a toolbar placeholder
Bug: T299907
Change-Id: I0eaeb98719bf7a43e4a87366cfcd204f35b74650
2022-02-14 16:17:48 +00:00
Bartosz Dziewoński 28c9a47164 Hide the edit notices tool earlier if there aren't any
Previously, a toolbar with the extra tool could be shown for a moment
while the editor was loading.

Bug: T301626
Change-Id: I7f5d01ef6e64ef85141a38a236fe2a1d1ada00e8
2022-02-14 15:48:55 +00:00
Bartosz Dziewoński efd1b3ab95 Fix narrow toolbar jumping during loading
When the editor is loading, and the browser window is narrow enough
that we should use the narrow toolbar, the wide toolbar would appear
for a moment. It was particularly jarring when it caused it to wrap
over two lines.

Bug: T301626
Change-Id: I551a66edab40235c4a26751eed163b5b30ef698f
2022-02-14 15:48:46 +00:00
Bartosz Dziewoński 7f79f2a0b4 Update VE core submodule to master (08aae2798)
New changes:
9ee9c8609 Localisation updates from https://translatewiki.net.
43e4c5e0e build: Updating npm dependencies
0b528cd63 Update OOUI to v0.43.1
c8a50eee9 build: Update eslint-config-wikimedia & stylelint-config-wikimedia
328b3d5b6 Localisation updates from https://translatewiki.net.
30591c0d0 Default target: Attach actions toolbar before init

Change-Id: Ifafd7a3453eee554138acca50ec1c49323d4f02d
2022-02-14 16:47:35 +01:00
Translation updater bot 773816af0d Localisation updates from https://translatewiki.net.
Change-Id: I4618643b0bc6e7306f269ded4796d75b0c8de0e4
2022-02-14 08:15:25 +01:00
jenkins-bot 66feffb991 Merge "Misnamed field on a/b test logging" 2022-02-12 20:37:04 +00:00
David Lynch d984bf2246 Misnamed field on a/b test logging
Bug: T301497
Change-Id: Ibbcb23fc3a1d4b89b2cae49fb56901b91be2b3a1
2022-02-11 19:58:36 -06:00
jenkins-bot 924ead5650 Merge "Improve DiscussionTools a/b test bucket logging" 2022-02-12 01:23:57 +00:00
jenkins-bot 6df803a821 Merge "Introduce VisualEditorBeforeEditorHook" 2022-02-12 00:54:15 +00:00
Ed Sanders 38bdb0f87a Smooth scroll the heading to the right place while target is loading
This avoids a sudden scroll jump when the editor finally loads.

Bug: T299773
Change-Id: Ia2d56f7898d8e4c886297807954604ad5a8e8c38
2022-02-11 23:24:00 +00:00
David Lynch 5ccf0324f0 Improve DiscussionTools a/b test bucket logging
Make sure it works on pages which don't trigger DT, such as full-page
wikitext editing.

Bug: T301497
Change-Id: Id3d46eef319f278ee71fbbedbddd16d5ffd540d8
2022-02-11 15:58:25 -06:00
Translation updater bot 7bde7d1712 Localisation updates from https://translatewiki.net.
Change-Id: I1abe1b21247d82264c4dc2f58265b50cddb930df
2022-02-11 08:42:37 +01:00
Ed Sanders fb8815f658 Fix some behaviour when user aborts VE loading with escape
* Pass 'noPrompt' to #tryTeardown
* #loadFail gets triggered by the data promise being aborted,
  so if 'activating' has been cleared at this point, don't
  prompt about there being load error.
* Retry/cancel dialog assumed you were coming from a wikitext
  editor. Rewrite the logic to handle teardown the target if
  the user is coming from read mode.

Change-Id: If9e5d1fbf00f8359f4d06fe7fc3064cc7e349bc9
2022-02-11 00:15:35 +01:00
Translation updater bot b37d95244b Localisation updates from https://translatewiki.net.
Change-Id: If0e230f40c97fc4d61481b99ec1f549d970027b8
2022-02-10 08:42:22 +01:00
jenkins-bot 0ab24602b6 Merge "Modernize some warnings about account not being registered" 2022-02-09 22:05:07 +00:00
Bartosz Dziewoński 8c0a6bce38 Modernize some warnings about account not being registered
Matching MediaWiki change I7a7046bf9b9765cbb82ec3caa1530de7f05e0da4.

Change-Id: I5b2587f00d00622a5e431d0fd69bdf8979b7bc53
2022-02-09 21:26:18 +01:00
jenkins-bot c3bd77c00f Merge "build: Updating npm dependencies" 2022-02-09 15:38:37 +00:00
jenkins-bot 962d95a51f Merge "Add ctrl/cmd backspace hotkey to delete part" 2022-02-09 12:04:25 +00:00
jenkins-bot d21783c363 Merge "Disable hide unused widget when all are selected" 2022-02-09 11:47:47 +00:00
WMDE-Fisch ce230afa09 Disable hide unused widget when all are selected
I bit more logic was needed to make sure, the state of the widget
resets when all unused fields are added during search.

Bug: T299811
Change-Id: I3006c233fda5490e323bc3a3e631bf0c1199bda3
2022-02-09 09:23:14 +00:00
libraryupgrader aa28b52dc9 build: Updating npm dependencies
* eslint-config-wikimedia: 0.21.0 → 0.22.1
* ansi-regex: 5.0.1 → 5.0.1
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* meow: 3.7.0 → 3.7.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v
* string-width: 4.2.3 → 4.2.3
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* strip-ansi: 6.0.1 → 6.0.1
  * https://github.com/advisories/GHSA-93q8-gq69-wqmw
* trim-newlines: 1.0.0 → 1.0.0
  * https://github.com/advisories/GHSA-7p7h-4mm5-852v

Change-Id: Iad400485f197940efd00dfabaddcae805365d116
2022-02-09 07:52:22 +00:00
Translation updater bot cee6e45730 Localisation updates from https://translatewiki.net.
Change-Id: Idaed10586f81902882d6a13dd344c432a4af67bc
2022-02-09 08:13:20 +01:00
jenkins-bot 25b97b933e Merge "ApiParsoidTrait: Make $title optional as it is not required when $oldid set" 2022-02-08 18:22:29 +00:00
WMDE-Fisch 4b2931276c Add ctrl/cmd backspace hotkey to delete part
Bug: T300971
Change-Id: Ie8752d632fba6a15cbf45176b71b3c77a7171360
2022-02-08 16:17:12 +00:00
WMDE-Fisch 9e5db239af Add hints for translators when the term 'field' is used
Bug: T300641
Change-Id: I05aef0cbbefb6a8d6899b5bff36566028e822259
2022-02-08 16:15:39 +00:00
jenkins-bot 7d297a20e9 Merge "Wire move/delete hotkeys to button functionallity" 2022-02-08 16:09:22 +00:00
jenkins-bot 5634e5e378 Merge "Hide unused paramters by default on multipart" 2022-02-08 15:58:16 +00:00
Ed Sanders ef29801474 ApiParsoidTrait: Make $title optional as it is not required when $oldid set
Change-Id: I307b649bf69e72ee5ca58c394af40e31c860d463
2022-02-08 15:09:28 +00:00
WMDE-Fisch b35ea59de5 Hide unused paramters by default on multipart
Covers the base functionality to hide the parameters. Performance
optimizations could be done in a follow up.

Bug: T300640
Change-Id: Ia99b5da392273f1445e475a0720a656460612dcf
2022-02-08 15:56:40 +01:00
WMDE-Fisch ef87088198 Wire move/delete hotkeys to button functionallity
The behavior is now consistant with what would happen when the
buttons are triggered.

Instead of emitting a button click I directly wired the methods
that will by triggerd by the click. This might make it easier to
remove the old sidbar later.

To avoid movement when the buttons should be disabled, an
additional check was added to the onMove method. It's not identical
to the more complex check in the outlineControlsWidget, but should
be enough for our use case. The onDelete method already just does
nothing if nothing is selected.

Bug: T300971
Change-Id: I8a278c9657c91fd648944b5a8c1204c9fff75b7e
2022-02-08 15:41:01 +01:00
Translation updater bot 99878d3634 Localisation updates from https://translatewiki.net.
Change-Id: I42bb2ccf22d9fe6e1ca587593fda2c9454a420b0
2022-02-08 08:07:16 +00:00
jenkins-bot 098791f6c7 Merge "Add vector-body class to diff/previews" 2022-02-07 23:38:15 +00:00
Translation updater bot 05c4329055 Localisation updates from https://translatewiki.net.
Change-Id: Ibc3fbad894f18d0ea73a220951ff43374b38f10d
2022-02-07 08:23:12 +01:00
jenkins-bot 934af1d42d Merge "ApiParsoidTrait: Add "@return never" for Phan" 2022-02-05 23:43:24 +00:00
jenkins-bot 3355918a30 Merge "Remove redundant Phan annotations" 2022-02-05 23:41:55 +00:00
Ed Sanders 5739da585a Add vector-body class to diff/previews
Bug: T287733
Change-Id: I6a4befb2a29489c767df5896a86ef6a607938685
2022-02-05 22:51:05 +00:00
Bartosz Dziewoński 72c68e9e65 Remove redundant Phan annotations
Change-Id: Ic87fcc132b310191b086ccf7facfdf262a544eb9
2022-02-05 16:55:42 +01:00
Bartosz Dziewoński 9e22d21c8e ApiParsoidTrait: Add "@return never" for Phan
Like in MediaWiki core in I895f70e82b3053a46cd44135b15437e6f82a07b2.

Change-Id: I3cc8f887534897153fdefb78a7f28de42ffdf217
2022-02-05 16:49:40 +01:00
jenkins-bot f4824633bd Merge "selenium: Refactor WebdriverIO tests from sync to async mode" 2022-02-04 17:52:51 +00:00
Translation updater bot a839e3c3b1 Localisation updates from https://translatewiki.net.
Change-Id: Ic40782ee2e5d237e7b396927df55f4e274dc9040
2022-02-04 08:22:44 +01:00
Translation updater bot 29f95e78ef Localisation updates from https://translatewiki.net.
Change-Id: I49ff4f0b18621039883f73bb64edcce3a7e7af71
2022-02-03 08:44:49 +01:00
osamaahmed17 40c5c4fe9e selenium: Refactor WebdriverIO tests from sync to async mode
WebdriverIO has dropped support of sync mode, hence changed to async.

Update npm packages: @wdio/*, wdio-mediawiki and webdriverio
because async mode needs at least webdriverio v7.9.

Remove npm package: @wdio/sync.

Bug: T299756
Change-Id: I4a09ccddd8049f84232b035b664b42a4e98d7ff0
2022-02-03 10:41:35 +11:00