Commit graph

18345 commits

Author SHA1 Message Date
jenkins-bot d4a25fdbe7 Merge "Use a fullscreen help dialog for templates on mobile" 2021-11-12 16:25:32 +00:00
Translation updater bot fba26d7305 Localisation updates from https://translatewiki.net.
Change-Id: I601d8229d21592c214e74e3af75f121c43f50615
2021-11-12 08:29:57 +01:00
Translation updater bot d57b3ad10d Localisation updates from https://translatewiki.net.
Change-Id: I689a7432ef84b9801092c48d551b1172df1e3699
2021-11-11 10:03:12 +01:00
Ed Sanders 33840e88ee build: Update eslint-config-wikimedia to 0.21.0
Change-Id: I19465a5ab3bf71cd97967fd1fac41c645f05a419
2021-11-10 14:52:56 -05:00
jenkins-bot 4cafe5105e Merge "Implement floating help dialog for templates" 2021-11-10 17:05:14 +00:00
Andrew Kostka da2df5a118 Use a fullscreen help dialog for templates on mobile
Bug: T294839
Change-Id: I1effb6ea70bcf5e9ce4e84e65431765d0d2f8125
2021-11-10 15:33:25 +01:00
jenkins-bot 54ca8bd99f Merge "Update VE core submodule to master (d29db14ee)" 2021-11-09 22:08:50 +00:00
Željko Filipin 0593278d05 selenium: The first test
The first test just opens the page for editing and checks if it opened.

Bug: T284165
Change-Id: Ifffaf3e5ab14811605d96fcdcfdc1f773880e52c
2021-11-09 16:11:22 +01:00
jenkins-bot d5ac4f4900 Merge "Localisation updates from https://translatewiki.net." 2021-11-09 14:28:25 +00:00
Andrew Kostka 72641151e4 Implement floating help dialog for templates
Bug: T294839
Change-Id: Id224b61bd0cd57f5e970ab62db2d82dab1db9252
2021-11-09 15:28:23 +01:00
Translation updater bot 8c1715713a Localisation updates from https://translatewiki.net.
Change-Id: Ifc15cbbc0439b407a8443fb1744c15ce7e7dc032
2021-11-09 07:30:03 +01:00
Ed Sanders 36eacb1095 assert.ok -> assert.true
Change-Id: I9987ae0cbe275bf492dcdef405454537119765ea
2021-11-09 00:30:20 +00:00
Bartosz Dziewoński b3925baed6 Update VE core submodule to master (d29db14ee)
New changes:
bde209a1c Add simple equality check shortcut to compareElementsUnannotated
79954cb58 Localisation updates from https://translatewiki.net.
2c84478ba Use null for deliberately empty values instead of undefined
18929710e assert.ok -> assert.true
d29db14ee ElementLinearData: Fix instance of data being modified in place

Change-Id: Ia307a129cc7725b2f5bfa168c48934f6f2aa1e67
2021-11-08 23:56:34 +01:00
Translation updater bot e9fd33f444 Localisation updates from https://translatewiki.net.
Change-Id: I1d2821d70762568cb906d26371dfe5193cf03def
2021-11-08 08:17:42 +01:00
WMDE-Fisch 3e28977087 Remove local aria-multiselectable
Added to OOUI v0.42.1 see I717ff53e18e95c72ace1c46b6236cfecb5cd8217

Bug: T291284
Change-Id: I45965181f22f9c5845f6dd44ab75e95305a43dce
2021-11-05 09:10:21 +01:00
Translation updater bot 4dddd70b5b Localisation updates from https://translatewiki.net.
Change-Id: I53a393fb92ce99ebcbd64375257d7a826d141503
2021-11-05 08:17:40 +01:00
jenkins-bot c93638db36 Merge "log restbase response body as attribute of response object" 2021-11-04 23:44:36 +00:00
Bartosz Dziewoński 39b6a8c521 Update VE core submodule to master (86aa5f8f8)
New changes:
f19ca060c Localisation updates from https://translatewiki.net.
0e82fee96 eslint: Fix errors from upcoming eslint-config-wikimedia
86aa5f8f8 Update OOUI to v0.42.1

Change-Id: I31aecaa3002c8dedc1dc787bd71d2e6781e1ecf1
2021-11-04 22:51:48 +01:00
Cole White 8b5bc61f43 log restbase response body as attribute of response object
Eliminates a source of log indexing failures.

Bug: T239458
Change-Id: I4f1cc06cdbd7e7ce02575b755aff6e9f7f9a8767
2021-11-04 15:27:07 -06:00
jenkins-bot f2ac725002 Merge "Update the shortcut for adding a template in the template dialog" 2021-11-04 15:12:35 +00:00
Translation updater bot 4877344048 Localisation updates from https://translatewiki.net.
Change-Id: I8f173862ffc847c3883d756461c6f71afa3b1333
2021-11-04 10:08:28 +01:00
Bartosz Dziewoński f5f26d848d ArticleTargetSaver: ve.init may be undefined
Bug: T294981
Change-Id: Ibd1cf9db9ebb58e7b7721e35991dd4027506c0dd
2021-11-03 22:12:33 +01:00
Andrew Kostka 7f3c24b48e Update the shortcut for adding a template in the template dialog
Bug: T294905
Change-Id: I980b72c98835865c065163fa17bfcc3b9434a80b
2021-11-03 15:40:16 +01:00
Translation updater bot 98c19c4a23 Localisation updates from https://translatewiki.net.
Change-Id: I8d58d90d344aca367b249764250f277d71bab7cb
2021-11-03 08:21:33 +01:00
jenkins-bot 3d3369298a Merge "Move id creation into AriaDescribe mixin" 2021-11-02 22:24:09 +00:00
vladshapik f17e84b331 Avoid using User::isBlockedFrom()
Replace User::isBlockedFrom with PermissionManager::isBlockedFrom since this method will be hard-deprecated.

Bug: T294823
Change-Id: Iea308ce73e4e91b21f55b60e0b3251d93ba18d7e
2021-11-02 13:13:12 +02:00
Thiemo Kreuz 56fb18243c Move id creation into AriaDescribe mixin
Change-Id: Ifef4f3c0fee13a241488f473b561ced7b327fd73
2021-11-02 09:44:02 +00:00
Translation updater bot 803641b05e Localisation updates from https://translatewiki.net.
Change-Id: I621e00525cf65ab1013c7fbe423dd1f6cccc46af
2021-11-02 08:07:43 +01:00
jenkins-bot f223046fc8 Merge "Introducing a mixin for ARIA descriptions on parameter selection" 2021-11-01 15:56:51 +00:00
WMDE-Fisch f9fda0594f Introducing a mixin for ARIA descriptions on parameter selection
Allows setting aria labels and descriptions on elements in a
convinient way. I did not use the the .mixin. convention here for
because there's already another mixin in that folder that's also
not having .mixin. as part of its name. And then there's also no
no need to open up that extra namespace here.

If we move this upstream at some point this can be changed though.

Bug: T291284
Change-Id: I1b3d40400d539f851f13719e16ced200968a7f92
2021-11-01 13:20:00 +01:00
Translation updater bot be30ca5ffd Localisation updates from https://translatewiki.net.
Change-Id: I59581127d4b7b586ab6a25b8e38a1a5ca96c844b
2021-11-01 09:34:52 +01:00
jenkins-bot b5a6e2e32b Merge "Support both DELETE and DEL when using template shortcuts on MacOS" 2021-10-29 16:10:37 +00:00
jenkins-bot c27c094cff Merge "Exclusively use CMD instead of CTRL for shortcuts on MacOS" 2021-10-29 16:10:34 +00:00
jenkins-bot f780c75b1f Merge "Add ARIA descriptions to sidebar widgets" 2021-10-29 10:37:55 +00:00
WMDE-Fisch dab5b5daae Add ARIA descriptions to sidebar widgets
When changing the source in the described-by attributes the screen
reader will read the text of the new source when the status changes.

Just changing the text within the elements holding the descriptions
does not work.

Bug: T291284
Change-Id: I31cc3061cf6c1f699babe41e99e0711f0eb03646
2021-10-29 12:07:53 +02:00
WMDE-Fisch 3e23d78d32 Hide more button on parameter descriptions for screen readers
Screen readers will read the collapsed content despite the fact that
it is not visible due to the way it is hidden with CSS. The more button
makes no sense for these users and is probably more confusing than
helpfull.

Bug: T291277
Change-Id: I71888d8b9565d5ee85c5e7a48965e9e9a76eb984
2021-10-29 08:48:32 +00:00
Translation updater bot 1a05bc2a73 Localisation updates from https://translatewiki.net.
Change-Id: I6c506371e0d864b1f4f14ef91edc0bf46fa6b38c
2021-10-29 08:22:35 +02:00
jenkins-bot 4cfe4b288a Merge "Update VE core submodule to master (2cd3eb52d)" 2021-10-28 21:05:38 +00:00
Bartosz Dziewoński c0fe5f3918 Update VE core submodule to master (2cd3eb52d)
New changes:
e8d275d8c Localisation updates from https://translatewiki.net.
ad26c337b Localisation updates from https://translatewiki.net.
41cde9de6 Visual diff: Handle null attributes in describeChanges
cdfeef319 Follow-up I61b477d1: Use setTimeout instead of afterLoopOne

Bug: T294394
Change-Id: I6018f183034de362291314992cb23410b723961e
2021-10-28 22:43:09 +02:00
David Lynch 03264d55a5 Pass editingSessionId through to API save requests
Bug: T286076
Change-Id: Iaec4fa50affddf01462156f11236c1210f76cc91
2021-10-28 21:17:55 +02:00
jenkins-bot c26f521cdb Merge "Set selected status to sidebar elements" 2021-10-28 12:20:39 +00:00
WMDE-Fisch ef57268b2e Set selected status to sidebar elements
ARIA-selected only works on specific elements/roles. I tried several
combinations here, the most fitting seemed to be the option role, but
that role did not work very well in FF with NVDA. It also should only
be used as direct child to a listbox e.g. with several children.

The next role that's working with ARIA-selected that seemed fitting
is the gridcell. It's still a bit hacky but works well in IE and FF
with NVDA. I suspect that that's pretty good coverage already then.

Bug: T291284
Change-Id: I85c865b0ab12d3923e472e5f36b5c07b7c722180
2021-10-28 12:40:50 +02:00
Andrew Kostka 0475812a20 Support both DELETE and DEL when using template shortcuts on MacOS
The following keyboard combinations are now supported on MacOS:

1) CMD + DELETE
2) CMD + DEL
3) CMD + FN + DELETE

(1) for keyboards without a DEL key use DELETE/BACKSPACE
(2) for keyboards with a DEL key
(3) FN + DELETE is a built-in an alias for DEL

Bug: T294519
Change-Id: I896837954b2f0b36a25484080e57d929a5abf774
2021-10-28 12:18:47 +02:00
Andrew Kostka 80fff73688 Exclusively use CMD instead of CTRL for shortcuts on MacOS
Bug: T294519
Change-Id: I8bd803b4a81ed5195ff0bb1b99b14f764d588eca
2021-10-28 11:53:38 +02:00
jenkins-bot c5792d95af Merge "Still hide mode button unless in small screen mode" 2021-10-28 09:42:06 +00:00
jenkins-bot c15baf9924 Merge "Show the "other actions" toolbar when unknown buttons are available" 2021-10-28 09:42:04 +00:00
Adam Wight 1e82a4ce78 Still hide mode button unless in small screen mode
Bug: T294351
Change-Id: Iebd9cbc5d48711c2e85cab927d4515e6fe0a7d03
2021-10-28 10:42:44 +02:00
Translation updater bot a915e046ef Localisation updates from https://translatewiki.net.
Change-Id: I18814b8ee9f48df72e1751257733e9fbc69e4f6e
2021-10-28 08:29:20 +02:00
Adam Wight b3e5478221 Show the "other actions" toolbar when unknown buttons are available
For example, the Citoid extension adds a "change reference type"
button which should be visible when editing a citation template.

TODO: Decide whether we want to hide the "hide options" button in
this case.  This should be handled in a separate patch and possibly
in a follow-up phase, it requires deeper changes to the logic.

Bug: T294351
Change-Id: I1c6c322fe48044d7e726bf20ba7cd2eda422cd8b
2021-10-27 13:10:23 +02:00
Translation updater bot 939548c812 Localisation updates from https://translatewiki.net.
Change-Id: I9f2cedaadf0eb460114132bae18a364dcd711864
2021-10-27 08:22:58 +02:00