Commit graph

14616 commits

Author SHA1 Message Date
jenkins-bot 4e17f2f131 Merge "Follow-up Ifdc951f: Don't use getLocalApi when VE not available" 2018-06-10 22:39:29 +00:00
jenkins-bot 7890f70d76 Merge "Minor code style fix (move semi colon)" 2018-06-10 22:38:18 +00:00
jenkins-bot 17d013f520 Merge "Never store ve.debounce in prototype" 2018-06-10 22:36:23 +00:00
Ed Sanders 6459de6978 Move module pre-loading from DAT.init to ArticleTarget
This makes this feature available on Mobile as well.

Change-Id: I26a2af63b3665f5563f8562f1a8e94287cad439f
2018-06-10 16:07:44 +01:00
Ed Sanders 6cc83781a3 Never store ve.debounce in prototype
This essentially creates a static debouncer, so if you have
multiple instances calling that method at the same time, only
one of them will fire.

Change-Id: I4c257b557e87f5638b459811655a14b8625de2e3
2018-06-10 16:00:37 +01:00
Ed Sanders 000559c790 Minor code style fix (move semi colon)
Change-Id: I00f635203c4fc58454aefa8840f0b204e1480c53
2018-06-10 15:59:26 +01:00
Ed Sanders e88cd81f94 Follow-up Ifdc951f: Don't use getLocalApi when VE not available
These popups on used on the 2010 wikitext editor as well, so
we can't use ve.init.target.

Change-Id: I7d4e97566dde10146893089427f95c0b598ef4bc
2018-06-10 14:14:23 +01:00
James D. Forrester b7594c7a32 Update VE core submodule to master (ae0ff21b9)
New changes:
d1b8a4141 Simplify conversion of images
e614bc70d Update OOUI to v0.27.3
b88f42a59 Refactor document drag/drop to use copy/paste methods
89220c69e Change image diff tests to use 'alt' instead of 'src'
bbb82023d deepEqual->strictEqual in modelRegistry tests
b6524e7a2 ModelRegistry: Prevent double registration

Change-Id: I1d7304091be256323f081810fe4e13cf8495dc0e
2018-06-08 08:20:11 -07:00
Bartosz Dziewoński 6840ac4dd1 ve.ui.MWSaveDialog: Remove unnecessary margin after last checkbox
Patch proposed on T196375 by Jack_who_built_the_house.

Bug: T196375
Change-Id: I30548650eab3d14e7c0de29c954ededcfa44648a
2018-06-08 09:57:01 +00:00
jenkins-bot c04e934361 Merge "Simplify conversion of images" 2018-06-07 20:51:51 +00:00
James D. Forrester 84eab48c68 Update VE core submodule to master (3cb400800)
New changes:
24e35e428 Factor out synchronous part of updateInvisibleIcon
7be1fc898 FocusableNode: Move getModel teardown check to updateInvisibleIconSync
6fe97c9f1 Performance improvements to compareElementsUnannotated
dfa42c223 Demos: Use SVG with well defined natural size
c2886b57b eslint: Enable qunit/no-assert-equal,no-early-return,no-negated-ok and enforce
4ca5a4088 eslint: Move qunit/resolve-async exceptions inline
eda91bd38 eslint: Move qunit env flag to test config
ce2983e52 Update OOUI to v0.27.2
e333fe327 Localisation updates from https://translatewiki.net.
3cb400800 ce.Surface: afterPaste should always remove ve-attributes

Bug: T196254
Bug: T196380
Bug: T196479
Change-Id: Ie7ce1fefdcede8eb61b722d8308ec9ee9b3bd1e3
2018-06-07 09:18:55 -07:00
jenkins-bot 1dc8d5db51 Merge "Add preview mode converter tests" 2018-06-06 21:28:19 +00:00
jenkins-bot 5e45047fe0 Merge "Fix parsing of external links, now Parsoid adds 'external' classes" 2018-06-06 21:28:10 +00:00
Translation updater bot a070e3ab3a Localisation updates from https://translatewiki.net.
Change-Id: I0f32f1f15372b041c161d7f69a0866b957f3e81b
2018-06-06 23:06:29 +02:00
jenkins-bot ef0f1db361 Merge "eslint: Move qunit env flag to test config" 2018-06-05 21:11:49 +00:00
L10n-bot a67813d8e5 Merge "Localisation updates from https://translatewiki.net." 2018-06-05 20:19:00 +00:00
Translation updater bot ed65185de2 Localisation updates from https://translatewiki.net.
Change-Id: I28b055d7d6180b6e815b85557966719886050636
2018-06-05 22:17:08 +02:00
Ed Sanders 7dbc4c7140 eslint: Move qunit env flag to test config
Change-Id: I290c436b25e306a3657324304ded08011ffcea7a
2018-06-05 21:12:56 +01:00
jenkins-bot cb62540fac Merge "eslint: Enable qunit/no-assert-equal,no-early-return,no-negated-ok" 2018-06-05 20:11:46 +00:00
Ed Sanders b668286e9b eslint: Enable qunit/no-assert-equal,no-early-return,no-negated-ok
Change-Id: I6a202a496ba9359c63febf623ef8b4dd3caa47dd
2018-06-05 20:41:39 +01:00
Ed Sanders dee50b778c MWTransclusionNode: Remove old createInvisibleIcon override
Bug: T196479
Change-Id: I99aab2e0eee3274305a6877263414ce21049fa5b
2018-06-05 18:50:14 +01:00
Ed Sanders b79c98f1e3 Simplify conversion of images
Assume that images provided by Parsoid will adhere to the DOMspec.

Change-Id: I52eb4f27e6b1e1cd092133c3e27e42021ae83783
2018-06-05 13:05:40 +01:00
Translation updater bot be1c31d988 Localisation updates from https://translatewiki.net.
Change-Id: Icbf7dc0eff8cb17579a06d162476bbabbc990fe3
2018-06-04 22:44:51 +02:00
Ed Sanders 98ec3947a9 Add preview mode converter tests
Change-Id: I58a2c9a9e8fd0bf8254819b960c5a5ad8190f643
Depends-On: I3f1a4772cbf67091b5fd52bab610390ebd9b16ef
2018-06-04 19:00:34 +00:00
Ed Sanders bb6cd33821 VisualDiff: Don't compare images with different src's
Bug: T196343
Change-Id: I99ddce806e044ca427bf01b41d164c89dd2e15fd
2018-06-04 18:49:18 +01:00
Ed Sanders a7049dacea Update language variant node to use new invisible icon API
Bug: T195887
Depends-On: I4eab7b9edf04454ef1a62535656b179480c3054b
Change-Id: I655757b13514e8ff89c312dcc2e1147d188a2718
2018-06-04 17:34:22 +00:00
James D. Forrester b998e3cae3 Update VE core submodule to master (aca98533e)
New changes:
d62da204c Fix documentation in dm.Surface, remove duplicate dm.Selection.equals
b2ee82d06 Bypass expensive hasRendering calculation for CommentNodes
522959e5c ve.ce.AlienNode: Fix hover highlight opacity in IE/Edge
06e67e2a1 ve.ce.FocusableNode: Remove "ve-ce-focusableNode-highlight-relocatable-marker"
d38b994d9 Localisation updates from https://translatewiki.net.
2056626bc Remove unused & untested HashValueStore.filter
49a8fbae4 Upstream comment node's invisble icon with label into focusable node

Bug: T195887
Change-Id: Id2da1f2da4e5e32acb3d604307d0f84f6a82bf39
2018-06-04 09:45:04 -07:00
jenkins-bot 6594055882 Merge "Paste conversion dialog shouldn't be escapable" 2018-06-04 16:44:39 +00:00
David Lynch d3fd979d3b Paste conversion dialog shouldn't be escapable
It doesn't have a "cancel and do nothing" route to fall back on, so pressing
escape does the non-progressive action, which is to paste-as-wikitext rather
than paste-as-plaintext. Neither of these is really an intuitive outcome.

Change-Id: I786b6fc87e3cdf3bb50898a070a15a353a242848
2018-06-04 11:16:19 -05:00
Santhosh Thottingal b049a82e8d
ApiResponseCache: Add a check for data.query before accessing redirects
Follow-up: If4f8c9b6719c123b31d852eb71f06a79cc0f7917
Change-Id: I5f1814f341ce401fcb3926487a2cea276698bca0
2018-06-04 13:50:27 +05:30
Translation updater bot a93d1e6102 Localisation updates from https://translatewiki.net.
Change-Id: I48d83893b5867283ea2835a31f879916f7055665
2018-06-03 22:36:44 +02:00
Translation updater bot 6883aaa323 Localisation updates from https://translatewiki.net.
Change-Id: I6163a444ab187b39bb56fdf3ee84d732dd718790
2018-06-02 22:41:45 +02:00
Translation updater bot c3f567ff02 Localisation updates from https://translatewiki.net.
Change-Id: I1eed9e109e011426386fb251f1a91c849518fb6d
2018-06-01 22:27:51 +02:00
Ed Sanders cb36c6ded3 Fix parsing of external links, now Parsoid adds 'external' classes
Bug: T196025
Bug: T188656
Change-Id: I89b8ba378108bde6c8db0144ed306cbc8471111b
2018-06-01 08:47:46 +00:00
jenkins-bot 22d1cfeecb Merge "Update VE core submodule to master (6847cfba6)" 2018-06-01 08:37:26 +00:00
Translation updater bot 15d048f9a3 Localisation updates from https://translatewiki.net.
Change-Id: I4edd4509605e81cbb80fa3580eead7d62432f9fd
2018-05-31 22:28:48 +02:00
Timo Tijhof 21f526bffe mw.trackSubscriber: Remove action.init.timing value
In Schema:Edit, all action timing durations (ready, loaded, saveAttempt etc.)
are defined as "time since the editor was initialised", which is internally
stored as the timestamp for the "init" action.

The 'init' action itself does not have a timing duratation, but the Edit schema
has a special case for it, definining it as "time since the page was loaded".

In actually, it isn't actually implemented as "time since the page loaded",
and I suspect that as such, this value is probably not used by EventLogging
consumers of the Edit schema. Or, it might be used, but doesn't represent
what the consumers think it does.

Presently, it uses the init time now() - mediaWikiLoadStart, which basically
means the time between the random point at which MediaWiki core JavaScript
finished executing which is quite variable in practice due to the race between
<script async> and browssing parsing/rendering of HTML. That is by design,
and is also why mediaWikiLoadStart is undocumented and internal, and actually
in the process of being removed.

After many iterations on this patch to try and approximate an alternative to
this undocumented variable, I came up with an alternative approach with DLynch
at the Hackathon, which is to simply not record this one timing value, but
preserve the behaviour of all the other timing values exactly as-is.

That is, keep the behaviour of storing `now()` as "init" when the editor
activates, and keep the behaviour of substracting "init" from all other action
times, but only don't report "init" itself to EventLogging (given its value
would be 0, which isn't useful).

Bug: T160315
Change-Id: I778234efe40dde8ff30333339335be1c3910a4e0
2018-05-31 18:27:12 +00:00
James D. Forrester d7dcf6f681 Update VE core submodule to master (6847cfba6)
New changes:
89c8891eb Update OOUI to v0.27.1
d542afe0f Fix OOUI deprecation warning from tests
962cd9f5c Localisation updates from https://translatewiki.net.
40e8a27b0 Add test coverage for preview mode (optionally)

Change-Id: I6dd76c021ffc4f5b4be9e5e12ddda710b4595c12
2018-05-31 10:10:37 -07:00
jenkins-bot 725adb2ae3 Merge "Disconnect surface model history listener when tearing down" 2018-05-31 00:23:37 +00:00
jenkins-bot 47fab2753b Merge "DesktopArticleTarget: Section-scroll as part of restoring the page" 2018-05-30 22:03:49 +00:00
jenkins-bot c9f3f45b9d Merge "ApiVisualEditor: Defensively check that query prop revisions returns arrays" 2018-05-30 22:03:35 +00:00
jenkins-bot fbdb76fd80 Merge "build: Introduce eslint-plugin-qunit" 2018-05-30 21:01:55 +00:00
Translation updater bot 46c0141eb3 Localisation updates from https://translatewiki.net.
Change-Id: Icc1af8332ff11f77790548d2fd43fb2b7a2d903a
2018-05-30 22:24:54 +02:00
Ed Sanders a7f5a76bca build: Introduce eslint-plugin-qunit
Change-Id: I0a169916eaf260500ca6a172e6fb2b0c61f8d422
2018-05-30 21:04:02 +01:00
jenkins-bot 083d2aa588 Merge "ApiResponseCache: Support redirects data processing" 2018-05-30 16:53:07 +00:00
Translation updater bot b687368264 Localisation updates from https://translatewiki.net.
Change-Id: Ic196eaf34d9e2189cc7b01f75bfbd920df8118be
2018-05-29 22:25:22 +02:00
James D. Forrester 8543cd525d Update VE core submodule to master (73e80ba80)
New changes:
15d2625b4 build: Bump devDependencies to latest
d613f4766 build: Introduce eslint-plugin-qunit
1d675a7b2 build: Enable eslint's qunit/literal-compare-order rule, with an exception
591a22590 build: Enable eslint's qunit/no-ok-equality rule
d89243c16 Move QUnit eslint config to tests/ folder
a67715636 Localisation updates from https://translatewiki.net.
4eb5301a0 Refactor diff ready for de-generalisation
a5e433473 Add expanded=false to FragmentInspector's container
ad4556a5e Rename 'Dialog windows' section to 'Window controls'
f5e9be727 annotationsAtFocus: Replace $.parents with $.closest

Bug: T195843
Bug: T195854
Change-Id: I20d39d0da4f88555bcb2ba5f691c51d22e497070
2018-05-29 08:40:20 -07:00
Translation updater bot d8a5f22e0f Localisation updates from https://translatewiki.net.
Change-Id: Id16069d8537e6fd9452451ba38876638ba51475d
2018-05-28 22:42:48 +02:00
Ed Sanders 4f456b143e Disconnect surface model history listener when tearing down
Bug: T195775
Change-Id: I6f6fe654dc190d7d891d3ac346bf3f4b2f426947
2018-05-28 18:30:07 +00:00
Ed Sanders 9386d54be9 Fix template param diff when value is empty string
Bug: T195764
Change-Id: I0bd5fe71996a2ffeaa201e549f8515439c07996d
2018-05-28 14:56:53 +01:00