Commit graph

10748 commits

Author SHA1 Message Date
Translation updater bot f6d891b216 Localisation updates from https://translatewiki.net.
Change-Id: I7b4a7018ede70f025c9d6969b7fba07794604754
2017-10-10 23:13:47 +02:00
David Lynch 4e938e58c7 init.mw.Target: make getSurfaceConfig aware of modes
ve.init.Target sets up TriggerListeners based on getSurfaceConfig if there's
no Surface instantiated. As such, loading directly in source mode would have
those listeners present and assuming the document is in visual mode. So, if
there's not a Surface already, we'll assume we're going to get one created
with the defaultMode, and set things up expecting that.

Bug: T153959
Change-Id: Ia0afe32e6b63ea0d3418137ca5c8bc32c009ecfa
2017-10-10 15:14:25 -05:00
jenkins-bot 762429e99f Merge "DesktopArticleTarget.init: Load 'mediawiki.action.view.postEdit' via loader" 2017-10-10 05:04:22 +00:00
Translation updater bot bfe3e66c5e Localisation updates from https://translatewiki.net.
Change-Id: Ib298629b582138e653c5e807c09a76339544fb8f
2017-10-09 23:11:04 +02:00
Translation updater bot 1d689c9bd2 Localisation updates from https://translatewiki.net.
Change-Id: Icd5cecac5b2d5c7f21b9f2bd9450f8c5f191cd11
2017-10-06 22:58:01 +02:00
James D. Forrester bd2deb3ac4 DesktopArticleTarget.init: Load 'mediawiki.action.view.postEdit' via loader
Bug: T164148
Change-Id: I537144bfd52ff84499f5d086f5d05efe2ba0493b
2017-10-05 15:54:20 -07:00
Translation updater bot ccac68067f Localisation updates from https://translatewiki.net.
Change-Id: I728c4e56f6e5a91ddca133607a01cfb910e4be61
2017-10-05 22:58:55 +02:00
Ed Sanders 43763f0a75 Target teardown refactor
* Rename 'deactivate' to 'tryDeactivate' as it may prompts
  the user to deactivate.
* Merge 'cancel' and 'teardownSurface' in to 'teardown',
  extending the parent method.
* Rename elementsThatHadOurAccessKey to $saveAccessKeyElements
  and move teardown to parent class where it is setup.
* Move toolbarSaveButton teardown to parent class where it is setup.
* Cleanup changeDocumentTitle

Depends-On: I9d97614695272dca6936ef6f3461178fcf0368a8
Change-Id: Ie998a04c21f6615b4415edf471310db5edca3b5a
2017-10-05 10:26:46 -07:00
jenkins-bot 65ede4fc4f Merge "Use destroy event to teardown new section inputs" 2017-10-05 17:24:57 +00:00
jenkins-bot 5d9c66497a Merge "Use parent #clearSurfaces method to clear surfaces" 2017-10-05 17:22:41 +00:00
jenkins-bot e657612068 Merge "Strip RESTBase IDs from historical diffs" 2017-10-05 16:06:43 +00:00
Ed Sanders 1256b19d72 Use destroy event to teardown new section inputs
Change-Id: I4990a162b62b7195016efba47cc5926b9e3a0f21
2017-10-05 16:20:48 +01:00
Ed Sanders e0f7f30bbd Use parent #clearSurfaces method to clear surfaces
Move mwTocWidget teardown to a destroy event listener.

Change-Id: If96be96aa67da55d3b17dd2565f5e954786ff3ff
2017-10-05 16:03:55 +01:00
Translation updater bot e0d047973a Localisation updates from https://translatewiki.net.
Change-Id: I5762bd8184d2b88c686f8b1c27787a6c279bbd73
2017-10-04 22:59:44 +02:00
jenkins-bot 6e2589d1a6 Merge "Abort loading when 'escape' is pressed" 2017-10-04 15:40:57 +00:00
Ed Sanders 58237588ad Abort loading when 'escape' is pressed
Bug: T117359
Change-Id: I2c60588f14b9f80b18a7ac8da753fee224be35a4
2017-10-04 14:09:19 +01:00
jenkins-bot 28d4ed974f Merge "Remove reference to editfont-default" 2017-10-03 18:48:21 +00:00
Ed Sanders ff896e0be6 Always use trackingName for tracking
Change-Id: Ifc7d3275277628b310f5c017c43a76f5a7c25ea7
2017-10-02 22:20:53 +01:00
James D. Forrester 09cde07c45 DesktopArticleTarget: Retain 'mwTarget' stats tracking object
Bug: T177250
Change-Id: I1584f452e16272886af459bac3e24c4995af2231
2017-10-02 21:03:09 +00:00
jenkins-bot fb4bb65a74 Merge "Allow MediaWiki extensions to use self closing tags" 2017-10-02 18:04:08 +00:00
Ed Sanders cd097bed3d Allow MediaWiki extensions to use self closing tags
Parsoid now supports this by setting body to null.

Change-Id: I24d856f0cffeacb00cb2b757e34315bc02b595d0
2017-10-02 10:52:48 -07:00
jenkins-bot 21bd98df61 Merge "ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission" 2017-10-02 17:44:46 +00:00
jenkins-bot e7ac894a94 Merge "MWExtensionWindow: Always send a string to setValueAndWhitespace" 2017-10-02 17:25:02 +00:00
jenkins-bot 2d2ed0094f Merge "MWAlienExtensionNode: Listen to attribute changes" 2017-10-02 17:22:51 +00:00
Ed Sanders ddc056a40a MWExtensionWindow: Always send a string to setValueAndWhitespace
Bug: T177180
Change-Id: I3a32e1b22e82bc0c182d26a952e7592aafd4b5e4
2017-10-02 16:26:16 +01:00
Ed Sanders 852e1ababe MWAlienExtensionNode: Listen to attribute changes
Also:
* Disconnect change event on this.input, which doesn't
  get destroyed on teardown
* Add padding between attributes and this.input
* Assume the alien extensions can have a rendering when
  their body is empty.

Bug: T177181
Bug: T177183
Change-Id: I2e59f8195b255f33f91901213c92ea14793635b4
2017-10-02 16:22:41 +01:00
Bartosz Dziewoński 2b3998df4b ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission
Bug: T177041
Change-Id: I28a7ec0710595977e5ec889016dd280d60e93034
2017-10-02 17:09:04 +02:00
Translation updater bot e667ebe5cb Localisation updates from https://translatewiki.net.
Change-Id: Ifd08290884dbeed1cc97dd04159d2b6161b31ce5
2017-10-01 22:48:18 +02:00
Translation updater bot 4ca4ddd991 Localisation updates from https://translatewiki.net.
Change-Id: I2ad37bcad504d1c0a6fb94e20fa9dc16f5003f59
2017-09-30 23:02:54 +02:00
jenkins-bot ff7c57489a Merge "Set padded=false for link inspector" 2017-09-29 16:42:29 +00:00
jenkins-bot 8032b97fa9 Merge "Remove upstreamed link inspector page icons" 2017-09-29 16:37:12 +00:00
Ed Sanders 582a3e62fb Remove upstreamed link inspector page icons
Change-Id: I997b299d9a61ec9307025a7f4d106f185283eb40
Depends-On: I297648d14b4a2540a40f3a0b7d22a7905ef7c035
2017-09-29 16:27:50 +00:00
Ed Sanders ef46e45b43 Set padded=false for link inspector
Logically depends on I615b485a272.

Bug: T177080
Change-Id: Ica54238d891fa41eefb0b9216eb4f2190818a502
2017-09-29 16:14:29 +01:00
Željko Filipin fe09c22e33 Delete Ruby Selenium tests
Tests are broken most of the time. Ruby framework will be deprecated next month. Selenium tests
that are needed should be implemented in Node.js.

Bug: T164479
Change-Id: I8ec1d9b19b9538936c508daf2b50249a705b3170
2017-09-29 16:55:12 +02:00
Ed Sanders dc500697e1 Follow-up Ia08dbb44: $attachable -> $bounding
Change-Id: I88101426998c7f11a7dfd3b971a1274e5aad638a
2017-09-28 17:36:37 +01:00
Bartosz Dziewoński 81d567bfdc ve.init.mw.DesktopArticleTarget: Fix the code to reorder tabs
This code is meant to fix up the tabs if wgVisualEditorTabPosition
was changed and we're seeing cached HTML with the tabs in wrong order.
But it seems it has never worked. `$caEdit[ 0 ].nextSibling` is a text
node and obviously not equal to `$caVeEdit[ 0 ]`, and vice versa for
the other case. The logic is actually correct, so let's fix it to skip
over text nodes.

Also, remove a stray 'eslint-enable' comment left over in
a0f934ed26.

Bug: T50017
Change-Id: I23663a9bfcfdbf52918452c878a128e6960b1191
2017-09-28 15:54:55 +02:00
Bartosz Dziewoński a0f934ed26 ve.init.mw.DesktopArticleTarget: Remove hack for reversed tabs in RTL in Vector
Vector no longer does the silly thing where the tabs are reversed in
the HTML in RTL languages, so we must remove our hack to do the same,
since otherwise it reintroduces the issue it was intended to prevent.

This essentially reverts 2efd4f0061.

Bug: T50017
Change-Id: Ibeaa55bc34899bffab849ea8ad8b127fb5184d43
2017-09-28 07:35:18 +02:00
Volker E 4067b05832 Unify monospace font family stack
Bug: T176636
Change-Id: I9ad1a92cef7875371e232c8e4babc842ba711e8c
2017-09-28 00:24:53 +02:00
Translation updater bot db59dc6776 Localisation updates from https://translatewiki.net.
Change-Id: Icc4ce2792ffbfb8f030c9fa162400c31f72dc8dd
2017-09-27 22:44:25 +02:00
Ed Sanders 90a9fdb6aa Ensure mw-notification-area doesn't get disabled
Bug: T176874
Change-Id: I43af13a0fcb5c19fdea53cfaeb941ac100579945
2017-09-27 14:50:59 +01:00
jenkins-bot 2411e7c04e Merge "Replace constructive with progressive UI flag" 2017-09-26 22:04:46 +00:00
Translation updater bot db5a06afd7 Localisation updates from https://translatewiki.net.
Change-Id: I55bcbb4134fd269f45b77115c025aea045e3bff8
2017-09-26 22:54:54 +02:00
James D. Forrester 2c70792c4f Replace constructive with progressive UI flag
Change-Id: Iae36e978978ed6642f44606a934c540cf5f8537f
2017-09-26 15:14:32 -04:00
Ed Sanders 38d716f895 Follow-up Iebd1def1: Revert MWSignatureTool case
The tool checks the page name before the target is initialized.

Change-Id: I02ec528a11cc01b026fb95617388d47323ad96ee
2017-09-26 19:59:56 +01:00
Ed Sanders 1b8f8d8908 Replace wg(Relevant)PageName with target#pageName
The default value of target#pageName is wgRelevantPageName
but other targets my override this, or change it dynamically
(e.g. ContentTranslation).

Also remove duplicate setter of pageName in mw.ArticleTarget,
already set in mw.Target.

Change-Id: Iebd1def1d4142978a673afec584a0b663644d176
2017-09-26 13:22:00 +01:00
Translation updater bot b81a4b0fea Localisation updates from https://translatewiki.net.
Change-Id: Ia27a53fdc504ca1bb3e2bbb3b0bc6e54542344aa
2017-09-25 22:54:09 +02:00
jenkins-bot c54a54d3f9 Merge "Api: Missing preloadparams" 2017-09-25 17:30:41 +00:00
Ed Sanders 842d0bb8ed Set bounding element to full frame for MW images
Logically depends on Iea800132.

Bug: T176646
Change-Id: Ia08dbb4400400990e1e518bc47afd5d60795c736
2017-09-25 17:17:27 +00:00
David Lynch 02c6e9142b Api: Missing preloadparams
* Tiny fix to 33dc60838c for PHP variable name
* Bigger fix to properly pass preloadparams in and split them up

Change-Id: I844db115f2563cb9ee1629c30d5f49d1ce58f5bd
2017-09-25 11:42:09 -05:00
Translation updater bot e13538a8f0 Localisation updates from https://translatewiki.net.
Change-Id: Ic73bdbb6f814da63a38099728cd960e805be4664
2017-09-24 23:06:22 +02:00
Translation updater bot d9de7e3235 Localisation updates from https://translatewiki.net.
Change-Id: I4ce90141a03f0cc736186a8375a21ff22bab349c
2017-09-23 22:58:22 +02:00
Translation updater bot 996e39613b Localisation updates from https://translatewiki.net.
Change-Id: I9496eda9f2f17527f36a8dcb356e1246d1f66b98
2017-09-22 23:29:36 +02:00
Translation updater bot 14ebd22180 Localisation updates from https://translatewiki.net.
Change-Id: Iee95738a77c34850701cc87b345391a73201145c
2017-09-21 22:58:48 +02:00
jenkins-bot f17b099984 Merge "Use findFirstSelectableitem instead of getFirstSelectableItem" 2017-09-21 18:13:09 +00:00
Ed Sanders 9572bbe245 Fix font size in local overlays in monobook
Change-Id: I742c090d64af4e22004e921ab772550474125224
2017-09-21 15:46:26 +01:00
Translation updater bot fa7cbf0849 Localisation updates from https://translatewiki.net.
Change-Id: I41c542b61bc744c201ce582267a8a992fde9c201
2017-09-20 23:09:44 +02:00
jenkins-bot 549290991e Merge "DesktopArticleTarget.init: handle new-section tab when in visual mode" 2017-09-20 17:04:48 +00:00
jenkins-bot e1ae0a91ec Merge "Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label" 2017-09-20 16:20:40 +00:00
David Lynch 325de4b130 DesktopArticleTarget.init: handle new-section tab when in visual mode
Bug: T157755
Change-Id: Ida657edb57c4d3067f17104ff1b74965c8082131
2017-09-20 15:49:21 +00:00
jenkins-bot c1721aabe9 Merge "Wait for tree to finish building before updating caption" 2017-09-20 15:41:33 +00:00
Ed Sanders 14f99e3757 Wait for tree to finish building before updating caption
Bug: T176265
Change-Id: Ib73943beedc6a0166699b33b4d1148d8ba32ad20
2017-09-20 16:00:41 +01:00
Translation updater bot 7a7e57504b Localisation updates from https://translatewiki.net.
Change-Id: Iad8f83651883d387edc898646acf6a1042ca38b9
2017-09-19 23:18:24 +02:00
jenkins-bot 0357252601 Merge "Use figure-inline instead of span for inline media" 2017-09-19 16:11:58 +00:00
jenkins-bot fbdd7c895f Merge "Do not "resolve attributes" in toDomElements() overrides" 2017-09-18 22:27:28 +00:00
jenkins-bot 0246c2a62f Merge "Enable preload in VisualEditor" 2017-09-18 19:59:13 +00:00
David Lynch c440a3576f DesktopArticleTarget: Support preloadtitle in source mode
Can't support it in visual mode, since there's no new-section handling at all.

Bug: T51622
Change-Id: I763d5fff156e9ef3893bd882fab1dc2d47121728
2017-09-18 10:18:37 -05:00
Translation updater bot 228af9d25d Localisation updates from https://translatewiki.net.
Change-Id: I10e3b3c86449102851aec61f7166adfd9432164b
2017-09-17 22:48:16 +02:00
Translation updater bot 76771b4cd0 Localisation updates from https://translatewiki.net.
Change-Id: I1cbc38a425ec200a585dfacb825893c20da5b1e2
2017-09-16 23:06:04 +02:00
David Lynch ea274c94cd Enable preload in VisualEditor
This allows the use of the preload and preloadparams query parameters. They
should behave as they do in the old editor, loading substituted content in
visual and source modes.

Bug: T51622
Change-Id: I522fb5b480d17912f6d6116be6aa043ead855b52
2017-09-15 17:17:51 -05:00
C. Scott Ananian 853ec0bc9c Inspectors for editing LanguageConverter markup
Basic inspectors for editing.  Changing from block to inline, or
adding "hidden" or "describe" flags not supported.

The UI layout for two-way and one-way rules could certainly be improved.

Bug: T49411
Change-Id: I5ce29e4bf47abf509afde0a57f64b5d1189f5185
2017-09-15 09:24:33 -07:00
jenkins-bot 0034fb3c65 Merge "CollabTarget: Disable submit button when input is invalid" 2017-09-15 00:22:12 +00:00
Ed Sanders 35be4f4757 CollabTarget: Disable submit button when input is invalid
Change-Id: Id8b3c098fc2fbec778b0d4cf98fa7cc35202d95b
2017-09-15 00:16:27 +00:00
Translation updater bot 253d0b2e09 Localisation updates from https://translatewiki.net.
Change-Id: Idc7a04710edbde1341c8fd87ab50d74a4ea87dd2
2017-09-14 23:36:51 +02:00
C. Scott Ananian 26df4dca33 Doc update: use the full class name so JSDuck hyperlinks it correctly
Change-Id: I2c6f6a6c5b497767d7f7731c86cc145ed60b1deb
2017-09-14 11:07:07 -04:00
Ed Sanders 405afdce70 Strip RESTBase IDs from historical diffs
Change-Id: I911d529204a97003ed233464709737b018918634
2017-09-14 13:45:10 +01:00
Translation updater bot 9dfe4bbdc7 Localisation updates from https://translatewiki.net.
Change-Id: I2195f7cb1d274f73a32a35237f6e0b9b23e29749
2017-09-13 22:56:59 +02:00
jenkins-bot 1809344c8a Merge "URL decode file names in gallery, as in PHP parser" 2017-09-13 18:00:56 +00:00
jenkins-bot 714f43c8c2 Merge "Fix typos in gallery attribute names" 2017-09-13 17:34:52 +00:00
jenkins-bot 779dcc2164 Merge "ArticleTarget: Make save commands triggerable from anywhere" 2017-09-13 15:40:19 +00:00
jenkins-bot d6fb66e70c Merge "Use lowerCamelCase for javascript var oldId" 2017-09-13 13:45:20 +00:00
jenkins-bot cd6dfaa42b Merge "Remove pageName/revision from ArticleTarget constructor" 2017-09-13 13:45:19 +00:00
jenkins-bot 15ba6dbc53 Merge "Change ArticleTargetLoader#requestPageData API to use options object" 2017-09-13 13:42:10 +00:00
Ed Sanders a6ac6d0cec Fix typos in gallery attribute names
The MW attributes are 'style' and 'class'. The plural
forms are used internally only to avoid JS keywords.

Change-Id: I1b7d14872aab4b6b3882d00165924fd1639e1744
2017-09-13 14:06:44 +01:00
Ed Sanders 280696ad3f URL decode file names in gallery, as in PHP parser
Bug: T175816
Change-Id: I3ec9c1f6db57798cdc1b5a787dd0bd9b4d3beef1
2017-09-13 14:03:20 +01:00
Ed Sanders f9562838bf ArticleTarget: Make save commands triggerable from anywhere
Change-Id: Iea5b2ff1210b0b28a58017f198f55124c9a3348d
2017-09-13 12:00:19 +00:00
Ed Sanders d515d418c1 Use lowerCamelCase for javascript var oldId
Change-Id: Idd04578a0035320f85dc911a2f4ddbc6f378887f
2017-09-13 12:57:37 +01:00
Ed Sanders ebce67b6ab Remove pageName/revision from ArticleTarget constructor
Other page state is read directly, rather than passed in.
If we come up with a use case for passing this in at a later
date we can reconsider the best way to do this.

Change-Id: Iee7e608c969776b89dbb38b3b56a5177e48344af
2017-09-13 12:57:37 +01:00
Ed Sanders 682787f312 Change ArticleTargetLoader#requestPageData API to use options object
Change-Id: I02e6218a8359b1cbc8fed1a34d68206a2a154d46
2017-09-13 12:57:37 +01:00
Translation updater bot c2b8de09a5 Localisation updates from https://translatewiki.net.
Change-Id: Ib39c3b33100062858098f2f803e1fad751f837d2
2017-09-12 22:56:25 +02:00
jenkins-bot 508fdf1543 Merge "Don't require a selection to run any of the save actions" 2017-09-11 15:10:23 +00:00
jenkins-bot 822db7eacf Merge "Add feedback link for visual diff inside save dialog" 2017-09-11 12:01:39 +00:00
Translation updater bot caa7341d49 Localisation updates from https://translatewiki.net.
Change-Id: If867adb27d970653090e741b90ed503f49a13842
2017-09-10 22:50:20 +02:00
Ed Sanders 13ef05b489 Don't require a selection to run any of the save actions
Change-Id: I3a8f7e1e9e3714f226ac240a429a62d011112285
2017-09-10 14:53:14 +01:00
Translation updater bot bf27796935 Localisation updates from https://translatewiki.net.
Change-Id: I09865a7a366e768cdb5ac6dcbcbb7ab15ac67420
2017-09-09 22:53:44 +02:00
Translation updater bot dc2366cbba Localisation updates from https://translatewiki.net.
Change-Id: I768e3e14ff1b0becdba08daa7694b22625792fab
2017-09-09 00:22:20 +02:00
jenkins-bot 2bc46f93d3 Merge "CollabTarget: Minimise dependencies, and make toolbar tweaks" 2017-09-08 15:52:55 +00:00
Ed Sanders e4585d520b CollabTarget: Minimise dependencies, and make toolbar tweaks
Change-Id: I37cccd5760b8e65fc4232ca4572147f3b031255d
2017-09-08 15:46:45 +00:00
Translation updater bot b80952158a Localisation updates from https://translatewiki.net.
Change-Id: I10f4721b977be987129d271ba1534887bcaabd4d
2017-09-07 23:42:28 +02:00
David Lynch 569f917edc MWExtensionWindow: clean up originalMwData on teardown
Not doing this makes adding a new extension node with the exact same content
as a previously-viewed one have the Done button disabled.

Bug: T172586
Change-Id: I39105144e17135044ef644b5464b0fbfdfc019d5
2017-09-07 10:40:36 -05:00
Bartosz Dziewoński 98351fbcf3 Do not "resolve attributes" in toDomElements() overrides
Resolving attributes means turning 'href' and 'src' URLs from possibly
relative to absolute, so that they don't depend on the base URI of the
document.

This is necessary when rendering for clipboard (and in some other
cases), but at the point when toDomElements() is called, the document
these elements are in does not necessary have a sane base URI set,
giving us hrefs pointing to nonexistent pages.

Don't do it here; it will happen later when we know what the right
document (and right base URI) is, e.g. in ve.ce.Surface#onCopy or
ve.ui.PreviewElement#replaceWithModelDom.

Bug: T169675
Bug: T175157
Change-Id: Ie0a5d6e1c57b8efdbbfba0c24f31ca91d156e200
2017-09-07 14:06:24 +02:00