New changes:
99d766aee ve.ce.BranchNode: Force re-applying of selection if tag name changes
d7b6b1650 Unwrap unsupported section tags when pasting
Bug: T243852
Bug: T244109
Change-Id: Id33b4dc4e0dfafcc2414e8b083bc6869964de38f
It turns out anonymous users can't apply change tags, so change
I2c1d0f8d69bc03e5c1877c790247e165f160e966 broke editing for them.
Bug: T242184
Change-Id: I7c27e4d9995428e213a980819810f235fdfe9435
New changes:
fb4f0a83b Completion framework
Local changes to wire in the completion framework
Bug: T232601
Depends-On: If6aee9df67e7a1234d47c0ba0c2f05ef47e5bd51
Change-Id: I075cac9aa195574c3d416a40bbdc5ec2d64424e2
New changes:
07c028575 Require two clicks on link for label editing after closing context item
ff0e814ad update-ooui: Fix link to release notes
0d9bdde76 Update OOUI to v0.36.4
c09049edc Change toolbar border hack to add borders instead of remove them
b888802f5 Rebaser: Bump dependency versions
624ec74b7 Localisation updates from https://translatewiki.net.
Bug: T232003
Bug: T232172
Change-Id: I7a74108c08fced3df33617993e98e39649bb4b41
The message wasn't updated when we changed our minds during the
development of d85d30f9b3. Now the
normal tagging is done in client-side code, so it's effectively
always "suppressed" when calling the API.
Change-Id: Ie75ce31e7c723ff2677e8caa205666f5394405fa
* Changing the 'mode' did not clear the old class, only add a new one.
* Clearing the 'class' or 'style' did not really clear it if the field
was left empty.
Both of these could result in the action not taking effect visually.
* Setting a class unintentionally also removed internal VE classes.
This doesn't seem to have any negative effects at a glance, but it's
probably a bad idea.
Change-Id: I304c222a2c8bc9d35b1cfaee401ab1f815251fde
New changes:
ab2f2ca1a ve.ce.BranchNode: Detach all children first when calling #detach
dae5a8c7e Localisation updates from https://translatewiki.net.
98e69f146 Remove hack to avoid iOS Safari menu bar area tap stealing
Bug: T206278
Bug: T227628
Change-Id: Id9442f433277bb32b7a581286ab3308bb0b16aae
New changes:
c5582eab7 Localisation updates from https://translatewiki.net.
33f0680f2 Always use excludeInsertion when translating table selections
6d9d86720 eslint: Use /mediawiki ruleset
48cf4045e ve.dm.SourceConverter: Add a trailing newline to each full paragraph
Bug: T243606
Bug: T243860
Change-Id: Ib2a2025dea1c393e436c0bad1ad42b6aa8a3717e
In the core MediaWiki editor, the detailed messages about page
protection are only shown when the user is allowed to edit the page;
otherwise, a generic permission error is shown. Do the same here.
Change-Id: Ia0ca52b9bf556354218b2aa91f141b429b0c5880
Explanation of what this code was for: T227628#5339392
As noted on that task, our behavior is actually unintuitive and
distracting, and iOS Safari limitations prevent us from doing it
better.
This reverts commit 600e369347.
Bug: T227628
Change-Id: Id1a5eebd06e4218e3e102165c60791999293d273
When a template does not have user-provided TemplateData documentation,
the TemplateData API falls back to extracting possible parameters from the raw wikitext
to generate an API response with a list of potential parameters. However, it also
sets the "notemplatedata" field in the response, causing the VisualEditor to think
the response contains no useful information and ignore it. This appears to have been
an unintended side-effect of I97a1bfc9f9ead082a673a91b9d2053630a90309c.
This patch ensures that the VisualEditor will correctly consider such responses from
TemplateData by modifying ve.dm.MWTransclusionModel to check if the response contains
a parameter map. Some unit tests were added for the class to verify this behavior.
Bug: T243868
Change-Id: I72005880d9301a53224473900efe2917379e8708
This opens up the API so that other tools can use it without being
forced to tag those edits as being from VE.
Also, document that tags is a working parameter that can be passed
through to the edit API.
Bug: T242184
Change-Id: I2c1d0f8d69bc03e5c1877c790247e165f160e966
Replace Title::userCan with PermissionManager::userCan.
Replace Title::getUserPermissionsErrors with
PermissionManager::getPermissionErrors.
Change-Id: I1afec4ba62185c3cd555a10ae35cef01b7194221
When mw.libs.ve.diffLoader#fetchRevision was calling this method, we
were accidentally making no query at all if RESTBase wasn't in use.
Change-Id: Ia98343aa1ba7f4f3be0c1a8ee5864653c429fb82
In many places we check whether VE is available before doing things
(init.isVisualAvailable). This variable includes checks for whether
the page is wikitext, etc. Now it will also include checking whether
VE is enabled in user preferences.
In almost all places where init.isVisualAvailable is used, we were
already also checking if VE is enabled, so this doesn't affect the
behavior. But notably, we didn't do it when showing the option to
switch to VE in the welcome dialog and in the toolbar, causing T243723.
Changing init.isVisualAvailable this way makes it consistent with
init.isWikitextAvailable, which has always included a checking whether
NWE is enabled in user preferences.
Bug: T243723
Change-Id: Ie174bc3f16bceb29cb155b9223e0acef70167fd6
