Commit graph

6753 commits

Author SHA1 Message Date
Roan Kattouw cebb0ad9da Bring down arrows in CategoryItemWidget back
This escaped the icon -> indicator migration because it was rolling
its own class (!).

Now using IndicatedElement to render the indicator.

Also, cleaned up some incorrectly named CSS classes.

Change-Id: I7f3369f2ffd3c34f0d29c0a235d1a15ddd68d1e3
2014-02-14 16:12:12 -08:00
Roan Kattouw 038fe128fe Clean up onResourceLoaderRegisterModules() to make it more data-driven
Bonus: it's now half the size.

Change-Id: I0946eaa8794b49e44a2791befe024e1bc475c0b8
2014-02-14 15:19:21 -08:00
Moriel Schottlender 21ccb20d3a Only display image info if that exists
When a new search is performed in the MWMediaSearchWidget,
image thumbnail details are extracted from the API's imageinfo.
In some cases, this parameter does not exist. MWMediaResultWidget
relies on that parameter to get image details like 'src' and
width/height. Without it the search fails.

This fix makes sure that the thumbnail result is only displayed
if there are 'imageinfo' details at all. Otherwise, the image
result is ignored.

Bug: 61392
Change-Id: I5261059bb42d3a57441514eafaa0bffa3a3c3ba4
2014-02-14 18:12:26 -05:00
jenkins-bot f22668be67 Merge "Update list of production wikis that should be tested as working" 2014-02-14 20:57:48 +00:00
James D. Forrester 220d19dd7d Update list of production wikis that should be tested as working
I fixed af, am, kaa, ln and szl wikis' Common.js files.

Ptwikiversity's wiki is working fine as far as I can see.

Change-Id: Ia856d0f5be1a7cb988df58e3914116075e9dc98f
2014-02-14 12:30:59 -08:00
Translation updater bot eb8ab705b8 Localisation updates from https://translatewiki.net.
Change-Id: I05f2feefb504d0b7c8ccae577e35b2459ca20272
2014-02-14 20:22:09 +00:00
jenkins-bot 4944dff419 Merge "Let users set #REDIRECT and __STATICREDIRECT__ status" 2014-02-14 03:46:12 +00:00
Translation updater bot 2eeb34d71e Merge "Localisation updates from https://translatewiki.net." 2014-02-13 21:21:43 +00:00
Translation updater bot bb71025d25 Localisation updates from https://translatewiki.net.
Change-Id: If5c1aeea1134b6cebb68b3c93fcf352fa4d40785
2014-02-13 21:20:32 +00:00
Jeff Hall a857e3079c [Browser test] Basic maintenance for headings browser test.
Change-Id: I85003448e41012af833a7b5754179da4a17cf652
2014-02-13 12:57:50 -08:00
Antoine Musso c2e1766fea [Browser test] bump mediawiki_selenium to 0.2.3
mediawiki_selenium 0.2.3 let us specify the destination of screenshots
via SCREENSHOT_FAILURES_PATH env variable.

Change-Id: Ieb6b6803c58760415dc45dc691556be774d4be8f
2014-02-13 15:22:14 +00:00
jenkins-bot 912fda938d Merge "Explain what the number on the edit summary screen means" 2014-02-13 01:09:33 +00:00
jenkins-bot 001d6f1c87 Merge "Update VE core submodule to master (43787a8)" 2014-02-13 00:31:13 +00:00
Juliusz Gonera ae2f5134b2 Make MobileViewTarget scroll to desired section
Implements
https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1626

Also, rename $el to $container so that it matches the docs.

Change-Id: I9f41ec6fb88f6f21e698553216ccf2c3231589c1
2014-02-13 00:22:53 +00:00
Juliusz Gonera a6b149decc Move restoreEditSection() to mw.Target
It can be reused in mw.ViewPageTarget and mw.MobileViewTarget.

Also, check if this.section is undefined instead of not null and update
docs. restoreEditSection() does not accept any arguments.

Change-Id: Ibbcf4cb936a89d3ae77bb61ee97b8ad00a8d8a53
2014-02-13 00:22:33 +00:00
James D. Forrester fee4209d14 Update VE core submodule to master (43787a8)
Also run grunt locally to apply fix.

New changes:
43787a8 Add ve.Scalable to documentation listing

Change-Id: I3915272768d43aa12bdd932e4035d9bad48a09d9
2014-02-12 16:06:51 -08:00
jenkins-bot 813cbd087a Merge "Fix more code that misreads API data with $wgDebugToolbar enabled" 2014-02-12 23:32:36 +00:00
James D. Forrester 5af9f61520 Let users set #REDIRECT and __STATICREDIRECT__ status
Adds setting and unsetting the #REDIRECT status of the page from the page
settings pane of the meta dialog, and toggle whether this is a static
redirect (i.e., it is not automatically changed when its target is moved).

If the page has a redirect set, the meta dialog will be shown on opening
the page so that users can adjust the redirect more swiftly.

Bug: 47328
Bug: 50878
Bug: 57173
Change-Id: Ibd89cf04486799f292b9fd045dae5bc23fcf6fd4
2014-02-12 15:24:12 -08:00
Roan Kattouw d4e8be5f49 A couple more OO.ui.deferMsg() calls
So as to not show message keys as labels :)

Change-Id: I98951d48449ed26cf35c192e871e4bb56fcd4e8b
2014-02-12 15:04:28 -08:00
Moriel Schottlender 02c072a29e Update image size properly when size is default
When an image with default size has a size change, the defaultSize
attribute in the data model must be set to 'false' so the new size
can be updated in parsoid.

Bug: 61270
Change-Id: I84388aec62674a3e3c6773f29bda7156254b5f4a
2014-02-12 17:23:18 -05:00
jenkins-bot 4ac1b42690 Merge "Add tooltips to the drop-down menus explaining what they do" 2014-02-12 22:10:32 +00:00
jenkins-bot 2f9c71edd3 Merge "(Stand back again) Even moar label manias! (label refactoring) + VE core update" 2014-02-12 22:08:27 +00:00
James D. Forrester e4f983356b Add tooltips to the drop-down menus explaining what they do
Needs Ic967b88d55daf48d365487e17f76488b3f02c60f to work properly.

Bug: 59719
Change-Id: I449be926e830de241a870d96bf30c835f60ca77d
2014-02-12 22:07:24 +00:00
Trevor Parscal eca0a08ad9 (Stand back again) Even moar label manias! (label refactoring) + VE core update
Update VE core submodule to master (84ced37) and update calling code
for changes in OOUI.

Depends on Ic967b88d55daf48d365487e17f76488b3f02c60f and Ib599b9bd5028e2df084fcc3da657aeb7f1569d2a

New changes:
94f03c3 Undefined variables first in selectNodes
62b5648 Localisation updates from https://translatewiki.net.
10c5a18 Don't descend into handlesOwnChildren nodes in selectNodes
4ed2432 Update jquery.client to MW's master (45192156d7)
d7e24b8 Localisation updates from https://translatewiki.net.
babb9da Localisation updates from https://translatewiki.net.
4639d18 Localisation updates from https://translatewiki.net.
a561537 Localisation updates from https://translatewiki.net.
8f7053a Localisation updates from https://translatewiki.net.
7112cc2 Update OOjs UI to v0.1.0-pre (a290673bbd)

Change-Id: Ie7d58472619509782f23a7dedc1ec27c3dcc7543
2014-02-12 14:05:23 -08:00
jenkins-bot b9aa9d2f27 Merge "Include edit status in the ve.deactivationComplete event" 2014-02-12 22:02:20 +00:00
jenkins-bot 3e4a67cf12 Merge "Quick fix: image size property update" 2014-02-12 22:00:29 +00:00
Sam Smith 5ebacd389d Include edit status in the ve.deactivationComplete event
Rather than setting the wgPostEdit configuration variable when the
user uses VisualEditor, i.e. communicating via mutable global
state, include whether or not the user edited the page in the
ve.deactivationComplete event.

Bug: 52955
Change-Id: I0f5067550921008f74221d6c92882adfe404b3a5
2014-02-12 13:59:04 -08:00
Moriel Schottlender 80558f85dc Quick fix: image size property update
This is a bit of a workaround for scalable image nodes to update the
current size rather than only the original one. This is done so the
MediaSizeWidget in the media edit dialog is fed the current dimensions
of the image even without the image being saved.

Ideally, the node's 'currentDimensions' property should be constantly
updated to current dimensions. This workaround fixes the given bug, in
which all images show the original wikitext/default size even after
being resized.

Bug: 61052
Change-Id: I902d1f51b1389f2f9b2b5c871b578ee2244a946f
2014-02-12 16:53:13 -05:00
Translation updater bot b2eebc1651 Localisation updates from https://translatewiki.net.
Change-Id: I90b4083cd404bc2fc07bf7a657017873af6adb0f
2014-02-12 21:36:53 +00:00
jenkins-bot 25276e2a5a Merge "Fix margins after they were broken in 9d988924" 2014-02-12 21:12:02 +00:00
jenkins-bot 84f7d9f3b0 Merge "Include fragments in normalizedTitle" 2014-02-12 18:32:08 +00:00
Ed Sanders fb1e746832 Include fragments in normalizedTitle
Otherwise they will compare as identical to non-fragmented links, and
the link inspector won't bother creating a replace transaction.

Bug: 53219
Change-Id: Ifb7c9ffc1e952817df524fcf2418e07299a7bda5
2014-02-12 10:29:45 -08:00
Ed Sanders c95e404a30 Give the document focus on save dialog open to resolve inspectors
Bug: 60837
Change-Id: I624a76f5d09db270e651ac004813acfba249f5f6
2014-02-12 14:14:23 +00:00
James D. Forrester 831141e692 Pass 'pst' as true in parse request for fragments
In our parse request for 'wikitext fragments', used in the transclusion dialog
and extension inspectors, we weren't passing 'pst' as true, so while [[Foo|Bar]]
came back as expected, [[Foo (bar)|]] just came back as plain text, confusing
users.

Bug: 60998
Change-Id: I9931ad8034273ceb19c027d5035c63422cc0e570
2014-02-11 17:06:26 -08:00
Trevor Parscal 79082ebf82 Fix margins after they were broken in 9d988924
Changes in MediaWiki core to the padding of div#content in Vector
(see 9d988924a0350228745375e074420a0e1214f7e3 ) made the toolbar in
VisualEditor's ViewPageTarget integration for Vector render incorrectly.

This adjusts the toolbar margins to match the changes in content padding.

Bug: 61224
Change-Id: Ie6b47f5d1929533669118ba51202c1fccda4a0d6
2014-02-11 23:08:58 +00:00
Jeff Hall 2962ca52b1 [Browser test] Update list of prod wikis to be verified.
Bug: 60797
Change-Id: Ib8fcc9a2a396bac8a2feadb535765b3f672baaa8
2014-02-11 13:20:26 -08:00
Translation updater bot b0d25097b1 Localisation updates from https://translatewiki.net.
Change-Id: I252f8007252639fccfa9735621dbbb9cf9747098
2014-02-11 19:58:41 +00:00
Zeljko Filipin 052b039074 [browser test] Fix failing tests, Watir and page-object API changed
Paired with Chris McMahon and Jeff Hall. Watir and page-object API
changed so it is now required to specify that a frame is an iframe.

Change-Id: Id269ec5bc9dc9c960fdf1f606cbc635a58659fa7
2014-02-11 17:47:17 +01:00
Zeljko Filipin 0b1fcc2231 [browser test] Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem
Bug: 56088
Change-Id: I9fdfcf0f9df8f1bd9df3c358d2e1a7925fa5928d
2014-02-11 15:17:31 +01:00
Krenair 0fea59f171 Fix more code that misreads API data with $wgDebugToolbar enabled
See also I907ef6fc.

Change-Id: Ie44faa15629ebba834cb08ba6247ff3beaabd0ae
2014-02-11 10:28:55 +00:00
Translation updater bot 8dd6239013 Localisation updates from https://translatewiki.net.
Change-Id: Idfc0f88d19d8b0e9e909cfe005ced96d648fb490
2014-02-10 20:50:51 +00:00
Jeff Hall 1a4cb81f6f [Browser test] VisualEditor availability on prod wikis
Ready for code review!

Bug: 60797
Change-Id: I0823e1d569410be5cfa57db77d402bd2c53a5ad8
2014-02-10 19:37:04 +00:00
Moriel Schottlender bee4e5323f Make MWMediaSearchDialog not ignore empty scriptDirUrl
For wikis that are installed in root directory, the API parameter
'scriptDirUrl' is an empty string. This change makes sure it is not
ignored.

Change-Id: Ib58adf76c184c32c0cdbb9dba31db1e4028fa383
2014-02-10 13:42:05 -05:00
Translation updater bot a498cb19f8 Localisation updates from https://translatewiki.net.
Change-Id: I83dbdff7ee6cc180838e62bfa75ae1ef91c9ddf9
2014-02-09 20:18:09 +00:00
Krenair c4903ac684 Explain what the number on the edit summary screen means
Bug: 50902
Change-Id: Ic548e624c1e7375b3151cc9d2f051a5bc665c759
2014-02-09 03:14:09 +00:00
Translation updater bot 783f99b45d Localisation updates from https://translatewiki.net.
Change-Id: I0a400075f800442b17a6cf47ab3a4c1b4819f295
2014-02-08 21:25:33 +00:00
jenkins-bot b12445f81b Merge "Pluralise visualeditor-linkinspector-suggest-(matching|redirect|disambig)-page" 2014-02-08 01:19:54 +00:00
jenkins-bot 6907654de1 Merge "Add image type change to media edit dialog" 2014-02-08 00:45:49 +00:00
Moriel Schottlender 19c584d166 Add image type change to media edit dialog
Adding a type change to the media edit dialog. Also changing SelectWidgets
to ButtonSelectWidgets for consistency.

Bug: 38129
Change-Id: I9c855e6381d970b5f08460822366f6333af24f82
2014-02-07 16:41:50 -08:00
Krenair a7f6b37096 Pluralise visualeditor-linkinspector-suggest-(matching|redirect|disambig)-page
Bug: 61071
Change-Id: Ia9893b8bfb80aa5d8a2bab9ecfe9ca1b6c85afbe
2014-02-08 00:35:30 +00:00