Commit graph

10509 commits

Author SHA1 Message Date
Ed Sanders af25311201 DesktopArticleTarget: Regenerate title in all non-view page scenarios
Bug: T168236
Change-Id: I15f2aeb42b98855512970e2f07396fd7a7c97354
2017-07-01 17:27:07 +00:00
Translation updater bot 90841ca36c Localisation updates from https://translatewiki.net.
Change-Id: I87974d7d4cbd1f83e913953849d7583d5aa60fc0
2017-06-30 23:43:26 +02:00
jenkins-bot 59d74932b0 Merge "Update VE core submodule to master (b528a5321)" 2017-06-29 07:39:01 +00:00
Translation updater bot 1055bebefc Localisation updates from https://translatewiki.net.
Change-Id: I6b7d0c0b29a571c695078b8a00086470751df315
2017-06-28 23:18:21 +02:00
David Lynch 7e678dc81a Update VE core submodule to master (b528a5321)
New changes:
44d2d666c Remove custom icon sizing from block slugs
793d131f9 Ignore covering annotations when looking for plain text pastes
b0025f3ab dm.Document fixupInsertion: check suggestedParents as well
73ce638f1 ve.ui.TableLineContext: Fancier popups
9d54d531e Visual Diff: add internal list diff
4f4e121b5 DiffElement: Add hacky support for template-defined references

Local changes:

dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings

Core VE doesn't have any elements with suggestedParents, so make sure this is
properly tested.

Bug: T153315
Bug: T162819
Bug: T164017
Bug: T165865
Change-Id: I01489226d282abe71020e65358ead24fe07692f7
2017-06-28 20:57:19 +01:00
jenkins-bot 05bc265198 Merge "Keep TOC in correct place in document" 2017-06-28 12:31:33 +00:00
jenkins-bot be808346c9 Merge "Fix TOC meta item detection" 2017-06-28 12:31:32 +00:00
Jforrester 15c6011875 Merge "Ensure MWInlineImages get the ve-ce-leafNode class" 2017-06-27 17:15:44 +00:00
Translation updater bot 42ca5c6d1e Localisation updates from https://translatewiki.net.
Change-Id: Ibb3f2f38abf77af4872012fb32f73f89d94d0c7b
2017-06-26 23:08:30 +02:00
jenkins-bot 7f14f854c4 Merge "ve.init.mw.DesktopArticleTarget: Remove some hacks" 2017-06-26 20:27:09 +00:00
Ed Sanders c4f93b1411 Ensure MWInlineImages get the ve-ce-leafNode class
Without this class, offset calculations fail and model/view
sync can be lost.

Bug: T167009
Change-Id: Ie7b6551ac5a532949c14122b9ee7584a794af0f2
2017-06-26 12:43:23 +00:00
jenkins-bot 0dee2be8d8 Merge "GalleryDialog: Re-order and make margins even" 2017-06-26 10:33:17 +00:00
jenkins-bot b2ae6ddcb8 Merge "GalleryDialog: Downstream fix for DraggableElement padding" 2017-06-26 10:32:07 +00:00
Translation updater bot 6623018b9d Localisation updates from https://translatewiki.net.
Change-Id: I97af6bed779e8435746a70ae0eba850ce4be1d2f
2017-06-25 23:21:18 +02:00
jenkins-bot ba3a5d85bd Merge "Show visual diffs on DiffPage" 2017-06-25 03:30:29 +00:00
jenkins-bot a7fdaffb1b Merge "Clear all diff state when switching editors" 2017-06-24 11:10:32 +00:00
Translation updater bot 2a2b22c829 Localisation updates from https://translatewiki.net.
Change-Id: I157176fbd3f29a718b7b95974216db819c881cb9
2017-06-23 22:54:56 +02:00
Ed Sanders 15af26876a GalleryDialog: Re-order and make margins even
Move image inside filename fieldset, and make
margins between fieldsets and button 1em.

Change-Id: I7f6789043f873f9da4e960c94e22a7ee096a352f
2017-06-23 12:16:35 -07:00
Ed Sanders 9eb637e933 GalleryDialog: Downstream fix for DraggableElement padding
Bug: T168745
Change-Id: I95e6f5cd2126878c4f973285fceece1d5a03c4eb
2017-06-23 11:58:37 -07:00
jenkins-bot 93a44ef399 Merge "MWTransclusionDialog: fix conditions for "show options" button disabling" 2017-06-23 17:21:50 +00:00
Ed Sanders fd1adfb3b5 Keep TOC in correct place in document
Change-Id: I6ad8cd8cbd7ef902204408673eb096b7405abd24
2017-06-22 15:16:15 -07:00
Ed Sanders 1a0fd81f64 Fix TOC meta item detection
Change-Id: Icce35100bbc0bfb5584a676eec0e1774308d0f68
2017-06-22 15:16:14 -07:00
Translation updater bot 48c6e558ea Localisation updates from https://translatewiki.net.
Change-Id: I03013c77fdaffbca561a7e3a3462a5469703b25b
2017-06-22 23:10:14 +02:00
Ed Sanders 11e6e25ac6 Clear all diff state when switching editors
Bug: T168618
Change-Id: I19ff5054b87568546bfe1202d67c5d863e1549be
2017-06-22 10:54:04 -07:00
David Lynch 9ded195f7e MWTransclusionDialog: fix conditions for "show options" button disabling
As I understand it, the button should be enabled whenever there's more than
one option in the sidebar, and disabled otherwise. The previously chosen
conditions weren't perfectly proxying this, and the button would be disabled
whenever editing an already-existing transclusion.

Bug: T167710
Change-Id: Id303b680c072642ae7b66066e28ecc9f1dc90fd7
2017-06-22 17:58:52 +01:00
jenkins-bot e285c8e4cb Merge "Show simple category list in preview" 2017-06-21 20:07:45 +00:00
jenkins-bot 090d26f9c5 Merge "Use Parsoid data for template names rather than detect from wikitext" 2017-06-21 01:15:38 +00:00
jenkins-bot 7cd5a5d61f Merge "Add newline to end of wikitext documents" 2017-06-21 01:10:57 +00:00
Ed Sanders 09519a24d2 Add newline to end of wikitext documents
Bug: T156609
Change-Id: I80d82ad87464b1c6e0344b29123bb96fcc4cffad
2017-06-20 17:51:51 -07:00
jenkins-bot 115f8e7ae5 Merge "Move preview document filtering into MWSaveDialog" 2017-06-21 00:41:26 +00:00
jenkins-bot fc4e836d4b Merge "Fix getWikitextFragment shortcut to return a promise" 2017-06-21 00:40:46 +00:00
Ed Sanders 6f72ef82d9 Show simple category list in preview
Bug: T153534
Change-Id: Ie86abdad76a38855d5ad1a394c0bfb3c8dd5a8c6
2017-06-20 23:50:52 +00:00
Ed Sanders 9dd638a5ab Move preview document filtering into MWSaveDialog
Also:
* Make mw-content-DIR nest inside mw-body-content
* Use ve.filterMetaElements

Change-Id: Ic70c7dff0f74b81f92b8bd48e8092549947990ba
Depends-On: I478fe1f39164b9fd7e71987b818b8f668d1a7020
2017-06-20 23:50:44 +00:00
jenkins-bot 87e1ede04a Merge "Return nothing from styleParsoidElements" 2017-06-20 23:11:46 +00:00
Translation updater bot 8beac44dab Localisation updates from https://translatewiki.net.
Change-Id: Ie734ca2986ad6f5a1da5f349b20756ef283246c3
2017-06-20 23:08:44 +02:00
Ed Sanders e1b4321b5a Return nothing from styleParsoidElements
The method modifies DOM elements in place, and the return
value is never used.

Change-Id: I6254389dbf8daa67795206cb508038b60e1a4761
2017-06-20 21:03:22 +00:00
jenkins-bot c4c4375b7d Merge "Remove old authorListWidget CSS" 2017-06-20 20:13:58 +00:00
Translation updater bot f7586d5f9d Localisation updates from https://translatewiki.net.
Change-Id: I59770f4737b52838d1c5cbdb2e9111986b76fc75
2017-06-19 23:12:02 +02:00
Translation updater bot c5dad8f018 Localisation updates from https://translatewiki.net.
Change-Id: I961fe87e1974dc12df7fd0df33745c95c926a871
2017-06-18 22:55:09 +02:00
Ed Sanders 585cf5f990 Fix getWikitextFragment shortcut to return a promise
Change-Id: Ide5c920332ba9dd0777a7c63e27ebbbc9a391172
2017-06-17 19:42:24 -07:00
Ed Sanders f400a6debe Remove old authorListWidget CSS
Change-Id: Ibeaae78f1424fc098dbc103438e7cb2c4d15c9d8
2017-06-17 19:42:22 -07:00
Translation updater bot b9a6dc8394 Localisation updates from https://translatewiki.net.
Change-Id: I53062bbd73eb478e27284f35320f5bc2bd4809bf
2017-06-17 22:50:13 +02:00
Translation updater bot d67005cdb8 Localisation updates from https://translatewiki.net.
Change-Id: Ic29540f87264d7541afa0a3be696cb47ed7e4f50
2017-06-16 23:02:01 +02:00
jenkins-bot 4b852d899b Merge "Use static parseDocument method" 2017-06-16 18:38:25 +00:00
jenkins-bot 14dd536d32 Merge "ve.ui.MWEducationPopupTool: Remove unnecessary manual popup positioning" 2017-06-16 18:32:51 +00:00
Ed Sanders 0e6d8d5fff Show visual diffs on DiffPage
Only shown if VisualEditorEnableDiffPage is set, or query
string param 'visualdiff' is present.

Currently:
* All VE javascript is loaded (could be cut down to just DM code)
* The entire Parsoid HTML of both revisions being compared is loaded
* Both Parsoid HTML docs are parsed into VE DM trees and diffed

Bug: T167508
Change-Id: I151fc9bab3d3032f50c8d11be6b54e45a06fcc34
2017-06-16 19:29:19 +01:00
Bartosz Dziewoński 624211a60f Use Parsoid data for template names rather than detect from wikitext
We were incorrectly handling transclusions with trailing
newlines after the template name.

This also improves handling of non-template transclusions,
e.g. parser functions like `{{int:mainpage}}`, which are
no longer mangled as if they were page names.

ve.dm.MWTransclusionNode#isSingleTemplate will now match
a template even if it's name is itself template-generated.

Logic for turning Parsoid's hrefs into page names stolen
from ve.dm.MWImageNode.prototype.getFilename.

Bug: T167613
Change-Id: Ibecf71338eb37bb3da81a7372e4ed41140a9af57
2017-06-14 23:15:18 +00:00
Bartosz Dziewoński 433e7b5069 ve.ui.MWEducationPopupTool: Remove unnecessary manual popup positioning
OOjs UI Popups position themselves automatically relative to their
$floatableContainer these days.

Also added explicit `$floatableContainer: this.$element` in the config
(although not strictly needed, since the parent node is used by
default, this makes the code more robust in case we move the popup
somewhere else in the DOM).

Bug: T167751
Change-Id: Id4267fce6499a4c217f7dc1d18871c02dd078aee
2017-06-14 23:19:09 +02:00
Bartosz Dziewoński 9dcf6dcddc ve.init.mw.DesktopArticleTarget: Remove some hacks
No longer needed after I2ede6c88be569224c0b2a4e388a133ad98b86a7b
in VisualEditor core.

* 'transform: none' from 049a32c60a
  (that change does not describe what the issue was, but clearly
  it wasn't a complete fix and I see no problems without it).
* 'z-index: 4' from 6fff13b898 (I can't
  reproduce the issue there after removing it).

Bug: T167616
Change-Id: I7e0d603af2668269e5587eaa5e4761166a1b4097
2017-06-14 22:25:25 +02:00
Bartosz Dziewoński 39b82f7b00 Revert 032fb292, a97eacd0
Reverting a new weird hack for an issue and bringing back the
old, tried and true hack that was removed in the mistaken belief
that if a bug is marked as fixed, it is really fixed.

* Revert "MWTransclusionDialog: size footer correctly"
  This reverts commit 032fb2924e.
* Revert "Remove dialog height hack tagged against resolved bug"
  This reverts commit a97eacd05b.

Bug: T93290
Bug: T167483
Change-Id: If1cc07837892bb0248c74025d5403f9698e77705
2017-06-14 20:38:38 +02:00
jenkins-bot 5fbe84a4e6 Merge "MWTransclusionDialog: size footer correctly" 2017-06-14 11:39:41 +00:00
Translation updater bot 98568e734f Localisation updates from https://translatewiki.net.
Change-Id: I751ac55b2a10f014c1db8df1d6915d71711ee5c9
2017-06-13 22:51:12 +02:00
Brad Jorsch 7ec68ed168 API: Split description messages into summary + additional text
See MediaWiki core patch I778bab2b

Change-Id: I642895c0e77dabfde3a7cdc744c5de4df9489aa5
2017-06-13 13:27:52 -04:00
David Lynch 032fb2924e MWTransclusionDialog: size footer correctly
Changing label means a refresh is needed.

Bug: T167483
Change-Id: Ie4b35696bdf21d2a74e786875615d8753a57972d
2017-06-13 11:48:38 -05:00
Translation updater bot 2dc77148cb Localisation updates from https://translatewiki.net.
Change-Id: I182b53a98bb4d7c5e471b23a4665c1c3a84c8b46
2017-06-12 22:52:07 +02:00
jenkins-bot 7e892bbc97 Merge "MWParameterPage: Fix missed remove -> trash icon name rename" 2017-06-12 18:55:05 +00:00
jenkins-bot b170e81d83 Merge "Fix i18n TODOs in CollabPad" 2017-06-12 18:51:31 +00:00
jenkins-bot 27c6f624ae Merge "[DEPRECATING CHANGE] Make Target#createModelFromDom static" 2017-06-12 18:50:38 +00:00
jenkins-bot 076a7feef2 Merge "Add filename to gallery dialog page" 2017-06-12 18:46:48 +00:00
James D. Forrester a7d48228dc MWParameterPage: Fix missed remove -> trash icon name rename
Bug: T167598
Change-Id: I1701bd426ea66a40937bcc69183c697a8e39710d
2017-06-12 11:39:50 -07:00
Translation updater bot 678949a23d Localisation updates from https://translatewiki.net.
Change-Id: Ia2bd46f3bbe52d17c6ea187dbd8a516de564adf8
2017-06-11 22:48:17 +02:00
Translation updater bot a84164a38b Localisation updates from https://translatewiki.net.
Change-Id: Ia38f09ce88980b0954a81b72ff32954e286fed23
2017-06-11 00:39:40 +02:00
Ed Sanders 23c0b6997e Fix i18n TODOs in CollabPad
Change-Id: Ifa802773881e2f2763578223bc76ca2798a08b17
2017-06-10 12:48:09 +01:00
Translation updater bot 44d0e3336b Localisation updates from https://translatewiki.net.
Change-Id: I3d19d4fed087b2f3b2fea902f2a223e765eceddd
2017-06-09 23:04:23 +02:00
Ed Sanders 75d583a0d9 Use static parseDocument method
Change-Id: I545a58ffcbf1c7c57c197f4858958de835a40394
Depends-On: I5b36e187a5e8bb68b47b2fccf5b46c08b81b01d9
2017-06-08 14:43:09 +01:00
Ed Sanders f178061117 [DEPRECATING CHANGE] Make Target#createModelFromDom static
Change-Id: I019689f87ac0f7f40a8a7600029b5ce1bc92e77f
2017-06-08 14:35:31 +01:00
jenkins-bot e97393434a Merge "Give extensions a fallback icon when invisible" 2017-06-07 23:34:20 +00:00
Ed Sanders 8fb56b8d75 Give extensions a fallback icon when invisible
Bug: T166526
Change-Id: I5eafbef3b751a83cef353c8a9f09d90820fa9409
2017-06-07 22:29:19 +01:00
Translation updater bot 94be609bb4 Localisation updates from https://translatewiki.net.
Change-Id: I881fdd18a2a6eda2af0f9b48d0e93ba05b845ee0
2017-06-07 22:56:46 +02:00
L10n-bot 46bcf496fe Merge "Localisation updates from https://translatewiki.net." 2017-06-06 21:03:23 +00:00
Translation updater bot 6c802d059f Localisation updates from https://translatewiki.net.
Change-Id: I927c7fe0f0c1dae63d337245a6e40723a69fd379
2017-06-06 22:50:16 +02:00
jenkins-bot 7774f2bee1 Merge "dm.MWTransclusionNode: Move mixin comment, remove duplicated static property" 2017-06-06 15:44:25 +00:00
Ed Sanders 9ccdf15695 dm.MWTransclusionNode: Move mixin comment, remove duplicated static property
Change-Id: Id8f8205db92a70dde7ba22b39e90e37590efb3d1
2017-06-06 16:28:01 +01:00
jenkins-bot 010197f1b8 Merge "Don't try to i18n-parse JSON string" 2017-06-06 15:08:16 +00:00
Ed Sanders 4a163020a8 Add filename to gallery dialog page
Also add fieldset headings consistent with media dialog.

Bug: T167049
Change-Id: I8112b70d8e3ba19079fdab0806ad343b233c9c18
2017-06-06 15:48:24 +01:00
Ed Sanders 4484f5c316 Don't try to i18n-parse JSON string
Bug: T167051
Change-Id: Idf07ba51d2681f0f5d275f2a732d77cd85e63d03
2017-06-06 11:12:41 +01:00
Translation updater bot 3830d2d864 Localisation updates from https://translatewiki.net.
Change-Id: Ib2dc866df76ca62367f5fbc76d0dd75831bf3968
2017-06-05 23:20:13 +02:00
Translation updater bot 507fdb73fc Localisation updates from https://translatewiki.net.
Change-Id: Ief77af837492f4171aebd118d3d07277adcdf8cf
2017-06-04 23:37:19 +02:00
Translation updater bot b7ef971cbf Localisation updates from https://translatewiki.net.
Change-Id: I670fd45d44a881de24917d40d4d4eea047cee185
2017-06-03 22:54:52 +02:00
Translation updater bot 748d301680 Localisation updates from https://translatewiki.net.
Change-Id: I9fe85ad034bd1784867bf9bbeb5b93d0d568e95d
2017-06-02 22:51:08 +02:00
jenkins-bot c5bdd39a63 Merge "Update for deprecation of OOjs UI openWindow/closeWindow promise" 2017-06-02 00:32:39 +00:00
Bartosz Dziewoński 4f55d8066e Update for deprecation of OOjs UI openWindow/closeWindow promise
Bug: T166729
Change-Id: I95b85a8c0d488993c11da74e1d856fef6cf0ebb4
2017-06-02 00:21:58 +02:00
Translation updater bot 87b90944c8 Localisation updates from https://translatewiki.net.
Change-Id: I2c7721a9dc5b4abe2151ebe6604bd1b4d7715999
2017-06-01 23:21:13 +02:00
jenkins-bot f01577ffa8 Merge "ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff" 2017-06-01 18:08:21 +00:00
jenkins-bot a506627f57 Merge "Correct numbers in visualeditor-dialog-meta-settings-toc-help" 2017-06-01 17:49:21 +00:00
David Lynch 7f8f188187 Correct numbers in visualeditor-dialog-meta-settings-toc-help
Bug: T166029
Change-Id: Ic15834218bed8a78ad2d9de6c0838988ca65cd4b
2017-06-01 10:46:02 -05:00
jenkins-bot 1a80348e8b Merge "Guard against mwdata.body being null" 2017-06-01 14:52:57 +00:00
Bartosz Dziewoński 834539748c ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff
This fixes the focussing problems from T166150.

As a separate consequence, when loading a template/transclusion
takes a while (it can take several seconds for e.g. a template with
100 parameters), we will now display nothing while the user waits.
Previously we displayed an empty frozen dialog (note that this only
worked the first time for some reason).

Bug: T166150
Change-Id: I414a72ee248517867eef63a75f2d327aa5d5b908
2017-06-01 16:31:05 +02:00
Ed Sanders a5e44034fb Guard against mwdata.body being null
Bug: T166754
Change-Id: I3b887a3a6ee81ca3fd0b242fadc8b833b9031b50
2017-06-01 14:01:23 +01:00
jenkins-bot c9d9361c5b Merge "Update VE core submodule to master (8be817396)" 2017-06-01 01:16:43 +00:00
Ed Sanders c7221988a1 Update VE core submodule to master (8be817396)
New changes:
26085a853 Make author list a ListPopupTool
c4ea53eef Update OOjs to v2.1.0
8c94697f3 Update OOjs UI to v0.22.0
cdebc4817 Follow-up 8c94697f: Actually commit the icon changes I had locally
8be817396 Update OOjs UI to v0.22.1

Local changes for author list popup

Change-Id: I36bcaf122528a4a12882aaff3b33ef936082a391
2017-05-31 17:48:45 -07:00
James D. Forrester 756079d477 Replace uses of the removed 'remove' icon with the 'trash' one
Bug: T166730
Change-Id: I528dcdb390a4488ffac89fc823ff35bc1eda4f24
2017-05-31 16:30:17 -07:00
Translation updater bot 8cb43a5f73 Localisation updates from https://translatewiki.net.
Change-Id: I154f2dd73776ab7c227c5776bdfd97a1228f5dd4
2017-05-30 22:50:10 +02:00
Translation updater bot f372a9fbc7 Localisation updates from https://translatewiki.net.
Change-Id: I6c06a3c102a1ac6c009c7c2fc074b6e7a7c55eb7
2017-05-29 23:33:34 +02:00
Translation updater bot b29b2816b2 Localisation updates from https://translatewiki.net.
Change-Id: Ia20bdbf2ab8962c4cd73c7296db5f5e1db55d80f
2017-05-28 22:42:27 +02:00
Translation updater bot ff1279244a Localisation updates from https://translatewiki.net.
Change-Id: Ic8decb78f5ba98c21d8b526ea91ae88db7bd3605
2017-05-26 22:53:58 +02:00
Translation updater bot efc4eccc47 Localisation updates from https://translatewiki.net.
Change-Id: I49161dac6c2583b4820a1d052b0cca8053e68583
2017-05-25 22:58:36 +02:00
Timo Tijhof a9ce695f75 mw.DesktopArticleTarget: Use require() for mw.page.watch
Add 'require' to eslint global whitelist for this extension,
since ResourceLoader provides this in all contexts now.

Bug: T166254
Depends-On: I0e6a95bd4fbaba06eae5137ac7af84f62bebf6f0
Change-Id: I6b2fe57317dcff18ec6d9ea0cd9e4eb9c894c169
2017-05-24 21:17:02 +00:00
Translation updater bot abaa359422 Localisation updates from https://translatewiki.net.
Change-Id: I2bfd2fa70e5aa870e2001a78d058e6e90a2bb73c
2017-05-24 23:04:42 +02:00
jenkins-bot 762344b2f1 Merge "Remove dialog height hack tagged against resolved bug" 2017-05-24 06:54:46 +00:00