Commit graph

7950 commits

Author SHA1 Message Date
Vikas S Yaligar c6b96d10e5 [BrowserTest] Save button locator now supports language screenshots
Change-Id: Ib3b6c577aee3e8fa61f76f19a170e4cf5c76bf45
2014-07-28 20:02:04 +05:30
Translation updater bot b74679c823 Localisation updates from https://translatewiki.net.
Change-Id: I05378bd550f36c036e9efcfc3085726f1d9c97b6
2014-07-27 22:26:07 +02:00
jenkins-bot 629f0c6908 Merge "SVG fixes" 2014-07-27 01:40:45 +00:00
Ed Sanders 61d40bd5ac SVG fixes
* Fix encoding
* Remove unused attributes
* Fix some IDs
* Fix pixel snapping in gallery icons

Change-Id: I084b3d7e3e5ba9b4ec234b94622cac076c7665e1
2014-07-26 18:38:11 -07:00
Translation updater bot c50c60ab67 Localisation updates from https://translatewiki.net.
Change-Id: I1dd18c5d92dfd25aec78f3c4dd4a79d489bca510
2014-07-26 21:49:46 +02:00
Ed Sanders 5e5755f09c Implement getFocusableNode for MWGallery nodes
Instead of using ve-ce-noHighlight we can just set and maintain
this.$focusable using getFocusableNode.

Change-Id: I0a6b2d6444df531b7c235ac9ff08a3ed8a0e99b3
2014-07-26 02:24:56 +00:00
Roan Kattouw c7fce9b2be Fix corruption bug in sortkeys containing underscores
We normalize underscores to spaces in sortkeys in toDataElement,
but when toDomElements recomputes the normalization to decide
if the sortkey really changed, it doesn't normalize underscores.
This is broken, both code paths need to use the same normalization;
we do this correctly for the category name.

This bug appears to date back to the introduction of category
support in March 2013 :(

Spotted in https://it.wikipedia.org/?diff=67220927

Change-Id: Ie3257fa335f3bd24a36c8654f3f5a24e89d7a9b9
2014-07-26 00:24:01 +00:00
jenkins-bot e49138a8c6 Merge "Actually clear diff viewer after closing save dialog and changing document" 2014-07-26 00:11:16 +00:00
Roan Kattouw 959fe94d51 Update VE core submodule to master (433007d)
New changes:
102e351 Remove transparent selection from focusable nodes in FF
7be8cd9 Add a space to the comment node for selection highlighting
40c7dd2 Highlight and bind events to $focusable, not $element
6d52af0 Add @embed directive for resize-nw-se and resize-nw-sw icons
004201c Initialize defaultSize as boolean in ve.dm.Scalable
a3eb9c0 Localisation updates from https://translatewiki.net.
bf5ccc6 Followup ab2d4cbe: Correct comment indicator's size
565e484 Fix copy paste of comments in Firefox
3698286 Generate fake comment nodes (spans) when copying
febb100 Meta-fy empty comments as they aren't editable/useful
fc553e2 Localisation updates from https://translatewiki.net.
433007d Style MobileContext properly

Change-Id: I55b79c398dd43bd5854ff53dc89f25cbca31670e
2014-07-25 16:48:47 -07:00
jenkins-bot 4d58b106f8 Merge "Attach mobile surface to the toolbar" 2014-07-25 23:24:21 +00:00
Roan Kattouw 1042733ee2 Attach mobile surface to the toolbar
Trevor promised to do this in Iafe64a6f but never did.

This needs styling changes to look right. It also means that
VE mobile standalone doesn't have a context at all right now,
which is horrible, but at least this makes MW mostly work.

Bug: 68546
Change-Id: Id8cc4b07905f777f667f36cbcc65e821847142d5
2014-07-25 23:10:15 +00:00
Translation updater bot 20c96f34c8 Localisation updates from https://translatewiki.net.
Change-Id: I40c516f30a94b3dd756993a4d25b1fcc87dbb87f
2014-07-25 23:07:52 +02:00
Roan Kattouw a6d94256d8 Actually clear diff viewer after closing save dialog and changing document
The window refactor removed the 'teardown' event from windows,
but ViewPageTarget was still listening to this event on the save dialog.
Instead, use the opening promise to be notified when the save dialog
closes and call onSaveDialogClose() at that time.

Change-Id: I31a9a359eb14a56b214a1240db08632bda6bc8b9
2014-07-25 13:14:07 -07:00
Cmcmahon 2fb3375000 [BrowserTest] turn Headings test back on for the builds
Change-Id: I58848fc8393ac2007dbb724e34a4c85e5142df7d
2014-07-25 12:55:11 -07:00
jenkins-bot 6ad2b0fb08 Merge "Actually show the corruption warning in the save dialog" 2014-07-25 18:50:59 +00:00
Roan Kattouw 7cc31d0c34 Actually show the corruption warning in the save dialog
It was being set, then immediately cleared again.

Also remove the unused dirtymsg div.

Change-Id: I22e5fbe814d14684626a7502d2401f414838709b
2014-07-25 11:39:03 -07:00
Cmcmahon 9b93c2c4fd [BrowserTest] prevent premature click of Edit button
Change-Id: Ibce2bf0f75e0639bbd3b90f2dc73716e43797841
2014-07-25 11:16:20 -07:00
Alex Monk 14753500a6 Don't overwrite #contentSub just to try to get the correct subtitle for redirects
Because this breaks other subtitles such as subpage breadcrumbs
Instead, deal with the #redirectsub (added in I780c965) directly.

Bug: 68432
Change-Id: I646868916a4480404f6d466fd89f84798d0e9df5
2014-07-25 18:57:08 +01:00
Translation updater bot af91451ddd Localisation updates from https://translatewiki.net.
Change-Id: Ie01fdcf4830f42bc176b337d3d221dbaf34c801e
2014-07-24 23:52:14 +02:00
Ed Sanders 97813e2696 Use faster (and more accurate!) computation of directionality
Per the comment above, dm doc direction will be a better
estimate of wiki direction than CSS, which is very slow.

Change-Id: I231738d660b429df1598eaaadf7397b47d35ea0c
2014-07-24 19:44:58 +00:00
Vikas S Yaligar aee1b125fc [BrowserTest] Language screenshot feature runs only for language screenshot job
Changes made in job which uses this patch is
https://gerrit.wikimedia.org/r/#/c/149012/

Bug: 68467
Change-Id: I8a28cfcf98b7cfcb64e809f08c7deadf086ba6d6
2014-07-24 22:43:43 +05:30
Cmcmahon 90a58ffe17 [BrowserTest] Switching from VE to wikitext update workflow
It got a little more complicated that it had been

Change-Id: I511aa1b6d5738f1c19d9ac395efccfef6b328798
2014-07-24 13:57:33 +00:00
jenkins-bot 04abfb3e79 Merge "Revert "Provide contextual help for the page settings dialog's controls"" 2014-07-24 02:12:35 +00:00
Jforrester f84c33f074 Revert "Provide contextual help for the page settings dialog's controls"
This reverts commit 9ba9b35b41.

Change-Id: I95dd24ec94f4e0ecc3a32fbcdac689cee4116ed5
2014-07-24 02:09:27 +00:00
James D. Forrester b4f2b24ad7 Update VE core submodule to master (98b5c53)
New changes:
d79270a Update context menu according to stricter rules
af6ec80 Ignore staging events in CE surface
43f7385 SpecialCharacterInspector: Don't have a hard-coded default message for the JSON blob
0081b13 Update OOjs UI to v0.1.0-pre (a7ce4d48d9)
8e08e9f build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass
a1fb10c Followup ab2d4cbebf40: fix whitespace preservation in CommentInspector

Change-Id: I1615665437a4c481371cee7e643cddf281c6434a
2014-07-23 19:02:06 -07:00
Roan Kattouw b0e3948b81 Followup e281f92: actually load CommentInspector CSS
Change-Id: I5d0f06693fb6a373973e7ef86f63d2b62f01bdf4
2014-07-23 18:51:17 -07:00
jenkins-bot 9774ceed20 Merge "Bump the height of the references list a little" 2014-07-24 00:43:02 +00:00
jenkins-bot 7a41e9fba9 Merge "Allow for a custom mechanism for scrolling to a section" 2014-07-24 00:42:55 +00:00
jenkins-bot 30bdf71193 Merge "[BrowserTest] Add parameter no longer exists" 2014-07-24 00:38:56 +00:00
Juliusz Gonera 8563668978 Allow for a custom mechanism for scrolling to a section
When I05f11246ca90a1ce3f741fd93194a827528cd597 gets merged, we will need
this to be able to scroll to a section on iOS (where the content will be
scrolled within a div, not as a whole page).

Change-Id: I6e47edfa8c3a3a46fd7a4f11e4a54955f3694b9b
2014-07-23 17:34:39 -07:00
jenkins-bot 3771aa92c1 Merge "Make the image model work without a node" 2014-07-24 00:32:54 +00:00
Moriel Schottlender 1bc7d074fe Make the image model work without a node
The image model should go by image attributes (whether it comes from
an existing node or a new one) and not a node.

Bug: 68242
Bug: 68000
Change-Id: I4cabd678157619331b3c47d3b44bc16a28fd7bd7
2014-07-23 17:27:30 -07:00
jenkins-bot c7026baf26 Merge "Defer building of MWReferenceSearchWidget index" 2014-07-24 00:27:16 +00:00
James D. Forrester 833baef313 Bump the height of the references list a little
Bug: 68226
Change-Id: Ic3c7b31dcaa6f7f8da3d86efab8c7ab94f4b1e62
2014-07-23 17:24:21 -07:00
Moriel Schottlender e281f921f2 Update VE core submodule to master (4424195)
Update tests and VisualEditor.php for comment node.

New changes:
5885b6a Update OOjs to v1.0.11
ab2d4cb [BREAKING CHANGE] Show comments inline to the user

Change-Id: Ie2787c3e29951cb7940f65bf104e7c9cccdbebd1
2014-07-23 17:21:47 -07:00
Cmcmahon 5b439da8bc [BrowserTest] Add parameter no longer exists
Change-Id: If422bedef833d0b97ca0105ad72c4ce69411bf38
2014-07-23 17:00:21 -07:00
James D. Forrester ed7f08ecd8 Update VE core submodule to master (1bfcb16)
New changes:
585401c Followup b141a7d23: don't display:none; the popup in the DesktopContext
1bfcb16 Localisation updates from https://translatewiki.net.

Change-Id: Ic687835458dd833ae0200a3cb5c51af49f4b5672
2014-07-23 15:36:54 -07:00
jenkins-bot ec8f48835e Merge "Actually document .static.nodeModel in MWExtensionInspector" 2014-07-23 21:08:02 +00:00
Translation updater bot cae18c1462 Localisation updates from https://translatewiki.net.
Change-Id: Ida21152abace33aa259b07d5f694a808a834b672
2014-07-23 22:53:48 +02:00
Roan Kattouw 71dd2bf852 Actually document .static.nodeModel in MWExtensionInspector
Undocument abstract static properties are bad.

Change-Id: Iae19fb83840fe7edaaaa5e80dff092064dc76361
2014-07-23 13:49:39 -07:00
Ed Sanders d8d3a8c98e Defer building of MWReferenceSearchWidget index
It can be very slow on pages with lots of references and
isn't required until you click 'Use existing reference'.

What is required is knowing if the list will be empty for
greying out the button, but that can be precomputed very cheaply.

Change-Id: I56909801a5685bb04e0c83cfb95463f705b8dfae
2014-07-23 15:12:31 +01:00
James D. Forrester d41a1d5cc5 Update VE core submodule to master (97a5007)
New changes:
9e2238b Add special case for up/down arrow key on focusable node
30f0329 Fix for cursoring into focusable nodes with up/down
6c8da6a Fix spacing inside fragment inspector
3114f74 Remove Firefox listnode hack
e7d98b7 Fix calculation of affectedRange in transaction processor
c6d7589 Use native focus
d71e3a2 Use proper methods for detecting data type in getAnnotationIndexesFromOffset
a930e57 Add optimised method hasAnnotationsInRange
74c729f Use the current document when evaluating activeElement
10aefba Remove is*ArrowKey functions
10465c1 Remove onFocusableHistory listeners
22eb203 Bind/unbind setResizableHandlesSizeAndPosition on focus/blur

Change-Id: I1843ae58fd692c940e4e3d285bfadd3febedca07
2014-07-22 19:30:05 -07:00
jenkins-bot 960922cdb0 Merge "MWReferenceSearchWidget buildIndex optimisations" 2014-07-23 02:23:43 +00:00
jenkins-bot e9f78820c3 Merge "Fix reference dialog focus" 2014-07-23 02:08:32 +00:00
Ed Sanders 24c322a124 Use native focus
It's faster.

Change-Id: I0a8a2452aa987e2b93c5c8ba3c6efa2bcafbaa86
2014-07-22 19:05:14 -07:00
jenkins-bot 0c205af338 Merge "Update VE core submodule to master (426f9e4)" 2014-07-23 02:03:08 +00:00
James D. Forrester 27c30322ed Clamp height of MWReferenceDialog to between 300 and 400px to avoid it being too small
Bug: 68232
Change-Id: If32edc5622565b28ae1f6a2423a7c2289965733c
2014-07-22 18:57:39 -07:00
jenkins-bot 08c3f6be04 Merge "Provide contextual help for the page settings dialog's controls" 2014-07-23 01:43:54 +00:00
James D. Forrester 9ba9b35b41 Provide contextual help for the page settings dialog's controls
Change-Id: I5c24d7f41ce33d1145f8bfbfd60bd78d08df39ce
2014-07-22 18:41:17 -07:00
Roan Kattouw 4d9cf59db0 Update VE core submodule to master (426f9e4)
New changes:
1b7b23b Tests: Move …/test/… to …/tests/… to be the same as other repos
cd3fc66 Update OOjs UI to v0.1.0-pre (9cd400e3d5)
81be252 Deprecate 'live' event in favor of 'setup' and 'teardown'

Change-Id: I71277d0a3fc85541cf3a0859f58d6d522ad1db6d
2014-07-23 01:23:02 +00:00