wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-04 10:48:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
13043 commits 14 branches 17 tags 199 MiB
Commit graph

118 commits

Author SHA1 Message Date
jenkins-bot b268b4f80f Merge "ve.init.mw.ArticleTarget: Only retry once after a 'badtoken' error" 2017-04-24 19:48:35 +00:00
Bartosz Dziewoński 371ac353cf ve.init.mw.ArticleTarget: Use a simpler error message when site is read-only 
Sites like to customize 'readonlywarning' with things that we can't parse.
Instead, use 'apierror-readonly'. The old message is still shown in edit
notices.

Bug: T163455
Change-Id: I592accde17b256ecee27820df12d9d312499f8f7
 2017-04-21 00:08:57 +02:00
Bartosz Dziewoński 91a75e3fef ve.init.mw.ArticleTarget: Only retry once after a 'badtoken' error 
If we retry and get another 'badtoken' error, something is very wrong,
and trying again and again is probably pointless. This behavior also
matches how mw.Api#postWithToken handles bad tokens.

Bug: T163493
Change-Id: I488fd7e74e37922044491695d6c9025a45531281
 2017-04-20 22:42:10 +02:00
Ed Sanders a6b4258f47 ArticleTarget: Refactor savedialog/target interaction 
* Pass a wikitext promise, instead of wikitext
* Handle writing of content to the dialog from within
  the dialog.
* Handle diff errors within the dialog.
* Never disable the 'Return to save form' (approve) button
* Remove redundant messages

Change-Id: Ibd76e8951998f751abfb4f407682202c2f73ac7e
 2017-04-10 10:29:41 -07:00
Ed Sanders 939a1f4005 VisualDiff: Fetch original doc from Parsoid if fromEditedState 
Bug: T160741
Change-Id: Ied0641cc868a8dd4cf540eba75e1b248277a96b0
 2017-04-09 22:28:53 +01:00
Ed Sanders 97f6bdd79a Make Target#getVisualDiff async 
This will be required later when we have to fetch the original
document from the server before running a visual diff.

Change-Id: I351688f4d1fec892bc297f40c209939cbb2ccf95
 2017-04-09 13:26:22 +01:00
David Lynch 758b2fd689 ArticleTarget: building summary in source mode, strip links from section titles 
Bug: T162017
Change-Id: I76e96d1e36f7bad0b3e17d8bb842c6ad1172f8cc
 2017-04-05 11:16:11 -05:00
James D. Forrester 8463524e18 MWSaveDialog: Run links through a render function for preview & visual diff 
Provide a utility funcition in ve.init.mw.LinkCache to do this.

Also use this in ve.ce.MWTransclusionNode/ve.ui.MWPreviewElement, and
introduce to ve.ce.MWExtenionNode

Bug: T73900
Bug: T153535
Change-Id: Ieb9a0274b8c5ae1932c431546f09d18000fa6dd9
 2017-03-31 10:51:35 +01:00
Ed Sanders 6d891dc049 Pass section when resolving conflicts in NWE 
Bug: T154217
Change-Id: I61f69df228fcbe25840b166a2081cacdb0417431
 2017-03-29 22:21:17 +01:00
Bartosz Dziewoński 645eb8e543 Don't use '#content #firstHeading', unnecessarily specific 
Simply '#firstHeading' does fine.

Change-Id: I7c72496f0d58b86582bd33c018b618e1b75f2c7a
 2017-03-29 17:37:29 +00:00
jenkins-bot 16918a08cf Merge "ve.init.mw.ArticleTarget: Don't construct element IDs dynamically" 2017-03-28 17:23:11 +00:00
Bartosz Dziewoński 6a9f8a1417 ve.init.mw.ArticleTarget: Don't construct element IDs dynamically 
Easier to find the usages this way.

Change-Id: I38ce1389af1d30ff1f5e0214b68d094a67da046f
 2017-03-28 19:01:46 +02:00
Ed Sanders b756199dc7 Use ve.targetLinksToNewWindow 
Depends-On: I3088e8b95d9032b8e8fd5bff58a8b97ffaa15f98
Change-Id: I07ec10841b62ed1e8c3b3cf82b42653327618cb0
 2017-03-24 21:34:47 +00:00
David Lynch 1dc18b6703 Section editing: strip links from heading text used for edit summary 
Stops us including "[edit]" in the summary when people have marked whole
headings for translation.

Bug: T160911
Change-Id: I906398e6bf45433d904795847f59b5bf0148092f
 2017-03-22 02:00:24 -05:00
Ed Sanders 335b56728a Introduce visual differ in the save dialog 
Bug: T143350
Change-Id: I1297d0f4bb87e69be3b50220c1830a22dac1bbae
 2017-03-16 15:33:54 +00:00
jenkins-bot 797aac9d88 Merge "ArticleTarget#switchToVisualEditor: Bail if the server won't let you switch" 2017-03-14 16:19:06 +00:00
David Lynch a9f54aacd4 DesktopArticleTarget: Clear stored summary value after save completes 
Bug: T160130
Change-Id: Id906da69c743f3a966d4182862cd173b26017059
 2017-03-10 10:19:12 -06:00
James D. Forrester d1f2bf1ecf ArticleTarget#switchToVisualEditor: Bail if the server won't let you switch 
Because otherwise you're just throwing all the user's input on the floor.

Bug: T158692
Change-Id: I5df00842697be11ecde9ea8ba2ab16b0dc90205e
 2017-03-09 17:09:16 -08:00
David Lynch 05e2a3119e ArticleTarget: Improve edit summary behavior when switching 
Distinguish between the initial summary state, and a value stored from the
summary when switching modes. This lets us avoid overwriting a stored value
when section-editing, or assuming a stored value after a switch was never
edited.

Bug: T159686
Change-Id: Ie7640538140a14bbafd539b3a45928f5c55cf804
 2017-03-09 14:23:36 -06:00
David Lynch 261d4e8974 ArticleTarget: use existing initialEditSummary if present 
Switching modes recreates the toolbar, so if someone has already edited the
save summary it shouldn't update the initialEditSummary to that.

Bug: T159686
Change-Id: I4109442853916bebae2bce804fcd6777e3eb6d34
 2017-03-09 12:05:12 -06:00
James D. Forrester e0814210e9 ArticleTarget#getWikitextFragment: Optimise no-op 
Change-Id: I6b54ae26e26c5ca697848d2534c128fc9c4bc4aa
 2017-03-01 19:17:26 -08:00
Ed Sanders b3989e4f07 Move switching methods to ArticleTarget and fix in mobile 
Change-Id: I7796dab5d2a24f9719870abf383925442b787612
 2017-02-28 11:47:35 -08:00
David Lynch 8a7d44224c ArticleTarget: try to refresh editToken if getWikitextFragment fails 
Refactor saveFail's badtoken handling out so it can be reused by
getWikitextFragment.

Bug: T156991
Change-Id: I686cddb5be4484211fa69640044db1bc34eacefc
 2017-02-07 11:20:59 -06:00
Bartosz Dziewoński 6f367ea0ec ve.init.mw.ArticleTarget: Don't try to clear non-existent message 
This is just dead code. We never call `.showMessage( 'captcha', ... )`
(the CAPTCHA is shown in the 'api-save-error' message).

Change-Id: I48f51e89d5b366384d184e2ed505be9e7b8f3401
 2017-01-31 14:40:32 +01:00
Ed Sanders f58d00b110 Move #getWikitextFragment up to ArticleTarget 
Change-Id: Ice4b04db4a45c07ccffc3892e6db5d814c2ec37b
 2017-01-20 23:15:17 +00:00
Ed Sanders 337614d142 Open preview links in new tab 
Bug: T155159
Change-Id: Idddc6b25303c17382ba1bc763b9001b727e1040e
 2017-01-12 16:07:00 -08:00
James D. Forrester 002b0adef0 ArticleTarget: Give users a specific message when HookAborted errors happen 
Change-Id: I7017412dc56200f5bb0adbd901aed15507447846
 2017-01-11 10:46:30 -08:00
James D. Forrester 2b502572ec ArticleTarget#saveErrorUnknown: Handle the xhr being complete 
Change-Id: I638b5b80c5a404a438ebd357b6e16bbab7871d6e
 2017-01-11 10:45:43 -08:00
jenkins-bot 4d64196fcb Merge "Fix loadFail parameter handling" 2017-01-04 22:46:27 +00:00
jenkins-bot e91f8f913e Merge "Allow 'T-' prefixed sections, and redirect if section link title isn't current page" 2017-01-04 22:38:34 +00:00
Alex Monk 1bcaa9056c Fix loadFail parameter handling 
Rename them while we're at it.

Bug: T151278
Bug: T152429
Change-Id: I435ac148007db87da69e8cf48568fafa646abb71
 2017-01-04 22:31:08 +00:00
Ed Sanders 808de2acea Add "templates used" page to meta dialog 
Bug: T149009
Depends-On: Id617f9afbddf094140133f9659efc4b4e746148c
Change-Id: I63e663d05aefb47274f1f28bdcafc5317c2fc4f6
 2017-01-04 18:30:11 +01:00
Ed Sanders b7dd6077b8 Allow 'T-' prefixed sections, and redirect if section link title isn't current page 
Bug: T153176
Change-Id: Ic6fda78d00715777df4a273e7d3e150f20185185
 2017-01-04 16:53:03 +00:00
jenkins-bot 78a38ae6ea Merge "Register shortcuts for minoredit/watchlist" 2017-01-03 18:54:26 +00:00
James D. Forrester 122f49b2dd build: Bump file copyright notices for 2017 
Change-Id: I3c20809e71cc0da58123e1b5f29c4f3aac945496
 2017-01-03 08:58:33 -08:00
Bartosz Dziewoński 90ff82a035 Use mw.Message#parseDom where appropriate 
Avoid turning DOM into HTML markup and parsing it back into DOM.

Change-Id: I34f56ee60b836a7e0556130a153fc95adb4f3467
 2016-12-27 23:54:12 +00:00
Ed Sanders 7611ee5a2c Register shortcuts for minoredit/watchlist 
Bug: T153925
Change-Id: I3f569a75a66e816d0a5c4ad966344100510a4f2b
 2016-12-23 13:36:48 +00:00
Ed Sanders aee5e665f1 Preserve checkbox data when switching from VE to NWE 
Bug: T153889
Change-Id: Ifc41ea9320c9f2627efff6f33d4ad87c59fad496
 2016-12-21 22:35:52 +00:00
jenkins-bot 2f790bb7a8 Merge "Show HTTP status alongside 'Unknown error' when it's not 200" 2016-12-16 18:51:57 +00:00
jenkins-bot 57d49550a0 Merge "Add shortcut for show preview and resolve access key conflicts" 2016-12-16 18:14:17 +00:00
Ed Sanders 4d134cfefc Add shortcut for show preview and resolve access key conflicts 
Refactor save dialog setup so logic for canPreview/canReview
is external and passed in.

'Show preview' will show in the VE command help dialog until
I56c1036e6 is merged in core.

Bug: T149914
Change-Id: Id718ad622be43c03df61d12b8688d53462c59f36
 2016-12-16 13:33:57 +00:00
Alex Monk a9feb8869c Show HTTP status alongside 'Unknown error' when it's not 200 
Change-Id: If14dc14f2cc43a1f12c1314342d5028ec524c31e
 2016-12-16 11:28:38 +00:00
Alex Monk 96b8d35bff Wrap localStorage.getItem calls in try { ... } catch () {} 
Bug: T153291
Change-Id: Ic4f8c390bfe6936bd182b28b1f2c6d19bf459eba
 2016-12-15 23:08:30 +00:00
Ed Sanders 9728d78126 Resolve URLs in show preview against correct base 
Bug: T153277
Change-Id: Icaa6de4618de008fb2024d1dd428114688cb1043
 2016-12-15 03:19:16 +00:00
Ed Sanders 61c7cc4a95 Extra section title for edit summary in source mode 
Bug: T153245
Change-Id: I3b3465f269831152fd7a820027f44bfaada067a8
 2016-12-14 21:22:10 +00:00
jenkins-bot dc897662bf Merge "Resize save dialog after showing captcha" 2016-12-13 17:19:20 +00:00
Ed Sanders 56c34fbf79 Follow-up I6eda4a7c: Fix typos in #updateTabs 
Change-Id: Ib80dec3fb199ea03609d5d0f242ac606052f24cc
 2016-12-13 15:19:05 +00:00
Ed Sanders 5a8106773c Support section=new in NWE 
Bug: T150709
Change-Id: I1002b97060d642df0988da15860a36c13712bade
 2016-12-13 12:20:55 +00:00
Ed Sanders 37190c3e8d Resize save dialog after showing captcha 
Change-Id: I219a1eae442bd580760235f22eee15a836d5ebae
 2016-12-13 12:05:42 +00:00
Ed Sanders 66e4a5cbe8 Simplify #updateTabs 
Change-Id: I6eda4a7c27f0b7590aae5505b0459ced07d2cc48
 2016-12-08 19:22:11 +00:00