The promise is supposed to return a function that can be used
to lazily generate the visual diff, not the visual diff itself.
This was broken when switching to arrow functions.
Bug: T364635
Change-Id: Ifa971333aa22af346bb62d031dc20afc8979992c
This line was introduced by If59979f.
This action is only invoked from the 'safe' action when the dialog mode
is 'info' - uploads are under 'upload-info' instead - so I believe we
shouldn't end up here from an upload and whatever condition this was
guarding against is no longer a concern.
Bug: T362015
Change-Id: I6a6551eab3fb698a6ae781be4623b48e4b4c7edb
* Add to npm run test, and exit with error code
* Improve output message, with instructions on
how to add to ignore list.
Change-Id: Id4ed56673e84073ac06468bdc429c138466e2501
They generate a lot of false positives in this extension.
Since this is client-side code, the worst that could happen is a
browser tab hanging, not any real security issues.
Change-Id: I177cfa7e57a6b7b528d558d2cba076e85fd0271f
New changes:
7f2382ade Convert local functions to arrow functions and remove `this` bindings
273812741 build: Update grunt-banana-checker to 0.12.0
Change-Id: I816e212d3d83da464e83620a02e4eb39dd1b7d4f
Follow-up to
I2495fe32c2d540be50450d715b049173f2f8727d
Done with the help of Matma Rex at Wikimedia Hackathon 2024.
Bug: T361103
Change-Id: Ica328233cb6172277e66d2341cfb53f87f8aff67
New changes:
14e855b40 README.md: Update doc link; add coverage; drop live demo
074cc8bde README.md: Fix Coverage/Code coverage link name split
f94cae724 JSDoc: Load all theme plugins
608c8194c README.md: Mark [[mw:VisualEditor/Setup]] link, as JSDoc doesn't autolink
9e65bfde3 eslint: Switch all code from jsduck to jsdoc mode
fdc0addee Prefer short arrow functions
5bbdc2f3e JSDoc: Fix some missing complex returns types
00b5bcdc4 Use ES6 variadic arguments
0a4a7e3a7 JSDoc: {Mixed} -> {any}
419162782 LanguageInputWidget: Fix logic for checking if language exists
2bc827327 Use more variadic args
Change-Id: I40fdc33b7b46fb38c597308e2615a37c89406378
* Remove need for manual hacking of sub groups via "msg" strings
carefully prepended to every assertion.
* Improve CI details, by reporting the specific case that failed,
and local dev via ability to re-run each case, and reporting names
directly in the HTML Reporter and CLI summary.
* Reduce need for assert.async() and tracking of callbacks, especially
to improve failure details in case of Promise rejection.
Current logic was likely to cause a confusing timeout instead of a
clear failure if the promise ends up rejected.
QUnit propagates these as part of awaiting and asserting the test
closure's promise value (as async fn) automatically.
This approach also avoids the pitfal of a falsely passing test
when an assertion inside a done() handler was never reached.
* Use modern for-of where possible to remove need for closures and
arrow functions. Thus reducing complexity of test code, where
complexity should be kept lowest to avoid false confidence.
* Use plain for-in instead of overly complex Object.keys().forEach().
Change-Id: I934a266e75e64371081f104cfb867fb2c282c84a
