wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-25 06:46:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
8676 commits 162 branches 1 tag 191 MiB
Commit graph

2508 commits

Author SHA1 Message Date
Roan Kattouw bb6e01c488 Fix back button not exiting VE 
When you clicked the Back button in the browser, the URL
in the address bar would change (removing veaction=edit),
but we would not go back to read mode. This was broken
by 5c0c11753 almost a month ago but apparently no one noticed.

This is because 5c0c11753 moved the pushState() calls to
be earlier (in init init), making the replaceState() call
in the ViewPageTarget constructor (which is there
specifically for this bug) run too late in those cases.

The simplest way to fix this is to duplicate these replaceState()
calls before the pushState() calls in init init.
I feel a bit bad about copying code, but not very bad
because the code I'm copying already has a FIXME comment
about how there should be a better way :P

Change-Id: I6627a5d1d9377ae815bc58bceeb059ce9f4f19ab
 2014-11-19 02:07:41 +00:00
jenkins-bot aa44c8916b Merge "Consistently use location as global, and location.href for full url" 2014-11-19 02:00:35 +00:00
jenkins-bot c8152914eb Merge "Use history as global instead of via window" 2014-11-19 01:59:26 +00:00
Timo Tijhof dc648e6b06 test: Omit 'window' in mw-preload.js 
Follows-up 92c38ea.

Change-Id: Ib8a37036a1a9dac980527bfccd506fff5ea8dce1
 2014-11-19 01:46:38 +00:00
Timo Tijhof c0692af5f7 Use history as global instead of via window 
Just like DOM interfaces such as document and location. And JS
constructors like Object.prototype, and libs like jQuery.
No need for the window host object.

Change-Id: Ie39aaea2ca17bdec5fb3afe32a4e6c9f751bd0c6
 2014-11-19 01:12:11 +00:00
Timo Tijhof 82657727f9 Consistently use location as global, and location.href for full url 
The location object is a global, just like document.

Using it via 'window' needlessly adds complexity and, for example,
makes it harder to catch typos in static analysis.

Standardise on location.href in place of the many different
variants for accessing and assinging the full url:

 location =
 location.href =
 location.assign() =

And each with 'window', 'document' and without host object.

Change-Id: If88515bd88fc5b93ebacd4ec41fce02fec540f18
 2014-11-19 00:20:08 +00:00
Translation updater bot 384232ee64 Localisation updates from https://translatewiki.net. 
Change-Id: I7e799602cb9d11c2e77be38b3707ebd0b82c7d9d
 2014-11-18 21:35:49 +01:00
Cmcmahon 210169c55b [BrowserTest] forgot a bit of dead code 
Change-Id: I249e229d449eb74ff341f511e84290a4ca731f92
 2014-11-18 13:09:17 -07:00
Cmcmahon 6489767bc7 [BrowserTest] remove sleeps from shared tests 
* remove dead code

Change-Id: Id95ff81746eb440124958bcc6dd9334b7ed299a4
 2014-11-18 12:59:34 -07:00
Cmcmahon 06aa53747c [BrowserTest] interim step, no functional change 
Change-Id: I3a7787c4ab9206c70f0f64b6c0986ae93ddb3d84
 2014-11-17 15:14:32 -07:00
Cmcmahon 94bab8f918 [BrowserTest] update transclusion test for Page Object vio and RS 
Change-Id: Ie80dce2d117d4d2dc836681dcd9362ae565f2aa8
 2014-11-17 14:59:14 -07:00
Cmcmahon 743d035fa1 [BrowserTest] update switch-edit-mode test for RSpec3 
Change-Id: Ia040f8b6e76a42c2c80bda382bf6ad6f30988ba1
 2014-11-17 14:42:59 -07:00
Translation updater bot 3386871003 Merge "Localisation updates from https://translatewiki.net." 2014-11-17 21:29:42 +00:00
Translation updater bot f8d851c50a Localisation updates from https://translatewiki.net. 
Change-Id: Iee3bdfaa9ef9b032cba0a958eb06ebbbb2e505a5
 2014-11-17 22:29:16 +01:00
Cmcmahon fa02c60586 [BrowserTest] fix minor Page Object design violation 
Change-Id: I75d282a7e176347b0995f2c2ccda8ab051aca270
 2014-11-17 14:18:13 -07:00
Cmcmahon 4383dedcfc [BrowserTest] minor violation of Page Object design pattern 
and RSPec syntax also fixed

Change-Id: I2bbaf460f6ddae708ea243064dd9a596bdd006f1
 2014-11-17 14:07:16 -07:00
jenkins-bot 83797c4925 Merge "[BrowserTest] more update to Cite test for RSpec3" 2014-11-17 20:59:12 +00:00
jenkins-bot c5ec9cb8d5 Merge "Methods for new "maps" property in TD Root" 2014-11-17 20:56:49 +00:00
Cmcmahon 3c5e695c5d [BrowserTest] more update to Cite test for RSpec3 
Change-Id: Ia2fa25bffe9bbdffb0eafc19396c06be253216c3
 2014-11-17 13:56:08 -07:00
Cmcmahon 94c30f01da [BrowserTest] update Cite test for RSpec3 
Change-Id: I589a65e0fe1b21ca6476a5c31b97d7632da39b13
 2014-11-17 13:31:30 -07:00
Cmcmahon 87ad037442 [BrowserTest] remove sleep() from template test 
Change-Id: Ia564232e02db2e6be3070d98691097350e920a3b
 2014-11-17 13:13:25 -07:00
jenkins-bot 51976d6237 Merge "[BrowserTest] interim step to sort G/W/T statements properly" 2014-11-17 19:29:12 +00:00
Cmcmahon ea0fac5e4f [BrowserTest] interim step to sort G/W/T statements properly 
no change to function

Change-Id: I2c2e9ccb6535c875d37ef59ab873a2f3280cca60
 2014-11-17 12:27:06 -07:00
jenkins-bot 7efa601837 Merge "On save, if there was no 'last modified' text at the bottom of the page, add it" 2014-11-17 17:48:50 +00:00
jenkins-bot e85550c350 Merge "Don't try to get newtimestamp from edit if no change was made" 2014-11-17 17:48:44 +00:00
Cmcmahon 9a4d2eeef9 [BrowserTest] interim step to alphabetize 
no change to function

Change-Id: Id655a9777e3b8bd3e3fbb974c73912f9f975bf7c
 2014-11-17 09:09:06 -07:00
Alex Monk ac6f6caeac On save, if there was no 'last modified' text at the bottom of the page, add it 
Just hope that wgMaxCredits is 0.

Change-Id: Idf4a7cceb0650eaec4442244066d875a3ff38e06
 2014-11-17 01:18:46 +00:00
Alex Monk ff3d76f488 Don't try to get newtimestamp from edit if no change was made 
ApiEditPage can give us 'nochange' instead of the
'oldrevid'/'newrevid'/'newtimestamp' keys if we gave it a null edit.

Bug: 73463
Change-Id: Ic22597dfed11de3823471673404090a9bce12928
 2014-11-17 01:03:00 +00:00
Translation updater bot fce0ed5d6c Localisation updates from https://translatewiki.net. 
Change-Id: I0a857cef14050c92c1236612006ad34b34bf49bc
 2014-11-16 22:53:55 +01:00
Translation updater bot 9b3b81c234 Localisation updates from https://translatewiki.net. 
Change-Id: I3e9b5d8b65d6b1a1b57762ae904554a7b4d47c73
 2014-11-15 23:18:28 +01:00
Cmcmahon 17f6badf0a [BrowserTest] update references test for modern RSpec syntax 
simple update to a nice test

Change-Id: Iad00e779295ccc610d20241693a87b76b817fbd6
 2014-11-14 15:52:51 -07:00
jenkins-bot 02407138ad Merge "[BrowserTest] remove sleep from multiedit test" 2014-11-14 22:35:31 +00:00
Cmcmahon 6d22cebb62 [BrowserTest] remove sleep from multiedit test 
* put the shared step in shared_steps.rb
* replace "onfocus" with simple "click"
* update RSpec while we're at it

Change-Id: I77754abdbeba1314758f5fe10601f6601e8783bd
 2014-11-14 15:30:10 -07:00
Translation updater bot e670131ea5 Localisation updates from https://translatewiki.net. 
Change-Id: I934ae1c25cf6d1396dc4517d438a76556d4c209d
 2014-11-14 22:27:52 +01:00
Cmcmahon 36e07b247e [BrowserTest] simple upate to a nice test 
Change-Id: Ib52582a677d8dc2f22552bf7c60f48de8f20d3c7
 2014-11-14 13:43:31 -07:00
Cmcmahon ea9df60aa3 [BrowserTest] RSpec update 
Change-Id: I03f89eda4292482dedaa335e3546af724ee55024
 2014-11-14 13:32:59 -07:00
Cmcmahon 1aa5d8905b [BrowserTest] remove sleeps from links test 
Change-Id: Ib0e09735331dadd5bb494fe87683f6f08b6aee31
 2014-11-14 12:30:13 -07:00
Cmcmahon da42fe407c [BrowserTest] hygiene changes 
* alphabetize headings steps
* move diff view check to shared_steps.rb

Change-Id: I68ac8de2f67a61bdd50f4892f58368e1bbd71271
 2014-11-14 16:05:14 +00:00
Translation updater bot 4387c52f93 Localisation updates from https://translatewiki.net. 
Change-Id: I92a1563c843ad912a71f642caa9d7af2300f0f6c
 2014-11-13 23:12:26 +01:00
jenkins-bot ed7cfa1207 Merge "When saving, return the full contentSub to the client" 2014-11-13 20:45:09 +00:00
Cmcmahon e4eeb40c17 [BrowserTest] interim alphabetization only 
Change-Id: I3a724d2cadbc40c63978058e4b2684ef86ceec03
 2014-11-13 10:04:19 -07:00
Cmcmahon 3ed807277e [BrowserTest] minor updates for hygiene, no functional changes 
Change-Id: I3d8ca33bd850caeb44b8e8e8017f2fa302676b1a
 2014-11-13 09:08:15 -07:00
jenkins-bot 12bff6a622 Merge "[BrowserTest] make bullets test modern" 2014-11-13 15:33:47 +00:00
jenkins-bot 6c377214b1 Merge "Move addClass calls to setup in GeneratedContentNodes" 2014-11-12 23:43:17 +00:00
Ed Sanders ef38ce8c8c Move addClass calls to setup in GeneratedContentNodes 
Ensures classes persist on content update.

Change-Id: I4828ad3208351e4b00e0be1f905b7eafd5e5e93b
 2014-11-12 22:52:59 +00:00
Translation updater bot 07c104b807 Merge "Localisation updates from https://translatewiki.net." 2014-11-12 21:25:27 +00:00
Translation updater bot e70164725a Localisation updates from https://translatewiki.net. 
Change-Id: I9a171c6b8c17a0a98f4a87619f28d3196c588b90
 2014-11-12 21:55:17 +01:00
jenkins-bot bec4ecfb37 Merge "Rename input variables in media dialog" 2014-11-12 20:48:24 +00:00
Ed Sanders 320206fe42 Rename input variables in media dialog 
Change-Id: I9b8edfaccb163aff313e267bb1a0f74455502242
 2014-11-12 19:51:48 +00:00
Ed Sanders 06bccbe986 MWLiveExtensionInspector: Move event unbinding to teardown process 
Change-Id: I6fae2ca3e1bc02b8edb707b4248b884a9f022c3f
 2014-11-12 19:33:24 +00:00