wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-29 00:30:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
11076 commits 13 branches 17 tags 198 MiB
Commit graph

8805 commits

Author SHA1 Message Date
Ed Sanders 2afd7c903d DesktopArticleTarget: Improve teardown sequence 
* Ensure activating classes are removed by rejecting activatedDeferred
  as soon as teardown starts.
* Try to teardown surfaces is surfaces exist, not just if the target is active.
* Remove noop teardownDebugBar. The debugbar lives inside the surface now.
* Ensure progress bar is always reset, even if target setup is aborted.

Bug: T99139
Change-Id: I16a071c0d4bc8bbc6af2e03e63ee0ffc18d55c75
 2015-12-23 12:13:50 +00:00
Translation updater bot 9cc9b8f1a1 Localisation updates from https://translatewiki.net. 
Change-Id: Ia72cf64c778cf9ab82f24700ec90e404bd0f9432
 2015-12-22 22:12:49 +01:00
Ed Sanders 93f0e8b30c Refactor MediaResources(Provider/Queue) 
Create a subclass for MediaSearch(Provider/Queue) and make the parent
class a more generic representation of API requests for media.

Change-Id: Iea8b90e829d532d210bfef3c96d6798c64e15eed
 2015-12-22 14:00:10 +00:00
Translation updater bot dd85041a29 Localisation updates from https://translatewiki.net. 
Change-Id: I66a72ca80277579be5674cbeb0794a70c7093345
 2015-12-21 22:07:16 +01:00
Translation updater bot 39d762e844 Localisation updates from https://translatewiki.net. 
Change-Id: I9de2feb735f9c722d941e7fdac53f4ee241ad9ad
 2015-12-20 22:36:27 +01:00
jenkins-bot 7c1660c933 Merge "Make Ace Editor adjustSize method chainable" 2015-12-20 12:56:03 +00:00
jenkins-bot 7da9dc409f Merge "ReferenceEducationPopup: Don't flip the numbers in the RTL image" 2015-12-19 15:06:24 +00:00
Florian 5627701cb1 Fix inheritance of ve.ui.MWTransclusionDialogTool 
From the description of the commit message[1] for WindowTool and
FragmentWindowTool, the ve.ui.MWTransclusionDialogTool should be
a FragmentWindowTool, and not a WindowTool.

In fact, the bug is caused by the missing isCompatibleWith method
in WindowTool.

[1] I3a0e761f0d6e942d503ec

Follow up: I676af9c50b09ef007926240eb2327d1a0fdd80f5

Bug: T121596
Change-Id: I9a47e5d67fcd7a94155b7cf77c734c94b0ed69e1
 2015-12-19 11:52:44 +00:00
Thalia f8fbbdf66d Make Ace Editor adjustSize method chainable 
Change-Id: I48307bd9184bb238a553d178c0d66084244e9ebf
 2015-12-19 10:57:04 +00:00
Translation updater bot c747c06759 Localisation updates from https://translatewiki.net. 
Change-Id: I6ee493d00d8fd9ad8ea4fc4efbf7513be9765d07
 2015-12-18 23:39:12 +01:00
Alex Monk c10236cc58 Preserve oldid when switching from VE into WTE 
Bug: T120898
Change-Id: I51774fd7ca5be7373d8aec55cb420a874bc7d531
 2015-12-18 00:47:03 +00:00
Translation updater bot a9637adf2d Localisation updates from https://translatewiki.net. 
Change-Id: Ic62f7e83d426f1e5872cd0597d54458d851490ad
 2015-12-17 22:46:49 +01:00
Translation updater bot 4e2d06605e Localisation updates from https://translatewiki.net. 
Change-Id: If7ed2349bec27df44a387cfca605de7e1f75873d
 2015-12-16 22:37:19 +01:00
jenkins-bot 607878e2ba Merge "MWTarget: Only add ve-init-mw-target-surface to the main target surface" 2015-12-16 20:06:33 +00:00
jenkins-bot 6b7fc00f68 Merge "DesktopArticleTarget: Change tab text on server side when possible" 2015-12-16 19:51:03 +00:00
Ed Sanders a689caa762 MWTarget: Only add ve-init-mw-target-surface to the main target surface 
Avoid adding it to TargetWidget surfaces.

Bug: T121450
Change-Id: I7c43b07c5bade3a778ad423e39b25616e03aa888
 2015-12-16 14:36:06 +00:00
jenkins-bot 46c2cafdf6 Merge "ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editing" 2015-12-16 06:44:45 +00:00
Translation updater bot b02b68626a Localisation updates from https://translatewiki.net. 
Change-Id: I2bcafc960dedf619d0c81163a7a75253b377a79d
 2015-12-15 22:25:56 +01:00
Alex Monk c99a5b627e DesktopArticleTarget: Change tab text on server side when possible 
Usually. Unless you load VE, because then you might be loading on
`action=edit` in remember-last mode and therefore the tab text needs to
be updated from "Edit source" to "Edit". Or "Create source" to "Create".
Or the equivalent with 'local description' in the case of pages from
foreign file repos, etc.

Bug: T120970
Change-Id: I8f07be6c8e415b40ad134ee82d0bda1d63cc4f96
 2015-12-15 10:49:45 -08:00
Alex Monk 76a12f2f9b Try to actually resolve visualeditor-editor preference setting when switching editors 
Seems we need to make sure this returns before navigating to the target page.
This reverts commit 40807a0743.

Bug: T121122
Change-Id: I4edf03bc0d57b03897d9f1802eabd8f0dd9962b9
 2015-12-15 17:35:22 +00:00
Ed Sanders f87d92a167 ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editing 
Otherwise temporary changes to the previewNode will pollute the original
doc's model tree.

Bug: T121488
Change-Id: I6a6b3d904061b0ce6e0c513ad424aabc3c4472b5
 2015-12-15 14:40:07 +00:00
jenkins-bot b08c8bd682 Merge "Fix up "Simplify some SET logic"" 2015-12-15 02:56:45 +00:00
Alex Monk 39af893c75 Fix up "Simplify some SET logic" 
By 'simplifying', I broke stuff.

This reverts commit b7227f96fe.

Change-Id: I46fdcf336f556680fa72df0893447b6850cc4b1d
 2015-12-15 02:50:15 +00:00
jenkins-bot d3d851f394 Merge "Simplify some SET logic" 2015-12-14 21:17:15 +00:00
Alex Monk b7227f96fe Simplify some SET logic 
Change-Id: Ie89260607f0253dd7d749af7426702985a0340f4
 2015-12-14 21:11:15 +00:00
Translation updater bot 0200bbf328 Localisation updates from https://translatewiki.net. 
Change-Id: I43deefad46e60797eda66e10c37eed67a61c141b
 2015-12-14 22:06:23 +01:00
jenkins-bot 33cbf199f1 Merge "Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set"" 2015-12-14 20:53:28 +00:00
Jforrester 40807a0743 Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" 
This reverts commit 5b083a7272.

Change-Id: Ieac905b80ea219075b4de498d645f22c3e86c5ca
 2015-12-14 20:46:08 +00:00
Bartosz Dziewoński ca81362afd ve.ui.MWMediaDialog: Make the dialog higher (600px) 
Avoids a scrollbar for option 4 of the A/B test from T120867.

Change-Id: I3eacb560117219febd6e08066599e2d4d42df219
 2015-12-14 20:53:32 +01:00
jenkins-bot d750417545 Merge "Take pageCanLoadVE into account when figuring out whether VE will load in-page or not" 2015-12-14 17:14:41 +00:00
jenkins-bot 04d8089db6 Merge "Fix setEditorPreference call" 2015-12-14 17:08:42 +00:00
Alex Monk 774034b553 Take pageCanLoadVE into account when figuring out whether VE will load in-page or not 
Bug: T121342
Change-Id: I84ade6e2ab062597fbfd859a90a864c7607547da
 2015-12-14 16:58:26 +00:00
Alex Monk a3148a1559 Fix setEditorPreference call 
Added brokenly in I82e39752

Bug: T121343
Change-Id: Ie7b228e94458b17d6ec7c23be264144dec9563be
 2015-12-14 16:49:28 +00:00
jenkins-bot 51d493918b Merge "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" 2015-12-14 16:46:02 +00:00
jenkins-bot 648457ca4c Merge "Switch numbered link context to "delete" instead of "clear"" 2015-12-14 01:19:22 +00:00
Translation updater bot a6bab3aeff Localisation updates from https://translatewiki.net. 
Change-Id: I9b6d4fa66a9a18160d5143de1ed1c6e783bd0ed3
 2015-12-13 22:24:39 +01:00
James D. Forrester 5b083a7272 DesktopArticleTarget: Don't abort in SET mode if veswitched is set 
Bug: T121122
Change-Id: I6dca85361be0c1c1c0d39b12b167af813706ae0b
 2015-12-11 18:15:25 -08:00
James D. Forrester 2368171fb7 DesktopArticleTarget: Consolidate editor preference setting code 
Change-Id: I82e3975233eee0473b513d0931a2d6770fc0f86d
 2015-12-11 17:12:28 -08:00
Alex Monk 0774bdf924 Try to clean up the WT->VE prompt opened -> closing -> closed data callbacks 
To use
	.then( function ( opened ) { return opened; } )
	.then( function ( closing ) { return closing; } )
	.then( function ( data ) {
etc. instead of nesting them in .done functions

Change-Id: Ic8cee9639b90cb378ce0b7e58dc04eab0ff4cbc7
 2015-12-11 23:43:13 +00:00
Alex Monk 155d0240a4 Remember switching into VE from WT when discarding changes 
Bug: T120966
Change-Id: I9a7b87cb2561416b72f53afa5140e9d2a4330cfe
 2015-12-11 23:35:59 +00:00
Alex Monk 9e5a01aa6b Check that we really want VE before loading it for section edits 
Bug: T121189
Change-Id: I34371bf78d34e9d362e9cf5c64bdd108478969b9
 2015-12-11 23:19:07 +00:00
Translation updater bot e71f1d67d6 Localisation updates from https://translatewiki.net. 
Change-Id: Ife97e1435802802dfeb7754fcea6874433bc6b0d
 2015-12-11 23:56:38 +01:00
jenkins-bot e24e2ed7cf Merge "[BREAKING CHANGE] Create ve.init.mw.Target base class" 2015-12-11 18:16:22 +00:00
jenkins-bot 2e6719c0d7 Merge "Use upstreamed actionGroups functionality" 2015-12-11 18:09:50 +00:00
Ed Sanders aa2e0af348 Update VE core submodule to master (19e50b7) 
New changes:
e536779 [DEPRECATING CHANGE] Rename link inspector tools
3899967 Localisation updates from https://translatewiki.net.
0a1c09e [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets

Local changes:
* Refactor tools for the breaking change

Change-Id: I676af9c50b09ef007926240eb2327d1a0fdd80f5
 2015-12-11 10:03:02 -08:00
Ed Sanders fbb05fb8ed Use upstreamed actionGroups functionality 
Depends on I272175dff3 in ve core.

Change-Id: I94cef0f3d8c1b903780890934c2c4963cbe05989
 2015-12-11 16:43:48 +00:00
Ed Sanders 21d5856000 [BREAKING CHANGE] Create ve.init.mw.Target base class 
Move over logic which isn't specific to the article
implementation of VE (e.g. nothing related to loading/saving).

Refactors setupSurface to use an abstract tracking method (which
does nothing by default), and moves surface CSS classes to #createSurface.

Breaking change:
* Rename onSurfaceReady to surfaceReady. We shouldn't need to listen
  to our own events.
* Rename onReady to documentReady. onReady is not a listener.

Bug: T97166
Change-Id: I7242b1bb5501b7755a18a13d13e166c30cac9cdd
 2015-12-11 16:41:47 +00:00
Ed Sanders 672c91f41b DesktopArticleTarget: Fix signature of editNotices 
Also ensure it is always an array.

Change-Id: I8498463d3131817b90fa91404289c839110bdeaa
 2015-12-11 16:41:47 +00:00
Alex Monk 98a456b189 Single edit tab: Fall back to the wikitext editor when certain parameters show up 
We can't handle these yet. There's also 'preview' but I think we probably
qualify as supporting that.

Bug: T121126
Change-Id: I4602992a77f460b9bfcbad0eac1bdd79d67df04d
 2015-12-10 23:13:25 +00:00
jenkins-bot 69778a65e5 Merge "Let the feedback tool be configured for a remote wiki" 2015-12-10 22:04:23 +00:00
Translation updater bot 46b901e640 Merge "Localisation updates from https://translatewiki.net." 2015-12-10 22:02:32 +00:00
Translation updater bot 536ff00e5a Localisation updates from https://translatewiki.net. 
Change-Id: Ide641aaf9ffec8558271116f9a3a29c1307ed588
 2015-12-10 23:01:35 +01:00
jenkins-bot 3db4f22ecf Merge "MWSaveDialog: De-flag the 'return to save' button on diffs" 2015-12-10 21:51:01 +00:00
James D. Forrester 705199753c Let the feedback tool be configured for a remote wiki 
Bug: T92661
Change-Id: Id48729c89db208714f67fec1eabafe577a834b51
 2015-12-10 12:12:59 -08:00
Ed Sanders 29f33a57d5 Rename mw.Target to mw.ArticleTarget 
This makes way for a base mw.Target class which is
not specific to articles (e.g. Flow boards).

Bug: T97166
Change-Id: If72650bdf87aa9f195b004da0a4d815f1a8063a3
 2015-12-10 16:26:20 +00:00
Alex Monk 128901866a Don't check editor preferences etc. if user wants veaction=edit 
Bug: T120978
Change-Id: I39e28c80440260959b7f1c25b82a057c21de43be
 2015-12-09 23:04:02 +00:00
jenkins-bot 212300af1f Merge "Avoid useless jQuery.click shortcut" 2015-12-09 22:18:12 +00:00
Translation updater bot d08da2d62f Localisation updates from https://translatewiki.net. 
Change-Id: Ibbc339a27888a391c6c40ced26c154cabb29acf7
 2015-12-09 21:43:17 +01:00
David Lynch e9fbb38818 Switch numbered link context to "delete" instead of "clear" 
Bug: T120705
Change-Id: I305a0469df8ca3fd75bcd371cf9b9f8894c09f7e
 2015-12-09 12:42:20 -06:00
Ed Sanders e7ccc77000 Edit mode switching: Tell VE if the wikitext was modified 
Currently we assume that any document state from WE is modified
but that is not necessarily the case.

Change-Id: I085825152528ae5a5e973e8b44f68cb07ee92416
 2015-12-09 17:44:43 +00:00
Ed Sanders e9250d87fd Avoid useless jQuery.click shortcut 
Why have one event API when you can have ten...

Change-Id: I645cbeb4e486aba9e734ba47d2e7c3958a694f19
 2015-12-09 17:34:00 +00:00
jenkins-bot a9894809f6 Merge "DesktopArticleTarget: Handle section edit link clicks in single edit tab mode" 2015-12-09 17:16:12 +00:00
Alex Monk b877e16723 DesktopArticleTarget: Handle section edit link clicks in single edit tab mode 
Bug: T58337
Change-Id: Ic4c19cdfc3cfcf33604d0c4e7780b45967cdf57d
 2015-12-09 09:08:46 -08:00
Ed Sanders ae26eefb05 Fix typos 
Add some common ones to typos.json

Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
 2015-12-09 16:47:13 +00:00
jenkins-bot 6c1e613fa4 Merge "Make clear button on numbered external links remove the node" 2015-12-09 16:26:29 +00:00
jenkins-bot 87ce2f0a20 Merge "EducationPopup: Increase z-index above toolbar dialog's" 2015-12-09 16:26:26 +00:00
David Lynch 7b66083319 Make clear button on numbered external links remove the node 
Bug: T120705
Change-Id: I07d57ba95f46f0fa80f9038ccb42d8d89375fd23
 2015-12-09 10:11:54 -06:00
Ed Sanders 1121dc5295 EducationPopup: Increase z-index above toolbar dialog's 
Bug: T116577
Change-Id: Icb91dcebd450f954b8bae18ee57f75386de754ac
 2015-12-09 15:56:08 +00:00
jenkins-bot 2efbdc670c Merge "Single edit tab and section links" 2015-12-09 00:40:46 +00:00
Ed Sanders 4513283140 ve.ui.Icons.css: Fix inpsector typo 
Change-Id: I9cb7f6ff38e26632d04a1ffc65ae468a5ee301cc
 2015-12-09 00:18:46 +00:00
James D. Forrester ccc087c461 MWSaveDialog: De-flag the 'return to save' button on diffs 
Change-Id: Icb7c07dae23b7f3ba1b4cdf6c73f17a1bbff1bdf
 2015-12-08 13:31:44 -08:00
Translation updater bot ce89f917df Localisation updates from https://translatewiki.net. 
Change-Id: Ie88cfc5d6f943fb52e25c0dd54fe907120dec972
 2015-12-08 22:26:41 +01:00
Alex Monk 748db015b0 Single edit tab and section links 
In addition to the couple of TODOs inline, we should do the following in
follow-up commits:
* Prevent FOUC due to changing things only on the client
* Make section link behaviour sensible

Bug: T58337
Change-Id: I65d966270491ffe017cb11a0daa915628fadf65c
 2015-12-08 17:47:16 +00:00
Translation updater bot bd5a6242f1 Localisation updates from https://translatewiki.net. 
Change-Id: I251067f1f7b60e3972f725aa192f2cb90178dc8d
 2015-12-07 23:16:10 +01:00
jenkins-bot 4be9c9178e Merge "MWTemplatePage: Re-word the no-description text to reflect being always there" 2015-12-07 22:07:17 +00:00
Bartosz Dziewoński ae8a275095 MWTemplatePage: Re-word the no-description text to reflect being always there 
The <visualeditor-dialog-transclusion-no-template-description> message
is now always displayed in template transclusion dialog, both when
adding a new one and when editing existing one. I think it's best to
just remove the incorrect part, as the dialog provides sufficient
context for what is happening.

The $2 parameter is no longer used or documented, but is still
supported for compatibility with existing translations.

Bug: T87130
Change-Id: Ibaa06c3bb1e9afbf0005b1605236f4be8cb15251
 2015-12-07 21:59:03 +00:00
jenkins-bot db7bec4825 Merge "MediaDialog: Remove useless empty object arg to media size widget" 2015-12-07 19:21:11 +00:00
Ed Sanders a917871505 GalleryInspector: Use namespace id constant 
Change-Id: Ia51634e84cf984d8ed4ecdab87590111bf12478f
 2015-12-07 18:49:53 +00:00
Ed Sanders 557eb4fe84 MediaDialog: Remove useless empty object arg to media size widget 
Change-Id: Id85498616f80147cd856d4d12bf5a0e58ad66029
 2015-12-07 14:12:56 +00:00
Translation updater bot 83620175ca Localisation updates from https://translatewiki.net. 
Change-Id: I3d109b133ee6d709a937013bb9eb825800c98775
 2015-12-06 21:45:56 +01:00
Translation updater bot db13a4d43a Localisation updates from https://translatewiki.net. 
Change-Id: I0d6dede3ef71b7729db66646875c308d50296d81
 2015-12-05 23:16:10 +01:00
Ed Sanders 63184600d4 Use wgNamespaceIds constants instead of hard-coded numbers 
Change-Id: I71b80e59a5e24d63e68637a1ae8422974643bd3a
 2015-12-04 19:57:56 +00:00
Translation updater bot 6ceb0c39e6 Localisation updates from https://translatewiki.net. 
Change-Id: Ie307b6e81958bb16c96a0ffff6b3568139564f4f
 2015-12-03 23:17:58 +01:00
James D. Forrester 3c9a361da0 MWMediaDialog: Add a margin back to the border checkbox 
This was removed upstream in OOUI as unecessary in general, but clearly
this was the place for which the rule had been designed. :-)

Bug: T119547
Change-Id: I46a1df1141c337b436e66872f1a8cdae026816cd
 2015-12-02 18:28:18 -08:00
Translation updater bot 7e50ac1ab6 Localisation updates from https://translatewiki.net. 
Change-Id: I2180bc4edca07261381b2790af6ebc29e0fde97f
 2015-12-02 22:01:03 +01:00
Translation updater bot d924ded91e Localisation updates from https://translatewiki.net. 
Change-Id: Ia694075416ebb62d351441419089d2570943ccf8
 2015-12-01 21:37:34 +01:00
Translation updater bot 3772e473d5 Localisation updates from https://translatewiki.net. 
Change-Id: I4133263c6d9228e867cb54be4b706e8f21a2bbc1
 2015-11-30 21:38:08 +01:00
jenkins-bot e24eaea22c Merge "Avoid embedding Git metadata in ext.visualEditor.data" 2015-11-30 11:48:28 +00:00
Ori Livneh b1db8349fe Avoid embedding Git metadata in ext.visualEditor.data 
Partially reverts "Expose version information in the client" (a72099af66 / I7836e1d40).
The Git data oscillates between two values due to differences between the
staging and production environments. Each change causes the module version to
change also, leading to cache churn.

Instead fetch version information with an API call the first
time the help popup is opened.

Bug: T119750
Change-Id: Ib9c45e60d3164cfa85eb1ef247cc91cf0d8bf954
 2015-11-30 12:34:56 +01:00
Translation updater bot 24046cb548 Localisation updates from https://translatewiki.net. 
Change-Id: I24ccb4b7af6241ed77eb47970d821262454ac26e
 2015-11-28 21:49:42 +01:00
Translation updater bot 1b176cba81 Localisation updates from https://translatewiki.net. 
Change-Id: I459d7ee237ffa2ba146bbd82059e5e22f92234b5
 2015-11-27 22:48:54 +01:00
Translation updater bot b367964ad6 Localisation updates from https://translatewiki.net. 
Change-Id: I57f93b07e2179ec7cbb75866094dd98f64b54f9c
 2015-11-26 22:06:32 +01:00
jenkins-bot 2a46cc7873 Merge "Add autocomplete options to AceEditorWidget config options" 2015-11-25 03:48:38 +00:00
Thalia 3d98b1d291 Add autocomplete options to AceEditorWidget config options 
Bug: T119549
Change-Id: I57db44c876c5cb0487bda6a72e36fedaccb532b5
 2015-11-24 19:44:41 -08:00
jenkins-bot 4655ba4c5c Merge "MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one" 2015-11-25 02:53:36 +00:00
James D. Forrester b68e34fdeb MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one 
Depends on If4ec151a in OOUI.

Bug: T111100
Change-Id: I90af27a7ba881c588b8a432f1cc1e54ab4c80f79
 2015-11-24 18:40:13 -08:00
Translation updater bot 0bfa4b7001 Localisation updates from https://translatewiki.net. 
Change-Id: I4894709e82769d5161cf39a6488ae1666d5690d6
 2015-11-24 23:12:39 +01:00
Ed Sanders bbdb48abdf Create MWPreviewElement which adds the mw-body-content class 
This fixes some rendering issues, and also increases the font
size of reference contexts from 12.8px (interface) to 14px (content).

Bug: T119430
Change-Id: Ib1bae8cd4cfe86903d78406a33db78e1489fde86
 2015-11-23 14:28:57 -08:00
Translation updater bot 23270f87f9 Localisation updates from https://translatewiki.net. 
Change-Id: I045fa54ee959371101a2fc62238d8b10ccb348b0
 2015-11-23 22:36:41 +01:00
jenkins-bot 22a8c76d09 Merge "When adding a label to a numbered link, force the selection" 2015-11-23 19:02:04 +00:00