wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-04 18:58:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
21374 commits 14 branches 17 tags 199 MiB
Commit graph

78 commits

Author SHA1 Message Date
Ed Sanders dbc696124f ESLint: Enforce no-var and autofix 
Temporarily disable prefer-const as this requires
manual fixing.

Change-Id: I477b69a57e8d33535c6fc71dba196a8605780725
 2024-05-21 17:40:52 +01:00
Ed Sanders eb757c4c9f Remove unnecessary context binding when using arrow functions 
Change-Id: Ie25e90aeb0519b1e0f793348b27d4d4a6b686698
 2024-05-03 12:47:47 +01:00
Ed Sanders e3659d4846 Prefer arrow callbacks 
Change-Id: Ia05b27f7c71c33580ffd0718e3bbc673dd8b3d63
 2024-05-01 14:11:54 +01:00
Ed Sanders fd122da6fd JSDoc: @mixins -> @mixes 
Change-Id: Ic06b8e058b387f8d683db6273f689694cf416ce6
 2024-04-29 18:51:41 +01:00
Ed Sanders d42a0772bb Move verbose copyright message to AUTHORS.txt 
Avoids having to update the date in every file every year,
which we stopped doing.

Change-Id: I7bf7aa0937eef911e00772470091753a7b06fd3d
 2023-12-01 16:07:39 +00:00
Ed Sanders 3801aa1bac Move var declarations inline 
Change-Id: I12639c515e33b3d9e7a819581b5022ea42fd7046
 2021-10-13 14:02:31 +01:00
Thiemo Kreuz 26b0322ff0 Minor documentation updates in template related classes 
Bug: T285483
Change-Id: I1cf17d7bfb01326b93bc781b2501a492d50f0aab
 2021-06-25 16:46:59 +02:00
James D. Forrester 2c77e88d2c doc: Bump copyright year for 2020 
Change-Id: I30539877543dc2a57bd1428a00d10ac46d8fc294
 2020-01-08 09:13:24 -08:00
David Chan 22098d6b16 Convert $.Deferred() to ve.createDeferred(), except in preinit 
Follow-up to a8e07e026dea4f54241d1dbb6b7bcdbd8c670db2 in core.

Change-Id: I09333adb4876c6e584a4a6b6a1628227c4cd2616
 2019-11-02 13:06:28 +08:00
Ed Sanders 89ecd64a55 Make extension body the default description for extension nodes 
Change-Id: Ifada2a6a0279e64a1ba82f49e03884e362516a83
 2019-07-31 16:38:27 +01:00
James D. Forrester 3c293ea00c doc: Bump copyright year for 2019 
Change-Id: I8991b97c980d4149f53eb5601036220ef3c0c440
 2019-01-01 13:24:23 +00:00
Ed Sanders f2a9ccd5bd Avoid HTML string parsing 
Identified using https://github.com/wikimedia/eslint-plugin-jquery/pull/12

Change-Id: I138e018fdc037d688e055eacddfdc5bfc2cc5abe
 2018-11-21 18:47:19 +00:00
Thalia bbed4307d7 Separate node classes into individual files 
Bug: T205231
Change-Id: I84a6f2f7a842ab44e1f7103c0f288deda0451e79
 2018-09-24 12:44:45 +01:00
Ed Sanders 16211cdc09 Abstract API calls to 'parsefragment' 
Change-Id: Id0be3207219a6d93cebff2b6b5061cd24898d5cb
 2018-04-06 13:49:16 +01:00
Ed Sanders 78ba8bbe3c Use OOUI 'markup' icon instead of local 'alienextension' 
Change-Id: Id15596ab0013cb2078480bdb4dde25ef8e7ae50b
 2018-03-20 17:27:54 +00:00
James D. Forrester 0a7a845a42 doc: Bump copyright year 
Change-Id: I0b299c840ede1a1b8552cecfc70c5760ab036181
 2018-01-03 17:45:07 +00:00
Ed Sanders 1b8f8d8908 Replace wg(Relevant)PageName with target#pageName 
The default value of target#pageName is wgRelevantPageName
but other targets my override this, or change it dynamically
(e.g. ContentTranslation).

Also remove duplicate setter of pageName in mw.ArticleTarget,
already set in mw.Target.

Change-Id: Iebd1def1d4142978a673afec584a0b663644d176
 2017-09-26 13:22:00 +01:00
Ed Sanders 8fb56b8d75 Give extensions a fallback icon when invisible 
Bug: T166526
Change-Id: I5eafbef3b751a83cef353c8a9f09d90820fa9409
 2017-06-07 22:29:19 +01:00
Ed Sanders a5e44034fb Guard against mwdata.body being null 
Bug: T166754
Change-Id: I3b887a3a6ee81ca3fd0b242fadc8b833b9031b50
 2017-06-01 14:01:23 +01:00
James D. Forrester 8463524e18 MWSaveDialog: Run links through a render function for preview & visual diff 
Provide a utility funcition in ve.init.mw.LinkCache to do this.

Also use this in ve.ce.MWTransclusionNode/ve.ui.MWPreviewElement, and
introduce to ve.ce.MWExtenionNode

Bug: T73900
Bug: T153535
Change-Id: Ieb9a0274b8c5ae1932c431546f09d18000fa6dd9
 2017-03-31 10:51:35 +01:00
James D. Forrester 122f49b2dd build: Bump file copyright notices for 2017 
Change-Id: I3c20809e71cc0da58123e1b5f29c4f3aac945496
 2017-01-03 08:58:33 -08:00
Ed Sanders e655880d14 eslint: Remove unused exception and fix documentation errors 
Don't enable valid-jsdoc yet though, due to @chainable bug.

Change-Id: I4d2a6de19c72c6e4c20733446616d8046419d431
 2016-10-28 12:02:36 -07:00
Tpt 8ccbb58ca6 MWExtensionNode#generateContents: Fix renderEmpty logic 
This static attribute is not used anywhere so it should be safe

Change-Id: I633c521859b59614835344a4644560ac933c6028
 2016-04-02 07:58:33 +00:00
Ed Sanders 5864a62134 Default extensions to not use the 'invisible icon' 
Bug: T125767
Change-Id: I58c58080382974a887ebc52c1ac80cb5970db8c7
 2016-02-04 19:38:16 +00:00
Ed Sanders 98bc5daba1 Use new iconWhenInvisible feature in Transclusion/Extenion nodes 
Change-Id: Iba55676c06a1cd625187c38c1ae0c9c20b065827
Depends-On: I127bb5d34850cdc545ea3c05d0fc41a8ae1c6dea
 2016-02-02 18:07:13 +00:00
James D. Forrester ada58df361 build: Bump file copyright notices for 2016 
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
 2016-01-03 14:57:25 -08:00
Ed Sanders d63dce138d MWExtensionNode: Fix selector to find dimension-less images 
Change-Id: Idf219636f9b2b58e30b1a155c052ada4c60e6ec9
 2015-10-02 14:18:13 +01:00
Ed Sanders 50de745afd MWExtensionNode: Copy mw data before modifying 
Otherwise we are directly modifying model.element.attributes
which is very bad.

Change-Id: Icf066a5848b9c67c2c4b3fcafd72d0142996e48d
 2015-10-01 13:34:01 +01:00
jenkins-bot 1b455ac201 Merge "Call afterRender whether or not images emit 'load'" 2015-09-30 21:00:13 +00:00
Thalia 53f4aa64d9 Call afterRender whether or not images emit 'load' 
MWExtensionNodes currently don't call afterRender if the image
is already loaded, which can happen if we decide not to rerender
after an update (e.g. when the response is an error).

Change-Id: Ic9c11e446a7cc789bb20680466709ff2ad5cb22e
 2015-09-30 21:47:40 +01:00
Ed Sanders 074f7bcefe Follow-up If556afa10: Fix typo: nodeType -> nodeName 
Change-Id: I19915647981787f7bbf2c86fc7bd02308d5da218
 2015-09-29 17:35:23 +01:00
Roan Kattouw 0d4b30f927 MWInlineExtensionNode: Don't assume responses are always <p>-wrapper 
For the Score extension they aren't, and this causes JS errors in production.

Change-Id: If556afa1046f460d7fdd29cb1c50ac93dad88fde
 2015-09-28 19:36:48 -07:00
Ed Sanders 519e029298 Rerender extension node immediately if no images exist 
Bonus: Filter out images which already have width/height defined

Bug: T110314
Change-Id: I9fbd5050bb5d10c9c24a2b761f6248da8179bf72
 2015-09-01 09:50:58 +00:00
James D. Forrester f5c6f61163 build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass 
Change-Id: I846d36c15e1b1f810d2ef7fd422f8412790bcb0f
 2015-08-19 10:33:02 -07:00
Ed Sanders 160a673e7c Omit extension attributes with an undefined value 
Change-Id: I0abad51eb392644159d1845ef3a35986dc5cb79b
 2015-06-08 16:03:47 +01:00
Roan Kattouw 95bffa22a0 Stop using this.$ 
Has been a backwards-compatibility alias since OOjs UI 0.7.0.

Change-Id: I17d7c03e9d1b9fa991d88444d22abfd403269ee0
 2015-04-14 02:54:01 +01:00
Ed Sanders fdcd42f73a Split AlienExtensionNode into inline and block 
MWExtensionNode:
* Inherit from LeafNode at the top level. Inline and block only
  differ in CE where inline has isContent set.

MWAlienExtensionNode:
* Inhert from MW(Inline|Block)ExtensionNode respectively. Both
  mixin MWAlienExtensionNode.

Bonus:
* Bring in paragraph unwrapping on inline nodes from MWMathNode

Bug: T93712
Change-Id: Ib04234f740cf1f27c861d8b3cfeea5e323b94678
 2015-04-09 16:32:02 +01:00
Roan Kattouw 6648f94982 Remove useless ve-ce-mw*Node classes from GCN subclasses 
Since GCN aggressively modifies this.$element, these classes
didn't survive for very long, and they weren't being used
anyway.

Change-Id: I6e9827499374941fbded983956c57cc250d957c8
 2015-03-09 12:05:30 +01:00
Alex Monk 8e48f94580 Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target 
Bug: T58659
Bug: T89435
Change-Id: I18162f04c50f48606378aed62ee99fccdc3159f6
 2015-02-25 01:57:22 +00:00
James D. Forrester bed038b509 build: Bump devDependencies to latest 
Updates:
* grunt-contrib-csslint  0.3.1  ->  0.4.0
* grunt-contrib-jslint   0.10.0 -> 0.11.0
* grunt-jscs             0.8.1  ->  1.2.0

For jscs, leaving requireSpacesInsideArrayBrackets to avoid headaches for now.

Change-Id: I62d34444edbba65c8bd22d2fa5e50e16cabb0042
 2015-02-02 14:30:39 -08:00
James D. Forrester 2f8b3e0d96 build: Bump copyright notices to 2015 
Change-Id: Ie92dab7411116d3410195c3fb0a3513c664c0c30
 2015-01-12 20:34:19 -08:00
Timo Tijhof 2b7ae8c175 Remove use of bind() for inline functions 
Follows-up b0e8900, 447e8de, d3f26e65.

Contrary to binding a reference, this-overiddes for inline
functions gets messy and fragile. There's also a minor
performance overhead that can be avoided. No separation of
concerns, eiter, as the object is held by the closure.

Also:
* Remove left-over instances of @method.
* Remove redundant '0' argument to setTimeout.
* Use null instead of $ for apply() on static methods like $.when.
* Use .empty().append() instead of .html(). Does the same but
  without additional overhead and without confusion association
  with "html" which isn't used (it doesn't serialise and re-parse
  or clone, it just appends when given one or more nodes).

Change-Id: I797a3667c67d52568150be9be5d043d149f22077
 2014-12-16 23:27:53 +00:00
James D. Forrester a232147b11 Switch 'disallowQuotedKeysInObjects' jscs rule on and fix up 
Change-Id: I75ac4b378ef485feead9d0eff34ed7877b94b5d0
 2014-08-22 13:50:48 -07:00
Ed Sanders 5e5755f09c Implement getFocusableNode for MWGallery nodes 
Instead of using ve-ce-noHighlight we can just set and maintain
this.$focusable using getFocusableNode.

Change-Id: I0a6b2d6444df531b7c235ac9ff08a3ed8a0e99b3
 2014-07-26 02:24:56 +00:00
James D. Forrester c2f37a0450 test: Move mw into the global list of globals for VE-MW 
Silly to have 38 MW-specific files needing to declare that they're using mw.

Change-Id: I97891ed922fe0c37d8c96425a4d23bd15098438b
 2014-07-19 17:42:45 +00:00
jenkins-bot a7f9e955c6 Merge "ve.ce.MWExtensionNode: Don't escape content of wikitext tags on preview" 2014-07-15 22:09:10 +00:00
Alex Monk 51142e8b11 Replace ve.bind( fn, ... ) calls with fn.bind( ... ) 
Bug: 62762
Change-Id: I1a7fc7f27fa737d17f5c6b3d084ef4a35e4bebc0
 2014-07-10 13:54:07 +00:00
Bartosz Dziewoński 68f561d2ad ve.ce.MWExtensionNode: Don't escape content of wikitext tags on preview 
XML-like tags in wikitext are not actually XML and don't expect their
contents to be escaped. The contents are usually not parsed as
HTML/XML anyway.

It means that it is not possible for a tag '<foo>…</foo>' to contain
the string '</foo>', but that is prevented by change Ia566452a.

Bug: 57429
Change-Id: I2516a897c85b4a3b79a34ff6cad5d124fbc30170
 2014-07-04 18:13:36 +02:00
Ed Sanders 41672be584 Update VE core submodule to master (dc01df0) 
New changes:
d02cf3d Fix simulation of .prepend() in ve.ce.BranchNode#onSplice
c19fa38 [BREAKING CHANGE] Remove generated content node wrappers

Local changes to remove classes attached to GC nodes

Change-Id: Ide82c96db4803ef59d398788b46fa5d7fb9a2476
 2014-06-30 16:34:56 -07:00
Ed Sanders 42cad57fb2 Render a placeholder when extension contents are empty 
Helps the context to find a position and shows an insertion point.

Bug: 66813
Change-Id: Ifbf5271a4f36f04256bb4c02d9120cc76012fc79
 2014-06-25 17:01:20 +01:00