jenkins-bot
b3cc892dad
Merge "ve.init.mw.DesktopArticleTarget: Handle deactivate on namespace tab when it's a talk namespace"
2018-09-13 19:20:04 +00:00
jenkins-bot
f8ab6b188e
Merge "ui.MWParameterPage: multiline inputs for line
if newlines already present"
2018-09-13 12:02:47 +00:00
Bartosz Dziewoński
bb5762a0b2
ve.init.mw.DesktopArticleTarget: Handle deactivate on namespace tab when it's a talk namespace
...
Turns out, talk namespaces are special.
Bug: T204194
Change-Id: Ie9af128edd5874075098f8593e01595da863102d
2018-09-13 11:04:47 +02:00
jenkins-bot
1bea2d1eb8
Merge "Revert "Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init"""
2018-09-12 22:05:46 +00:00
jenkins-bot
6a1b16f20c
Merge "Replace deprecated 'advanced' by renamed to 'settings' icon"
2018-09-12 17:26:09 +00:00
David Lynch
d30e6925bf
ui.MWParameterPage: multiline inputs for line
if newlines already present
...
TemplateData doesn't always match up with the way the template is being used.
If a field has the `line` type, but is provided with newlines, we should avoid
mangling it by forcing it into a single-line field. As-is, any edit to the
template, even if the user only thinks they touched unrelated parameters,
would cause this.
Bug: T190191
Change-Id: I4f2a0b6c46532dcc268288cb209d0260b18f3ad7
2018-09-12 12:01:03 -05:00
jenkins-bot
df253967e1
Merge "DesktopArticleTarget.init: Pass platform to ve.track directly"
2018-09-12 14:20:43 +00:00
Volker E
40b8c0da5c
Replace deprecated 'advanced' by renamed to 'settings' icon
...
Bug: T190581
Change-Id: Ie598c703ca03adb98ca05ed3ab227aba2b5ab971
2018-09-07 19:46:12 -07:00
David Lynch
627128f1ae
DesktopArticleTarget.init: Pass platform to ve.track directly
...
ve.track tries to guess the platform, but it needs a loaded Target to do so,
and init happens before that.
Also, log a warning when this happens, in case it comes up again.
Bug: T203618
Change-Id: I35fa58a42cd247e01f3717c9ab3a10d8ea93a484
2018-09-06 10:52:46 -05:00
Ed Sanders
6396fad416
Release editWarning unload event when switching from old wikitext to VE
...
Bug: T202587
Change-Id: I81ff882e0e4ccf0b26d73be5f55cbf2da0d97a47
2018-09-06 14:13:55 +01:00
jenkins-bot
4dafa321a9
Merge "Cleanup setEditorPreference: Always return promises, never deferreds."
2018-09-04 16:25:45 +00:00
Esanders
a21e95b67a
Revert "Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init""
...
Re-enable tests, but disable setEditorPreference API calls in setup.
This reverts commit d5fe71fd6e
.
Change-Id: Ib6f0f18acc1ccb40cb6c055609dc1484b381bc8f
2018-09-04 13:45:52 +01:00
Ed Sanders
8ac5a03a05
Cleanup setEditorPreference: Always return promises, never deferreds.
...
Change-Id: I59a5fdc29ee64abe422610da835e6f089ad7267a
2018-09-04 13:45:52 +01:00
jenkins-bot
05dae065c9
Merge "Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init""
2018-09-03 22:56:52 +00:00
Bartosz Dziewoński
d5fe71fd6e
Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init"
...
Causes random failures in other unit tests due to API requests.
This reverts commit 031d2dd50e
.
Bug: T203412
Change-Id: Ia94b090687ba8d6023060e6dbe10b6a45035e76a
2018-09-03 22:39:27 +00:00
Bartosz Dziewoński
efd1a957f5
Remove unnecessary "eslint-disable-next-line new-cap"
...
Change-Id: I94f31ef934f9a0192ac906cada5dba05214d259e
2018-09-03 23:11:29 +02:00
jenkins-bot
31ee84540b
Merge "Follow-up I38eda4a: Add unit tests for lang/dir in target init"
2018-09-03 16:18:46 +00:00
jenkins-bot
15df919bc1
Merge "Replace jQuery.grep with Array.prototype.filter"
2018-09-03 15:40:49 +00:00
jenkins-bot
3023ca8e90
Merge "Match width of template lookupMenu to input"
2018-09-03 15:40:44 +00:00
jenkins-bot
3f55b7432e
Merge "Fix: Apply placeholder colour style to first child, not parent"
2018-09-03 15:06:51 +00:00
jenkins-bot
4914787e62
Merge "Don't assume commandGroup has a demote property set"
2018-08-31 23:31:45 +00:00
Ed Sanders
222ad828bd
Don't assume commandGroup has a demote property set
...
Bug: T203282
Change-Id: Ic67dcfb2a473559d5e5d457072cda101844fe1e9
2018-08-31 22:20:36 +01:00
jenkins-bot
048ac8193e
Merge "Remove unnecessary IE10 blacklist"
2018-08-31 18:30:07 +00:00
Ed Sanders
ed047b6cdd
Fix: Apply placeholder colour style to first child, not parent
...
This ensures any colour applied to branch nodes is overridden.
Change-Id: Ib6f5d2509021ba0ba085050bc1fe993e7d887b3e
2018-08-31 16:59:54 +01:00
Ed Sanders
031d2dd50e
Follow-up I38eda4a: Add unit tests for lang/dir in target init
...
Change-Id: I426f88ce3982deb850c4cedb110b87c9a59157ef
2018-08-31 14:45:54 +01:00
Ed Sanders
22f3075b52
Fix typo in mw.Target#setupSurface
...
Bug: T203213
Change-Id: I38eda4aac48b3363c6211e225b8f0cadf6b40853
2018-08-31 13:16:21 +01:00
Ed Sanders
10ce48a57e
Remove unnecessary IE10 blacklist
...
IE10 support was dropped from MediaWiki core in 1.31.
Change-Id: I1c8c790428df5afe019e10a65ba5e891f5895dfb
2018-08-30 19:01:59 +01:00
Ed Sanders
76d0b95af3
Re-order MWCommandHelpDialog and promote/demote insert tools
...
Change-Id: I3ac4e556e06e2ab899d8bc07ca79d847146952e6
Depends-On: Ic12bc1c3ac96a1feb79e277e65aaf2d29af4f03f
2018-08-29 10:51:00 +00:00
jenkins-bot
919f74f10b
Merge "Don't wait for surface to blur before hiding pageToolbar"
2018-08-29 01:58:14 +00:00
Ed Sanders
eea7b93895
Don't wait for surface to blur before hiding pageToolbar
...
Bug: T202986
Change-Id: Ia25dd7aab7c72f6888fab1fcec0185fe0b4111b5
2018-08-28 12:08:09 +00:00
jenkins-bot
bf9d3c1b06
Merge "Template dialog: Lazy resize multiline text inputs on first focus"
2018-08-27 20:43:38 +00:00
Ed Sanders
1703cc6361
Move link styling into overridable method for CX
...
Change-Id: I5c349d15ecc0df29827d41c9cc408bb826924447
2018-08-27 12:26:05 +01:00
jenkins-bot
c09c9a408a
Merge "Update VE core submodule to master (e69a4a07c)"
2018-08-25 22:13:19 +00:00
Ed Sanders
7bf56a3bd4
Update VE core submodule to master (e69a4a07c)
...
New changes:
3b62827b8 Remove negative margin from mobile context action buttons
694705894 Implement a simple notification system to fill in for mw.notify
461283560 Validate history start when applying/unapplying change
Bug: T202514
Change-Id: I203dc5101bc31988df2d3986da4300a318e5e889
2018-08-25 18:08:48 +01:00
Ed Sanders
e67f870922
Fixup Ie40baad: Avoid triggering surfaceReady when adding dummy surface
...
Change-Id: I01f77633a11c6c5b8d484836940ea10b975c7a9e
2018-08-25 18:06:37 +01:00
jenkins-bot
99485b7cbb
Merge "Cleanup: Get rid of surfaceReady callback"
2018-08-25 13:48:37 +00:00
Ed Sanders
07e05c7954
Cleanup: Get rid of surfaceReady callback
...
Just call the method after surface init.
Also move all the post-dm building code into
an #addSurface override.
Change-Id: Ie40baadfa6cd826a92f8fb7d928f4d995286f69f
2018-08-25 14:04:00 +01:00
petarpetkovic
30f099382a
Replace jQuery.grep with Array.prototype.filter
...
Change-Id: I912fb68060d88b618cb2a2502417c1bccc5fecec
2018-08-25 00:11:30 +02:00
Ed Sanders
23ec1973d8
Match width of template lookupMenu to input
...
Bug: T196117
Change-Id: I58909b2f0138b512df03a8990d3c19cb0b184cad
2018-08-24 14:22:00 +01:00
Ed Sanders
0f81aae133
Template dialog: Lazy resize multiline text inputs on first focus
...
Bug: T134814
Bug: T200834
Change-Id: I3ec84ad01db1ed896c41ac8ef38cce8eddb0b8c2
2018-08-23 17:34:25 +01:00
Ed Sanders
8f49bb391a
WelcomeDialog: Check at least one editor is available
...
Bug: T201928
Change-Id: Ibac6cf921fdc3daba2d671d9bd668fa7bcb9e7a2
2018-08-23 14:21:40 +01:00
David Lynch
26f6429702
TemplateStyles support
...
MWTransclusionNode will preserve TemplateData <style> in its generated content.
Disable TemplateStyles stylesheets in the original page content, and reenable
them when the surface deactivates.
Remaining TODO: if multiple copies of a template with deduplicated styles are
on the page, and the one containing the actual <style> is removed, all will
lose their styling.
Bug: T197563
Change-Id: Ibd8939eef7d8eb532719f4ee0ce200600449ef81
Depends-On: Ia9f2afcdba5456238e3ef444c202c9b0c78838bf
2018-08-22 17:03:27 +00:00
Bartosz Dziewoński
1481f70b9e
ve.ui.MWSettingsPage: Fix missing icon (renamed in OOUI)
...
Bug: T202101
Change-Id: I3ed199269e1f4452739628ae8d51a04fb911cc04
2018-08-21 00:26:01 +02:00
jenkins-bot
9498b6a72b
Merge "Export to page using action=submit"
2018-08-19 12:02:48 +00:00
Ed Sanders
cb10316a7b
Export to page using action=submit
...
Change-Id: I0d719905203d24a545d9b7dcea5bb9d032f10a76
2018-08-19 11:25:17 +00:00
jenkins-bot
e6d89cd1ec
Merge "Show signatures in NWE visual diff"
2018-08-17 13:29:41 +00:00
jenkins-bot
4d78073001
Merge "Replace 'settings' by renamed 'pageSettings' icon"
2018-08-17 00:28:05 +00:00
Volker E
07f58084cd
Replace 'settings' by renamed 'pageSettings' icon
...
Bug: T190581
Change-Id: Ie0307ebc16d516463302773ef4226f2ba2dbd16c
2018-08-16 17:00:38 -07:00
Ed Sanders
20662e6dde
Fix icons broken by OOUI update
...
Change-Id: I44edf30dc578787935c0052e8675bfde7fdd746d
2018-08-16 22:41:31 +01:00
Thalia
4a1d52ccb3
Show signatures in NWE visual diff
...
Parse document with pre-save transform for the diff.
Bug: T184166
Change-Id: Iffc9ed8ba88dcb55bef73f1708118663b0c38068
2018-08-16 21:45:28 +01:00