wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 06:24:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

ve.init.mw.DesktopArticleTarget: Handle deactivate on namespace tab when it's a talk namespace

Browse source 
Turns out, talk namespaces are special.

Bug: T204194
Change-Id: Ie9af128edd5874075098f8593e01595da863102d
This commit is contained in:
Bartosz Dziewoński 2018-09-13 11:04:47 +02:00
parent 1ffc627532
commit bb5762a0b2
1 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
View file

@ -1103,17 +1103,26 @@ ve.init.mw.DesktopArticleTarget.prototype.editSource = function () {
* @method
*/
ve.init.mw.DesktopArticleTarget.prototype.setupSkinTabs = function () {
var namespaceKey;
var namespaceNumber, namespaceName, isTalkNamespace, namespaceKey, namespaceTabId;
if ( this.isViewPage ) {
// Mimics getNamespaceKey in Title.php
namespaceKey = mw.config.get( 'wgCanonicalNamespace' ).toLowerCase() || 'main';
namespaceNumber = mw.config.get( 'wgNamespaceNumber' );
namespaceName = mw.config.get( 'wgCanonicalNamespace' );
// MWNamespace::isTalk()
isTalkNamespace = namespaceNumber > 0 && namespaceNumber % 2 !== 0;
// Title::getNamespaceKey()
namespaceKey = namespaceName.toLowerCase() || 'main';
if ( namespaceKey === 'file' ) {
namespaceKey = 'image';
}
// SkinTemplate::buildContentNavigationUrls()
if ( isTalkNamespace ) {
namespaceTabId = 'ca-talk';
} else {
namespaceTabId = 'ca-nstab-' + namespaceKey;
}
// Allow instant switching back to view mode, without refresh
$( '#ca-view a, #ca-nstab-' + namespaceKey + ' a' )
$( '#ca-view a, #' + namespaceTabId + ' a' )
.on( 'click.ve-target', this.onViewTabClick.bind( this ) );
}
mw.hook( 've.skinTabSetupComplete' ).fire();