Commit graph

17165 commits

Author SHA1 Message Date
Ed Sanders 4b9ad322ea CollabTarget: Fix focus of authorList
Change-Id: I91e4fb75af6b65df9da2d8b2f7277e685d54d0f8
2020-12-04 17:59:48 +00:00
jenkins-bot b4c26620e1 Merge "Send EventLogging when adding template parameters" 2020-12-04 17:09:28 +00:00
jenkins-bot 18be32a9dd Merge "Send EventLogging when editing parameter values" 2020-12-04 17:06:22 +00:00
jenkins-bot 4e436dc2ea Merge "Send an event when the template doc link is clicked" 2020-12-04 16:50:49 +00:00
Ed Sanders 9c926903a0 CollabTarget: Add missing message
Change-Id: I162ea3de02b902d9076f9656b9fe872adf85cd86
2020-12-04 14:43:45 +00:00
jenkins-bot 2cba844265 Merge "ve.dm.MWInlineImageNode: Alienate malformed figures" 2020-12-03 11:49:46 +00:00
Translation updater bot d89bfcc7e6 Localisation updates from https://translatewiki.net.
Change-Id: I3dc9be992b558ee22b3770983498326ab75fd655
2020-12-03 08:33:36 +01:00
Thiemo Kreuz fb0e33f987 Fix incomplete return in DesktopArticleTarget.tryTeardown()
If a teardown has started, there should be a teardownPromise,
otherwise return a rejected promise.

Bug: T268358
Change-Id: Ia5cbd6b409a38f97243234ea7c87d24f71bdf3d6
2020-12-02 21:22:10 +00:00
Ed Sanders 3e6d5c6817 Remove upstreamed clearfix
Change-Id: I9c5c56bd8a30b96b43fe680bcc8a7151de5f78be
Depends-On: I840ecdf2cfd3f4fba51418199346164fd0c439b6
2020-12-02 21:21:49 +00:00
Bartosz Dziewoński f50e4f3182 Update VE core submodule to master (b615c2e21)
New changes:
61cd9ac49 Improve appearance of images in diffs
b615c2e21 Upstream diffElement clearfix

Bug: T187687
Change-Id: Idffab14484592ed67255cb38eefc58803a7450f8
2020-12-02 22:20:48 +01:00
Translation updater bot ba32f591b3 Localisation updates from https://translatewiki.net.
Change-Id: I6a01471c57e0fc74173dadcb08252e150866bc11
2020-12-02 08:33:23 +01:00
James D. Forrester 688edf1d64 build: Use "Grade A" rules for stylelint
Change-Id: I54b16407450960fefd5522a25cb733853d2f9372
2020-12-01 08:35:03 -08:00
James D. Forrester f57816cfe9 Update VE core submodule to master (b134dfac3)
New changes:
bc54c0d4c Localisation updates from https://translatewiki.net.
89187bb69 Use "Grade A" rules for stylelint
b134dfac3 Localisation updates from https://translatewiki.net.

Change-Id: I20d84c94e2d0b7976fdf51ca3f61a7d65acde772
2020-12-01 08:29:42 -08:00
Translation updater bot 83e106172b Localisation updates from https://translatewiki.net.
Change-Id: I22104b534ebbda7427ec605c11664cd98894b964
2020-12-01 08:23:54 +01:00
David Lynch efd2cc0d03 Give revision_id a fallback that'll validate
In the new-page case, wgRevisionId will be 0 so it'll try looking for
parentRevId and the cast-to-int on an undefined will get us NaN. That
fails validation, so we should give one last fallback to 0.

It's _possible_ that we could instead make this an explicit check for
using wgRevisionId if it's anything not-undefined, but I'm not certain
about whether there are cases that wouldn't cover.

Bug: T237063
Change-Id: I8a38c0f3b8f8b2b596f5d0933e1a9e7f1326d7be
2020-11-30 11:17:23 -06:00
Translation updater bot 12860d0a53 Localisation updates from https://translatewiki.net.
Change-Id: I89cb809619d007280f4edc2e6917c1d39c9b6763
2020-11-30 08:48:20 +01:00
Translation updater bot 8c130d92c1 Localisation updates from https://translatewiki.net.
Change-Id: I1cf62c43f5ddf5295a9844e99f949082d5eb5456
2020-11-27 08:31:20 +01:00
jenkins-bot 2b34787241 Merge "Don't block media dialog on initialising upload booklet" 2020-11-26 20:10:47 +00:00
Adam Wight 9925ad3a88 Send EventLogging when editing parameter values
The first edit to a parameter will cause an event to be sent,
subsequent edits to the same parameter will not send an event.

Bug: T258920
Change-Id: Ibe663ce99a8fdf85a5add17186fb44fdbd4176bf
2020-11-26 11:13:14 +01:00
Adam Wight 46dad92e7d Send an event when the template doc link is clicked
Bug: T258920
Change-Id: I579472f2f9a683f63a08abc97f69c080e84bed35
2020-11-26 11:12:20 +01:00
Adam Wight 19723ba681 Send EventLogging when adding template parameters
Record that a parameter was added, and whether it was known or
unknown--whether it's documented the TemplateData.  Note that
`.isParameterKnown` returns true after an unknown parameter is added
to the template, so we need to set up the event early.

Bug: T258920
Change-Id: I5f8d8d06226474160a0a82c2e85a7fa4e22ba8cb
2020-11-26 11:10:48 +01:00
Translation updater bot 6ebd6da663 Localisation updates from https://translatewiki.net.
Change-Id: I8fab335093739e8a5a54d25b146201b033e1e0ab
2020-11-26 08:28:42 +01:00
jenkins-bot df622d3b9e Merge "Remove maxLength from new section title in NWE" 2020-11-26 00:03:45 +00:00
Bartosz Dziewoński c49f919d90 Remove maxLength from new section title in NWE
MediaWiki doesn't have such a limitation. This might have been copied
from the edit summary code, which used to be limited to 255 bytes.

Change-Id: I4afe9b1cde0663c47c0c2502b6e32116b912208b
2020-11-26 00:22:36 +01:00
Translation updater bot 98616b6bb5 Localisation updates from https://translatewiki.net.
Change-Id: I2c5191f8fc5b78b13bce7726503401839cf4a883
2020-11-25 08:34:48 +01:00
Translation updater bot 9cef19bcf1 Localisation updates from https://translatewiki.net.
Change-Id: Ic774dc2ed465168c847c306a8718bc076e9235d1
2020-11-24 08:40:57 +01:00
James D. Forrester d4952a1ad7 Update VE core submodule to master (5c953fd1e)
New changes:
d0f8b5890 Prevent Chromium Edge's translate feature from translating our editable surface
9e33552e8 build: Updating npm dependencies
a292ce22b Fix a typo: emtpy -> empty
5c953fd1e Localisation updates from https://translatewiki.net.

Bug: T201491
Bug: T267747
Change-Id: I7d1eaa7333e3adc80064c6c4dfed89247b3878ce
2020-11-23 09:00:48 -08:00
Translation updater bot 8339a38e5d Localisation updates from https://translatewiki.net.
Change-Id: I697f746be0907f4e915cfff9d63c0b2d115f26a5
2020-11-23 08:40:25 +01:00
Translation updater bot a7a27d06c9 Localisation updates from https://translatewiki.net.
Change-Id: Ifcf80fd6b1f8f15d2af1747c22fd973b78952493
2020-11-20 09:18:21 +01:00
Ed Sanders 6a238b784e stylelint: Remove needless disables
Change-Id: I83c778f1b08b96e6a34068f497c7a72f2887ad4c
2020-11-19 23:38:11 +00:00
James D. Forrester 726e63cca7 build: Upgrade stylelint-config-wikimedia from 0.10.1 to 0.10.3
Change-Id: Idca06a9c5f8e3b1fa7be156613380e1ed99973fd
2020-11-19 23:37:03 +00:00
Translation updater bot 336135115a Localisation updates from https://translatewiki.net.
Change-Id: Ibfbef2a5c759bb1738ce384e269291da53e95cc0
2020-11-19 09:10:49 +01:00
Bartosz Dziewoński e46f4aa644 Update VE core submodule to master (a466243e6)
New changes:
fc123da18 Revert "Firefox Mobile: Prevent scrolling after mousedown"

Bug: T196839
Change-Id: I1079f80027216c5b9c5ac248075a7200d225fec0
2020-11-18 20:18:03 +01:00
Translation updater bot 79edcdf7a9 Localisation updates from https://translatewiki.net.
Change-Id: I44f9993ac05eaeacda8826f04d896aeb5143d945
2020-11-18 08:57:20 +01:00
libraryupgrader ce544c807e build: Updating mediawiki/mediawiki-phan-config to 0.10.4
Change-Id: Ia700e8ac15f42277f348d0b82b55304ed65b63ee
2020-11-18 04:24:31 +00:00
Translation updater bot fb23e6fb8e Localisation updates from https://translatewiki.net.
Change-Id: I3b331f988a44140debcdfc4755ed3c72cf0b6d39
2020-11-17 08:43:39 +01:00
Bartosz Dziewoński 9bc0bcd302 Update VE core submodule to master (8b37f95f1)
New changes:
6e6e6d8d4 Localisation updates from https://translatewiki.net.
dda4604b1 Localisation updates from https://translatewiki.net.
c75775d9a build: Unbreak language lists, adding 'nqo'
d01619a07 ve.adjacentDomPosition: Fix doc comment
f88e84b37 Catch errors from getNodeAndOffset in ve.ce.Surface#focus
9350800dd Avoid errors from adjacentDomPosition in LinearDeleteKeyDownHandler
8b37f95f1 Localisation updates from https://translatewiki.net.

Bug: T136780
Bug: T259154
Bug: T262303
Bug: T262487
Change-Id: Icdba67cc5cb8c2798605c2bfc47af8888e3721c3
2020-11-16 23:27:06 +01:00
Máté Szabó d127dc48b7 ve.dm.MWTemplateModel: Don't add spurious empty parameters
Make ve.dm.MWTemplateModel#serialize ignore empty parameters if they were not
present in the transclusion before the edit. This avoids dirty diffs where an
user edits a template transclusion via VisualEditor, and the editor adds all
available template parameters to the edit wikitext, even if they were not
changed during the edit.

This logic was ported from the old Wikia-WMF VisualEditor project.[1]

Additionally, add tests for ve.dm.MWTemplateModel serialization.

---
[1] https://github.com/Wikia/app/pull/6450/commits/858eaa9

Bug: T101075
Change-Id: I35f8812724658904d30034db4e4684193a661c1e
2020-11-16 19:54:44 +01:00
Translation updater bot e38dd7188e Localisation updates from https://translatewiki.net.
Change-Id: Iaf6fa02c8d52e659c287e8d0206ac88ed0257d91
2020-11-16 08:38:33 +01:00
Translation updater bot c7ff91119f Localisation updates from https://translatewiki.net.
Change-Id: I5d145e35fece2ac256f35a37d8ed3ea8923abcb4
2020-11-13 08:31:16 +01:00
Translation updater bot 879a6bcfcc Localisation updates from https://translatewiki.net.
Change-Id: I9e45cec1947106e491e6aa1c88fcf135ed10c9f9
2020-11-12 08:22:52 +01:00
Translation updater bot 20efaaac91 Localisation updates from https://translatewiki.net.
Change-Id: I1905da6e0dc2fe956d9d8550d35cf91c26809aed
2020-11-11 08:37:10 +01:00
jenkins-bot f612cb90d5 Merge "ArticleTargetLoader: Add ve.loadModules hook" 2020-11-11 01:37:37 +00:00
Roan Kattouw 4f5c27be09 ArticleTargetLoader: Add ve.loadModules hook
This provides a consistent entry point for registering plugins on both
desktop and mobile, without needing to do strange things if the right
ResourceLoader module hasn't loaded yet.

Without this, registering a plugin module in JS requires ugly code,
and on mobile it wasn't possible at all.

Bug: T267692
Change-Id: Ie2c320c33ec2b064fba4fb45ba62545b9211439a
2020-11-10 23:31:07 +00:00
Bartosz Dziewoński d7d2faa23e Merge "Update reference paste test with "reference" class" 2020-11-10 20:43:43 +00:00
Translation updater bot 5fb891e9db Localisation updates from https://translatewiki.net.
Change-Id: Ia61c4e22f140c0fa43636c9f4366d7b44068f364
2020-11-09 08:36:11 +01:00
Bartosz Dziewoński 0337f665af Update reference paste test with "reference" class
Needed by I9d6856f03071c09617b8ae7db938135a3e30fe8e in Cite.

Change-Id: I61a2132f3876e2d9567d985358f51eb51c479813
2020-11-06 18:50:00 +01:00
Translation updater bot 4a4a4fc7cf Localisation updates from https://translatewiki.net.
Change-Id: Ia824ebe96d05440c2bd83c7dcb8bd20be901dcf8
2020-11-06 08:35:02 +01:00
Bartosz Dziewoński 80691d9404 ve.dm.MWInlineImageNode: Alienate malformed figures
Parsoid sometimes emits empty <figure-inline> tags. We can't edit
that, so alienate them, instead of throwing exceptions.

Bug: T267282
Change-Id: Ie6a659a9137a1c5e82f10e0a51abb5d60f68d43e
2020-11-05 22:47:35 +01:00
Translation updater bot 9687b9bd36 Localisation updates from https://translatewiki.net.
Change-Id: I7c5d0a9d27378f783c4165fbd293fb376189efe5
2020-11-05 08:29:11 +01:00