wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 02:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix incomplete return in DesktopArticleTarget.tryTeardown()

Browse source 
If a teardown has started, there should be a teardownPromise,
otherwise return a rejected promise.

Bug: T268358
Change-Id: Ia5cbd6b409a38f97243234ea7c87d24f71bdf3d6
This commit is contained in:
Thiemo Kreuz 2020-12-01 08:43:33 +01:00 committed by Bartosz Dziewoński
parent 3e6d5c6817
commit fb0e33f987
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
View file

@ -559,7 +559,7 @@ ve.init.mw.DesktopArticleTarget.prototype.teardownNewSection = function ( surfac
*/
ve.init.mw.DesktopArticleTarget.prototype.tryTeardown = function ( noPrompt, trackMechanism ) {
if ( this.deactivating || ( !this.active && !this.activating ) ) {
return;
return this.teardownPromise || ve.createDeferred().reject().promise();
}
// Just in case these weren't closed before