Commit graph

583 commits

Author SHA1 Message Date
Ed Sanders d85e8da9e2 Remove MSIE from blacklist, already blacklisted upstream
We support all versions of IE that MW supports, so no need
for additional blacklisting.

Bug: T160494
Change-Id: I771459b4d6a0e2d5781a69a905a51323369b3b66
2017-03-15 17:42:34 +00:00
James D. Forrester 6ab24fe9f0 Update VE core submodule to master (41134af2b)
New changes:
1e12d0174 Generalize DiffElement logic (improves lists and tables)
24e0c7a94 Localisation updates from https://translatewiki.net.
32759ae86 Allow variable-length sequences without a fake space terminator, use for autolinking
82c204ba0 QUnit.assert.equalHash: Correctly compare JSON representation
2e5462610 DiffElement: Allow a node change to be an attribute change *and* a linear diff
41134af2b ve.ui.LinkAction: Allow autolinking ranges including trailing spaces again

Local changes:
Updated tests for 32759ae86: the autolinkUrl command no longer expects
trailing whitespace to be included in the range.

Bug: T117165
Bug: T149537
Bug: T158518
Change-Id: I5c2d5b97894fc93f49ce6270a198f3dfdcd09986
2017-03-14 12:47:32 -07:00
Bartosz Dziewoński b109c3405f ve.ui.MWWikitextStringTransferHandler: Avoid API call for magic links
Updated tests to stop assuming that MWWikitextStringTransferHandler
always goes through an API request and Parsoid.

Bug: T117165
Change-Id: I24dffaaf3b4051b1b807ec29ac456d24da2f1fe9
2017-03-13 19:54:19 +01:00
James D. Forrester 9b4e27a91c MWWikitextStringTransferHandler.test: Don't pass around an invalid doc
Even if it sounds cool, it isn't.

Change-Id: Ib6612bc0ea8d66fc1964b3a782ad56356da65952
2017-03-02 05:43:10 +00:00
Željko Filipin f776983204 Update tests to Selenium 3
Bug: T158074
Change-Id: I784fc7bb85f32d5e50b5abb500c51493839ccebe
2017-02-28 14:39:00 +01:00
Bartosz Dziewoński 2c78411113 ve.test.utils.createSurfaceFromDocument: Actually attach surface to DOM
Bug: T158141
Change-Id: I999bcdc7095a3b9e2a86a7d5eca0e1f3ceb175ef
2017-02-16 01:17:17 +01:00
Ed Sanders 1d7f929a91 Update VE core submodule to master (139bdf7)
New changes:
d79138b Overwrite selected content when pasting via DataTransferItem
3c4737f Ensure clipboard is never empty text
3b1339e Create dummy platform and target for tests
4d63c8e Pass text as string to insertDocument when detected as plain text

Local change:
Remove VE standalone module

Flow used to use it, but not anymore. Going forward no one should
be using it in MW.

Bug: T154020
Bug: T156302
Bug: T156498
Depends-On: I078c244ef524669da477a43f9b37c847252e5ad7
Change-Id: Ifc4be16269f819890f2dcdddbbdebf9694ad2868
2017-01-29 18:50:47 +00:00
James D. Forrester 122f49b2dd build: Bump file copyright notices for 2017
Change-Id: I3c20809e71cc0da58123e1b5f29c4f3aac945496
2017-01-03 08:58:33 -08:00
Ed Sanders 2ee9e62a4d Use upstream media search widget from core
Bug: T140166
Depends-On: If53ef7f4b62c7a5d4da565c14dd2a353778694e5
Change-Id: I28845e9c143e78d3a377f067606c62da212e3bf1
2016-11-29 17:19:14 +00:00
Ed Sanders 37ccaca2ec eslint: Re-enable wrap-iife and partially enable dot-notation
Change-Id: I4420d66f528dcb18ebe2b9f63996661b2969f833
2016-11-12 14:43:43 +00:00
James D. Forrester 36befda61c build: Replace jscs and jshint with eslint
It's new, it's fresh, it's amazing, it's here.

Change-Id: I5dc784411f704685ed5cc763a2b2b1c5d3e5a610
2016-10-28 18:33:15 +00:00
Alex Monk 25933c09ec Strip RESTBase IDs from HTML generated when wikitext is pasted
Bug: T146054
Change-Id: I0013673a9e41ea191ea64f3208a06288efb2ecd3
2016-10-13 17:42:11 -07:00
Ed Sanders e1e02fa0d8 Update VE core submodule to master (90cbd62)
New changes:
abf8f41 Replace Array#concat with Array#push in converter
02aeb90 Localisation updates from https://translatewiki.net.
902ddda Use safer batchPush in converter
6368191 Use current surface's sequence registry in command help dialog
f7ce4b9 Optimize batchPush on small lists
fb43a0a ve.batchPush: add unit test to exercise long-array path
d6c7d24 Factor out RESTBase ID regular expression
ffcbf4b IndentationCommand: Use hasMatchingAncestor
d447023 Allow ommission of range from ve.dm.Document cloneFromRange
cfbc344 Don't strip empty paragraphs on paste if they are generated
01c918b Localisation updates from https://translatewiki.net.
1467947 Fix documentation of getMetadataIdRegExp

Local changes:
* Define RESTBase ID pattern in platform and fix slightly
* Bring in paste test from core, which requires platform switching.

Bug: T147607
Depends-On: Ifc1c15872a50f915e5ef8d561b3a363dc5f4d28f
Change-Id: I3eb21e115de92a67afa85b5675fcbca5b111adb6
2016-10-13 17:10:33 -07:00
Roan Kattouw bb45d984ca dm.MWInternalLinkAnnotation: Fix href normalization for special characters
<a href="Foo%3F"> would dirty-diff to <a href="Foo?"> and also render
as such, pointing to the wrong page.

We also called decodeURIComponent() on the href twice, which can't
have been good.

Move URI decoding and underscore normalization into
getTargetDataFromHref(), and add rawTitle for callers that need it.
Put rawTitle in the origTitle attribute, so that equivalence
comparisons (decode(origTitle) === title) work as intended.

Bug: T145978
Change-Id: I29331a4ab0f8f7ef059c109f6813fa670a2c7390
2016-09-22 09:10:41 -07:00
David Lynch 5bc54fd036 dm.MWInternalLinkAnnotation: Add some test cases
Change-Id: Ie338d5538959ea2cc296886b623e9dc2cd84fa8f
2016-09-21 09:57:45 -07:00
Željko Filipin f3f432e722 Disable failing Selenium tests
The tests are failing with RSpec::Expectations::ExpectationNotMetError
for 2-3 days in a row.

Bug: T145861
Change-Id: Ieec2a67857b90033cdd0ddf63025d2af9de504a5
2016-09-16 13:12:02 +02:00
Ed Sanders 5788340b49 Update VE core submodule to master (632f0a9)
New changes:
14b5fbc [BREAKING CHANGE] Move originalDomElements to the IV store and use MD5
c5d21f0 Provide methods to (de)serialize transactions

Local changes to move originalDomElements to IV store

Depends-On: I8a71c1a40ec35108d0a9a388da6f75632f8dc53c
Depends-On: I32c9b5f984fcf96e3354841ecfcd444149e8f159
Change-Id: I0fbb6324eede94558426178cbdad6b5daf0f8318
2016-08-24 18:14:14 +00:00
Željko Filipin 59d771e1ac Fix failing Selenium tests
There were a couple of pieces of language screenshots related Ruby code
left that was breaking Selenium tests.

Bug: T139613
Change-Id: I3d327b3cfd5f52e60fee07095eefdd8feecaba98
2016-08-24 16:47:14 +00:00
Željko Filipin 2fb5c18ced Upload language screenshot files using commons_upload Ruby gem
Use the latest version of commons_upload. Delete no longer needed files
from previous Ruby implementation.

Bug: T143563
Change-Id: I7c0ca64aeea54501c51eb56a950143d5af251cf7
2016-08-24 14:47:45 +00:00
Željko Filipin cbccba89a0 Remove Ruby implementation of language screenshots
It is now implemented in JavaScript/Node.js.

Bug: T132574
Change-Id: I299332ac4f849b951ba24564bd0282ca0e25afd2
2016-08-22 12:19:21 +02:00
Translation updater bot 7660980ab5 Localisation updates from https://translatewiki.net.
Change-Id: I75f5c71990c63b2a21c85ae9217476101b384cc5
2016-08-17 22:42:44 +02:00
Translation updater bot 567bc298c5 Localisation updates from https://translatewiki.net.
Change-Id: I77aca2aafa920a83a17af3e67e686f591c38c93a
2016-08-11 23:59:28 +02:00
James D. Forrester cad4066bc9 Gemfile: Bump mediawiki_api from 1.7.1 to 1.7.2
Bug: T129483
Change-Id: Ief831d41df9352a824f4bd7a2a030cc4681950a2
2016-08-08 10:54:21 -07:00
Translation updater bot 530d911dd5 Localisation updates from https://translatewiki.net.
Change-Id: I17eb6510ad35f8e60f892b10b4430432601b08ec
2016-08-02 22:47:12 +02:00
Translation updater bot 5a0b12bfb4 Localisation updates from https://translatewiki.net.
Change-Id: I92e686fa6e7018b506629fc857fb951f72e84447
2016-07-04 22:35:04 +02:00
Ed Sanders 40d606abdc Test removing all table classes
Bug: T138896
Depends-On: I2698428f0aa69e2dcec2680efed44d064bf6e542
Change-Id: I5df5d51fc5b69df6eae40ac29f6b82f446b26ae8
2016-06-30 17:41:42 +01:00
Ed Sanders aeca19c9ea Ensure text version of counter is written to external links when copying
Bug: T137503
Change-Id: Iae791253ea272847984fee5d0586dc302027f1bd
2016-06-27 22:17:58 +01:00
Translation updater bot b11b838f6e Localisation updates from https://translatewiki.net.
Change-Id: I7dbad46f1d3d13dff617e7bde9de1d416bc32882
2016-06-18 22:50:50 +02:00
Translation updater bot 953422a605 Localisation updates from https://translatewiki.net.
Change-Id: Ibc8094f70202a731d21f954e5bdab8214abc062d
2016-06-07 22:47:17 +02:00
Translation updater bot 3af1ddc490 Localisation updates from https://translatewiki.net.
Change-Id: I9c271d5ea6ae3f1a8a5c59bd462c71c1740e2a0f
2016-06-05 22:23:23 +02:00
Translation updater bot 9bdc38b864 Localisation updates from https://translatewiki.net.
Change-Id: Ib899d193506842d6a278f8e89e8672fa64bb9e73
2016-06-04 22:25:19 +02:00
Translation updater bot 3d994ac23e Localisation updates from https://translatewiki.net.
Change-Id: I6ab9559b62d7b80727795a612d3e98c4ff271ed6
2016-05-31 22:46:04 +02:00
Ed Sanders 20fa650a6b Un-blacklist Firefox versions 12,13,14
T52720 (link corruption in FF13/14) appears to be fixed.
T52780 (editor not loading in FF11/12) appears to be fixed.

FF11 has a new issue where templates are normalised even
when not touched (T136607)

Change-Id: I34358e3d90b8186e6b89c04c038ab79c908fc81b
2016-05-31 09:46:50 -07:00
Ed Sanders 7f0b56ff6c Use new action test runner
Bug: T90370
Change-Id: Ice209791f323c19743c192c5f864b2f8202b5ca9
Depends-On: I9b9275b55b367a1335bf4c4f8f52a68f6aeb9827
2016-05-13 14:21:49 +00:00
Translation updater bot 0153870e30 Localisation updates from https://translatewiki.net.
Change-Id: Ieda52ac7aec208e81de8a000d602afe705779145
2016-05-08 22:46:24 +02:00
Ed Sanders f30000ed4c Wikitext paste: Discard autoGenerated items after conversion
Otherwise the reference contents (stored in the reflist) is lost.

Bug: T134228
Depends-On: I718963e3c460a5bed38fba4152b03442bbe6169e
Change-Id: I20171eb97eb1b4757a2c8a25217adb4d680a9057
2016-05-04 10:58:01 -04:00
Translation updater bot e59a008a1e Localisation updates from https://translatewiki.net.
Change-Id: Ib1c3814addf800ff893d224b69812c436f9b27ab
2016-05-03 22:27:39 +02:00
jenkins-bot 6cf2af4f5c Merge "[BrowserTest] Migration of browsertests* Jenkins jobs to selenium* jobs" 2016-04-26 10:58:02 +00:00
Željko Filipin 58049b0c2c [BrowserTest] Migration of browsertests* Jenkins jobs to selenium* jobs
selenium* jobs are a new way of running Ruby based Selenium tests. The
jobs are triggered daily.

Bug: T128190
Change-Id: I11554b23a0e347736a67766f8c0b9879d5a6bed9
2016-04-26 12:40:45 +02:00
Ed Sanders 4479633159 Remove IE9 from blacklist, but don't add to whitelist (yet)
This puts IE9 on the greylist, meaning it will open but with
a warning.

Bug: T133094
Depends-On: I817b286e16b7923dd4dd456467466a0128805da1
Change-Id: I55fcbd1b7c4a82e11d61d3b93b4fdb7e992fba1d
2016-04-20 00:10:26 +00:00
Antoine Musso 4a97e9585f [BrowserTest] Fix i18n files lookup
The visual_editor_page used relative paths expecting the current
directory to be modules/ve-mw/tests/browser. Use absolute paths instead.

Change-Id: I8b1c4eddc2085ee80380f288bceb14c6feee0a60
2016-04-04 11:52:36 +02:00
Ed Sanders 18df6c3d47 MWWikitextStringTransferHandler: Add test for autoGenerated=true
Bug: T131153
Change-Id: I4922abe7978e1f04eb2276214c761622b44149c7
2016-03-29 19:57:45 +00:00
Ed Sanders b51b512555 MWWikitextStringTransferHandler: Factor out body tag from response
Change-Id: Ic694d1099538d2c60900d490667f2175f7f3afb3
2016-03-29 19:57:36 +00:00
Ed Sanders 818931dd9e MWWikitextStringTransferHandler: Remove data-parsoid from tests
It is ignored by VE, and isn't present in restbase responses.

Change-Id: Iaa2a6a66ba76ca0d63b4d6791ab8589191bce0f2
2016-03-29 19:57:26 +00:00
Translation updater bot f239e17a1e Localisation updates from https://translatewiki.net.
Change-Id: Ie585e9b5dd0251d35e90646f0ff79cc76cf66da8
2016-03-27 21:25:48 +02:00
Ed Sanders 6a159001ab Make data-mw/body.html attribute comparable
Change-Id: Ie23c5816a18f4da84c3d40c13a8c048710389f4b
2016-03-23 11:03:53 +00:00
James D. Forrester 7df0e7589e Update VE core submodule to master (eb97c1f)
New changes:
e661245 Localisation updates from https://translatewiki.net.
d0bac53 ElementLinearData: Add test for sanitize conversions
53988e4 ElementLinearData: Test blacklist unwrapping
8593098 ve.dm.Model: Remove unused, untested method 'hasAttributes'
6247dd2 ce.Surface: Add tests for table strip delete
bee1851 ce.Surface: Add larger table strip-delete test
42d39e7 ce.Surface: Test table navigation with enter/escape/tab/shift-tab
5d248f9 Remove TableCaptionCommand
a86ad04 PreviewElement: Check node is a GCN, and always return a boolean
b518839 Localisation updates from https://translatewiki.net.
8834e9c ce.Surface: Allow any key code in the key handler tests
6b3ea6a ce.Surface: Linear arrow tests for block node
026999d Localisation updates from https://translatewiki.net.
eb97c1f Localisation updates from https://translatewiki.net.

Change-Id: Ic5853116d97623316d9a6bbacda2ecab9e4b49d5
2016-03-22 15:12:36 +00:00
Translation updater bot eed6125ef2 Localisation updates from https://translatewiki.net.
Change-Id: I197104b10bb7aa062030a6cf22975283dbe42d28
2016-03-20 22:43:49 +01:00
Translation updater bot c37a2d11f7 Localisation updates from https://translatewiki.net.
Change-Id: Ia9b65fcfe6117d2075483bd130900c51b787eddc
2016-03-18 22:45:18 +01:00
Ed Sanders b7d25d92bc Detect the type of plain pasted links
Using the same logic we used for converting pasted URLs, detect
internal links by matching their base.

Currently link pasting is still disabled in the VE target, but
has been enabled elsewhere (Flow).

Change-Id: Iebd61abbe1fe82fd18d129e1dbc815ca75f44e87
2016-03-17 19:30:13 +00:00
Ed Sanders 5e6cbc187c Link pasting: Match RDFa-less links as external
Now that some targets support link pasting (Flow) we need to
make sure that pasted links match to an allowed type ('link/mwExternal')
instead of plain 'link' annotations which should never exist
in an MW document.

In a later commit we should auto-detect internal links.

Change-Id: I7faae834aa6e730c3cf93a691331a05fd0fe3d5c
2016-03-17 17:18:41 +00:00
Željko Filipin 63eb2a2f46 [BrowserTest] Increase the time Selenium waits for VisualEditor to load
I have noticed that Jenkins job that runs daily fails sometimes because
looking up the element failed after 5 seconds. The time is increased
from 5 to 10 seconds.

Bug: T94150
Change-Id: Ib23f4ac72aa6c734f297e8f9fb5ad4645ac8891e
2016-03-14 13:00:17 +01:00
Željko Filipin 43e9c8714f [BrowserTest] Disable failing language screenshot scenario
VisualEditor_Insert_Menu scenario fails with `Original image height is
too small! (ChunkyPNG::OutOfBounds)`.

Bug: T119482
Change-Id: I30c3a9757c5754a40921fce5225b73897eed865b
2016-03-10 15:06:56 +01:00
jenkins-bot 2e89f4f658 Merge "[BrowserTest] Disable failing language screenshots" 2016-03-09 17:32:57 +00:00
jenkins-bot 67fb8dd07f Merge "[BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError" 2016-03-09 17:31:27 +00:00
jenkins-bot 8d7baccd5f Merge "DesktopArticleTarget: Add Edge and MSIE to whitelist" 2016-03-07 23:28:58 +00:00
James D. Forrester 79d1f92b42 DesktopArticleTarget: Add Edge and MSIE to whitelist
Bug: T128447
Change-Id: Ia7afe4ddd5abd4fd1de85ba2d2df1fefa6735d79
2016-03-07 14:58:10 -08:00
Željko Filipin dc3944726a [BrowserTest] Disable failing language screenshots
Bug: T119482
Change-Id: I165fcb2ee94430d29e287b80e13a48e05a021f77
2016-03-04 15:54:13 +01:00
Željko Filipin 8e0e40d5cc [BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError
Sauce Labs browsers raise
Selenium::WebDriver::Error::StaleElementReferenceError
if a test tries to use an element but VisualEditor is not loaded.

Bug: T128731
Change-Id: Icb01b4dee256a0270d722492d11dabf0cfc4f8c4
2016-03-03 14:58:14 +00:00
Željko Filipin 301b152ec8 [BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages
Looks like local browsers raise
Selenium::WebDriver::Error::JavascriptError while remote (Sauce Labs)
browsers raise Selenium::WebDriver::Error::UnknownError if a test tries
to use an element but VisualEditor is not loaded.

Bug: T126966
Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77
2016-03-02 13:50:44 +01:00
Translation updater bot eceb548e6c Localisation updates from https://translatewiki.net.
Change-Id: Id1453f111870ee703f552fa407dab76b19d786f5
2016-03-01 22:04:45 +01:00
Translation updater bot 7546362fa9 Localisation updates from https://translatewiki.net.
Change-Id: I7bade8021975fc1c3e2426211e6805a913f07891
2016-02-28 22:00:32 +01:00
Translation updater bot cef228ec1d Localisation updates from https://translatewiki.net.
Change-Id: I8a8e0b9b879d18d8011821e49dc8c23624652a38
2016-02-25 22:22:09 +01:00
jenkins-bot 222a5361ba Merge "[BrowserTest] Fix ve.init is undefined error messages in Selenium tests" 2016-02-24 17:56:57 +00:00
Željko Filipin 60a08f925c [BrowserTest] Fix ve.init is undefined error messages in Selenium tests
All scenarios that are passing are enabled to run in Jenkins.
(The commit increases the number of passing scenarios from 2 to 18.)

Bug: T126966
Change-Id: I9789ca42717133120197c4625bb8dad4ea496aa8
2016-02-18 15:42:05 +01:00
Translation updater bot dabeb4218d Localisation updates from https://translatewiki.net.
Change-Id: Iaabe8dd045b2670aeb9fc0164fcb30f682f73b6c
2016-02-17 22:52:14 +01:00
Željko Filipin 966f2f7bbb [BrowserTest] Jenkins runs only passing Cucumber scenarios
To get at least some Cucumber scenarios running in Jenkins, disable all
of them that are failing and run only ones that are passing.

The next step will be to fix failing scenarios.

Bug: T94162
Change-Id: Id0338c1d6b86d6b45220c5c0802074be397fb607
2016-02-15 13:18:19 +00:00
Translation updater bot 047517fa22 Localisation updates from https://translatewiki.net.
Change-Id: I475a76215ab50328eb2c65d68b2c4be2a5afd6e2
2016-02-08 22:17:32 +01:00
jenkins-bot 5a360f4cbb Merge "Remove mwReference tests, moved to Cite extension" 2016-02-05 22:16:24 +00:00
Ed Sanders 094555cb3c Remove mwReference tests, moved to Cite extension
Change-Id: I07a2bf45117c2d14c7b00875c0a710e20980a23a
2016-02-05 21:36:56 +00:00
Translation updater bot bd848ac4f1 Localisation updates from https://translatewiki.net.
Change-Id: Ic65af97f6c29c1e0c47317997b18ab064f80a2f5
2016-02-05 21:54:43 +01:00
Translation updater bot 622ca082ca Localisation updates from https://translatewiki.net.
Change-Id: I29d93111a508e8af12752b6b93dc13d106f01d5f
2016-02-03 23:09:41 +01:00
Translation updater bot 1b33f7b912 Localisation updates from https://translatewiki.net.
Change-Id: I499a7c36f46bed65f06c881de3df9fdf53e20036
2016-01-30 22:50:35 +01:00
Ed Sanders 0ed45dbf61 MWTable: use new sanitization method
This prevents tables from getting sanitized even on
VE to VE copy. Also by calling ClassAttributeNode sanitize
extra CSS classes are removed.

Bug: T97462
Bug: T125220
Depends-On: Ia3ce386b2a03bc227818b10423bca72c736c0656
Change-Id: Ifd91e00b40665b446bbdcdf8859d2bb641bc0e67
2016-01-29 10:29:19 -08:00
Ed Sanders b66aa990ba Follow-up I9714cf3: Add tests for wikitable paste
Bug: T85577
Change-Id: I8e2893c9a6f80fafe6cae142e4f50ffbe6d550ac
2016-01-22 20:13:26 +00:00
Translation updater bot b382eced8c Localisation updates from https://translatewiki.net.
Change-Id: Idce091710bdb8936a362df1ce2f000b792b1b286
2016-01-21 21:56:24 +01:00
jenkins-bot 7a39be3798 Merge "Stop using broken image links in tests" 2016-01-07 01:21:25 +00:00
David Lynch 3cffb489bb Stop using broken image links in tests
They make it a little bit more cluttered to hunt down problems when
testing. So, use the minimum image instead of just "Foo" or similar.

Bug: T121636
Change-Id: I3209c377ad870f669cac7d40d991968cff52c39e
2016-01-06 17:11:38 -08:00
Dan Duvall 96677fb74a [BrowserTest] Experimenting with JS object references
References to JS objects for VE elements can determined by referencing
the VE and OOUI API documentation[1][2] and interrogating the objects in
a browser console. Errors should be closer to what developers understand
but testers should pair with developers to better understand how to
define new page elements and where to go for documentation/help.

The VE entrypoint for the singleton reference is `ve.init.target` (if
there's only one instance of VE target; there may be multiple in some
cases like Flow).

[1] https://doc.wikimedia.org/VisualEditor/master/
[2] https://doc.wikimedia.org/oojs-ui/master/js/

Change-Id: I1f642807cdd3059d8e7e885a8b239ac01b9b3024
2016-01-06 17:07:35 -08:00
James D. Forrester ada58df361 build: Bump file copyright notices for 2016
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
2016-01-03 14:57:25 -08:00
Translation updater bot f1df0e0df4 Localisation updates from https://translatewiki.net.
Change-Id: I88a173f67541d0a5d1c8628e81871cbfce6db393
2015-12-30 21:46:23 +01:00
Željko Filipin 2cfaa9528c [BrowserTest] Update mediawiki_selenium Ruby gem to the latest version
Bug: T114241
Change-Id: Ic6cf69516a1e36173fbbf6b86494e845721a19d0
2015-12-30 11:46:23 +00:00
Translation updater bot dd85041a29 Localisation updates from https://translatewiki.net.
Change-Id: I66a72ca80277579be5674cbeb0794a70c7093345
2015-12-21 22:07:16 +01:00
Translation updater bot a6bab3aeff Localisation updates from https://translatewiki.net.
Change-Id: I9b6d4fa66a9a18160d5143de1ed1c6e783bd0ed3
2015-12-13 22:24:39 +01:00
Ed Sanders 29f33a57d5 Rename mw.Target to mw.ArticleTarget
This makes way for a base mw.Target class which is
not specific to articles (e.g. Flow boards).

Bug: T97166
Change-Id: If72650bdf87aa9f195b004da0a4d815f1a8063a3
2015-12-10 16:26:20 +00:00
Ed Sanders ae26eefb05 Fix typos
Add some common ones to typos.json

Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
2015-12-09 16:47:13 +00:00
Translation updater bot 6ceb0c39e6 Localisation updates from https://translatewiki.net.
Change-Id: Ie307b6e81958bb16c96a0ffff6b3568139564f4f
2015-12-03 23:17:58 +01:00
Ed Sanders 68755b212e MW Examples: Fix test message
Change-Id: I4a0b9bb92fa45fca82391943b86a43fec8f2e3a1
2015-11-20 20:34:18 +00:00
Ed Sanders 287436ae25 Add tests for RESTBase ID comparison
Depends on I8323bbf34 in core.

Change-Id: I4043322361cdbbfd211133191c062eae42269ca4
2015-11-20 20:34:12 +00:00
Ed Sanders 3d7d363e9c Improve tests of data-parsoid annotation comparisons
So that it actually fails if you remove the key feature.

Depends on Iff15190e in core.

Change-Id: I1557f683241193aa4a97e04af0b4daf244a8b121
2015-11-20 12:32:29 -08:00
Translation updater bot 64d8e394ce Localisation updates from https://translatewiki.net.
Change-Id: Iaf8fb457fd0b835d5b8819f5dab015c4a59e0a78
2015-11-16 22:19:07 +01:00
C. Scott Ananian 236fad19b6 Ensure magic link nodes inherit the annotations of their text
If you create an autolink in the middle of bolded text, the magic link
should also be bolded.  Similarly, if you convert a bolded simple link
to a magic link, the magic link should stay bolded.

Change-Id: I38c7f3c0c275851049088a37f3b37d815ed38e4e
2015-11-13 13:48:18 -08:00
jenkins-bot 96f91758f6 Merge "Update VE core submodule to master (77d786a)" 2015-11-11 22:10:08 +00:00
Translation updater bot c1ac8806c6 Localisation updates from https://translatewiki.net.
Change-Id: I7f3c0dfe04074271159b7f22032c587374f72836
2015-11-11 21:57:36 +01:00
Ed Sanders 9bcc61e195 Update VE core submodule to master (77d786a)
New changes:
95589a6 test: Add a Rakefile for new CI requirement
1a4497e ve.ui.DialogTool: Do not require that a command is set
cbf1bff ve.ui.Tool: Fix documentation for getCommandName
530022d Localisation updates from https://translatewiki.net.
9529093 Update OOjs UI to v0.13.2
b8d6c15 Add icon: Rename 'insert' to 'add'
2f3015b Update OOjs to v1.1.10
78ceb18 Fix deletion inside a structural node at start/end of document
ce3e9a4 ve.utils: Use binarySearch from OOjs

Local change:
* MW test cases for new structural deletion logic

Bug: T52250
Change-Id: I643449c1fa08ea12c8c3aa13f4a4b97d8876990d
2015-11-11 12:35:53 -08:00
James D. Forrester 09800aa249 Replace 'source' icon with OOUI's 'wikiText' one
Change-Id: Id66d436b9140604ace7ebfbec1f80dc8f3830a20
2015-11-04 06:15:29 -08:00
James D. Forrester c714eb173c Update VE core submodule to master (062cb26)
New changes:
6cae77b ElementLinearData: Add another case to hasContent
d2e15f2 SurfaceFragment: Improve handling of delete all
16db2a3 Return 'null' instead of null in ve.Filibuster observers
24de6b2 Introduce key down handlers to separate logic from ce surface
f77fe99 Localisation updates from https://translatewiki.net.
062cb26 Localisation updates from https://translatewiki.net.

Change-Id: I61c94983c7898af219266af3022761638c7578b7
2015-11-03 10:36:53 +00:00
jenkins-bot 54782884d5 Merge "[BrowserTest] Select English when LANGUAGE_SCREENSHOT_CODE environment variable is not set" 2015-11-02 12:22:39 +00:00
Vikas S Yaligar 0971054f40 [BrowserTest] Select English when LANGUAGE_SCREENSHOT_CODE environment variable is not set
Bug: T111525
Bug: T90577

Change-Id: I421c4c0ce7bcf7be757d31481940ada58e4c9f20
2015-11-02 12:18:07 +00:00
Translation updater bot 3791e5658a Localisation updates from https://translatewiki.net.
Change-Id: I75b45bcfab4a86d785dfd8052c950ad5edd4e4f3
2015-10-31 21:08:22 +01:00
Translation updater bot 8303873ced Localisation updates from https://translatewiki.net.
Change-Id: I86d151740c187a018a7e33afc88c601e614f8dd7
2015-10-30 21:51:06 +01:00
Translation updater bot 7317ee1f2c Localisation updates from https://translatewiki.net.
Change-Id: Ic63f9b48379735da1b506ea7f7e447c0196c761e
2015-10-22 22:05:34 +02:00
Translation updater bot ab7394f674 Localisation updates from https://translatewiki.net.
Change-Id: I6ad4b1bbd99e737e50e43ffa50bd5efead3142b0
2015-10-19 22:22:09 +02:00
Ed Sanders 5bde3be8a6 Browser tests: Fix selectors for strikethrough and underline
Change-Id: I94010005369b225494f5e603d71d1f57941d7db0
2015-10-15 15:49:01 +01:00
Ed Sanders 780d42b295 Browser tests: Fix table test
Change-Id: Ib2751cd58dd134f61f94e0a0e8c9c3540a7f26ea
2015-10-14 22:27:42 +01:00
Ed Sanders 4cbcfe8b66 Browser tests: Fix media insert test
Change-Id: I55c9247d235fa7ed4e020c62338d42a88d6c2358
2015-10-14 22:27:42 +01:00
Ed Sanders 2948d0b324 Browser tests: Update link inspector tests
Change-Id: I5e902b4ab3215450a4374fb7327159d3edfc5ef2
2015-10-14 21:29:14 +01:00
Esanders 60e3b55393 Revert "[Browser tests] Wait for save button to be enabled"
This reverts commit 122be9c95a.

Change-Id: Ia79636d5fdcf3f1a224c93688c164bf1030c3bee
2015-10-14 21:27:21 +01:00
jenkins-bot 41b168b0ec Merge "[Browser tests] Wait for save button to be enabled" 2015-10-14 19:08:23 +00:00
Ed Sanders 36652a721a Browser tests: Add API URLs to environments.yml
Change-Id: I524eb984cf04baeacfc131f482b2a773636dc87f
2015-10-14 17:42:49 +01:00
Ed Sanders 122be9c95a [Browser tests] Wait for save button to be enabled
In some tests the save button won't be available for a few ms
until the latest transaction has been pushed to the undo stack.

Change-Id: If03f03b033a21a039a322ca32983d0302e44efbb
2015-10-14 15:28:14 +00:00
jenkins-bot 1da509937d Merge "[BrowserTest] Use English if i18n file does not exists to convert the text" 2015-10-12 15:21:35 +00:00
Vikas S Yaligar 0d282a5e32 [BrowserTest] Use English if i18n file does not exists to convert the text
Bug: T111525
Change-Id: Iaf557114df0bcdca3f82fc0ba0bcb752f5cb2c3d
2015-10-12 15:13:48 +00:00
Translation updater bot 34ce74e044 Localisation updates from https://translatewiki.net.
Change-Id: I7933389827e2e2b99aeddfc7a1222ee06a5e96dc
2015-10-11 21:24:43 +02:00
Vikas S Yaligar df2c17bfd2 [BrowserTest] Load i18n messages from MediaWiki to browser tests
* translate method can be called to translate a particular string to a
specific language.

Bug: T90577
Change-Id: I7852ee0b0009e70bd9decef0dd317055d91a06a6
2015-10-09 09:49:37 +00:00
Ed Sanders 9fb6977e52 Update VE core submodule to master (363adf2)
New changes:
63c5f67 [BREAKING CHANGE] GeneratedContentNode: Introduce new hash for rendering
6dd1cb2 Add ve.dm.Surface#selectLastContentOffset

Local changes:
* Use new getHashForRendering in GeneratedContentNode users

  As we no longer have a model hash, remove the originalIndex check
  and just rely on the deep comparison of mwData (trading a deep copy
  for a hash computation should result in similar performance).

Bug: T114689
Change-Id: Ida0ee0234418408b735232c633d41908a424a9ff
2015-10-07 15:00:32 +00:00
Translation updater bot 4eb7a0554b Localisation updates from https://translatewiki.net.
Change-Id: I1574aa4164e8e530740112596120b44b1707d562
2015-10-04 22:20:56 +02:00
Translation updater bot d17197696f Localisation updates from https://translatewiki.net.
Change-Id: I89a27eeb175bfcf2f4cb3dd4beba38a664def4d8
2015-09-28 22:51:02 +02:00
Translation updater bot a60f360ae0 Localisation updates from https://translatewiki.net.
Change-Id: I081accdb1ac5a8d321b05bed986862f161a9bd99
2015-09-26 21:18:17 +02:00
C. Scott Ananian 92bfa93e4e Autolink of magic links should create node not annotation
Depends on: I9679cf0fd550c9b156370fc88953414460c801a4

Bug: T112675
Change-Id: I97a1750b3424c09e181976029f10ee161129b166
2015-09-25 14:21:33 -04:00
Translation updater bot 535ae912b2 Localisation updates from https://translatewiki.net.
Change-Id: Idbf9eec0b8b72d140631bdf8ae2a8592d569ce75
2015-09-22 22:29:05 +02:00
Translation updater bot 8486cbb0a8 Localisation updates from https://translatewiki.net.
Change-Id: I0a35c367cad0ce4efd25d6f27f55468d37a86f41
2015-09-21 21:59:21 +02:00
Translation updater bot 1094eb83d2 Localisation updates from https://translatewiki.net.
Change-Id: I81be3f5e22c33817b1dbe20ed629def4b36934f0
2015-09-17 22:42:45 +02:00
Translation updater bot 09f8a24bf3 Localisation updates from https://translatewiki.net.
Change-Id: I9214b262c6895a8e00b9939e6cb14279df57b226
2015-09-14 22:08:33 +02:00
Translation updater bot a76c3ad66d Localisation updates from https://translatewiki.net.
Change-Id: I46dedc50c43bc858187fb179c387d36fd305f61a
2015-09-08 21:50:34 +02:00
Translation updater bot 0853d62fa0 Localisation updates from https://translatewiki.net.
Change-Id: I05d75e4f420a5915e346a120e51b2e2567a6be56
2015-09-05 21:10:47 +02:00
Translation updater bot b3bdb8691d Localisation updates from https://translatewiki.net.
Change-Id: Icfa560e58cb0deabd2722c261ec44ce8f3c8d6e4
2015-09-04 21:54:45 +02:00
Translation updater bot c503547e47 Localisation updates from https://translatewiki.net.
Change-Id: I6aad78decfbb76f3ea704a381971ff73cb5f31cb
2015-09-02 21:39:43 +02:00
Translation updater bot 2462889843 Localisation updates from https://translatewiki.net.
Change-Id: I42f1f5497936b7fb0a5af3050a5955ec1508640c
2015-09-01 21:46:35 +02:00
jenkins-bot 8502d3ea05 Merge "Specialized inspector for ISBN magic links" 2015-09-01 18:34:23 +00:00
C. Scott Ananian 7cc23367f6 Specialized inspector for ISBN magic links
Implement a special node type, context item, and inspector for
ISBN/PMID/RFC magic links.  Add buttons to the link inspectors
to convert back and forth between "simple" links, and magic links.

Depends on I5d000d8b63dafdfe0a2753069d3f0ac5b03b8829 in Parsoid
for clean round-tripping of localized ISBN magic links.

Bug: T63558
Change-Id: Id5b7a2ae3c80b0e5eed598f0bd024d3e94f7e9aa
2015-09-01 14:25:59 -04:00
Translation updater bot 3f0be19d56 Localisation updates from https://translatewiki.net.
Change-Id: I0d2732c724ac3c422eb76a269be789fd0805e62a
2015-08-29 21:47:45 +02:00
Translation updater bot 397c5ce65e Merge "Localisation updates from https://translatewiki.net." 2015-08-27 19:40:29 +00:00
Translation updater bot c0c1b542b3 Localisation updates from https://translatewiki.net.
Change-Id: Iefbd74f51a24c9018fed8cd5551e5d2eb0927380
2015-08-27 21:38:37 +02:00
Roan Kattouw e4d2d4785e ve.dm.MWImageModel: Require parent document
Add a parentDoc parameter to the MWImageModel constructor and use
it to inherit language, direction and HTML document. Remove
getLang(), setLang(), getDir() and setDir() whose only purpose
was to propagate the language and direction from the parent document
in a hacky way.

Also add a parentDoc parameter to newFromImageAttributes(), replacing
the lang and dir parameters. Remove the unused and ill-conceived
caption parameter.

This causes caption documents to always have an HTML document
for URL resolution. Previously, this worked when editing existing
images because a document generated by cloneFromRange() (which
propagates the HTML document) was passed into setCaptionDocument(),
but it didn't work when creating new images.

Bug: T109599
Change-Id: Ida36862092cd779ffc2f04c0ecbc1164f8d71453
2015-08-27 00:09:21 -07:00
jenkins-bot c02874842b Merge "Fix pattern for matching wikitext headings" 2015-08-25 16:23:15 +00:00
jenkins-bot 547d5afebd Merge "MWInternalLinkAnnotation: Override new getDisplayTitle method" 2015-08-24 21:41:22 +00:00
Ed Sanders a67965a888 MWInternalLinkAnnotation: Override new getDisplayTitle method
This allows the URL paste handler to use the normalized title
as the text content. Add a test to cover this behaviour.

Depends on Ica48fea69cc in core.

Bug: T109980
Change-Id: I2784adaf2949a73256049921227dde0917ef9aef
2015-08-24 14:29:49 -07:00
Ed Sanders 456439923a Fix pattern for matching wikitext headings
Fix the back-reference to \1 (1st set of brakcets).

Add an test to make sure the example sequences actually trigger the
wikitextString handler, and tweak test to ensure that the start-of-line
restriction in the heading regexp doesn't affect link matches.

Change-Id: I76187a12292a4923d1ee2505cfb955431ac252bb
2015-08-24 16:54:45 -04:00
Ed Sanders a33b082c13 MWWikitextStringTransferHandler: Show indeterminate progress bar while converting
Also store the abortable API request so it can be cancelled
by the dialog.

To test this, put sleep(4); in ApiVisualEditor.php.

Depends on Ied21e574baa in core.

Change-Id: I83ffa9e0b7164ca4a34eae86cde452d8f38dc853
2015-08-23 14:18:40 -07:00
C. Scott Ananian ceb0e1f867 Autolink typed ISBN/RFC/PMIDs
Depends on Ibdad2fa98fca08eeaa96bf33a08dd7723c1edb8c in Parsoid.

Depends on I3dcd289ed7b565b9162ee671038eeb45449e1215 in ve-core.

Bug: T109498
Change-Id: I5650410d7fca30c90baddd4f0c3f6d80e6b39042
2015-08-23 13:59:22 -07:00
Translation updater bot d9af00392f Localisation updates from https://translatewiki.net.
Change-Id: I0c362dd030a23102524c0300d6bc6a6771f6b6fa
2015-08-21 21:00:37 +02:00
jenkins-bot c20915032e Merge "QA: Upgrading to mw-selenium 1.x" 2015-08-20 17:27:12 +00:00
Dan Duvall 668a149103 QA: Upgrading to mw-selenium 1.x
Upgraded mw-selenium to 1.x, following the docs at
https://doc.wikimedia.org/rubygems/mediawiki-selenium/file.UPGRADE.html

Created an `environments.yml` file, converted page object definitions to
use relative paths, and refactored references to the global `ENV` using
methods of `MediawikiSelenium::Environment`.

Upgraded commons_upload as well to resolve a dependency conflict on
mediawiki_api.

Paired with: Rummana Yasmeen <ryasmeen@wikimedia.org>

Bug: T99661
Change-Id: I2a05cd816ea43afb48157e5dbe1ae42c6c124f6b
2015-08-20 09:52:16 -07:00
jenkins-bot 90b2717bb9 Merge "build: Enable jscs rule 'requireVarDeclFirst' and make pass" 2015-08-19 20:45:13 +00:00
jenkins-bot 8b50887e78 Merge "build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass" 2015-08-19 20:31:38 +00:00
Translation updater bot 6f5de25be5 Localisation updates from https://translatewiki.net.
Change-Id: I08cf651d4e52d32b5c9a700630fa98308f7e6455
2015-08-19 22:16:27 +02:00
James D. Forrester 19df1d4c8a build: Enable jscs rule 'requireVarDeclFirst' and make pass
Change-Id: Ia2f765d12bde001c329c2ff4c080a36b71de9803
2015-08-19 11:05:01 -07:00
James D. Forrester f5c6f61163 build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass
Change-Id: I846d36c15e1b1f810d2ef7fd422f8412790bcb0f
2015-08-19 10:33:02 -07:00
C. Scott Ananian a6775796fe Detect paste of wikitext and convert it
This invokes Parsoid to convert likely wikitext pastes.

This addresses about 20% of the <nowiki> insertion quantified at
https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis/Nowiki
for 2015-04-08 which were due to inadvertent pastes of wikitext.

For a better user experience, suppress Parsoid's P-wrapping if the
output consists of a single top-level P element.  This ensures that
pasting '[[Foo]]' won't add an unexpected newline before the paste.

Bug: T54204
Bug: T109449
Change-Id: I26a4cd8dc5b7e7caf16ca081dbe7baf6a7db8e5c
2015-08-18 15:16:06 +00:00