wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-26 15:21:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
7052 commits 30 branches 0 tags 192 MiB
Commit graph

136 commits

Author SHA1 Message Date
cmcmahon 2b9e0cb1ff interim move prevents edit conflicts while we sort test data issues 
Change-Id: I857fd2d99513e0c176ef832bc92e0a16d972e74a
 2013-12-24 10:35:22 -07:00
Jeff Hall 385cc12fd9 [Browser test] Update test to handle SSL in test2 
Changed URL matching condition to be indifferent
to HTTP vs HTTPS addresses since it's not
relevant for what is under test here.

Change-Id: I3382174d6cd0e05c28fc94e0a2fcbc5d170fed3c
 2013-12-23 22:28:37 +00:00
Jeff Hall 456e8c1f99 [Browser test] Update test to use existing hook 
1) Reduce some code duplication.
2) Added bonus: will fix a problem with the failing "links" test.
3) Removed some commented code lines in feature file.

Change-Id: I7ad4ade89c6477fd42eca178bae294f4dfecdf5b
 2013-12-23 22:05:34 +00:00
cmcmahon 7689946826 [browser test] replace single quotes with double quotes 
Change-Id: I569c31b389a9678e2d99709073511711e7e628e3
 2013-12-19 10:07:10 -07:00
Zeljko Filipin 30f2619c14 [Browser test] New test for switching between editing modes 
1) Using native page-objects methods for dealing with Javascript alerts.
2) Added tags to feature file per reviewer comment.

Change-Id: I3e9d9ae16f1c880878c8e198c647376a0b9aed37
 2013-12-19 14:56:30 +00:00
Jeff Hall 2b74982e95 [Browser test] New test for multi-edit workflow 
1) Per reviewer comments, moved some of the verbosity
   from feature to steps file in order to make
   the feature file a little more readable.
2) Using random strings for the text of each edit
   in order to make every edit unique.
3) Removing a commented line that wasn't needed.

Bug: 57654

Change-Id: Ib8b15964436d9c24556fac32977a64e2d5f22044
 2013-12-19 14:28:11 +00:00
Zeljko Filipin 1cd761dad8 [browser test] Prefer string interpolation instead of string concatenation 
Following Ruby coding convention[1].

Also fixes "no implicit conversion of nil into String (TypeError)"
error.

1: https://github.com/styleguide/ruby

Change-Id: I3bcf9ba08476117921de7d5a242f3726d8b05efb
 2013-12-18 16:38:48 +00:00
jhall 5e6154ebc4 [Browser test] New transclusion template search 
Per Bug: 58406, updating search criteria for
tranclusion templates to work with existing
content in beta labs.

  Please enter the commit message for your changes. Lines starting

Change-Id: Iac6919d234bd298034cc3c3d90ec62239a3fd0df
 2013-12-17 08:30:07 -05:00
Jeff Hall f83c8d7519 [Browser test] Additional waits for SauceLabs timeouts 
Applying same fix that was applied earlier to "bullets_steps.rb"
since that relieved frequent timeout behavior seen with tests
run via SauceLabs.

Change-Id: I0c924a315cd2bf4821a9155a1d1dcd052910e50e
 2013-12-16 10:29:20 -08:00
jhall c6a002110e [Browser test] Add waits for SauceLabs happiness 
1) when_present waits to deal with SauceLabs sluggishness
2) Restore a "sleep" method for running test locally

Change-Id: I692befa5da607cf2468e3a56eb9b634a17f8deb2
 2013-12-13 18:56:53 +00:00
jenkins-bot 630249b1cc Merge "[Browser test] Update Firefox + Selenium versions." 2013-12-12 21:40:42 +00:00
jhall b552171189 [Browser test] Update Firefox + Selenium versions. 
Change-Id: Iea8b5dea546140da58759da2db3150f85e1a553f
 2013-12-12 21:33:27 +00:00
jhall b9cd28589b [Browser test] Updates to use new Insert menu 
"Insert" menu replaces "More" menu for
accessing some advanced markup features.

Change-Id: I57635b54f3a5b2b72f754747bdb836fe1bfda5ec
 2013-12-12 21:32:42 +00:00
jhall d35cc1e573 [Browser test] Update to use new text styling menu 
Also removed some duplicated code and
added test cases for bold and italic styling.

Change-Id: I181c208dd1165ea52bd4c49eb00c2eaae41ef05f
 2013-12-12 10:37:48 -05:00
cmcmahon d627b4da8f [Browser tests] maintenance for remove parameter/template buttons 
Change-Id: Ia04ddc5aa18f412bb2e02ee45dcfdc421b3ec64a
 2013-12-09 17:39:09 +00:00
jhall ba90be7d7a [browser test] Headings now include a buffer space 
Confirmed with James F that this was an intentional Parsoid
change (and not a bug).

Change-Id: I21d7eba4675eaf7250267003516585e96069b4e6
 2013-12-06 20:55:58 +00:00
Zeljko Filipin e195aa7bb5 Updated Ruby gems 
Checking if selenium-webdriver 2.38.0 fixes cursor problem in Chrome.

Change-Id: I4467ed4ec1b3d7007f4293e3791f41502ce05959
 2013-12-06 16:11:36 +00:00
cmcmahon e54170929d [browser test] Chrome seems to not honor when_present() correctly 
1) Added another sleep statement which seems to fix the issue locally.
2) Modified a link page element identifier.

Change-Id: Ic0006f18752d3625bc244d924a7a8a9fac2d5221
 2013-12-06 15:02:53 +00:00
mayankmadan 306665fa72 [browser test] Changed readme file so that it points to mediawiki-selenium 
Bug: 56089
Change-Id: Ia0f5d0a36337d883c4066a866aada98d849b8315
 2013-12-05 17:52:58 +00:00
jhall 02ae003f2b [Browser test] Removing hard-coded MEDIAWIKI_USER value 
Per this QA mail list discussion:
http://lists.wikimedia.org/pipermail/qa/2013-December/000799.html

Change-Id: Ide3bafe9b69eb5769eb99d0a3989d0e909f512ea
 2013-12-05 16:56:29 +00:00
jhall 1b847c44dd [Browser test] Restoring a missing page element 
Earlier check-in for a VE media interface test
inadvertently re-named a page element that
should not have changed.

Change-Id: Iac1ef365e9cb3912977c8a89f3158ad9d122c93d
 2013-12-04 16:03:15 +00:00
jenkins-bot 12d2210cb3 Merge "[Browser tests] Prefer double-quoted strings in Ruby code" 2013-12-04 12:17:01 +00:00
jhall 73198b52d0 [Browser test] New test for VE media interface 
Updated to capture changed iframe positioning of some page controls.

Change-Id: I3864e04935eca1ae7c9d70df42fd34ce58e90d66
 2013-12-03 23:12:57 +00:00
cmcmahon c65a683ecf [browser test] more shuffling of elements among iframes 
Change-Id: I1a60e2370fc436702d983705d7360563f5483242
 2013-11-27 09:05:58 -07:00
mayankmadan 2af79b6108 [Browser tests] Prefer double-quoted strings in Ruby code 
Bug: 57597
Change-Id: I4ddc3f20d03bf3e66b04234be529c3eaa29be9e0
 2013-11-27 16:01:23 +05:30
cmcmahon 0a091193f9 [browser test] elements moved among iframes 
Change-Id: Icc9f3f4422dfed063073724f8b610e75fd967b2d
 2013-11-26 18:55:21 -07:00
Jeff Hall c027af9e12 [Browser test] Expanding test with additional text markup types 
Change-Id: I3141993f1527dfdeea66ac2a52ee7c8be384f198
 2013-11-19 13:42:07 -08:00
Jeff Hall 583936f82f [Browser test] Add Review Changes workflow per reviewer comment 
Change-Id: I50d0defb3c4f51f317a497d0f805859e961b8f7f
 2013-11-19 10:28:26 +01:00
cmcmahon 2d6864e19f [browser test] Additional UTF-8 editing test string 
Change-Id: Iaf894043462e114e0845fc3016396ab4f51fa21b
 2013-11-13 18:46:44 +00:00
cmcmahon d2165ad8fb [browser test] identifier for Link close element changed 
Change-Id: Ia923c775315af9f0cd7017e0b02e621b3d9112b4
 2013-11-13 00:23:50 +00:00
cmcmahon f8d0cbded5 [browser test] one more variable string no longer hard coded 
Change-Id: Ifa4917442707d0c83799ea7e018ae1c4aa7bb4c6
 2013-11-08 09:19:30 -07:00
cmcmahon 53cb5a3ffd [browser test] edit string no longer hard coded 
Change-Id: I8d9e9ae2cafa18a9a680abdca8c4224ef10a08b6
 2013-11-08 07:35:38 -07:00
cmcmahon ca2a7ce38f [browser test] input string no longer hard coded 
Change-Id: I361b3ea025e405d1fc5a2e12c3c85d177147b90d
 2013-11-06 17:08:42 -07:00
cmcmahon 3754bc77e4 [browser test] add a test to edit with utf8 strings 
Change-Id: I88e475ee98bc8f696c1a1d0ad108c12a48fe7eee
 2013-11-05 07:45:06 -07:00
Zeljko Filipin efa741baea [browser test] Updated Ruby gems 
Change-Id: I8c298efe8dd1abbb42b5c42ee0b8075a0aad9acf
 2013-11-04 15:36:03 +01:00
Zeljko Filipin abc5b9920d [browser test] Removed visual_editor from file names 
No longer needed, since the files are now in VisualEditor repository.

Change-Id: Id677c2630ff5a1ae2d49f62058d0d4fdebeaf381
 2013-10-31 16:22:08 +00:00
jenkins-bot 5d55d3a5b9 Merge "[browser test] changes make it convenient to click Refs icon" 2013-10-30 17:32:34 +00:00
cmcmahon 86745454a6 [browser test] changes make it convenient to click Refs icon 
Change-Id: I9a9ca50357601e9d254a8c86e172a497ca839387
 2013-10-30 10:35:57 -06:00
cmcmahon 937f68aaa8 [browser test] changes make it more convenient to click Transclusion icon 
Change-Id: I21e5a0f11f58c7f199d9c36c2ac65705c295b397
 2013-10-30 16:27:15 +00:00
cmcmahon e4549a14b3 [browser test] disabled indent/outdent are now spans not links 
Change-Id: I8b8788f4c92219480936360efe7153ab093c274e
 2013-10-30 09:49:39 -06:00
cmcmahon 2fd5507f99 [browser test] remove OS-specific part of elements using :title 
Change-Id: I1d6db5b6bf9bec44f5646ed8f7096ce462a5707c
 2013-10-29 09:47:44 -06:00
jenkins-bot 9ae15a77b7 Merge "[browser test] fixed Cucumber tags" 2013-10-29 06:20:59 +00:00
Roan Kattouw c9b959e878 [Browser tests] Fix a couple of stray ve-ui classes that moved to oo-ui 
Change-Id: Ie89c0b1312b3150e7a3d9144d771a8996f0f606d
 2013-10-28 23:10:42 -07:00
Trevor Parscal e83dc3f8fc Use a toolbar for the actions buttons in ve.init.mw.ViewPageTarget 
Change-Id: I260059802379d8cab8ca175b7d7d32813e3ff10a
 2013-10-29 05:57:52 +00:00
Trevor Parscal 230d88d182 Isolate links within OO.ui.Tool 
This allows other content to be added without it being nested inside an
<a> which results undesired visual and functional effects.

Change-Id: I667878fe4ae682712094a61bb4b411ac5fb999c7
 2013-10-28 22:55:32 -07:00
Zeljko Filipin 781e788b9d [browser test] fixed Cucumber tags 
There was no space between a couple of tags in a couple of files.

Change-Id: I1fadc61e41a4a0e210739106f5f8b28b2a460f01
 2013-10-29 06:55:24 +01:00
jenkins-bot 40da34aa36 Merge "Split oojs-ui from ve.ui" 2013-10-29 05:45:02 +00:00
Trevor Parscal d2dfb9ac4f Split oojs-ui from ve.ui 
* Move and rename generic parts of ve.ui to OO.ui
* We now have a UI test suite because ve.Element (outside ve.ui)
  is now part of oojs-ui, so it needs a test suite.
* Added to the MW test run (just like we do for unicodejs).
* Updated csslint config (also added ve-mw and syntaxhighlight
  which were missing).

oojs-ui still depends on the TriggerRegistry in VE, this is addressed
in a follow-up commit.

Change-Id: Iec147155c1ddf20b73a4d15d87b8742207032312
 2013-10-28 22:40:08 -07:00
cmcmahon 192b9d3c1e [browser test] workaround for VE bug probably caused by https://bugzilla.wikimedia.org/show_bug.cgi?id=56274 
Change-Id: I2b872966399ecb6eb60da619eb9af52ae33f3aca
 2013-10-28 20:42:46 +00:00
jenkins-bot 58d581669b Merge "[browser test] don't run cursor test pending Bug 56068 and review" 2013-10-28 16:58:08 +00:00
jenkins-bot c51d3f7b64 Merge "[browser test] organize tags for running in beta, test2" 2013-10-28 16:57:01 +00:00
cmcmahon f0444ca3c0 [browser test] don't run cursor test pending Bug 56068 and review 
Change-Id: If7f7b063398adef822f1a4d1bfa385f1517b8533
 2013-10-28 10:44:54 -06:00
cmcmahon 4029605979 [browser test] organize tags for running in beta, test2 
Change-Id: I706cd995c9e8c5529782621288e24952cd6b3b63
 2013-10-28 09:58:05 -06:00
cmcmahon 5b7bd6d56b [browser tests] add the double-logout fix to the other Before clause 
Change-Id: I23e73d0c91b9d7f77fb8390fcae22ac00ce086e1
 2013-10-28 15:40:53 +00:00
Zeljko Filipin aa3c569e28 [browser test] Workaround for the problem when Cucumber hook executes twice 
Bug: 56116
Change-Id: I99bf48b1452647b42edd97dc47e8664b08b7667a
 2013-10-25 17:26:05 +02:00
Zeljko Filipin e6cd405abf [browser test] Use the latest version of mediawiki-selenium gem 
Change-Id: I14baca7b9cfb6a76a4e026ea5c6673b87ced3c0f
 2013-10-25 15:10:56 +00:00
Zeljko Filipin 904c5a48ad [browser test] Moving shared code to mediawiki-selenium Ruby gem 
Bug: 53579
Change-Id: I4ef8b63f485b0274f252cf95e566f0484615e8cf
 2013-10-23 16:43:51 +00:00
Zeljko Filipin 421924bd69 [browser test] cursor feature was not tagged @login 
Change-Id: I587ad033c93078d8e626840de3b3eedc73b83516
 2013-10-21 13:04:43 +00:00
cmcmahon 828747f0f0 [Browser tests] identifier for anonymous warning changed for test2 
Change-Id: Idfdd6db441205280373f8d24bf0a693b46eed1af
 2013-10-18 01:31:47 +00:00
Zeljko Filipin a3ae0478ed [browser test] Updated Ruby gems 
Change-Id: I78cbac61ca534957a39474a82306aaa954ab9de1
 2013-10-17 16:19:03 +00:00
cmcmahon 22f409070b [browser test] icons appear hovering when cursor is on object 
Change-Id: I296445d0ec11f375ddb30f293ec3542ccc6332d6
 2013-10-11 17:19:01 +02:00
cmcmahon 50ffa7c40c [browser tests] remove cruft and order page.rb file 
Change-Id: I7d7cba0256e1d2631cdc4b73026c89cb5c85e0f5
 2013-10-10 07:35:50 -06:00
cmcmahon bd2b828555 [browser test] update references for proper iframes, new workflow 
Change-Id: Icafbbcac9a70401bd87ea87e6dbb94ea9a6c3726
 2013-10-09 13:29:58 -06:00
cmcmahon 46aed9debd [browser test] up arrow no longer exists, use X instead 
Change-Id: I79684633b69ad48b4ce291e2bd6e12d14564cca6
 2013-10-09 12:51:03 -06:00
cmcmahon 6c299ff2b3 [Browser tests] Sort all the elements for Links tests to proper iframes 
Change-Id: I873cfaccf7211f379eadc6574edbe8de8c2e15f1
 2013-10-09 18:26:48 +00:00
cmcmahon d3a75d0501 [browser tests] editing controls to proper iframe 
Change-Id: Ifc24e4fcc0fe4688ee8e8b277f54fe2582dcadaf
 2013-10-09 17:24:19 +00:00
cmcmahon f8d4f10de7 [Browser tests] transclusion elements to new 3rd iframe 
Change-Id: Ia1a02ece54c44d3bfb0dd985fec97e9c8d5b9d59
 2013-10-09 16:55:03 +00:00
cmcmahon 46d14ca163 iframe 
Change-Id: Id771991a89e1cf836c7f19083df22edb38ffc6c8
 2013-10-08 16:38:44 -06:00
cmcmahon ad1a579197 dismiss latest warning iframe 
Change-Id: Ic1c5099f1531174140c2033212da35632a6188cc
 2013-10-08 11:17:14 -06:00
cmcmahon 971b026786 id for ip warning changed 
Change-Id: I6623751228be1aa550ec8c7e1e3071a38563ada0
 2013-10-08 06:00:43 -07:00
Trevor Parscal 6ec34a3dee Toolbar action widgetization and UI refactoring 
Objectives:

* Use widgets to render toolbar actions
* Remove labels next to help notices and edit notices buttons
* Add a close button to the help notices and edit notices

Overview:

* ve.ui.ButtonWidget is now abstract, use ve.ui.PushButtonWidget instead
* ve.ui.IconButtonWidget now inherits from ve.ui.ButtonWidget
* ve.ui.PopupWidget's display method no longer takes x and y arguments
* Fixup naming issues in MWCategoryPopupWidget
* Fixup naming issues with some ve-init-mw CSS classes
* Rename ve-mw/ui/styles/ve.ui.Widget.css to ve.ui.MWWidget.css
* Change uses of "callout" to "tail"
* Add hyperlink functionality to buttons
* Make buttons accessible through focusing, but make unfocusable by
  clicking
* Add head option to popup for rendering a title and close button

Bug: 52386
Change-Id: Iea2c8df1be64d40f9c039873d89ee540cc56e687
 2013-10-04 16:26:13 -07:00
Zeljko Filipin 45a222a863 The element has different title on a Mac 
It is "Edit this page with VisualEditor [ctrl-option-v]".

Change-Id: I54d72c63f07826106e8fbb0de0828dd82b67c766
 2013-10-04 17:14:03 +02:00
cmcmahon d8bdbd0570 reset @make_selectable_line properly again 
Change-Id: I1efa45f639bc4a7cdd764be3f5c23ba2ef2605e9
 2013-10-02 08:44:18 -07:00
cmcmahon eb0919981f reset @make_selectable_line properly 
Change-Id: I8bd55b2ddc55b8368826af58903e7f988058b325
 2013-10-02 15:03:32 +00:00
cmcmahon f5e18e45a2 refactor to use Scenario Outline and REUSE_BROWSER env var 
Change-Id: I65970c0df35bcac48f16899090cadc8df8c560c6
 2013-09-27 11:36:53 -07:00
cmcmahon 7849be8ec0 indent/outdent is conceptually different than bullets strings 
Change-Id: I8fec64d6d01148f18588a8af7336e9791f88640b
 2013-09-27 09:08:37 -07:00
cmcmahon 2fb1313f7e VE link not immmediately present since opt-in change, especially in Chrome 
Change-Id: Ia0baff017b3b887f06182b1c8630b2270bc8823b
 2013-09-26 23:11:02 +00:00
cmcmahon 5d84372f36 make test DRY, use Before hook 
Change-Id: I6f127e675a3c9e7b6126c0f052dce781d1103b52
 2013-09-26 18:01:37 +00:00
cmcmahon a855dd067a don't run VE test on beta for anon, since VE is now opt-in 
Change-Id: If6690ff82c23fe69544d087efb51ae4c6b1891fb
 2013-09-24 10:18:19 -07:00
rachel99 1157b50fe8 VE bullets, numbering, indents, outdents 
Change-Id: I0394c9d6f89e9a723d070b517560685d003f7bef
 2013-09-18 11:53:30 -07:00
cmcmahon ab26c1fb2f update class for suggestion list element 
Change-Id: Id4e653ec0400609d1aa19de55a7080ec122216d7
 2013-09-17 17:19:41 -07:00
Zeljko Filipin f4de574350 Updated Ruby gems 
Cucumber 1.3.6 seems to be problematic:

gems/cucumber-1.3.6/lib/cucumber/rb_support/rb_language.rb:122: warning: redundant nested repeat operator: /^** This is a new line/

Updating the rest of the gems too.

Change-Id: Ia173312baa178a45d648fc537c8abf914144bbd5
 2013-09-17 20:46:14 +00:00
cmcmahon daa0b10b16 VE support on beta is now reliable, run tests there 
Change-Id: I82e42f24a6950680770bf6fc2b11e554d95224b6
 2013-09-16 18:50:26 +00:00
cmcmahon 6a91695c59 update tests for latest release- no issues found 
Change-Id: I84830927a72a908fa4b676ccdbbd33afd8835638
 2013-09-06 11:23:45 -07:00
cmcmahon 88504aa3d9 use regexp anchors to prevent false matches 
Change-Id: Ib13b85986e3df431b0f900fea38165197411370e
 2013-08-30 17:28:40 +00:00
Zeljko Filipin 8f7e9c27a7 Moved VisualEditor Selenium tests from browsertests repository 
Requested by James Forrester at QA mailing list:

http://lists.wikimedia.org/pipermail/qa/2013-August/000339.html

Bug: 53467
Change-Id: I915b4e41d32c9190ccea73f2b3bce9a53918fe80
 2013-08-28 20:14:21 +00:00