Commit graph

8595 commits

Author SHA1 Message Date
jenkins-bot ad92b977d5 Merge "Followup a054a75: don't reintroduce removed template parameters" 2014-11-10 20:44:28 +00:00
jenkins-bot c888e2b0d3 Merge "Followup c232083: use getRelativeTitle for template titles" 2014-11-10 20:34:56 +00:00
Roan Kattouw aa84df021a Followup a86d824: fix reference to this in foreach callback
Bug: 73235
Change-Id: Ib8f877f747df6c8047c7e3d2c152e0e7a9f60b8a
2014-11-10 15:22:19 -05:00
Roan Kattouw 5f1e7a651c Followup a054a75: don't reintroduce removed template parameters
Deep-extending originalData is asking for trouble, because there's
no way to delete anything that way.

Bug: 73134
Change-Id: I44d3e582e04942efceae3e0bdbbaa147095b5146
2014-11-10 15:04:42 -05:00
Roan Kattouw 2ba844a372 Followup c232083: use getRelativeTitle for template titles
Otherwise we output stuff like {{Template:Echo|hello}}

Change-Id: Ib6c3996ab40e01a5ddce84b7daffa27a74020ee5
2014-11-10 15:03:10 -05:00
jenkins-bot e611eaeb5f Merge "[BrowserTest] Fixed failing language screenshot browser tests" 2014-11-10 13:06:47 +00:00
James D. Forrester d4c133b573 Update VE core submodule to master (bc4355a)
New changes:
fe0bc6c Move most of ve.js to ve.utils.js
6be79d9 Remove and restore selection for non-isolated dialogs
2bf123d Localisation updates from https://translatewiki.net.
d2c4d18 Fix missed conversion of inlineMenuWidget to dropdownWidget in demos
bc4355a Localisation updates from https://translatewiki.net.

Local changes:
* ve.utils.js updates

Change-Id: Ibb7d7483b23edcccbd83dc8fadd4407dca380a25
2014-11-10 12:56:17 +00:00
Vikas S Yaligar 901b0deeed [BrowserTest] Fixed failing language screenshot browser tests
Bug: 73033
Change-Id: Iea3a03b1ec628bfe03f10b4cb2a4795d4fabb8bc
2014-11-10 11:07:49 +00:00
Translation updater bot 2addf93fa0 Localisation updates from https://translatewiki.net.
Change-Id: I1aac2fe3ad1eec132d45a7315e5e098ace57c546
2014-11-09 21:55:01 +01:00
jenkins-bot 1f4335a1e2 Merge "Show category items as red if they don't have description pages" 2014-11-09 14:10:32 +00:00
Translation updater bot aa0eab73b6 Localisation updates from https://translatewiki.net.
Change-Id: Ieb369522a74d50eef8cdea0a409abdf29d65b140
2014-11-08 22:20:26 +01:00
Alex Monk de73246ee1 Show category items as red if they don't have description pages
Also fix some lies I wrote in related code/docs

Bug: 65517
Change-Id: Iafacee7d8e460913d84808fe38ecc8da4a1817c0
2014-11-08 14:27:27 +00:00
jenkins-bot 3ebbfe6953 Merge "Fix craziness in template dialog focusing" 2014-11-08 00:54:56 +00:00
Roan Kattouw a86d824c56 Fix craziness in template dialog focusing
setMode() is called multiple times, but it didn't
check whether the mode being set was already set.
Because it's a setter, make it idempotent.

This fixes the problem where the first input will
be focused first, then blurred later, but it
introduces a new problem because the label for
the 'mode' ActionWidget is set from setMode().
To solve that, factor the setting of this label
out into its own function and call it on setup.

Bug: 73138
Change-Id: I9bb127f22f6c0b745b393c523ec42f320fc85cf3
2014-11-07 16:41:03 -08:00
Translation updater bot 6fea75bf7b Localisation updates from https://translatewiki.net.
Change-Id: I76eb90ec1ad222f5887a01a1a4abb38337b8a9ce
2014-11-07 22:15:17 +01:00
jenkins-bot f7b947f14c Merge "Support pre's in tables" 2014-11-07 17:56:11 +00:00
Cmcmahon d51e171268 [BrowserTest] Update RubyGems to get the latest version of Selenium
Change-Id: I5ba443b68d831f4a8763b2f57463b56a17c90c2c
2014-11-07 15:47:54 +00:00
Ed Sanders 5238d06dc7 Support pre's in tables
Bug: 73100
Change-Id: I971420047026c91ed92a19a52d2fd3b6fbeac24a
2014-11-07 15:44:13 +00:00
James D. Forrester 09a518db71 Update VE core submodule to master (bb67705)
New changes:
a824357 Node method cleanups
fa4e504 Add isAllowed(Child|Parent)NodeType to ve.Node
08974ed Replace block drop logic with isAllowedChildNodeType check
5fb113e Don't focus Edit HTML on load
799d27b Create table cells with wrapper paragraphs by default
5d3b5db Localisation updates from https://translatewiki.net.
11cb975 Use hasOwnProperty instead of 'key in obj'
77e24e2 Update OOjs to v1.1.2
bd36a32 Update OOjs UI to v0.1.0-pre (12b66051ff)
f368788 Localisation updates from https://translatewiki.net.
1ee759b Fix non-linear selection handling in ce.Surface#focus

Change-Id: I89aba1cb50cda91721473c2c33b41d7b12433bd5
2014-11-06 17:03:11 -08:00
jenkins-bot 27e70a6a21 Merge "Matching pages from suggestions in link dialog now actually work as links" 2014-11-06 21:49:07 +00:00
suchetag cb704dee84 Matching pages from suggestions in link dialog now actually work as links
* A subclass of MenuItemWidget from OOUI, MWLinkMenuItemWidget, is introduced that, when used in MWLinkTargetInputWidget for both
external and internal links, returns actual page links.

* MWInternalLinkMenuItemWidget is extended from MWLinkMenuItemWidget to support the internal links.

* LinkCache is being used in MWInternalLinkMenuItemWidet to stylize the links. Thus, getting rid of some old css classes.

Bug: 51205
Change-Id: I3ac18dabd514ca539fff1db3c67ae97931c3d4fc
2014-11-06 13:46:09 -08:00
Translation updater bot 47295b4441 Localisation updates from https://translatewiki.net.
Change-Id: I0d8f1d19fdae87a23f088dbad5e2dac413b5825a
2014-11-06 21:56:21 +01:00
jenkins-bot 613e69b2c8 Merge "Refactor out show/hide loading spinner" 2014-11-06 18:39:06 +00:00
Ed Sanders 841dfda98d Refactor out show/hide loading spinner
Change-Id: If505a46f54921ce4742ecfed598eb07a9ba5e3eb
2014-11-06 16:41:05 +00:00
jenkins-bot 1a6c46f7ee Merge "Use hasOwnProperty instead of 'key in obj'" 2014-11-06 12:37:04 +00:00
jenkins-bot 81d153b430 Merge "Disable review button while save dialog is pending" 2014-11-06 00:35:17 +00:00
jenkins-bot 209dbe2449 Merge "Allow headings in table cells" 2014-11-05 23:52:23 +00:00
Alex Monk 3628fc0ffc Disable review button while save dialog is pending
Bug: 65310
Change-Id: I7cfb5d84b91b4a20282e126b8c863c15519b5a9d
2014-11-05 23:36:33 +00:00
jenkins-bot cfed84e063 Merge "QA: sort remaining page elements that belong in the iframe" 2014-11-05 22:43:36 +00:00
Cmcmahon beebfff6f9 QA: sort remaining page elements that belong in the iframe
We need to figure out where the language screenshot elements reside

merged as an interim step to share the code more easily, no change
to function

Change-Id: Icae480aaa526a9de6e6926e027c0cac0c7de997e
2014-11-05 15:39:10 -07:00
Ed Sanders 26f567d84f Allow headings in table cells
We possibly want to discourage this somehow but our current
functionality achieves this by doing an isolateAndUnwrap
which for a table is catastrophic.

Bug: 72990
Change-Id: I79f1348da20385dfec014afcac0fb5464580cf2f
2014-11-05 22:34:13 +00:00
Roan Kattouw e144e55972 Followup 31bafa1: forgot to rename 'data' to 'args' for citation commands
Bug: 73001
Change-Id: I8cc436cbe16955130d25b2385e3f561fd2ffb4d5
2014-11-05 13:46:54 -08:00
jenkins-bot ca7ef3be1f Merge "Remove the loading spinner at the end, not halfway through loading" 2014-11-05 21:00:53 +00:00
Ed Sanders 0efbfa7e21 Use hasOwnProperty instead of 'key in obj'
Change-Id: I48f044c547b48a97cdfb31f7b887dca0ed7e341b
2014-11-05 20:54:50 +00:00
Roan Kattouw ccd9142262 Remove the loading spinner at the end, not halfway through loading
We were attaching its removal to the wrong promise in 2 of the 3
places where it was being called.

Also this file is horrible and should be refactored. A lot.

Change-Id: If74b1629266f22e2d110305b139bef4a8e69b13b
2014-11-05 12:50:40 -08:00
Translation updater bot 58ba085453 Localisation updates from https://translatewiki.net.
Change-Id: Icaf0b9a1ce7848d97c1466cdbc1cff4d4335e54a
2014-11-05 21:50:17 +01:00
Roan Kattouw 0f58940c4d Follow-up 07251d0: Add mobile target to RangeFix
Bug: 73038
Change-Id: I675c21ffe575e27a6fbc13bccbc1482e884f50e0
2014-11-05 11:08:44 -08:00
Cmcmahon f8b34e4e89 QA: remove stuff now that iframes are gone
Change-Id: I6d520acd9d1e18d803f7e44f5ea45502658f14d9
2014-11-05 10:01:55 -07:00
jenkins-bot 06387f7f54 Merge "Revert "Clear selection after tearing down surface to work around Firefox bug"" 2014-11-05 01:39:16 +00:00
jenkins-bot 49f41784ab Merge "Update VE core submodule to master (caaff2c)" 2014-11-05 01:39:14 +00:00
Catrope c8396eb65f Revert "Clear selection after tearing down surface to work around Firefox bug"
Superseded by I051ef92eeea9 in VE core.

This reverts commit d68eae6c8d.

Change-Id: Ie5e0a6169cfe3634e20a3b88e8aeb980b4094e10
2014-11-04 17:20:30 -08:00
jenkins-bot d6c3a4aa92 Merge "Kill MWCategoryWidget#onLookupEnter" 2014-11-05 01:18:15 +00:00
Roan Kattouw 711d3629dd Update VE core submodule to master (caaff2c)
New changes:
d0ab5bd Localisation updates from https://translatewiki.net.
6b876bd Update OOjs UI to v0.1.0-pre (b38d485723)
caaff2c Blur contentEditable node while destroying surface

Change-Id: I4121ed82617053e8763cdc3d3aaa5ee9aa76e571
2014-11-04 17:17:47 -08:00
jenkins-bot 3c899559b4 Merge "Fix indicator alignment in MWCategoryItemWidget" 2014-11-05 01:01:23 +00:00
Roan Kattouw a5e9e1f456 Fix indicator alignment in MWCategoryItemWidget
We were setting the height to 2.25em which just happened
to be right, but it depended on the browser's default
line-height being a certain value. Now that that's changed
with unisolation, the alignment breaks.

Instead of using a magic value, use height: 100%; so it
takes the parent's height. We don't even have to make the
parent position: relative; because it already is.

Also change the width to 2em, which is a much more defensible
value than 2.25em. Previously 2.25em kind of made sense because
that was also the height (resulting in a square box), but
now we don't have that excuse any more.

Bug: 72962
Change-Id: Id617bfaafefd1fc1530fbee29be5d935ec486b92
2014-11-04 16:53:11 -08:00
Roan Kattouw 07251d070b Add the RangeFix library to VisualEditor.php
It wasn't being loaded at all, but we didn't get any errors
because every single call to RangeFix was in a try-catch.
We did, however, notice that context positioning was broken,
this fixes that.

Change-Id: I0a981f0c70a9a7bbd89ee2946cb7c566a63490aa
2014-11-04 15:28:52 -08:00
jenkins-bot 309305b03e Merge "[BrowserTest] WIP adding cases to test other options under Page Settings to options.feature" 2014-11-04 23:04:40 +00:00
ryasmeen@wikimedia.org 4aa8be0e71 [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature
Also:
* Fixed a typo in options_steps.rb
* Disabled Metrics/ClassLength Rubocop cop.

Change-Id: I7128ba8f7ebf9c63aef9399a9cdf24831e1a2d38
2014-11-04 15:01:45 -08:00
Translation updater bot f9517993de Localisation updates from https://translatewiki.net.
Change-Id: If507707479641bfd07e950f03136b46e53f3c62f
2014-11-04 23:33:19 +01:00
James D. Forrester 31bafa183d Update VE core submodule to master (a942301)
New changes:
2cc219a Update OOjs UI to v0.1.0-pre (571f26d0ab)
3543cb7 Protect against offset=-1 in insertContent()
7a3d456 [BREAKING CHANGE] Move selection restrictions from tools to commands
3d847bb Disable desktop context on table selections
41282dd Missed function rename from RangeFix change
dd6c8b8 Support toDomElements returning an empty array
9be6464 Placholder -> placeholder
9bdd0a8 Restore basic styling to toolbar in core target (only)

Local changes:
Move selection restrictions from tools to commands

Change-Id: I88f3d04946bd1d03ed001d747475a8b495a0f64c
2014-11-04 14:11:04 -08:00