Volker E
a5a3d829a9
Update user avatar icon and make use of OOUI's built-in
...
Bug: T123810
Change-Id: I3ed04d3037836b47706d9f7284eeb9668712bdcb
2018-10-10 18:34:27 -07:00
Thalia
a4f033a1e6
Use correct OOUI hierarchy in media dialog
...
In the "advanced settings" tab, make sure widgets are wrapped in
field layouts, then fieldset layouts.
Bug: T205615
Change-Id: I141f9954e482f9d5afd84bfa63384b90a2911d00
2018-10-03 21:54:41 +01:00
Thalia
56cd18e674
Refactor media dialog initialize method
...
Change-Id: Ida7b50a89ab454ba023334cd2203d2e2e6150931
2018-10-03 20:50:36 +01:00
Bartosz Dziewoński
7a18889ddd
ve.ui.MWMediaDialog: Remove unused CSS
...
This rule was being overridden by a more specific rule from OOUI with
the selector `.oo-ui-fieldLayout.oo-ui-labelElement`. I don't think
the margin tweak would be useful.
Change-Id: If6321ba7ea1cfad83f65f137b2a440957bf2fea6
2018-10-02 00:02:03 +02:00
Bartosz Dziewoński
9cf5515ccb
ve.ui.MWMediaDialog: Remove unused widget and messages
...
* visualeditor-dialog-media-size-originalsize-error
Unused since 37b3c07b26
.
* visualeditor-dialog-media-originaldimensions
Never used (introduced in 4947420650
).
Change-Id: I22f37b457cc6fbac03593fece003e97f4f5a2ccf
2018-09-27 18:31:20 +02:00
Thalia
9813d876e1
Enable the media dialog on mobile visual editor
...
Also make improvements to the layout, so that the dialog works
in desktop and mobile - most importantly, change from booklet
to index layout.
Bug: T190885
Bug: T118710
Change-Id: I1915d06c9b0e4b7907136e645f60be96e30cc287
2018-09-27 13:21:15 +01:00
Ed Sanders
985a94777a
Change type from 'frame' to 'thumb' when resizing
...
Bug: T204185
Change-Id: If40c70a074263b870aee4e5c87c3f4b5e98d0c4b
2018-09-24 15:31:58 +01:00
Bartosz Dziewoński
fc91623b94
ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess
...
Follow-up to 13675e4a81
.
Bug: T185944
Bug: T199841
Change-Id: I2bf08bc0a3684dbfdb9574ea6df0352e8d9d8fd7
2018-07-18 06:30:46 +02:00
Ed Sanders
6bf9210abe
De-duplicate and fix updating of file link in media dialog
...
Bug: T198565
Change-Id: I7d06d3316b317fb85edb9461080f5f2e5cd439fe
2018-07-03 17:59:43 +01:00
jenkins-bot
95d831c2de
Merge "Create getters for localised APIs (getContentApi/getLocalApi)"
2018-05-07 15:51:45 +00:00
jenkins-bot
25d2eb2848
Merge "Use ve.resolveUrl in MediaContext/Dialog"
2018-05-07 15:28:52 +00:00
Ed Sanders
478b0bcbb9
Create getters for localised APIs (getContentApi/getLocalApi)
...
Pass through the current document when available, otherwise
assume the current surface's document.
Also add a getter for getPageName, so that can vary based
on the target document.
Bug: T193856
Change-Id: Ifdc951fdc6a43b924d102e3fcd7e59e52023757b
2018-05-05 14:32:55 +01:00
Ed Sanders
3b4923fa74
Use ve.resolveUrl in MediaContext/Dialog
...
Change-Id: I53e28d6cec13ac77718ba3cae425c4c43c96e174
2018-05-05 14:04:15 +01:00
Ed Sanders
ebcf1e1151
Check imageModel exists in #checkChanged
...
Bug: T193879
Change-Id: Ic6eda7a056e5207042b575609b9da1869e3a759e
2018-05-04 14:52:03 +01:00
Bartosz Dziewoński
b8bcba8cbe
ve.ui.MWMediaDialog: Use dropdown for image type selector
...
The dialog is not wide enough to fit four buttons side-by-side.
Bug: T74187
Change-Id: I6a4e5692b5f1b2ca9bb78d4e6c6103036f371a52
2018-03-27 14:40:39 +02:00
Ed Sanders
8bfb270168
Use single-line editor for image captions
...
Depends-On: I2be081c766fab41b152d03b43e7e936e3f636166
Change-Id: Ifcdc34826ad81e96c22fd68ceb637107cde24d4a
2018-03-20 22:51:27 +00:00
James D. Forrester
0a7a845a42
doc: Bump copyright year
...
Change-Id: I0b299c840ede1a1b8552cecfc70c5760ab036181
2018-01-03 17:45:07 +00:00
Ed Sanders
8a356b19d7
Enable spellchecking on media caption inputs
...
Bug: T182393
Change-Id: I23d3f1b37225f9e5a9a9651b6e7b590d38dc99b3
2017-12-12 16:42:55 +00:00
David Lynch
7777f69e7b
Use rel="noopener" on links targeted at new windows
...
Bug: T180932
Change-Id: I93bda6aaebf97727a187774cccbeba4f27fcddd5
2017-11-30 13:15:38 -06:00
James D. Forrester
2c70792c4f
Replace constructive with progressive UI flag
...
Change-Id: Iae36e978978ed6642f44606a934c540cf5f8537f
2017-09-26 15:14:32 -04:00
jenkins-bot
b73deb1690
Merge "Create wrapper paragraph when converting block image to inline"
2017-08-24 22:16:16 +00:00
Ed Sanders
eb2ee52de0
Create wrapper paragraph when converting block image to inline
...
This prevents the image jumping into another paragraph,
e.g. in a different table cell.
Move the logic for removing the old image out of MWMediaDialog
and into MWImageModel#insertImageNode.
Bug: T121449
Change-Id: Ibd7c92f3f90c382ceffd3e0defb12ba36a3786d2
2017-08-24 15:56:22 +01:00
Ed Sanders
b11b144ad6
Don't focus media dialog until ready process
...
Bug: T174027
Change-Id: I070b5538e12c8a165a714ac6c3fd172f0ed179d4
2017-08-24 15:38:11 +01:00
Ed Sanders
835a775a49
build: Upgrade grunt-eslint from 19.0.0 to 20.0.0
...
Mostly indent and regex fixes.
Change-Id: Iaf9d02363c78cb71deec5c4cab53a05b67f60600
2017-07-18 12:55:33 +01:00
Volker E
f695877de7
Rename deprecated Card to current TabPanel
...
Renaming CardLayout to TabPanelLayout and all connected code instances.
Follow-up to Icfe1652cc038dc131b6b855ce9b45040b8ee5178
Bug: T164903
Change-Id: I9ce4e31e390522d469e126fb3a4b05787cef7fef
2017-05-10 11:46:49 -07:00
David Lynch
9e86d17260
MediaDialog: flag caption widget as being in a dialog
...
This means that cmd+enter won't add a newline when it closes the dialog.
Bug: T161555
Change-Id: I738c9acf8cce437ce6bc4c8db29f28d1fff3d2c9
2017-03-28 11:43:59 -05:00
Bartosz Dziewoński
22df25c108
Pass $overlay to FieldsetLayout and FieldLayout in various places
...
We now use dialog's overlay in every case where we have a FieldsetLayout
or a FieldLayout with a help popup inside a dialog.
Bug: T100571
Change-Id: I8bd0ed430637feca63ec0f13cb7e1e1c659391a5
2017-02-16 02:56:03 +01:00
jenkins-bot
d816492ca1
Merge "rm stray fileRepoPromise property from media dialog"
2017-01-03 20:24:34 +00:00
James D. Forrester
122f49b2dd
build: Bump file copyright notices for 2017
...
Change-Id: I3c20809e71cc0da58123e1b5f29c4f3aac945496
2017-01-03 08:58:33 -08:00
Alex Monk
d7cf29f1c0
rm stray fileRepoPromise property from media dialog
...
seems to have gone upstream to core's mw.widgets.APIResultsQueue
Change-Id: I3c2a6dbdca60ceadc9e7175e5f8ad83b7fc4b7a0
2016-12-24 18:59:48 +01:00
jenkins-bot
745e919f97
Merge "Update VE core submodule to master (9625e8f)"
2016-11-29 20:46:54 +00:00
Ed Sanders
aeafa6afca
Update VE core submodule to master (9625e8f)
...
New changes:
f1297b8 [BREAKING CHANGE] Allow target widgets to be re-used
Local changes:
Re-use target widgets
Change-Id: I5decb918f398704d4b6c108a16fbc1cc073ef077
2016-11-29 11:48:15 -08:00
Ed Sanders
2ee9e62a4d
Use upstream media search widget from core
...
Bug: T140166
Depends-On: If53ef7f4b62c7a5d4da565c14dd2a353778694e5
Change-Id: I28845e9c143e78d3a377f067606c62da212e3bf1
2016-11-29 17:19:14 +00:00
James D. Forrester
36befda61c
build: Replace jscs and jshint with eslint
...
It's new, it's fresh, it's amazing, it's here.
Change-Id: I5dc784411f704685ed5cc763a2b2b1c5d3e5a610
2016-10-28 18:33:15 +00:00
Matthias Mullie
2b4948b0b6
Change mid-upload 'cancel' button to 'back'
...
Bug: T114938
Change-Id: I964708e1267223b181630b9bea5b19e2bdf242be
2016-09-22 16:13:57 +02:00
Ed Sanders
35c0a0dc69
Use cloneWithData
...
Change-Id: I7ffe3c7ab20d5f785a6642c8293f271f4dc08ff8
2016-05-30 21:40:07 +01:00
Ed Sanders
c516d897d2
Remove icon properties from windows
...
Windows stopped supporting icons a while ago.
Change-Id: I8a63152282a5968dcd17675330e31bd1ebe4b68b
2016-03-29 12:33:42 +01:00
Ed Sanders
67c207a6f5
Use abstract target widget creation
...
Change-Id: Ic7e43e80f4f48df99842cee702963d54205e5055
Depends-On: I6a667a641540b347052ea0c645af4e1e59cf333a
2016-03-03 11:49:44 -08:00
David Lynch
7486f74c6f
MWMediaDialog: Only cache relevant information
...
Trim the cached image data from the media dialog down so that it only caches
the same information that would have been fetched for a non-uploaded image.
Consistency!
Bug: T126081
Change-Id: I0f057c111b66f29c6360e27f97256384f5320b75
2016-02-29 10:16:34 -06:00
jenkins-bot
74b2489276
Merge "Link to file description pages in media dialog"
2016-02-22 21:07:43 +00:00
Ed Sanders
deb676e73d
MediaDialog: Use CC logo from upstream (ooui-icons-wikimedia)
...
Change-Id: I4fabf5f8d87b9b21623883203b9d6965a0ff33a0
2016-02-21 18:20:30 +00:00
Alex Monk
ca5cab52af
Link to file description pages in media dialog
...
Bug: T125227
Change-Id: I243f5479ab27ab098d41db08ff4a53195d382577
2016-02-21 03:45:37 +00:00
Ed Sanders
abb094babd
MWTargetWidget: Add missing indent commands to blacklists
...
Bug: T124619
Change-Id: If2a5d98673db6e2d29fe49f1e7f5307437ba3866
2016-01-26 23:46:12 +00:00
James D. Forrester
ada58df361
build: Bump file copyright notices for 2016
...
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
2016-01-03 14:57:25 -08:00
Bartosz Dziewoński
ca81362afd
ve.ui.MWMediaDialog: Make the dialog higher (600px)
...
Avoids a scrollbar for option 4 of the A/B test from T120867.
Change-Id: I3eacb560117219febd6e08066599e2d4d42df219
2015-12-14 20:53:32 +01:00
Ed Sanders
ae26eefb05
Fix typos
...
Add some common ones to typos.json
Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
2015-12-09 16:47:13 +00:00
Ed Sanders
557eb4fe84
MediaDialog: Remove useless empty object arg to media size widget
...
Change-Id: Id85498616f80147cd856d4d12bf5a0e58ad66029
2015-12-07 14:12:56 +00:00
James D. Forrester
3c9a361da0
MWMediaDialog: Add a margin back to the border checkbox
...
This was removed upstream in OOUI as unecessary in general, but clearly
this was the place for which the rule had been designed. :-)
Bug: T119547
Change-Id: I46a1df1141c337b436e66872f1a8cdae026816cd
2015-12-02 18:28:18 -08:00
James D. Forrester
b68e34fdeb
MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one
...
Depends on If4ec151a in OOUI.
Bug: T111100
Change-Id: I90af27a7ba881c588b8a432f1cc1e54ab4c80f79
2015-11-24 18:40:13 -08:00
Ed Sanders
e1d14099e0
Image/gallery icons: Rename and use new upstream versions
...
Depends on oojs-ui > 0.13.2.
Change-Id: Iee4cc52b998626e829fd92346d5ee1295c08f26f
2015-11-18 01:49:31 +00:00