New changes:
6cf26d2 demo: Unbreak eventLogger.html and eventSequencer.html
0ec8fe0 Localisation updates from https://translatewiki.net.
c739533 Destroy toolbar dialog manager when surface is destroyed
652fd88 Localisation updates from https://translatewiki.net.
649c9ce ve.ce.TestRunner: Don't assume there is a 'changeText' before 'endLoop'
8bc7441 imetests: Add a regression test for Polish keyboard input
b12ff72 ve.ce: Remove hacks from Surface#onDocumentKeyPress; add related IME test
8db941e Localisation updates from https://translatewiki.net.
76af411 Localisation updates from https://translatewiki.net.
d8e5766 Localisation updates from https://translatewiki.net.
4c1a0fa Update grunt-css-url-embed
127cd7c Localisation updates from https://translatewiki.net.
1545c82 Localisation updates from https://translatewiki.net.
f40b2ca Update bugzilla links to phabricator
bfd8205 Localisation updates from https://translatewiki.net.
e384bdf Localisation updates from https://translatewiki.net.
1e2e37d Localisation updates from https://translatewiki.net.
Change-Id: I4eb46a831b013aa36678b49575c90388cd5b52c7
Comment updated to indicate that the TemplateData
extension may also register the jquery.uls.data
module.
Bug: T85733
Change-Id: I161662e91148eff515d473ebe5d49d784b21a7a2
This cleans up the selectors for the elements on the toolbar
so that they can be tested.
Class names in the form of ve-test-* are added to elements
that have words for labels: 'Paragraph', 'Cite', 'Insert'.
There is no other way to look up these elements in the DOM
except using the UI text, but it is different in different languages,
so this is unusable for the language_screenshots job,
which is multilingual by its nature.
Bug: T76143
Change-Id: Ib0cb67151d893a5d2efccf798d6b25d197ed34d2
The issue is that when running automatically, upon loading the
page to be edited a second and third time, the cursor ends up
in a random place within the existing text of the article.
The test expects the cursor to always be at the start of the
article text, and this happens in Firefox.
I did a cursory check and I could not reproduce the issue of random
cursor placement upon multiple edits to the same article. There
may be a bug here, but it is not trivial to reproduce.
So let's take this test out of the Jenkins builds in the service
of more reliable green tests.
Change-Id: Ie3dd76c5b40f3035d43e6f0a06327adb70900f60
MobileViewTarget.
Due to this being missed, pageName was getting set to a jQuery object,
which eventually got passed as a data value in a $.ajax call, causing
jQuery to emit a TypeError: Illegal invocation.
I guess this needs a MobileFrontend commit as well. Don't think it fixes
all the issues with loading VE mobile though.
Bug: T78710
Change-Id: I431a902563f608a7a33028cd60112f39c57000a4
New changes:
4166f91 Refactor debug bar dump methods and add hide button
1568e52 Record whitespace on generated empty paragraphs correctly
2253934 Fix whitespace consistency checking when child has no whitespace property
29b249f Improve support for multiple surfaces in demo
Change-Id: Ic496da654130a356530d6028a5fe4230d6c0c735
Local changes:
* Call bindHandlers()/unbindHandlers() in activate/deactivate
* Extend onDocumentKeyDown rather than overwriting it
Change-Id: I0739e71781c5140c54512ab421bdcb6d1df5fbbe
Follows-up b0e8900, 447e8de, d3f26e65.
Contrary to binding a reference, this-overiddes for inline
functions gets messy and fragile. There's also a minor
performance overhead that can be avoided. No separation of
concerns, eiter, as the object is held by the closure.
Also:
* Remove left-over instances of @method.
* Remove redundant '0' argument to setTimeout.
* Use null instead of $ for apply() on static methods like $.when.
* Use .empty().append() instead of .html(). Does the same but
without additional overhead and without confusion association
with "html" which isn't used (it doesn't serialise and re-parse
or clone, it just appends when given one or more nodes).
Change-Id: I797a3667c67d52568150be9be5d043d149f22077
New changes:
fd433fa Add getter for toolbarDialogs in ve.ui.Surface
00c3eb7 Add 'done' button to find and replace dialog
3642dc8 Localisation updates from https://translatewiki.net.
fe2d908 Update OOjs UI to v0.6.0
Local changes to ve.ui.MWFormatTool.css for OOjs UI breaking change.
Change-Id: I6bf98ea988b3e1deb4824189ef8e6d59387b6ffc
