Commit graph

5906 commits

Author SHA1 Message Date
jenkins-bot a8910ca542 Merge "Remove edit tab from the DOM if it's hidden" 2014-05-19 17:51:12 +00:00
jenkins-bot 76a379b6cd Merge "On file pages, only replace the (local) image description when saving" 2014-05-19 17:51:08 +00:00
Ed Sanders bd3b5ffc4f Initialise save panel on 'ready' so focus works
Bug: 65222
Change-Id: I18a0191a3013332621e44455ea59d5f8d683117e
2014-05-19 17:23:38 +01:00
Translation updater bot d36f22e620 Localisation updates from https://translatewiki.net.
Change-Id: Id0ff995087d24b865ba7a888aeb3e4cb2b696852
2014-05-18 20:08:44 +00:00
Translation updater bot 825749a52f Localisation updates from https://translatewiki.net.
Change-Id: Ia2f6952cd6b1c97f6aa9846bd993433031f2b49b
2014-05-17 19:57:15 +00:00
Krenair eb7b727a53 On file pages, only replace the (local) image description when saving
Instead of overwriting everything else on the page (including the thumbnail!)

Bug: 65349
Change-Id: Ib6c4928646d6d278e29fbe31ae1902b0dc3b146a
2014-05-17 17:53:15 +01:00
Krenair e7787db92d Remove edit tab from the DOM if it's hidden
Fixed bug 64142, works around bug 65292

Bug: 64142
Bug: 65292
Change-Id: I31d8f7b149d657a678ed6ebc56b92305934f34bc
2014-05-17 00:56:38 +01:00
jenkins-bot 191fb5e1f1 Merge "Hide 'no results found' once there's at least one result" 2014-05-16 23:16:19 +00:00
Moriel Schottlender 3a9faa44fc Hide 'no results found' once there's at least one result
Naturally, the 'no results found' should only appear as long as there
are actually no results found.

Bug: 52463
Change-Id: I0116b769b9e4995678975d43a74c54c4d426f672
2014-05-16 18:35:41 -04:00
Trevor Parscal 658d614fb8 Change Cite > Newspaper to Cite > News
As per request from talk page:

https://en.wikipedia.org/wiki/Wikipedia:VE/F#VE_citation_tool

Bug: 65207
Change-Id: I3eed54610f5283cab154213c511c56ebe9e19d8f
2014-05-16 22:15:56 +00:00
jenkins-bot 52d562a92a Merge "Remove MWCommandHelpDialogTool" 2014-05-15 20:58:35 +00:00
jenkins-bot b20a4cdb62 Merge "Set up edit notices for things like unknown browsers on each activation" 2014-05-15 20:45:26 +00:00
Translation updater bot d96ce9d2d1 Localisation updates from https://translatewiki.net.
Change-Id: Ib0d8ba18310a95a32e23751f620c81ce95fa2330
2014-05-15 20:33:32 +00:00
Krenair 411f0a7729 Set up edit notices for things like unknown browsers on each activation
The list is cleared on cancel

Bug: 65236
Change-Id: I96a1d95535ec0569e3e25adaa64625fc3a0c4b97
2014-05-15 21:01:30 +01:00
Timo Tijhof 2ef5468471 mw.ViewPageTarget.init: Remove redundant hasOwn check
Follows-up e3be4a6. Object properties default to undefined, no
need to check existance first. Looks like like an "isset()" in
PHP for preventing E_NOTICE.

Change-Id: I594b23e6caf1e17d6d5d37e6a5fd81152e78b3a6
2014-05-15 16:58:03 +00:00
Timo Tijhof 25d00cc777 build: Update jscs and jshint
jshint:
* Update to grunt-contrib-jshint v0.10.0 (jshint v2.5.0).
* Remove coding style options covered by jscs.
* Enable new option "freeze" (prohibits changing native prototypes).
  http://www.jshint.com/blog/new-in-jshint-oct-2013/#option-freeze
* Re-order to match http://www.jshint.com/docs/options/

jscs:
* Update to grunt-jscs-checker v0.4.4 (jscs v1.4.5).
* Format .jscsrc file in a more spacious way and order the
  properties less arbitrarily (using the jscs's readme order).
* Enforce more details of our coding style
* Get rid of the unsable "sticky" operator rules which have been
  deprecated in favour of using other rules instead that are able
  to enforce this more accurately.
  - disallowLeftStickedOperators: Remove deprecated rule.
    * Ternary covered by requireSpacesInConditionalExpression.
    * Rest covered by requireSpace{Before,After}BinaryOperators.

  - requireLeftStickedOperators: Remove deprecated rule.
     * Comma covered by disallowSpaceBeforeBinaryOperators.

  - requireRightStickedOperators: Remove deprecated rule.
    * Logical not (!) covered by disallowSpaceAfterPrefixUnaryOperators.

See also If46b94ce1, Ib731f11b1 and I0b0cadbc5 in oojs/core.

Also:
* Update grunt-contrib-watch to latest upstream version.
  Change log at https://github.com/gruntjs/grunt-contrib-watch/blob/v0.6.1/CHANGELOG#L1-L17

Change-Id: I6c5a34afea8b05a3dca617897c192594df06ca90
2014-05-15 16:52:34 +00:00
jenkins-bot f0d19359a6 Merge "Fire hook when VE activates/deactivates" 2014-05-14 23:29:34 +00:00
Krenair 28fb8c8d4c Fire hook when VE activates/deactivates
Bug: 65320
Change-Id: I3658d6cbe6dd81d8d143fce9659f2c8c4e25ba07
2014-05-15 00:26:36 +01:00
jenkins-bot fb4b6f0b0d Merge "Move shortcut keys help from "Page options" dropdown to "Help" popup" 2014-05-14 23:16:48 +00:00
Roan Kattouw 29fc9ea1b0 Remove MWCommandHelpDialogTool
Now unused. Also should have been a subclass of the (also unused)
CommandHelpDialogTool in VE core.

Change-Id: I865317aa41dbf93c98620c0f89b6d7ac92499022
2014-05-14 16:16:26 -07:00
jenkins-bot 95828d4ff1 Merge "If no media is found display a message in media insert dialog" 2014-05-14 23:10:23 +00:00
Moriel Schottlender 8f68e9f497 If no media is found display a message in media insert dialog
Add a message indicating to the user that no image results were
found in the media insert dialog in case no results are found.

Bug: 52463
Change-Id: I93aea897d864298bf891a90c2fb147f7d34df06d
2014-05-14 16:08:11 -07:00
jenkins-bot 0680c02aa7 Merge "Hide PageTriage curation toolbar while VE is open" 2014-05-14 23:04:03 +00:00
Krenair 204554a567 Swap from using native confirm() to using an OOUI dialog when cancelling
Relies on:
* I292fb34d in OOjs UI to add the confirmation dialog
** I67329820 in MediaWiki core to use the messages added in OOjs UI
** I38f5bb63 in VisualEditor core to register the confirmation dialog

Bug: 50955
Change-Id: I98f9a03d780556b360b57c018c05a27cc1b3862e
2014-05-14 23:00:35 +00:00
jenkins-bot 424c4e4764 Merge "Revert "Cache image scalable promises by filename"" 2014-05-14 22:56:39 +00:00
Catrope 582daaeb70 Revert "Cache image scalable promises by filename"
Caused bug 65314.

This reverts commit 97bc12a421.

Bug: 65314
Change-Id: Iaca46e5458fbc44446cc92e7241dd24d7de883d8
2014-05-14 22:54:48 +00:00
Krenair ddd43b8227 Hide PageTriage curation toolbar while VE is open
Bug: 56731
Change-Id: Iee842d4444ead00587dbfb21f93b65bdec728405
2014-05-14 23:19:39 +01:00
jenkins-bot a323589401 Merge "Only send useful oldid while switching to wikitext editor if it's specifically requested" 2014-05-14 21:33:41 +00:00
Krenair 81801edb50 Only send useful oldid while switching to wikitext editor if it's specifically requested
Usually we can just send 0. Sending anything else makes PostEdit think we're restoring an old revision.

Bug: 65269
Change-Id: I60454a7a4ea3f6c7cef4c707da3016dd0ec29b88
2014-05-14 22:24:47 +01:00
Translation updater bot b71683b880 Localisation updates from https://translatewiki.net.
Change-Id: Icfddb1f9e2b0426026f12c701a27cf9ec39df41a
2014-05-14 19:36:29 +00:00
jenkins-bot 00e5b9ea38 Merge "Changing formatting of Cite drop-down for mobile/tablet interface" 2014-05-14 18:49:53 +00:00
jenkins-bot bfa15be3db Merge "[browser test] Don't rely on existing page for anon edit test" 2014-05-14 17:58:48 +00:00
Ed Sanders af9cf9b2ff inheritdoc lowercase
Change-Id: Ie7a824a4f145d039b45fe60afbc7fe2a382c5e2d
2014-05-14 16:46:16 +01:00
cmcmahon 9db7256fff [browser test] Don't rely on existing page for anon edit test
Change-Id: I43a7d78894ec290faa9e74b085aa2ead15958c62
2014-05-14 08:37:22 -07:00
kaldari e2f29231cb Changing formatting of Cite drop-down for mobile/tablet interface
These changes are to accomodate the design for the mobile/tablet
version of VisualEditor which uses an icon rather than a label
for the drop-down button.

Change-Id: I1086ed4a84ae4061fcc79cc7f587657232c5d5df
2014-05-13 16:49:22 -07:00
Translation updater bot 5a1e66b0a0 Merge "Localisation updates from https://translatewiki.net." 2014-05-13 20:12:02 +00:00
Translation updater bot 841e2f9456 Localisation updates from https://translatewiki.net.
Change-Id: I8a8e62ebc4bc04228301b281d70e2c049fea5bbb
2014-05-13 20:11:13 +00:00
Moriel Schottlender 2731b1ee48 Make sure originalDimensions are available before use
Before applying default size based on originalDimensions, make sure
these are available through the scalable call. The image will be
marked as default size, but the presentation will depend on whether
or not we have the defaultDimensions from the API.

Bug: 65239
Change-Id: I41b30498713e969bd24ef0ad3e9a074c6ffcdc3b
2014-05-13 15:53:30 -04:00
vikassy af2fe79f9b [browser test] Testing use of existing reference in Reference User Interface
Change-Id: Ic27711bcef33614fe4706df48dbcd6d0dca038b4
2014-05-13 03:39:10 +05:30
Translation updater bot 2f180887ba Localisation updates from https://translatewiki.net.
Change-Id: I6b33cfdd1f107e40082ca0ea6c0a0a61cbb03673
2014-05-12 20:11:25 +00:00
Bartosz Dziewoński d8de718a5d Move shortcut keys help from "Page options" dropdown to "Help" popup
Obviously it doesn't belong there. I think I'm getting the hang of this. :D

Change-Id: I5933e32bb8a803d004c2e33d55d7900d1b18a44e
2014-05-12 15:28:30 +00:00
Translation updater bot 3f926bc5ae Localisation updates from https://translatewiki.net.
Change-Id: I454a8e66e98bdb5432ada7ae584e7823a56bccdc
2014-05-11 19:10:51 +00:00
jenkins-bot b84bceda7a Merge "Follow-up Id401d973: mw.Target: Make the "Cite" label in the toolbar translatable" 2014-05-11 07:18:10 +00:00
Bartosz Dziewoński 5e253306d1 Follow-up Id401d973: mw.Target: Make the "Cite" label in the toolbar translatable
Also, re-alpha-sort the ve-mw i18n files.

Change-Id: Id3fc7894b3774042c5eda877c9edf55ef4941ebf
2014-05-11 09:09:09 +02:00
James D. Forrester 80fc16a57e Follow-up Ica9e5a9284: Actually make visualeditor-hidebetawelcome work
Three 'minor' points:

* You have to declare even hidden preferences. Whoops.
* There's no such thing as an "optionsToken", use "editToken".
* You need to POST action=options API calls.

Ahem.

Change-Id: I9c4358107af7bcfca157bd014de49882914e990c
2014-05-10 20:02:40 +00:00
jenkins-bot 20b5c4038b Merge "Make citation tools' compatibility check use normalized titles" 2014-05-10 19:13:32 +00:00
Roan Kattouw a15fa5a17c Make citation tools' compatibility check use normalized titles
Greatly enhance the functionality of ve.dm.MWTransclusionNode#isSingleTemplate
and actually use it places.

Use mw.Title to normalize titles, accounting for case differences and
spaces vs underscores. Also allow an array of template names to
be specified.

Use isSingleTemplate() in the transclusion and citation dialog tools,
which were duplicating this logic. Also document the .static.template
properties.

Without this, the citation tool will appear for a reference using
{{Cite news}}, but not for one using {{cite news}} or {{Cite_news}}.

Change-Id: I18d2bb1b22a5ab269694ad0818b1bb326ef8d1fd
2014-05-10 21:10:09 +02:00
jenkins-bot 83480093d3 Merge "ve.ui.MWTemplatePage: Display template name in text form, not dbkey form" 2014-05-10 18:17:55 +00:00
Bartosz Dziewoński a842801557 ve.ui.MWTemplatePage: Display template name in text form, not dbkey form
Change-Id: I66f0ca431616d932da336f3d05d2500d1cd21ff8
2014-05-10 20:02:52 +02:00
jenkins-bot fabb4f0aec Merge "mw.ViewPageTarget: Hide the welcome dialog via a preference if possible" 2014-05-10 12:06:23 +00:00