Commit graph

12524 commits

Author SHA1 Message Date
Bartosz Dziewoński a811168c2a ve.ui.MWParameterPage: Restructure constructor to reduce needless work
We were constructing a lot of widgets, and never using them all
(they were forever hidden or not even appended to DOM). For large
transclusions this was causing a noticeable performance hit.

I don't think this quite resolves T134814, but it should improve the
situation.

* this.rawFallbackButton is now constructed and appended only when needed.
* this.removeButton is now constructed and appended only when needed.
* this.infoButton can now be a PopupButtonWidget or a disabled ButtonWidget.

Bug: T134814
Change-Id: I2ea00a88a1ea22b73b0c6d10334a94f45734ec3b
2016-12-27 23:54:49 +00:00
Bartosz Dziewoński e0c97ab2f0 ve.ui.MWParameterPage: Hide the "Fall back to plain wikitext" button when in wikitext
We were trying to hide it by detaching, which did not work because it
was getting attached again in later code. Clicking the button just did
nothing.

Change-Id: I027550eb723c43dc85453959159b93e6e802e099
2016-12-27 23:54:42 +00:00
Translation updater bot f5b1a5bb18 Localisation updates from https://translatewiki.net.
Change-Id: I1c8e16e199bbef502b296802acbb3cc15ee417be
2016-12-26 22:42:30 +01:00
Translation updater bot 2ea87fcaf3 Localisation updates from https://translatewiki.net.
Change-Id: Ia3b0f68931e0894aa10d2992f90dc8703f8712cb
2016-12-25 22:20:41 +01:00
Translation updater bot d87a54a31b Localisation updates from https://translatewiki.net.
Change-Id: I21a43826c79cf6d234fb003f3f20c254758380fd
2016-12-24 22:41:04 +01:00
Translation updater bot 55a9cf5208 Localisation updates from https://translatewiki.net.
Change-Id: I39a587eeb157951e8f848cda002f9a46b77d162a
2016-12-23 22:34:34 +01:00
Translation updater bot 2dc86af85a Localisation updates from https://translatewiki.net.
Change-Id: Ic57783cd0222ba31b3c343881a4a4732ad7d0404
2016-12-22 23:00:45 +01:00
jenkins-bot d5f66e4fe9 Merge "Preserve checkbox data when switching from VE to NWE" 2016-12-22 12:37:37 +00:00
jenkins-bot 50da8d8ab9 Merge "Add comments in some places where we really want to treat messages as HTML" 2016-12-22 00:32:23 +00:00
Ed Sanders aee5e665f1 Preserve checkbox data when switching from VE to NWE
Bug: T153889
Change-Id: Ifc41ea9320c9f2627efff6f33d4ad87c59fad496
2016-12-21 22:35:52 +00:00
jenkins-bot 8497b06287 Merge "ve.init.MWWelcomeDialog: Don't treat text messages as HTML" 2016-12-21 02:49:09 +00:00
jenkins-bot d1b243e660 Merge "Ensure document base is always correct, even in source mode" 2016-12-20 18:51:23 +00:00
jenkins-bot 477f892423 Merge "Change wikitext link inspector name to avoid conflict" 2016-12-20 13:44:36 +00:00
jenkins-bot ced46300cb Merge "MWTemplatePage: Show a link to the template even when there's a description" 2016-12-20 11:04:24 +00:00
Bartosz Dziewoński 72569159b8 Add comments in some places where we really want to treat messages as HTML
Change-Id: I439338dabd4b031ed1c4cfc9d89af5a6f2971676
2016-12-20 10:50:15 +00:00
Bartosz Dziewoński dc3bae7d36 ve.init.MWWelcomeDialog: Don't treat text messages as HTML
This appears to be unintentional. The messages don't have any markup.

Change-Id: I6f6570c5ef90e4a06ead1a23f6f851021a77c234
2016-12-20 10:50:10 +00:00
jenkins-bot 2a4da6ede6 Merge "Update VE core submodule to master (f8fc228)" 2016-12-20 07:37:57 +00:00
Translation updater bot f6ba11dec9 Localisation updates from https://translatewiki.net.
Change-Id: I7601c2c303782796f9ca3090f0798b9e354baffa
2016-12-19 22:50:11 +01:00
Ed Sanders 46385a557e Ensure document base is always correct, even in source mode
Bug: T153624
Change-Id: I3f74f67ce975f5b371ab42adf5213256ae816f7f
2016-12-19 21:08:58 +00:00
Ed Sanders 323050467f Change wikitext link inspector name to avoid conflict
This was causing the VE link inspector to fail badly if
NWE was enabled.

Bug: T153668
Change-Id: Ie665715a5f5401e59fc6468b81a4122ca5ebd5a3
2016-12-19 12:03:58 +00:00
James D. Forrester d576fac49f MWTemplatePage: Show a link to the template even when there's a description
Bug: T51772
Change-Id: Ia7084dc7dd4e4c092c0d24b123da19721dca54a9
2016-12-18 21:56:12 +00:00
Translation updater bot 4a1cd55503 Localisation updates from https://translatewiki.net.
Change-Id: I19262ad5964b36fc84551c68ede397705980d44a
2016-12-18 22:18:37 +01:00
jenkins-bot 3a9e03d84b Merge "Updated VisualEditor maintenance scripts to use $this->requireExtension()" 2016-12-18 09:35:52 +00:00
Translation updater bot 56ba9a9839 Localisation updates from https://translatewiki.net.
Change-Id: I8f757626dd2ed47aa772ee5c19e4bec5fe72a8c5
2016-12-17 22:25:49 +01:00
IvanFon 74063d339b Updated VisualEditor maintenance scripts to use $this->requireExtension()
Added $this->requireExtension() in autodisablePref.php

Bug: T152139
Change-Id: I561322ccbfb900ed06f79cca382662e1483fea4f
2016-12-17 15:25:06 -05:00
Translation updater bot 7a8b171d01 Localisation updates from https://translatewiki.net.
Change-Id: I04e37ca08cc134ce68b667deda2fd101d62f6eb6
2016-12-16 22:18:10 +01:00
James D. Forrester 2b63ffba4a Update VE core submodule to master (f8fc228)
New changes:
b74276f Fix <br> sanitization.
2cb48b6 Use try-finally instead of try-catch-rethrow
3c3ec31 Try text fallback for drag and drop even if exception not thrown
af66347 Localisation updates from https://translatewiki.net.
1e6aa55 Ignore covering annotations when importing source
5dd073c Follow-up 2cb48b6: Add a comment explaining why we're not re-throwing

Bug: T153223
Bug: T153315
Change-Id: Id8c0cd35b4f4d989c65a556e843eed0438aa59b0
2016-12-16 11:53:37 -08:00
jenkins-bot 2f790bb7a8 Merge "Show HTTP status alongside 'Unknown error' when it's not 200" 2016-12-16 18:51:57 +00:00
jenkins-bot 57d49550a0 Merge "Add shortcut for show preview and resolve access key conflicts" 2016-12-16 18:14:17 +00:00
Ed Sanders 4d134cfefc Add shortcut for show preview and resolve access key conflicts
Refactor save dialog setup so logic for canPreview/canReview
is external and passed in.

'Show preview' will show in the VE command help dialog until
I56c1036e6 is merged in core.

Bug: T149914
Change-Id: Id718ad622be43c03df61d12b8688d53462c59f36
2016-12-16 13:33:57 +00:00
Alex Monk a9feb8869c Show HTTP status alongside 'Unknown error' when it's not 200
Change-Id: If14dc14f2cc43a1f12c1314342d5028ec524c31e
2016-12-16 11:28:38 +00:00
Alex Monk 5d5645565f Fix I0e802a47: Don't try to send dieWithError error codes as integers
Bug: T152429
Change-Id: If882b14adc945ca49e51a912a676aee0be9c9fec
2016-12-16 11:10:31 +00:00
Alex Monk 96b8d35bff Wrap localStorage.getItem calls in try { ... } catch () {}
Bug: T153291
Change-Id: Ic4f8c390bfe6936bd182b28b1f2c6d19bf459eba
2016-12-15 23:08:30 +00:00
Translation updater bot c8995a6a88 Localisation updates from https://translatewiki.net.
Change-Id: Ifc8297cbb54b183ee024b085006f0f7e69fb473a
2016-12-15 23:20:22 +01:00
jenkins-bot ee2cb3048d Merge "DesktopArticleTarget: Generate the original page title if needed" 2016-12-15 16:50:47 +00:00
jenkins-bot 552e21b74b Merge "Properly clear this.section when switching from VE" 2016-12-15 04:18:37 +00:00
Ed Sanders 9728d78126 Resolve URLs in show preview against correct base
Bug: T153277
Change-Id: Icaa6de4618de008fb2024d1dd428114688cb1043
2016-12-15 03:19:16 +00:00
Ed Sanders 17a164363b Properly clear this.section when switching from VE
Bug: T153276
Change-Id: Idc251c73c03bf87b6e6ca716be98b38d4fb68c5e
2016-12-15 01:34:30 +00:00
Ed Sanders c92418e4da Fix wikitext handling of DataTransferHandlers when IVStore is used
Bug: T153269
Change-Id: Ida6ffffac6e6a65784dc84a388d3702680a79db9
2016-12-14 22:56:18 +00:00
Ed Sanders 1b726dc9bc Fix DataTransferHandlers when loading source editor directly (no etag)
Bug: T153268
Change-Id: I0b43fd651e26c3d74a5f29e8ed80e5dee28ac399
2016-12-14 22:56:00 +00:00
jenkins-bot 9c448dd827 Merge "Use deep clone for empty convertFromSource" 2016-12-14 22:27:19 +00:00
Ed Sanders 854256bb8e Use deep clone for empty convertFromSource
Bug: T153254
Change-Id: I0dc6be0d20020e3fb385c9d065f9395dbda5a6b6
2016-12-14 22:09:25 +00:00
jenkins-bot 5042fe3360 Merge "Extra section title for edit summary in source mode" 2016-12-14 21:51:02 +00:00
Translation updater bot 01d75a2e86 Localisation updates from https://translatewiki.net.
Change-Id: Ifdb762bec4c05e58c37ad9fc28b39ceee00d535d
2016-12-14 22:27:17 +01:00
Ed Sanders 61c7cc4a95 Extra section title for edit summary in source mode
Bug: T153245
Change-Id: I3b3465f269831152fd7a820027f44bfaada067a8
2016-12-14 21:22:10 +00:00
James D. Forrester ccbf20496b i18n: Point to a better page for NWE feedback
Change-Id: I43db0b4dcab051aa17f4ad033628aad770738c60
2016-12-14 19:38:58 +00:00
Ed Sanders 856d480f7d Follow-up Ic1f1de26: Fix typo in edit tab selector
Change-Id: I0ac685f1d942a7d40c6926b8ae8d751db04e1474
2016-12-14 17:35:09 +00:00
jenkins-bot 593474912f Merge "Fix logic for create accesskey=v, and bind to onEditTabClick" 2016-12-14 01:30:17 +00:00
David Lynch b1aed096cb DesktopArticleTarget: Generate the original page title if needed
When switching from the old wikitext editor to VE, we stored "editing..." as
the original page title. Then restored that when saving / switching to "read".
Instead, detect if we're on top of the classic editor, and use the pagename
message to make a plausibly-correct title.

Bug: T126077
Change-Id: Ib0289de71c3ae947ca0a3e45fe1e620378689c35
2016-12-13 19:28:15 -06:00
jenkins-bot 8861ec2d35 Merge "Get content format from EditPage, instead of guessing 'text/x-wiki'" 2016-12-14 01:14:04 +00:00