Commit graph

15498 commits

Author SHA1 Message Date
Ed Sanders 70253d450a Cleanup save-error handling
* Use ve.getProp
* Use .abusefilter key instead of string search (the key
  didn't exist when we first implemented AF support)
* Move AF handler next to captcha handler, and comment
  both as should-be-moved-to-plugin.

Change-Id: I171d63844b84b5a12396b6d6746f92110fc06c6c
2018-11-23 15:42:39 +00:00
Thalia a5c5bc5116 ve.dm.MWExtensionNode: check for body in describeChanges
Bug: T210257
Change-Id: Iffda3dc0b5b9dc84d294240546193e4b55c45bb7
2018-11-23 12:27:13 +00:00
Translation updater bot 9441222619 Localisation updates from https://translatewiki.net.
Change-Id: If1e3578d855ea739c8bf7aec41e978c9a0411b1e
2018-11-22 22:22:28 +01:00
jenkins-bot c5252fd968 Merge "Avoid HTML string parsing" 2018-11-21 21:46:33 +00:00
Translation updater bot abbdb1354d Localisation updates from https://translatewiki.net.
Change-Id: I1d8665aa451f415a02692c921d1ceb1a31475c8e
2018-11-21 22:29:34 +01:00
Bartosz Dziewoński 89126ad660 Update VE core submodule to master (c9b894467)
New changes:
d5d971214 Replace $.isFunction with typeof
b185014a2 Avoid stray tabs
c9b894467 build: Upgrade eslint to 0.9.0

Change-Id: I8d2b663a1b6b612f3ee90d56af0bc3450a1f3f4c
2018-11-21 21:40:58 +01:00
jenkins-bot 6291dff109 Merge "build: Use eslint-config-wikimedia v0.9.0 and make pass" 2018-11-21 20:25:39 +00:00
Ed Sanders f2a9ccd5bd Avoid HTML string parsing
Identified using https://github.com/wikimedia/eslint-plugin-jquery/pull/12

Change-Id: I138e018fdc037d688e055eacddfdc5bfc2cc5abe
2018-11-21 18:47:19 +00:00
Ed Sanders 1a3e8a958c build: Use eslint-config-wikimedia v0.9.0 and make pass
Change-Id: Idb57fc12e7822cf17e10dbb726480fc7de0ae199
2018-11-21 16:51:20 +00:00
Thalia 883e0c23a5 Track when block notices are shown on visual editor
When an edit notice is passed through from the API, allow
a type to be specified, and specify type 'block' if the
notice is a block notice.

If VisualEditorTrackBlockNotices config is true, track
when a message with type 'block' is shown.

Bug: T209633
Change-Id: If5fecc2c2c1c39f4b7245b9a215e1120c93b2b22
2018-11-21 11:22:50 +00:00
jenkins-bot 44fcea9f65 Merge "Track when block notices are returned on the api" 2018-11-20 22:31:27 +00:00
jenkins-bot cf32ca44d9 Merge "ve.ui.MWTransclusionContentPage: Fix missing icon" 2018-11-20 16:58:14 +00:00
jenkins-bot 71b127b48c Merge "Filter out junk from the HON browser plug-in" 2018-11-20 15:51:18 +00:00
Dayllan Maza 3269bb136c Track when block notices are returned on the api
Tracking is behind $VisualEditorTrackBlockNotices config flag
which is set to false by default. Additional data will be logged
into a different bucket on the client and both metrics will be
considered with their known limitations.

The reason behind this is to get an idea on how frequently blocked
users attempt to edit a page. Similar tracking is being added to
MobileFrontend and mediawiki/core.

Bug: T201718
Change-Id: I51576276b97be0716c2c22348eaa756ffb04fe50
2018-11-19 23:02:02 -05:00
Bartosz Dziewoński 120788db59 ve.ui.MWTransclusionContentPage: Fix missing icon
It's missing here: https://phabricator.wikimedia.org/F27262533
We forgot this in 09800aa249 (in 2015).
Oops.

Change-Id: I0f1cda43c6566accf45c82a858158f15c2229f47
2018-11-20 04:04:25 +01:00
James D. Forrester a5c5176333 Filter out junk from the HON browser plug-in
Bug: T209619
Change-Id: If399319b2675ac8ca6d3d17acbf96634ab5f6395
2018-11-19 15:25:12 -08:00
Thalia ceb02d3296 Remove needless function call in DesktopArticleTarget
Change-Id: I6e691e97fe7330496cdf45a2439d8fd373cf221f
2018-11-19 18:58:38 +00:00
Bartosz Dziewoński a9684ebc37 Update VE core submodule to master (812b2140a)
New changes:
eac3c90d5 Revert "TargetWidget: 'change' on document transact, not surface history"
812b2140a Localisation updates from https://translatewiki.net.

Bug: T209648
Change-Id: I18b89b6c03bc09d40f7f314c36b5540ca9c0a27b
2018-11-19 19:14:42 +01:00
jenkins-bot 974afc4849 Merge "ve.ui.MWTemplateDialog: Unbreak the logic to enable/disable "Apply" button" 2018-11-19 17:53:06 +00:00
Translation updater bot 0f862703fd Localisation updates from https://translatewiki.net.
Change-Id: I8b37d79b9739eb528cab7b5e9eaf31c25b096b9a
2018-11-18 22:48:53 +01:00
Translation updater bot cbee7b7b5a Localisation updates from https://translatewiki.net.
Change-Id: I61c5e68d95aff04ddb8c5fd4dd22edb31e674187
2018-11-17 22:19:55 +01:00
Translation updater bot 0e7315776a Localisation updates from https://translatewiki.net.
Change-Id: I78783662110e7f61da6e3fb815eedee8bc2a79d9
2018-11-16 22:29:49 +01:00
Bartosz Dziewoński 914e6905ed ve.ui.MWTemplateDialog: Unbreak the logic to enable/disable "Apply" button
I have moved this block of code to the wrong place in change
13675e4a81. As a result,
`this.loaded` was being set early, so the dialog was treating
all of the pre-existing transclusion parts as newly inserted,
and the "Apply" button was therefore always enabled.

Bug: T209661
Change-Id: I3c1b45f91738ab6fc4a6f6d61ae5bf925c9a1bb5
2018-11-16 01:08:29 +01:00
Translation updater bot 2e19e941a5 Localisation updates from https://translatewiki.net.
Change-Id: Id96a9b4e387ee948a858da3e11cf748fa0677e05
2018-11-15 23:00:35 +01:00
Bartosz Dziewoński 79e16e218f ve.ui.MWGalleryDialog: Improve modification checks
Undoing the changes to an image caption or alt text, or to the gallery
caption, or to the order of images, or removing a previously added
image, will now disable the "Apply" button again.

The following cases will *not* disable the button again, and it is not
feasible to implement them:
* Re-adding a previously removed image with identical options
* Changing any caption to the old value by other means than "Undo"
* Changing image caption or alt text to the old value after switching
  to a different image and then back

Bug: T206534
Change-Id: I7c19600e741211a6ba61837513497facbafc5cef
2018-11-15 22:16:26 +01:00
Bartosz Dziewoński a66f57643c ve.ui.MWGalleryDialog: Update "Apply" button when image added
Use 'change' event instead of 'reorder' to respond to this event.
This also covers removing images now, so delete that code.

Bug: T206534
Bug: T209451
Change-Id: I9eda383be2ca7f02b42814d43e6b42961b9b96e7
2018-11-15 20:56:39 +01:00
jenkins-bot 6c3f516843 Merge "Update VE core submodule to master (b17770c7e)" 2018-11-14 19:12:29 +00:00
libraryupgrader ef389963e1 build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Change-Id: I2c2c3c74c94561af6e1844d9109a8f11ee8ae16b
2018-11-14 05:59:31 +00:00
James D. Forrester d2fbebc184 Update VE core submodule to master (b17770c7e)
New changes:
9c4d8f893 Place popups instead toolbar.$bar
0a1dd51e8 Only attach scroll listeners is toolbar is floatable
a8e07e026 Convert remaining $.Deferred() to ve.createDeferred()

Bug: T209192
Change-Id: I08328ca5f6aadad7db069dcd81734e1932e616e7
2018-11-13 15:35:44 -08:00
Thalia 70c3bc65d9 ve.ui.MWGalleryDialog: Improve how dialog actions are enabled
Enable the Apply changes/Done action if (i) the current contents
of the dialog inputs would change the gallery node or (ii) if the
user has interacted with inputs that alter the gallery caption or
images (including dragging/dropping or removing an image).

Bug: T206534
Change-Id: Ia6c1cc60d4f32ac66778e6973e2d400491f74128
2018-11-13 19:14:33 +00:00
Bartosz Dziewoński e8cb9ee7f5 Update VE core submodule to master (f391832c5)
New changes:
9be96b536 ve.ui.DesktopContext: Actually hide mobile '.ve-ui-linearContextItem-info'
ee8bceb13 LinearContextItem: Added text wrapping when it is too long
b565dd5c1 Update OOUI to v0.29.5
be24f8d32 TargetWidget: 'change' on document transact, not surface history
ffcd8518a Make table selections immutable (refactor #expand)
55a6f1bc1 Scroll 60px past toolbar on mobile to avoid context menu clash on Android
9bf6d9612 Scroll 30px above bottom of viewport on Android to keep selection handles visible
f391832c5 Localisation updates from https://translatewiki.net.

Bug: T188823
Bug: T202723
Bug: T204718
Change-Id: I7ee8382ef6bd27c0fe2a2b6a43df9c121c5c0a5f
2018-11-13 20:12:39 +01:00
Translation updater bot b92cc326c0 Localisation updates from https://translatewiki.net.
Change-Id: I4ed1c4597919d2ce0dd2d5b6d7ebd62e33620ea7
2018-11-12 22:13:02 +01:00
Translation updater bot 7fd4ef486a Localisation updates from https://translatewiki.net.
Change-Id: Ide93caeaa6840dd1a063ba19a8d2a8fe0f829f48
2018-11-11 22:34:01 +01:00
Translation updater bot 0cd1017c71 Localisation updates from https://translatewiki.net.
Change-Id: I92aef7d5478233355e25857290adf7d880ad1cf1
2018-11-10 22:28:34 +01:00
Translation updater bot e3bad5ba65 Localisation updates from https://translatewiki.net.
Change-Id: I438f73e8695be48457ee606923d0cc4f58bca341
2018-11-08 22:18:18 +01:00
jenkins-bot 4c7d142816 Merge "Separate handling of document HTML and edit metadata" 2018-11-08 20:13:44 +00:00
Ed Sanders b2718b186a Separate handling of document HTML and edit metadata
For now this is just moving code. In the future we will
be able to make the handling of edit metadata async.

Change-Id: I7b442dfbdd890154de0e7faab1f6b0346caa8de0
2018-11-08 18:30:33 +00:00
Bartosz Dziewoński 7bcb1ac50c Update VE core submodule to master (f32c0be7c)
New changes:
61992def0 Remove dedicated annotation operation types
c18308313 Move 'enter' and 'f2' keydown handlers to command/trigger code

Bug: T205535
Change-Id: Ibbf578070c820ae63a8b8ab50e6e4520cabfebe6
2018-11-08 13:45:21 +01:00
Bartosz Dziewoński 2639984bb3 Update VE core submodule to master (0d1902e04)
New changes:
2c90701db Guard against ve.dm.Document not existing in argument check
68641c9c5 eslint: Disable jQuery/browser environment expectation in DM code
946d9c9d0 Abstract construction of Deferred objects and $.when
e20c7f8a3 ce.ResizableNode tests: increase coverage
0d1902e04 Localisation updates from https://translatewiki.net.

Bug: T195111
Bug: T208515
Change-Id: I84c08142e7cfe3254e54c0d691bc6dac9bcc30ce
2018-11-08 12:44:48 +01:00
Translation updater bot 825f67f905 Localisation updates from https://translatewiki.net.
Change-Id: Ifb33d53323e8784975041613899cb20c42293c34
2018-11-07 22:22:37 +01:00
jenkins-bot b588eb2f97 Merge "$.extend -> ve.extendObject" 2018-11-07 18:28:08 +00:00
Ed Sanders 3564006e91 $.extend -> ve.extendObject
Change-Id: I1def4d63c231da153a52a649e7bab584e789b6d1
2018-11-07 16:51:39 +00:00
Ed Sanders ff1a05e245 Bump version number due to recent breaking change
Specifically I715ae805f, which changes the signature of
ve.dm.*Selection objects.

Change-Id: Iffa657179dd8a126e9f16787f3b33743f6e3d489
2018-11-07 16:50:35 +00:00
jenkins-bot 89ba8d0ba8 Merge "Fix margin/padding on save dialog enter prompt" 2018-11-07 16:21:45 +00:00
Ed Sanders 2149de7bb0 Fix margin/padding on save dialog enter prompt
Non integer px values were resulting in scrollbars.

Bug: T208947
Change-Id: Ifeefbcc6068b086a3b351706827b34129b7d0227
2018-11-07 13:50:18 +00:00
jenkins-bot 73deda8f66 Merge "ve.init.mw.DesktopArticleTarget.init: Move Vector styles to separate file" 2018-11-07 13:18:47 +00:00
jenkins-bot 07856d2a16 Merge "ve.init.mw.DesktopArticleTarget: Edit surface padding and gutter for Minerva" 2018-11-07 13:18:42 +00:00
jenkins-bot 4d0de7744d Merge "MWTempWikitextEditorWidget: Don't rely on skin to set width for textareas" 2018-11-07 13:18:39 +00:00
jenkins-bot 45c9ff5e21 Merge "ve.init.mw.DesktopArticleTarget.init: Make multi-tab mode compatible with Minerva" 2018-11-07 12:26:38 +00:00
jenkins-bot 50b7291ab4 Merge "Update VE core submodule to master (a4b936b5e)" 2018-11-07 11:35:48 +00:00