There are two ways dialogs determine if they are inserting or updating.
1. They evaluate whether the dialog is inserting or not and set a boolean
flag, used later to steer the saving code
2. They evaluate whether the dialog is inserting or not and, if not,
store the node to be updated in a property, used later to steer the
saving code
In the reference list dialog, setup used strategy 1, and teardown used
strategy 2. We've now normalized to use strategy 2 in both methods, which
fixes this bug.
Bug: 61885
Change-Id: I1b077b2aef4121328bce2b373874dd7373e405a1
These were being used indirectly in the MW*Model's. Use surface
fragments instead.
Fixes I0fae3e5ff2bd.
Change-Id: I1d6aa5e00a9315cf7088f87f9e9d828833feec64
New changes:
af131d3 Clean up ve.dm.SurfaceFragment#isolateAndUnwrap a bit
b064ae8 Convert language name to lower case when looking for i18n file
f16dcac Fix ve.dm.SurfaceFragment#getSelectedNode
0fe1152 Clean up lots of minor things in SurfaceFragment
aec3043 Add excludeInsertion to translateRange()
f930950 Add excludeInsertion property to SurfaceFragment
a7ddd89 Exclude insertions in ve.dm.SurfaceFragment#isolateAndUnwrap
8108a0f Remove zh-[hk|tw] in favour of zh-han[s|t]
74353d9 Update OOjs UI to v0.1.0-pre (729c7bbe31)
Change-Id: I7aaebb071d544aec069d5ddab68740d93aed5bf4
Move various bits of code from initialize to setup as required.
MWDialog is now useless so use ve.ui.Dialog directly.
New changes:
0b2d03f [BREAKING CHANGE] Pass fragments, not surfaces, to windows (reprise)
0101ac4 Update OOjs UI to v0.1.0-pre (ac6848398c)
Change-Id: I0fae3e5ff2bd0da5b74c244af226b07b1f5883bd
ve.dm.Scalable is now a computational model for image scaling and
size manipulation. This commit adjusts the nodes and the edit and
insertion dialog to handle the new scalable model, and by that
use a centralized computational engine for all scaling and size
changes.
New changes:
3ec19fb8 Refactor Scalable functionality
Change-Id: I017a017924f544cc8bc9b7d8245335759ae0e890
* Truncate beyond 3 parameters
* Add a special option class that, when clicked, shows the remaining parameters
* Use a special option class for the no parameters item instead of hacking the normal one
* Simplify the design of the no parameters item: no icon, centered text
Change-Id: Ia8259e91b42a59c2b08019df36217d485208ad99
New changes:
33e6dcd Update OOjs UI to v0.1.0-pre (98570355f6)
a90eb8c Inspectors should only hide on blur if the selection has been cleared
d6feda2 grunt: Run grunt-build as part of grunt-test and grunt-watch
3972dce Apply annotations to partially annotated selections
5b157e2 Debug bar fixes
8907f17 Use new banana checker as a linter to avoid lacking qqq messages
a6bdc7a Re-sync generated files output from `grunt`
cf31d70 Localisation updates from https://translatewiki.net.
4c2e83a Listen to close events on window sets to give focus back to the surface
290d593 Set content directionality on the model
9772a50 Use #isContentOffset instead of slug detection for word expansion
7203025 'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear();
4964b82 Localisation updates from https://translatewiki.net.
957d81c Revert "'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear();"
35c09bf Update OOjs UI to v0.1.0-pre (70932872ba)
Change-Id: I205604fb8bd93948b7de84498da7fdf30fc70c1d
Changes:
* Change uses of initializeSelection to selectItem
* Use "choose" event to respond to deliberate item selection by the user
Depends on changes in OOJS-UI (Ib3826ed)
Change-Id: Ia167a70ca5f40b1f15adad30620fdb13ef0d02d7
This test never worked. Last week this feature broke but the
test continued to pass. Let's not do that again.
Change-Id: I9819a3304191959b9b194b3e675dfdd273618881
'editing/beta' section stopped being used by anything other than
VisualEditor in 3c0aa26a0da68a9 in June 2013, and the section was
removed from MediaWiki core in ief2c7d1df876fb04.
This is a follow-up to 799e11ca7e which omitted one occurrence.
Change-Id: I05a6cce89d71808d82c12f54beb6b7a6730b265f
'editing/beta' section stopped being used by anything other than VisualEditor
in Id8b9a47a in June 2013, and the section was removed from MediaWiki core in
I76667a15cc today.
Change-Id: Ida16f714c28c46d552b92c05b07b63f5d6dd361e
