Commit graph

8940 commits

Author SHA1 Message Date
Translation updater bot bd848ac4f1 Localisation updates from https://translatewiki.net.
Change-Id: Ic65af97f6c29c1e0c47317997b18ab064f80a2f5
2016-02-05 21:54:43 +01:00
Translation updater bot 7c07b2706b Localisation updates from https://translatewiki.net.
Change-Id: Ibd8991424c15ff9d6700c5103c75aff17aa452d9
2016-02-04 22:18:02 +01:00
Ed Sanders 5864a62134 Default extensions to not use the 'invisible icon'
Bug: T125767
Change-Id: I58c58080382974a887ebc52c1ac80cb5970db8c7
2016-02-04 19:38:16 +00:00
Translation updater bot 622ca082ca Localisation updates from https://translatewiki.net.
Change-Id: I29d93111a508e8af12752b6b93dc13d106f01d5f
2016-02-03 23:09:41 +01:00
Translation updater bot 0acd4160f4 Localisation updates from https://translatewiki.net.
Change-Id: Id1d12847d0c09993453c889af16266b9bac9d9ee
2016-02-02 21:33:11 +01:00
jenkins-bot 804ab26fb2 Merge "Check xhr.responseText is set before trying to send it to $.byteLength" 2016-02-02 19:08:08 +00:00
Alex Monk 9808d04bfe Check xhr.responseText is set before trying to send it to $.byteLength
Bug: T125399
Change-Id: I09881fe8b6db7d95e32732129d043c4a13fa7a9a
2016-02-02 18:52:56 +00:00
Ed Sanders 98bc5daba1 Use new iconWhenInvisible feature in Transclusion/Extenion nodes
Change-Id: Iba55676c06a1cd625187c38c1ae0c9c20b065827
Depends-On: I127bb5d34850cdc545ea3c05d0fc41a8ae1c6dea
2016-02-02 18:07:13 +00:00
Translation updater bot 9ec0705a2b Localisation updates from https://translatewiki.net.
Change-Id: If02911bde5c9cdbaeeaf52a45f4746b1b61b7d16
2016-02-01 21:56:13 +01:00
Ed Sanders db5ed236dd Add controls for wikitable and sortable to table dialog
Bug: T95189
Depends-On: Ife3f3505b845db28dd29a07e9be1533c39726ce1
Change-Id: I1672d8cd2e138df1fad19dcfd948700942e87f2c
2016-02-01 10:58:42 -08:00
Ed Sanders 74358498da Update VE core submodule to master (70ff8cc)
New changes:
242ab45 DesktopContext: Float the context when it goes beyond the viewport
405c44d Rename TableContext to TableLineContext
6c564be Sort messages alphabetically
70ff8cc Introduce table and table cell context

Change-Id: I4357162bc192c90f99ca0aec12eb67bf848e5504
2016-02-01 10:51:26 -08:00
Ed Sanders 5e296a959b Sort messages alphabetically
Change-Id: I45b440b1b020ea79ab4c1eba78effb526c41ddc4
2016-02-01 17:36:43 +00:00
Translation updater bot 122d76bfbe Localisation updates from https://translatewiki.net.
Change-Id: Ib037f762e584c8b6bc153a469057b362e31393fc
2016-01-31 21:42:24 +01:00
Translation updater bot 1b33f7b912 Localisation updates from https://translatewiki.net.
Change-Id: I499a7c36f46bed65f06c881de3df9fdf53e20036
2016-01-30 22:50:35 +01:00
Alex Monk 8cc034b9af Run VE->WTE modification checks regardless of how the user got into VE
I think this fixes a bug similar to the one described in the bug below.

Bug: T124708
Change-Id: I61558227315bec36b71dac281b8da311a3d6bb1a
2016-01-30 03:06:46 +00:00
Translation updater bot de5f372ac5 Localisation updates from https://translatewiki.net.
Change-Id: Idfb5e5fdd92cae124b428c768fd89baa6239541c
2016-01-29 22:43:50 +01:00
Ed Sanders 0ed45dbf61 MWTable: use new sanitization method
This prevents tables from getting sanitized even on
VE to VE copy. Also by calling ClassAttributeNode sanitize
extra CSS classes are removed.

Bug: T97462
Bug: T125220
Depends-On: Ia3ce386b2a03bc227818b10423bca72c736c0656
Change-Id: Ifd91e00b40665b446bbdcdf8859d2bb641bc0e67
2016-01-29 10:29:19 -08:00
jenkins-bot 66b0ff5111 Merge "ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl" 2016-01-29 17:00:38 +00:00
Translation updater bot 77a11811fb Localisation updates from https://translatewiki.net.
Change-Id: If88cee4c9c766aabdccc4d996d48c0151e5611bb
2016-01-28 21:11:06 +01:00
Bartosz Dziewoński fb54d03a59 ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl
Change-Id: Iae61d13a6c776c86bcec6744a2153b14c07722e9
2016-01-28 19:02:38 +01:00
jenkins-bot e4e7fce00e Merge "Create a more neutral warning message" 2016-01-28 07:57:33 +00:00
Justin Du 854f0a3692 Create a more neutral warning message
Change was made because editing mode is not always left to go to view mode,
but for example also because of clicking on "History".

Bug: T121754
Change-Id: Ibc1ba697081e60b8a797f5ea1b814a320ba812c3
2016-01-28 07:29:09 +00:00
Translation updater bot e181ca806b Localisation updates from https://translatewiki.net.
Change-Id: I694abc3d49df4ed6b580a10bdc37ba24fc288ac0
2016-01-27 21:46:32 +01:00
jenkins-bot f78dd8ad72 Merge "MWWelcomeDialog: Let the user switch editors" 2016-01-27 00:20:10 +00:00
James D. Forrester d8769edd01 MWWelcomeDialog: Let the user switch editors
Change-Id: If88942d866278f3012dae7972d464a3d2a6a4f82
2016-01-27 00:14:07 +00:00
jenkins-bot fc43d61ec5 Merge "MWTargetWidget: Add missing indent commands to blacklists" 2016-01-26 23:53:51 +00:00
Ed Sanders abb094babd MWTargetWidget: Add missing indent commands to blacklists
Bug: T124619
Change-Id: If2a5d98673db6e2d29fe49f1e7f5307437ba3866
2016-01-26 23:46:12 +00:00
James D. Forrester 2c76dc5b50 MWEditingTabDialog: Use 'small' size
Change-Id: Icb30d4fbea21653cf2fb6c782a4314be97a3e0a2
2016-01-26 14:51:55 -08:00
jenkins-bot 75b0a8de63 Merge "Don't try to load VE over the top of the wikitext editor we just switched to" 2016-01-26 17:01:24 +00:00
Alex Monk 589437a772 Don't try to load VE over the top of the wikitext editor we just switched to
(if we discarded changes)

Bug: T124316
Change-Id: Ic5e6ee8f4b6e75c3ae877021bcb29733b881e6d2
2016-01-26 16:49:50 +00:00
Alex Monk d7183d7e64 Check user permissions for viewsource before loading VE on-load on action=edit/submit etc.
Clicking 'View source' should probably not cause VE to load

Bug: T124650
Change-Id: I236de38b0f90f1aaa5d04b57cb7759e5951baf2b
2016-01-26 16:47:26 +00:00
Alex Monk bfa15c44a5 Check user preferences before loading VE on-load on action=edit/submit etc.
Bug: T124743
Change-Id: I2e8a19014464a2b7fb76de08676e7cb808e06956
2016-01-26 02:48:27 +00:00
Translation updater bot 71c0473094 Localisation updates from https://translatewiki.net.
Change-Id: I159863f04ee8af735dde305b24d8f5cd0a5c8b2b
2016-01-25 22:33:02 +01:00
jenkins-bot 6666bfcaea Merge "MWTableNode: Mixin ve.ce.ClassAttributeNode" 2016-01-25 20:54:15 +00:00
Ed Sanders ba0b084813 MWTableNode: Mixin ve.ce.ClassAttributeNode
The DM side already had the mixin, the CE side was still using custom
logic that has since been moved to ce.ClassAttributeNode.

This fixes the issue of tables not getting the wikitable class in VE
as it was only applied on attribute change previously, which never happened.

Change-Id: I197347762fc9228034f7664484539e5888722bcf
2016-01-25 16:35:49 +00:00
Translation updater bot 8e5a9e71a9 Localisation updates from https://translatewiki.net.
Change-Id: I401186574b88f3c5c810644799b55f2af5740f8c
2016-01-24 21:22:34 +01:00
Translation updater bot d246540ccf Localisation updates from https://translatewiki.net.
Change-Id: Ie90b5f4eb9a6303d4374b99c98c0dfeb8e595fbc
2016-01-23 22:30:32 +01:00
jenkins-bot d29524c8b3 Merge "When loading VE from action=edit/submit, replace the title shown" 2016-01-22 20:43:02 +00:00
Alex Monk 38180b5d4d When loading VE from action=edit/submit, replace the title shown
Bug: T117643
Change-Id: Ice21389d02ea10adc668c5b0a64ba2b0b9cf5744
2016-01-22 20:27:01 +00:00
Ed Sanders b66aa990ba Follow-up I9714cf3: Add tests for wikitable paste
Bug: T85577
Change-Id: I8e2893c9a6f80fafe6cae142e4f50ffbe6d550ac
2016-01-22 20:13:26 +00:00
jenkins-bot e6c61052a0 Merge "MWTableNode: Apply wikitable class to pasted tables" 2016-01-22 19:10:41 +00:00
Ed Sanders bf50e2a570 MWTableNode: Apply wikitable class to pasted tables
Bug: T85577
Change-Id: I9714cf3e8ccc165f91af939481c845c3ec9c5f6b
2016-01-22 18:43:47 +00:00
Thalia 16330ac05d Add method for setting minimum number of rows in Ace editor widget
Bug: T123891
Change-Id: Ia2e094071f385628449f1935f0250cbeb75196f0
2016-01-22 17:05:35 +00:00
Translation updater bot b382eced8c Localisation updates from https://translatewiki.net.
Change-Id: Idce091710bdb8936a362df1ce2f000b792b1b286
2016-01-21 21:56:24 +01:00
Translation updater bot 27261322b4 Localisation updates from https://translatewiki.net.
Change-Id: I6f9e970a0cb80e33849c67d1a850ce019cdcd76e
2016-01-20 21:09:24 +01:00
jenkins-bot 3bc62ba61d Merge "SaveDialog: Fix alignment of checkboxes" 2016-01-20 18:36:46 +00:00
Translation updater bot 5b95d6c1e6 Localisation updates from https://translatewiki.net.
Change-Id: I5b3ed86498fcc81cb448d056d32b53cb9a15a579
2016-01-19 21:22:21 +01:00
Ed Sanders 74e4450c92 SaveDialog: Fix alignment of checkboxes
Change-Id: Ia7718e7cebe7c533a76533dc82bcf93f8da49d15
2016-01-19 16:40:32 +00:00
jenkins-bot ee70cc5c44 Merge "Single Edit Tab: simplify logic; make 'prefer-wt' just disabled" 2016-01-18 21:28:26 +00:00
Translation updater bot 9b0ba61924 Localisation updates from https://translatewiki.net.
Change-Id: I45ba38e70875a2e7783144aa0756f4bc8989c835
2016-01-18 21:38:20 +01:00
James D. Forrester aa08d34318 Single Edit Tab: simplify logic; make 'prefer-wt' just disabled
Change-Id: I090375933656f29636c355c4d2ce358dd7f7f074
2016-01-18 11:23:59 -08:00
James D. Forrester 68ea08cd5e Drop support for adding prefix/appendix labels to edit tabs/links
Depends-On: I264599a1c4f60b37a46d49c808cf271ba0a8f882
Change-Id: Icebc378f5c00aac57ad361f8ba85da93b8178650
2016-01-18 03:06:33 +00:00
Translation updater bot f0b2ce2ded Localisation updates from https://translatewiki.net.
Change-Id: If3cb31818a635b6f5b4ac4796fced777f5517dd0
2016-01-17 22:35:39 +01:00
Translation updater bot 81a33e1ddc Localisation updates from https://translatewiki.net.
Change-Id: If2e5f3a07d289d3575ada8cc712b80ed11e2f532
2016-01-16 21:59:41 +01:00
Translation updater bot 5a8b1c294e Localisation updates from https://translatewiki.net.
Change-Id: I1653aca5124b19dbd879d82196ec381070ccce13
2016-01-14 22:26:26 +01:00
Translation updater bot 6606c25902 Localisation updates from https://translatewiki.net.
Change-Id: I913124a4a85545e9abc179a225ec3ee5746bda11
2016-01-13 23:32:14 +01:00
Translation updater bot cec85b9e3c Localisation updates from https://translatewiki.net.
Change-Id: I76a506a5fb58dee87fd3459d557b29190ad7e777
2016-01-12 22:49:13 +01:00
Translation updater bot c37fbf1f70 Localisation updates from https://translatewiki.net.
Change-Id: Ie52c778d1291121d3d78dcae9ae8a5d23d5c27b8
2016-01-11 22:55:11 +01:00
Translation updater bot 946163d758 Localisation updates from https://translatewiki.net.
Change-Id: Ib5d617cc8a22b6c5e5248c3a374d10d08cd3434f
2016-01-10 23:15:09 +01:00
Translation updater bot f26501b4f6 Localisation updates from https://translatewiki.net.
Change-Id: I6c324c98c20cc8d4b7b1b51f7eec5b5a608eee2b
2016-01-08 22:22:26 +01:00
Translation updater bot d1386ae5b8 Localisation updates from https://translatewiki.net.
Change-Id: Icf5edd18f9fa08c0ff63808c750b2f64698066bf
2016-01-07 23:39:13 +01:00
jenkins-bot 7a39be3798 Merge "Stop using broken image links in tests" 2016-01-07 01:21:25 +00:00
David Lynch 3cffb489bb Stop using broken image links in tests
They make it a little bit more cluttered to hunt down problems when
testing. So, use the minimum image instead of just "Foo" or similar.

Bug: T121636
Change-Id: I3209c377ad870f669cac7d40d991968cff52c39e
2016-01-06 17:11:38 -08:00
Dan Duvall 96677fb74a [BrowserTest] Experimenting with JS object references
References to JS objects for VE elements can determined by referencing
the VE and OOUI API documentation[1][2] and interrogating the objects in
a browser console. Errors should be closer to what developers understand
but testers should pair with developers to better understand how to
define new page elements and where to go for documentation/help.

The VE entrypoint for the singleton reference is `ve.init.target` (if
there's only one instance of VE target; there may be multiple in some
cases like Flow).

[1] https://doc.wikimedia.org/VisualEditor/master/
[2] https://doc.wikimedia.org/oojs-ui/master/js/

Change-Id: I1f642807cdd3059d8e7e885a8b239ac01b9b3024
2016-01-06 17:07:35 -08:00
Translation updater bot 739b4c796d Localisation updates from https://translatewiki.net.
Change-Id: I406227f147f21b4deed2a5a6e9f556e84cd32a65
2016-01-06 21:56:55 +01:00
Translation updater bot 94126edb04 Localisation updates from https://translatewiki.net.
Change-Id: I1d7295d5aee0dd72a7469c6467b12177187988dc
2016-01-05 22:31:09 +01:00
Translation updater bot b3a11a9325 Localisation updates from https://translatewiki.net.
Change-Id: I79bdcd360cf4c879b8344f75af927fdfac89dcd2
2016-01-04 22:38:41 +01:00
jenkins-bot 3591a0e63d Merge "Education popups: Only show for DesktopArticleTarget" 2016-01-04 20:00:58 +00:00
Ed Sanders e7ee5c20c6 Education popups: Only show for DesktopArticleTarget
For now they are not well supported by other targets
(e.g. Flow and Mobile).

Change-Id: Ibd1f3c8994611661b52c0cf36438b41f623b9451
2016-01-04 10:43:43 -08:00
James D. Forrester ada58df361 build: Bump file copyright notices for 2016
Change-Id: I3c618c196e504a80ca297a4132a17f1977a24fb7
2016-01-03 14:57:25 -08:00
jenkins-bot e59e36e225 Merge "Refactor MediaResources(Provider/Queue)" 2016-01-03 22:55:39 +00:00
James D. Forrester 4a781a3a16 EditingTabDialog: Shorten the copy to make snappier, drop 'Edit' tab name
Change-Id: Idd5f373d9fef364318efddcc98ea2de5e91860a8
2016-01-03 13:44:54 -08:00
Translation updater bot 93b4a43b18 Localisation updates from https://translatewiki.net.
Change-Id: I26cf69fe5f4593ca22c9a170fd16fb02549b187e
2016-01-03 21:45:19 +01:00
Alex Monk 85bb085418 DesktopArticleTarget: Preserve oldid when switching from WTE into VE
Change-Id: I8682a2a2b90ae2e42f1a8e01e16d0f9f3d66a2d5
2016-01-03 10:59:21 -08:00
jenkins-bot 26e3c0ad1d Merge "Preserve oldid when switching from VE into WTE" 2016-01-03 06:35:58 +00:00
Translation updater bot f80e0c7482 Localisation updates from https://translatewiki.net.
Change-Id: I58460ed4632db989f00464d0401a7bba5cd072da
2016-01-01 20:07:11 +01:00
Translation updater bot f1df0e0df4 Localisation updates from https://translatewiki.net.
Change-Id: I88a173f67541d0a5d1c8628e81871cbfce6db393
2015-12-30 21:46:23 +01:00
Željko Filipin 2cfaa9528c [BrowserTest] Update mediawiki_selenium Ruby gem to the latest version
Bug: T114241
Change-Id: Ic6cf69516a1e36173fbbf6b86494e845721a19d0
2015-12-30 11:46:23 +00:00
Translation updater bot 8eca31d729 Localisation updates from https://translatewiki.net.
Change-Id: I8c80187c5efb9b45b2a0df338a778a6074d467ac
2015-12-28 21:05:28 +01:00
Translation updater bot 7dcba8dbf4 Localisation updates from https://translatewiki.net.
Change-Id: I03f05bd052a77b75d731994fb8b247d21dff1077
2015-12-27 20:38:22 +01:00
Translation updater bot ac555fd695 Localisation updates from https://translatewiki.net.
Change-Id: If3e7e7050a93934732703d239b76c3b7c31069cb
2015-12-26 21:12:39 +01:00
Translation updater bot 97dd3ee12d Localisation updates from https://translatewiki.net.
Change-Id: I491b5cdaa05e954fffc5c11e6db6e12629064893
2015-12-25 21:55:54 +01:00
jenkins-bot 3231220774 Merge "SET: Don't try to do any client-side section link magic if we're not supposed to." 2015-12-23 23:18:57 +00:00
Alex Monk 76cb69ecec SET: Don't try to do any client-side section link magic if we're not supposed to.
Ugh.

Bug: T121599
Change-Id: I47a93d5dbedc5ae989a2973fb793ac99edfb139a
2015-12-23 22:10:20 +00:00
Translation updater bot fa66daef6c Localisation updates from https://translatewiki.net.
Change-Id: Ie2040e33f23c85fc0f6a2a66773c67c30aa6ac83
2015-12-23 22:08:06 +01:00
Ed Sanders 2afd7c903d DesktopArticleTarget: Improve teardown sequence
* Ensure activating classes are removed by rejecting activatedDeferred
  as soon as teardown starts.
* Try to teardown surfaces is surfaces exist, not just if the target is active.
* Remove noop teardownDebugBar. The debugbar lives inside the surface now.
* Ensure progress bar is always reset, even if target setup is aborted.

Bug: T99139
Change-Id: I16a071c0d4bc8bbc6af2e03e63ee0ffc18d55c75
2015-12-23 12:13:50 +00:00
Translation updater bot 9cc9b8f1a1 Localisation updates from https://translatewiki.net.
Change-Id: Ia72cf64c778cf9ab82f24700ec90e404bd0f9432
2015-12-22 22:12:49 +01:00
Ed Sanders 93f0e8b30c Refactor MediaResources(Provider/Queue)
Create a subclass for MediaSearch(Provider/Queue) and make the parent
class a more generic representation of API requests for media.

Change-Id: Iea8b90e829d532d210bfef3c96d6798c64e15eed
2015-12-22 14:00:10 +00:00
Translation updater bot dd85041a29 Localisation updates from https://translatewiki.net.
Change-Id: I66a72ca80277579be5674cbeb0794a70c7093345
2015-12-21 22:07:16 +01:00
Translation updater bot 39d762e844 Localisation updates from https://translatewiki.net.
Change-Id: I9de2feb735f9c722d941e7fdac53f4ee241ad9ad
2015-12-20 22:36:27 +01:00
jenkins-bot 7c1660c933 Merge "Make Ace Editor adjustSize method chainable" 2015-12-20 12:56:03 +00:00
jenkins-bot 7da9dc409f Merge "ReferenceEducationPopup: Don't flip the numbers in the RTL image" 2015-12-19 15:06:24 +00:00
Florian 5627701cb1 Fix inheritance of ve.ui.MWTransclusionDialogTool
From the description of the commit message[1] for WindowTool and
FragmentWindowTool, the ve.ui.MWTransclusionDialogTool should be
a FragmentWindowTool, and not a WindowTool.

In fact, the bug is caused by the missing isCompatibleWith method
in WindowTool.

[1] I3a0e761f0d6e942d503ec

Follow up: I676af9c50b09ef007926240eb2327d1a0fdd80f5

Bug: T121596
Change-Id: I9a47e5d67fcd7a94155b7cf77c734c94b0ed69e1
2015-12-19 11:52:44 +00:00
Thalia f8fbbdf66d Make Ace Editor adjustSize method chainable
Change-Id: I48307bd9184bb238a553d178c0d66084244e9ebf
2015-12-19 10:57:04 +00:00
Translation updater bot c747c06759 Localisation updates from https://translatewiki.net.
Change-Id: I6ee493d00d8fd9ad8ea4fc4efbf7513be9765d07
2015-12-18 23:39:12 +01:00
Alex Monk c10236cc58 Preserve oldid when switching from VE into WTE
Bug: T120898
Change-Id: I51774fd7ca5be7373d8aec55cb420a874bc7d531
2015-12-18 00:47:03 +00:00
Translation updater bot a9637adf2d Localisation updates from https://translatewiki.net.
Change-Id: Ic62f7e83d426f1e5872cd0597d54458d851490ad
2015-12-17 22:46:49 +01:00
Translation updater bot 4e2d06605e Localisation updates from https://translatewiki.net.
Change-Id: If7ed2349bec27df44a387cfca605de7e1f75873d
2015-12-16 22:37:19 +01:00
jenkins-bot 607878e2ba Merge "MWTarget: Only add ve-init-mw-target-surface to the main target surface" 2015-12-16 20:06:33 +00:00
jenkins-bot 6b7fc00f68 Merge "DesktopArticleTarget: Change tab text on server side when possible" 2015-12-16 19:51:03 +00:00
Ed Sanders a689caa762 MWTarget: Only add ve-init-mw-target-surface to the main target surface
Avoid adding it to TargetWidget surfaces.

Bug: T121450
Change-Id: I7c43b07c5bade3a778ad423e39b25616e03aa888
2015-12-16 14:36:06 +00:00
jenkins-bot 46c2cafdf6 Merge "ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editing" 2015-12-16 06:44:45 +00:00
Translation updater bot b02b68626a Localisation updates from https://translatewiki.net.
Change-Id: I2bcafc960dedf619d0c81163a7a75253b377a79d
2015-12-15 22:25:56 +01:00
Alex Monk c99a5b627e DesktopArticleTarget: Change tab text on server side when possible
Usually. Unless you load VE, because then you might be loading on
`action=edit` in remember-last mode and therefore the tab text needs to
be updated from "Edit source" to "Edit". Or "Create source" to "Create".
Or the equivalent with 'local description' in the case of pages from
foreign file repos, etc.

Bug: T120970
Change-Id: I8f07be6c8e415b40ad134ee82d0bda1d63cc4f96
2015-12-15 10:49:45 -08:00
Alex Monk 76a12f2f9b Try to actually resolve visualeditor-editor preference setting when switching editors
Seems we need to make sure this returns before navigating to the target page.
This reverts commit 40807a0743.

Bug: T121122
Change-Id: I4edf03bc0d57b03897d9f1802eabd8f0dd9962b9
2015-12-15 17:35:22 +00:00
Ed Sanders f87d92a167 ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editing
Otherwise temporary changes to the previewNode will pollute the original
doc's model tree.

Bug: T121488
Change-Id: I6a6b3d904061b0ce6e0c513ad424aabc3c4472b5
2015-12-15 14:40:07 +00:00
jenkins-bot b08c8bd682 Merge "Fix up "Simplify some SET logic"" 2015-12-15 02:56:45 +00:00
Alex Monk 39af893c75 Fix up "Simplify some SET logic"
By 'simplifying', I broke stuff.

This reverts commit b7227f96fe.

Change-Id: I46fdcf336f556680fa72df0893447b6850cc4b1d
2015-12-15 02:50:15 +00:00
jenkins-bot d3d851f394 Merge "Simplify some SET logic" 2015-12-14 21:17:15 +00:00
Alex Monk b7227f96fe Simplify some SET logic
Change-Id: Ie89260607f0253dd7d749af7426702985a0340f4
2015-12-14 21:11:15 +00:00
Translation updater bot 0200bbf328 Localisation updates from https://translatewiki.net.
Change-Id: I43deefad46e60797eda66e10c37eed67a61c141b
2015-12-14 22:06:23 +01:00
jenkins-bot 33cbf199f1 Merge "Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set"" 2015-12-14 20:53:28 +00:00
Jforrester 40807a0743 Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set"
This reverts commit 5b083a7272.

Change-Id: Ieac905b80ea219075b4de498d645f22c3e86c5ca
2015-12-14 20:46:08 +00:00
Bartosz Dziewoński ca81362afd ve.ui.MWMediaDialog: Make the dialog higher (600px)
Avoids a scrollbar for option 4 of the A/B test from T120867.

Change-Id: I3eacb560117219febd6e08066599e2d4d42df219
2015-12-14 20:53:32 +01:00
jenkins-bot d750417545 Merge "Take pageCanLoadVE into account when figuring out whether VE will load in-page or not" 2015-12-14 17:14:41 +00:00
jenkins-bot 04d8089db6 Merge "Fix setEditorPreference call" 2015-12-14 17:08:42 +00:00
Alex Monk 774034b553 Take pageCanLoadVE into account when figuring out whether VE will load in-page or not
Bug: T121342
Change-Id: I84ade6e2ab062597fbfd859a90a864c7607547da
2015-12-14 16:58:26 +00:00
Alex Monk a3148a1559 Fix setEditorPreference call
Added brokenly in I82e39752

Bug: T121343
Change-Id: Ie7b228e94458b17d6ec7c23be264144dec9563be
2015-12-14 16:49:28 +00:00
jenkins-bot 51d493918b Merge "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" 2015-12-14 16:46:02 +00:00
jenkins-bot 648457ca4c Merge "Switch numbered link context to "delete" instead of "clear"" 2015-12-14 01:19:22 +00:00
Translation updater bot a6bab3aeff Localisation updates from https://translatewiki.net.
Change-Id: I9b6d4fa66a9a18160d5143de1ed1c6e783bd0ed3
2015-12-13 22:24:39 +01:00
James D. Forrester 5b083a7272 DesktopArticleTarget: Don't abort in SET mode if veswitched is set
Bug: T121122
Change-Id: I6dca85361be0c1c1c0d39b12b167af813706ae0b
2015-12-11 18:15:25 -08:00
James D. Forrester 2368171fb7 DesktopArticleTarget: Consolidate editor preference setting code
Change-Id: I82e3975233eee0473b513d0931a2d6770fc0f86d
2015-12-11 17:12:28 -08:00
Alex Monk 0774bdf924 Try to clean up the WT->VE prompt opened -> closing -> closed data callbacks
To use
	.then( function ( opened ) { return opened; } )
	.then( function ( closing ) { return closing; } )
	.then( function ( data ) {
etc. instead of nesting them in .done functions

Change-Id: Ic8cee9639b90cb378ce0b7e58dc04eab0ff4cbc7
2015-12-11 23:43:13 +00:00
Alex Monk 155d0240a4 Remember switching into VE from WT when discarding changes
Bug: T120966
Change-Id: I9a7b87cb2561416b72f53afa5140e9d2a4330cfe
2015-12-11 23:35:59 +00:00
Alex Monk 9e5a01aa6b Check that we really want VE before loading it for section edits
Bug: T121189
Change-Id: I34371bf78d34e9d362e9cf5c64bdd108478969b9
2015-12-11 23:19:07 +00:00
Translation updater bot e71f1d67d6 Localisation updates from https://translatewiki.net.
Change-Id: Ife97e1435802802dfeb7754fcea6874433bc6b0d
2015-12-11 23:56:38 +01:00
jenkins-bot e24e2ed7cf Merge "[BREAKING CHANGE] Create ve.init.mw.Target base class" 2015-12-11 18:16:22 +00:00
jenkins-bot 2e6719c0d7 Merge "Use upstreamed actionGroups functionality" 2015-12-11 18:09:50 +00:00
Ed Sanders aa2e0af348 Update VE core submodule to master (19e50b7)
New changes:
e536779 [DEPRECATING CHANGE] Rename link inspector tools
3899967 Localisation updates from https://translatewiki.net.
0a1c09e [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets

Local changes:
* Refactor tools for the breaking change

Change-Id: I676af9c50b09ef007926240eb2327d1a0fdd80f5
2015-12-11 10:03:02 -08:00
Ed Sanders fbb05fb8ed Use upstreamed actionGroups functionality
Depends on I272175dff3 in ve core.

Change-Id: I94cef0f3d8c1b903780890934c2c4963cbe05989
2015-12-11 16:43:48 +00:00
Ed Sanders 21d5856000 [BREAKING CHANGE] Create ve.init.mw.Target base class
Move over logic which isn't specific to the article
implementation of VE (e.g. nothing related to loading/saving).

Refactors setupSurface to use an abstract tracking method (which
does nothing by default), and moves surface CSS classes to #createSurface.

Breaking change:
* Rename onSurfaceReady to surfaceReady. We shouldn't need to listen
  to our own events.
* Rename onReady to documentReady. onReady is not a listener.

Bug: T97166
Change-Id: I7242b1bb5501b7755a18a13d13e166c30cac9cdd
2015-12-11 16:41:47 +00:00
Ed Sanders 672c91f41b DesktopArticleTarget: Fix signature of editNotices
Also ensure it is always an array.

Change-Id: I8498463d3131817b90fa91404289c839110bdeaa
2015-12-11 16:41:47 +00:00
Alex Monk 98a456b189 Single edit tab: Fall back to the wikitext editor when certain parameters show up
We can't handle these yet. There's also 'preview' but I think we probably
qualify as supporting that.

Bug: T121126
Change-Id: I4602992a77f460b9bfcbad0eac1bdd79d67df04d
2015-12-10 23:13:25 +00:00
jenkins-bot 69778a65e5 Merge "Let the feedback tool be configured for a remote wiki" 2015-12-10 22:04:23 +00:00
Translation updater bot 46b901e640 Merge "Localisation updates from https://translatewiki.net." 2015-12-10 22:02:32 +00:00
Translation updater bot 536ff00e5a Localisation updates from https://translatewiki.net.
Change-Id: Ide641aaf9ffec8558271116f9a3a29c1307ed588
2015-12-10 23:01:35 +01:00
jenkins-bot 3db4f22ecf Merge "MWSaveDialog: De-flag the 'return to save' button on diffs" 2015-12-10 21:51:01 +00:00
James D. Forrester 705199753c Let the feedback tool be configured for a remote wiki
Bug: T92661
Change-Id: Id48729c89db208714f67fec1eabafe577a834b51
2015-12-10 12:12:59 -08:00
Ed Sanders 29f33a57d5 Rename mw.Target to mw.ArticleTarget
This makes way for a base mw.Target class which is
not specific to articles (e.g. Flow boards).

Bug: T97166
Change-Id: If72650bdf87aa9f195b004da0a4d815f1a8063a3
2015-12-10 16:26:20 +00:00
Alex Monk 128901866a Don't check editor preferences etc. if user wants veaction=edit
Bug: T120978
Change-Id: I39e28c80440260959b7f1c25b82a057c21de43be
2015-12-09 23:04:02 +00:00
jenkins-bot 212300af1f Merge "Avoid useless jQuery.click shortcut" 2015-12-09 22:18:12 +00:00
Translation updater bot d08da2d62f Localisation updates from https://translatewiki.net.
Change-Id: Ibbc339a27888a391c6c40ced26c154cabb29acf7
2015-12-09 21:43:17 +01:00
David Lynch e9fbb38818 Switch numbered link context to "delete" instead of "clear"
Bug: T120705
Change-Id: I305a0469df8ca3fd75bcd371cf9b9f8894c09f7e
2015-12-09 12:42:20 -06:00
Ed Sanders e7ccc77000 Edit mode switching: Tell VE if the wikitext was modified
Currently we assume that any document state from WE is modified
but that is not necessarily the case.

Change-Id: I085825152528ae5a5e973e8b44f68cb07ee92416
2015-12-09 17:44:43 +00:00
Ed Sanders e9250d87fd Avoid useless jQuery.click shortcut
Why have one event API when you can have ten...

Change-Id: I645cbeb4e486aba9e734ba47d2e7c3958a694f19
2015-12-09 17:34:00 +00:00
jenkins-bot a9894809f6 Merge "DesktopArticleTarget: Handle section edit link clicks in single edit tab mode" 2015-12-09 17:16:12 +00:00
Alex Monk b877e16723 DesktopArticleTarget: Handle section edit link clicks in single edit tab mode
Bug: T58337
Change-Id: Ic4c19cdfc3cfcf33604d0c4e7780b45967cdf57d
2015-12-09 09:08:46 -08:00
Ed Sanders ae26eefb05 Fix typos
Add some common ones to typos.json

Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
2015-12-09 16:47:13 +00:00
jenkins-bot 6c1e613fa4 Merge "Make clear button on numbered external links remove the node" 2015-12-09 16:26:29 +00:00