Commit graph

16841 commits

Author SHA1 Message Date
James D. Forrester b28c4bd31e Update VE core submodule to master (aec8d85c5)
New changes:
aec8d85c5 build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issue

Change-Id: Ia2e5f94899fbb6d3ba036d820df95a3149df0a03
2019-08-26 14:35:29 -07:00
Bartosz Dziewoński 02d0936d90 Update VE core submodule to master (3a669b323)
New changes:
13477446b Localisation updates from https://translatewiki.net.
9ef837943 GeneratedContentNode: Re-apply model selection if DOM node count changes
45c37f702 ve.ce.Surface: Don't request offsets that are out of bounds

Bug: T231085
Bug: T231094
Change-Id: Iad370402c5645a0ed4078977155815a95715dab5
2019-08-26 20:29:01 +02:00
Translation updater bot b4d74b314b Localisation updates from https://translatewiki.net.
Change-Id: I300c93288d73642772ef33685b6bf55d4b2e5d2c
2019-08-25 10:32:38 +02:00
James D. Forrester 90eaa75878 Update VE core submodule to master (7c1d4680d)
New changes:
2e37aaea7 Localisation updates from https://translatewiki.net.
85011b54a Utils: Move ve.supportSelectionExtend to client-only utils
077dfaa59 ve.dm.Change: Remove no-longer used doc argument from #deserialize
586a91bc5 ve.dm.Change: Fix serialize to be recursive

Change-Id: Ia70f2a663899972e35ac0b077465f946ebc49ffc
2019-08-23 06:32:49 -07:00
libraryupgrader efe71172c8 build: Updating eslint-utils to 1.4.2
* https://npmjs.com/advisories/1118

Additional changes:
* Added .eslintcache to .gitignore.

Change-Id: I6a5730042aaeba30614cfca2692991493ba32574
2019-08-23 08:43:09 +00:00
Translation updater bot 3df39a1082 Localisation updates from https://translatewiki.net.
Change-Id: I3dd366aaffefb2ad96ebec5d6a017e71de13c8e9
2019-08-23 09:49:59 +02:00
Ed Sanders 042bfdfd9d Update VE core submodule to master (07687721b)
New changes:
77076f828 LinkAnnotationInspector: add a "label" field on mobile

Local changes:
* Updates for mobile link label editing

Bug: T229431
Change-Id: Ib0489f6f59b228ebc4a20f7a0a515be938a8f6d3
2019-08-23 00:25:51 +02:00
Bartosz Dziewoński 54cd987398 Update VE core submodule to master (663b34056)
New changes:
f373fbea1 Remove redundant @method annotations
ca2ea9246 Fix issue URL typo

Change-Id: I04cfc6b9cc98108261237642dae3be119d8a42a6
2019-08-22 21:22:49 +02:00
Translation updater bot 6dff2dd032 Localisation updates from https://translatewiki.net.
Change-Id: I0cefdc0b02238bb1d506522d8b95acc2825d43a0
2019-08-22 10:10:30 +02:00
Bartosz Dziewoński 756572ed8a ve.init.mw.ArticleTarget: Use errorformat=html when saving
When saving fails for a reason we don't handle explicitly, the error
message will have HTML formatting and will respect any on-wiki
overridden messages, rather than being plain text generic message.

Extensions providing custom SaveErrorHandlers may need to be updated.
The only one in Gerrit that requires a fix is TitleBlacklist:
Ibeae79c95557a7af699716c9d921f34c310bee6d.

* Remove handling for errors returned in .visualeditoredit.edit.info
  rather than .errors (.error in old format). AFAIK this is only used
  by some extensions, it is probably incorrect to do (T229539) and all
  extensions I know of that do this (AbuseFilter, SpamBlacklist,
  ConfirmEdit) have custom SaveErrorHandlers.

* Remove custom error messages for 'readonly' (identical to API
  response) and for 'hookaborted' (very unhelpful and there is a
  chance that the API response is better, if the extension causing
  this error generates any error message).

* Add a silly shim for MobileFrontend integration, because we allow it
  to handle error responses, and it expects them in the old format.
  This is probably subtly wrong in many ways, but MobileFrontend code
  only uses this for logging, so it shouldn't explode. In the future
  we will hopefully change it to use errorformat=html (T228897#5366960).

Bug: T229532
Change-Id: I3b9c4fefc0869ef7999c21cef754434febd852ec
2019-08-22 00:37:15 +00:00
Bartosz Dziewoński 84d548e7b1 Remove redundant @method annotations
A @method annotation is only necessary when the docblock is not
directly followed by a function declaration (in which case JSDuck
assumes it documents a property), e.g. when defining an abstract
function or referencing a function from another library.

I verified that JSDuck generates exactly the same output before and
after this change (docs/data-<hash>.js files are identical).

Change-Id: I7edf51a8560ab9978b42800ab1026f0b5555c3bf
2019-08-21 23:33:15 +02:00
jenkins-bot 5b5e573383 Merge "Update VE core submodule to master (3a7bad9c0)" 2019-08-21 17:29:08 +00:00
jenkins-bot eaeb3bde40 Merge "MobileArticleTarget: Tweak styling for editor switcher" 2019-08-21 17:00:41 +00:00
James D. Forrester bd0bcff6e4 Update VE core submodule to master (3a7bad9c0)
New changes:
92b32ff5e Localisation updates from https://translatewiki.net.
43950656f Rebaser: Listen to surface history event, not document transact event
3847440a4 Localisation updates from https://translatewiki.net.
5e3e913ea Consider focus, not anchor, in ve.ce.RangeState
56378e975 Prevent RangeState tests from hanging QUnit via a huge diff

Bug: T230814
Change-Id: Ib1f238c4800e3acb581122cbb999a8e59dd5b2c5
2019-08-21 14:33:14 +01:00
Translation updater bot 66223e011b Localisation updates from https://translatewiki.net.
Change-Id: Ie12883ab889384c3b36ed5417747ec8f8bce79e0
2019-08-21 10:11:51 +02:00
jenkins-bot d2c6d0f295 Merge "Fix 'paramter' typo in code and add to typos list, now covering PHP" 2019-08-20 11:32:21 +00:00
DannyS712 00a98dd8f2 Fix 'paramter' typo in code and add to typos list, now covering PHP
Bug: T201491
Change-Id: I28d3b3871a2de54e575163bec7c364b68da8d5a6
2019-08-20 12:10:04 +01:00
Translation updater bot e2348eef46 Localisation updates from https://translatewiki.net.
Change-Id: I9b858efabbf1a390d3984b62f368ec865312e825
2019-08-20 10:28:50 +02:00
Translation updater bot a2ac605ad3 Localisation updates from https://translatewiki.net.
Change-Id: Ib7a3436239f4aa463b6ce6ddee358e784fe5bf8e
2019-08-18 09:34:09 +02:00
Translation updater bot 08a5daeceb Localisation updates from https://translatewiki.net.
Change-Id: Ic6bb33d07dc484779b074ecc022227fb1ff1b71b
2019-08-16 09:19:41 +02:00
jenkins-bot 2d52d7e86c Merge "MWSaveDialog: On mobile show a back button rather than an x" 2019-08-15 09:32:32 +00:00
Ed Sanders 3cbe0a5a20 Update VE core submodule to master (c2c5149f3)
New changes:
62f06382c Localisation updates from https://translatewiki.net.
5fc25c0d9 LinkContextItem: Apply ellipsis directly to link

Local changes to fix link ellipsis styles.

Bug: T230267
Depends-On: I25bb4fa9b7288232b08bab9c88f281817a26d6bb
Change-Id: I8a4b04d45979a1f6c375a7c92a340e3e81d7753c
2019-08-15 10:12:22 +02:00
David Lynch ac471d47e9 MWSaveDialog: On mobile show a back button rather than an x
Bug: T230058
Change-Id: I370fedddf8475e5688ac4ce53f9ccd7d6137705b
2019-08-14 11:38:38 -05:00
Translation updater bot 21dca00701 Localisation updates from https://translatewiki.net.
Change-Id: I48726698afd509243018c20293364669c45d7e29
2019-08-14 09:16:44 +02:00
Translation updater bot 3b75e86a19 Localisation updates from https://translatewiki.net.
Change-Id: I56e158eb64ff55a3c4c31a1e0ddf7e310f60ef10
2019-08-13 09:17:01 +02:00
Translation updater bot b062f93511 Localisation updates from https://translatewiki.net.
Change-Id: I77227a8e58ce7212fc50737a6a57a48b7b50c3a5
2019-08-12 09:07:48 +02:00
Translation updater bot 99def73efa Localisation updates from https://translatewiki.net.
Change-Id: I1781a43249a969506979426f96736ab0713a3842
2019-08-10 22:50:22 +02:00
Translation updater bot 32c7418c65 Localisation updates from https://translatewiki.net.
Change-Id: Iaa8eaf0c88f3a7014cfaa652ee775d7783a8e43b
2019-08-09 09:11:38 +02:00
Bartosz Dziewoński e14e24f037 MobileArticleTarget: Tweak styling for editor switcher
The .oo-ui-popupToolGroup-handle styles only need to apply to the
editTools toolbar, where they override OOUI styles so that our
"stretched" toolbar works; they don't need to apply to the pageTools
toolbar, which contains just the editor switcher, and where they make
it look different from the MF wikitext editor toolbar for no reason.

Change-Id: I21315b34be0a7c3938f84ada720ff5754d953879
2019-08-08 19:47:14 +02:00
Translation updater bot 8b3ec008e9 Localisation updates from https://translatewiki.net.
Change-Id: Ie90e7f506bb89a70db21ffcd8f866e8033261421
2019-08-07 09:45:20 +02:00
Ed Sanders 90fc49e18b Update VE core submodule to master (70bf52198)
New changes:
70bf52198 MobileContext: Clear opening timeout when closing

Bug: T229879
Change-Id: I4c13c0e8bc56262f0504dab19847718fe4d60ce6
2019-08-06 15:27:03 +01:00
Translation updater bot 86919974e3 Localisation updates from https://translatewiki.net.
Change-Id: I9c836119d79c1ee63e212f6d8ebf190931dd3756
2019-08-06 09:12:09 +02:00
jenkins-bot 134e4f7cbe Merge "MWSaveDialog: Don't pretend saveButtonLabel is optional" 2019-08-05 21:57:13 +00:00
jenkins-bot 198397ae86 Merge "Update VE core submodule to master (aae84a489)" 2019-08-05 20:51:04 +00:00
Ed Sanders 348c880cbe MWSaveDialog: Don't pretend saveButtonLabel is optional
Change-Id: I7cfc5bfbf8893fa4808f2823b37efae7b9e520ac
2019-08-05 21:16:21 +01:00
Ed Sanders 88cb572e35 Fix typo in file header
Change-Id: I6f258f81e6cb129328bf912245f23d6c4d877f47
2019-08-05 21:15:58 +01:00
Ed Sanders c8c81d2894 Grunt: Expand js{,on} pattern
Change-Id: I5061da3bced0a5c943038a9ec7bdbf8f38b35009
2019-08-05 21:15:37 +01:00
Ed Sanders d8461241f2 Update VE core submodule to master (aae84a489)
New changes:
1375d1500 Document that toJSON takes a key argument
27056b919 Localisation updates from https://translatewiki.net.
aa52f476f Only create context footer on mobile
ab6d942c5 Deactivate surface during replaceAll
aae84a489 MobileContext: Ensure isVisible returns true while opening

Bug: T229734
Bug: T229879
Change-Id: Ic03c22a785a2e9e8a4d38c17789ea2d4f16ef3ed
2019-08-05 21:13:05 +01:00
Ed Sanders bae45b63d2 Use flexbox for mobile toolbar
* Makes edit tools equal width
* Improves horizontal alignment within tools

Change-Id: I01b9668b638c21607b12381efc198edfe02f23da
2019-08-05 12:01:32 +01:00
jenkins-bot 644f409d61 Merge "Use MobileFrontend license message on mobile when available" 2019-08-02 22:12:12 +00:00
Ed Sanders 0b1f0a0eda Use MobileFrontend license message on mobile when available
Bug: T229579
Change-Id: I861f0d997607a34ca04727afd55771cbf14e253b
2019-08-02 16:29:54 -05:00
jenkins-bot a0a8213dc0 Merge "build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1" 2019-08-02 18:38:56 +00:00
James D. Forrester 67087af16d Update VE core submodule to master (0de28ce64)
New changes:
cd5e54f78 MediaSizeWidget: Make methods chainable
1606e2dd5 Localisation updates from https://translatewiki.net.
5a2f5fdb5 ve.ui.AnnotationInspector: Select inserted elements (not text) after inserting
6f2206ee2 Fix ve.dm.Change#toJSON to cope with arguments passed by JSON.stringify
7c78f1db7 Document ve.dm.TransactionProcessor#process better

Bug: T227630
Change-Id: Ic79e8bb8ef9a6288d80b591a83bf43cafc83743d
2019-08-02 10:26:51 -07:00
James D. Forrester 05fb44ae56 build: Upgrade eslint-config-wikimedia from 0.12.0 to 0.13.1
Change-Id: I43f407da92f59a8bf758cc2586e84aa5e18d9ab0
2019-08-02 09:51:07 -07:00
James D. Forrester dce6efb31e Update VE core submodule to master (a7d95c35b)
New changes:
d6d0ff8ce Localisation updates from https://translatewiki.net.
f57c6344c Move common code from FragmentDialog and FragmentInspector to FragmentWindow
a7d95c35b build: Bump lodash for npm audit

Change-Id: Ide09983d0b8c2006b25ab257fc048416a83b50c6
2019-07-31 18:50:04 -07:00
Ed Sanders 89ecd64a55 Make extension body the default description for extension nodes
Change-Id: Ifada2a6a0279e64a1ba82f49e03884e362516a83
2019-07-31 16:38:27 +01:00
jenkins-bot 51b93cea94 Merge "ve.init.mw.DesktopArticleTarget: Fix generated URL when loaded using veaction=edit in single-tab mode" 2019-07-31 13:28:59 +00:00
jenkins-bot 2d2e7dcdb2 Merge "ve.ui.MWLinkAnnotationInspector: Correct code comment" 2019-07-30 23:58:16 +00:00
Bartosz Dziewoński 7d3154fea8 ve.init.mw.DesktopArticleTarget: Fix generated URL when loaded using veaction=edit in single-tab mode
We were incorrectly always adding action=edit to the URL in that case.
The condition was always passing because `this.section` is `null` when
unset, but `this.currentUri.query.section` is `undefined` when unset.
This is a similar fix/bug to a68cc38b22.

Bug: T209163
Change-Id: Ic80ac377b763aea53678c4209ba6b3a6ba2996c9
2019-07-31 01:10:56 +02:00
Bartosz Dziewoński 0f5fe34534 ve.ui.MWLinkAnnotationInspector: Correct code comment
The way this works changed in ff9bf1fcb3 (2015).

Change-Id: I61617723ec6ada8018cdca55eb3fcc971796fded
2019-07-31 00:21:45 +02:00