Commit graph

8501 commits

Author SHA1 Message Date
Roan Kattouw 884aa1f243 Add forgotten $overlay pass-through in MWReferenceDialog
We were doing this for the exact same widget in
MWReferenceListDialog, but not here.

Bug: 72785
Change-Id: I4a905b944be44ec1aec5cdba7580283ec18c5c7c
2014-10-30 14:50:10 -07:00
Alex Monk b71bb51171 Remove more references to ve.bind
Seems some of them have crept back in since I1a7fc7f2 (and we missed one somehow)

Bug: 72156
Change-Id: I5631fb7d5963d06aeb238c1daa44344b2060ef1a
2014-10-30 20:55:44 +00:00
jenkins-bot c83961842c Merge "Preserve original data inside parameter objects too" 2014-10-30 20:47:32 +00:00
Ed Sanders 17f3930203 Missing message from table merge
Change-Id: I67d42ece613358b1e48cd04d8d53df0d94a79cbc
2014-10-30 20:11:27 +00:00
jenkins-bot 9a1ed3ce3d Merge "Toolbar: Make styling and insert menus collapsible" 2014-10-30 19:56:08 +00:00
James D. Forrester 6626450419 Toolbar: Make styling and insert menus collapsible
Also re-synchronise toolbar in MWMediaDialog and MWReferenceDialog.

Change-Id: I8cd5f0d9f7e188fa1a7ab8d34a2796340f5e99b7
2014-10-30 12:22:20 -07:00
jenkins-bot c402528d1a Merge "Also add tableCaption to mwTable parentNodeTypes hack" 2014-10-30 19:19:27 +00:00
Roan Kattouw a054a753be Preserve original data inside parameter objects too
Parsoid has added a "key" property to parameter objects,
so now we have to preserve that rather than regenerating
all parameter objects.

Do this by changing the existing use of this.originalData
to a deep extend.

Change-Id: Ib4d31c2e0f7b567da1a148b51c42e688a2590b8e
Bonus: avoid modifying this.originalData
2014-10-30 11:59:42 -07:00
Roan Kattouw 407ed04ef0 Update VE core submodule to master (f9f51a5)
New changes:
7d36bd8 Don't create tables with a thead
dfee68d Localisation updates from https://translatewiki.net.
dde7897 Fix selection transitions between FocusableNodes and non-linear selections
6f9437f Update OOjs UI to v0.1.0-pre (da4b0d5c14)
1ec4bf5 Always emit context change on null selection

Change-Id: Ib3c175199950822cda7b34a3c8ca4faa20c53cfc
2014-10-30 11:52:59 -07:00
Roan Kattouw 190ba17b74 Also add tableCaption to mwTable parentNodeTypes hack
Change-Id: Ic7e387bdb774699746e6bafb62daf9c843af77b5
2014-10-30 11:38:26 -07:00
jenkins-bot 3806a2838c Merge "Clear selection after tearing down surface to work around Firefox bug" 2014-10-29 23:21:36 +00:00
jenkins-bot 48e40fe3c2 Merge "MWTransclusionModel: Exclude parts serialising to '' from the plain object" 2014-10-29 23:20:48 +00:00
jenkins-bot 51df4d0f05 Merge "Add i18n for API module help" 2014-10-29 22:42:57 +00:00
Roan Kattouw f35d577acb Followup e0981a3: don't pass undefined to getClassAttrFromAttributes()
Change-Id: I987345cd923d1b128573f5669d4d0dd4e82db1c9
2014-10-29 14:50:50 -07:00
Translation updater bot 7ea182fa79 Localisation updates from https://translatewiki.net.
Change-Id: I21dc334f17f93a3c3d89d8d961fafda2ee288180
2014-10-29 22:08:10 +01:00
Brad Jorsch 7d4ecc09c8 Add i18n for API module help
MediaWiki core change I04b1a384 added support for i18n of API module
help. This takes advantage of that while still maintaining backwards
compatibility with earlier versions of MediaWiki.

Once support for MediaWiki before 1.25 is dropped, the methods marked
deprecated in this patch may be removed.

Change-Id: I67395aff48185f3e09da31b51a08aa2541fe6a17
2014-10-29 13:59:41 -07:00
jenkins-bot dcb14bc9bf Merge "Hide page status indicators even if they aren't :visible" 2014-10-29 20:59:00 +00:00
Bartosz Dziewoński 2a55baaef7 Hide page status indicators even if they aren't :visible
The container is zero-height and zero-width, so jQuery doesn't
consider it :visible, and yet it still takes up visual space.

Bug: 72693
Change-Id: I3bed5394a2a64a9f7f0a331f850aa412b5b11b7d
2014-10-29 21:52:38 +01:00
Ed Sanders e0981a327f Create mwTables with wikitable attribute by default
Change-Id: I094b1823248e16dd3b9a0a10ba13104f14798621
2014-10-29 12:52:24 -07:00
James D. Forrester cc8f6970a5 Update VE core submodule to master (f4ff1d6)
New changes:
d845991 Data model implementation for tables
a27c148 ContentEditable implementation for tables
3c47428 Actions and context menus for manipulating tables
543ca54 Support annotation tool on table selections
149cf3d Supporting copy paste of single table cells
25c9eee Table header/data format tools
e557e46 Merge cells tool
afcf2d9 Allow custom type and attributes when creating a table

Local changes:
Add the files and messages for table editing

Change-Id: I6e6c33b96d3089049a0fd5385191caa83df5756b
2014-10-29 11:52:09 -07:00
Ed Sanders cfee8047e4 Use ClassAttributeNode mixin in MWBlockImageNode
This functionality was factored out into core for this purpose.

Depends on I2db6563 in core.

Change-Id: I4fc42e1468a9f0860c7c13e73967204bdf5ad78d
2014-10-29 18:28:33 +00:00
jenkins-bot 44816dfa7f Merge "Update VE core submodule to master (545d8db)" 2014-10-29 18:25:36 +00:00
Roan Kattouw f039160b62 Update VE core submodule to master (545d8db)
New changes:
b79bf0d Add table to test node hack as MWTable is coming
545d8db Provide a generic mechanism for mapping classes to attributes

Change-Id: I4911e81856c66fdde4b5cae622b474be36834911
2014-10-29 11:19:35 -07:00
suchetag c6f7f361c2 Introducing isValid() in MWTitileInputWidget
A method isValid() is added to MWTitleInputWidget which would validate the titles given as inputs

Bug: 71249
Change-Id: I7749165652bd3c0bb08ca42289a425fe8e25483d
2014-10-29 11:13:42 -07:00
suchetag 9191465039 Introducing getTitle() in MWTitleInputWidget
A method for getTitle() is added which can return the valid title,
or, it can return null, in case the value isn't a valid title

Bug: 72468
Change-Id: I8a13afc9a66c167fe25010743c0d9e1424133d96
2014-10-29 18:12:04 +00:00
Amir E. Aharoni b4e98c1490 [BrowserTest] Disable two failing scenarios
To allow other screenshots to be created.

Change-Id: I3e892baa9cb2c8c1303fab232a2b1c64ebdd8f26
2014-10-29 09:44:55 +00:00
Roan Kattouw cbb113bccc Convince jsduck mw.Title exists
Apparently we didn't have any functions taking or returning
an mw.Title object, which is kind of concerning. But now that
we're introducing one, we need jsduck to shut up about mw.Title
not existing.

Change-Id: I04028e0e3d55ed9901878cce593f857183246ab3
2014-10-28 18:20:13 -07:00
Alex Monk a982d2d3fe MWTransclusionModel: Exclude parts serialising to '' from the plain object
So we get rid of empty content nodes

Bug: 63341
Change-Id: I1d49cc709bf92cc53ba064d148a76650c5143935
2014-10-29 01:08:41 +00:00
Roan Kattouw d68eae6c8d Clear selection after tearing down surface to work around Firefox bug
Bug: 71852
Change-Id: I3b4f0f755ece5c9e5444f8abadb1950a3f4ef318
2014-10-28 11:23:06 -07:00
jenkins-bot d73a692f57 Merge "Show warning on reference dialog when editing a reference used in more than one place" 2014-10-28 17:36:07 +00:00
jenkins-bot fe41462fb9 Merge "Update VE core submodule to master (ce4ee02)" 2014-10-28 17:34:37 +00:00
jenkins-bot 538c8769a6 Merge "Move core/MW messages to correct sections" 2014-10-28 17:31:50 +00:00
jenkins-bot 78b2a2885c Merge "Pass $overlay to widgets that need it" 2014-10-28 17:30:57 +00:00
Ed Sanders b89510c18b Move core/MW messages to correct sections
Also bring in visualeditor-version-label message from core.

Change-Id: I91ceba0e0550239a10329b327b5c6b5a01e460a9
2014-10-28 17:30:19 +00:00
James D. Forrester 564a6d0a90 Update VE core submodule to master (ce4ee02)
New changes:
56c30cb Remove font-size: 0.8em; rule for OOUI change
97d5111 Update OOjs UI to v0.1.0-pre (deccd11549)

Change-Id: I6efd0a9a996ae60404e029748ef71672cd5ab07d
2014-10-28 10:28:50 -07:00
jenkins-bot 5eb0baf55d Merge "Sprinke some child selectors around in MWTransclusionDialog.css" 2014-10-28 16:55:27 +00:00
jenkins-bot 370e15c1d9 Merge "Update VE core submodule to master (07b2eda)" 2014-10-28 16:55:26 +00:00
jenkins-bot 1cc342a462 Merge "Put icons back in template parameter search" 2014-10-28 16:48:52 +00:00
Translation updater bot 47115a9e4e Localisation updates from https://translatewiki.net.
Change-Id: I84552cda584f0078f60955c1872178b820beefe7
2014-10-28 15:21:02 +01:00
Alex Monk 3846e20463 Show warning on reference dialog when editing a reference used in more than one place
Bug: 52792
Change-Id: I2b183c3867ddb601041f9989964aa6f78b5f37e4
2014-10-28 12:58:50 +00:00
jenkins-bot ef90da1484 Merge "Override overflow: hidden; for <h3>s in the command help dialog" 2014-10-28 09:58:03 +00:00
Roan Kattouw 97dcee132d Put icons back in template parameter search
These disappeared when DecoratedOptionWidget was split
out of OptionWidget in I508c1555 in oojs-ui back in July,
and apparently no one noticed.

Make MWParameterResultWidget and MWMoreParameterResultWidget
inherit DecoratedOptionWidget instead of OptionWidget so
the icon config parameter is recognized again.

Change-Id: I08d8a0466c211a29eb62043131725073dece4eb5
2014-10-28 01:32:22 +00:00
Roan Kattouw dde33f2297 Update VE core submodule to master (07b2eda)
New changes:
4193898 Remove mw-specific message
f14b214 tests: Prepare repository for running RuboCop after every push to Gerrit
1d81df3 Localisation updates from https://translatewiki.net.
ded6be7 Localisation updates from https://translatewiki.net.
8417636 Localisation updates from https://translatewiki.net.
881d9e5 Make link inspector not close itself in IE... again
07b2eda Recalculate toolbar size on window resize

Change-Id: I5e3becac07cb20d39026786051ca28db0b3a13ca
2014-10-27 18:03:30 -07:00
Roan Kattouw 5876014c8f Override overflow: hidden; for <h3>s in the command help dialog
When this dialog is not isolated, MediaWiki's overflow: hidden;
rules for headings cut off part of the text in the <h3>s.

Compensates for Id425c56d9d24 in VE core.

Change-Id: Id9f6bd2bdbed0c6fe57e897c2415c3eceff900a6
2014-10-27 17:51:46 -07:00
Roan Kattouw 33c5b38b64 Remove oo-ui-{ltr,rtl} special-casing for parameter icons
It works both with and without in isolated dialogs,
but styling things this way breaks in non-isolated dialogs.

Change-Id: Ia498b48d8c199f50df326ddeb61d958cbe2c520d
2014-10-27 17:49:42 -07:00
Roan Kattouw d0f273d6db Sprinke some child selectors around in MWTransclusionDialog.css
Indiscriminately styling all .oo-ui-widget elements with a
descendant selector is very evil, use a child selector instead.
The use of a descendant selector broke inline dropdowns.

Change-Id: I25c5007ef1ffab9e59c46c3b11270b8f77610327
2014-10-27 17:38:20 -07:00
Roan Kattouw 61e8115e8b Pass $overlay to widgets that need it
Also change this.$overlay (which doesn't even exist) to
config.$overlay in MWTemplatePlaceholderPage and document it.

Compensates for I39df86373ea in oojs-ui.

Change-Id: I4a233c058439d6cfb38d80ece890c8fe57d58f49
2014-10-27 17:36:19 -07:00
jenkins-bot 0dad360036 Merge "Disable parameter add icon when there's no transclusion parts" 2014-10-27 20:39:46 +00:00
Alex Monk d128378f5a Disable parameter add icon when there's no transclusion parts
Would put this code in onBookletLayoutSet, but that doesn't appear to be
getting called in this case.

Have to detect whether or not we should be changing the disabled status, rather
than just setting it straight away, which would break every other case where
onBookletLayoutSet is called.

Bug: 63158
Change-Id: I6f62479291424d9b2ee0e42481dec9d085169c63
2014-10-27 20:33:35 +00:00
Translation updater bot dfd00e83c6 Localisation updates from https://translatewiki.net.
Change-Id: I5d874f7c0cfa4bdfcca99b7336efe9de03cfb356
2014-10-27 20:21:32 +01:00