This version is more robust. It reports common problems like
fileexists-shared-forbidden and fileexists-no-change.
In case of trouble it reports the error and goes to the next file.
Bug: T189122
Change-Id: I510ba7d378cb71b177a54d2ba771c51fbdead90f
New changes:
8d8030fd1 Localisation updates from https://translatewiki.net.
37302d389 Show timeout message if diff times out
4fa6e3005 ve.dm.Converter: Handle meta nodes for empty annotations same as normal
f74c630d6 ve.Node: Make #getOffsetPath not fail while rebuilding the document
bd62f3e74 Fix global overlay classes
Bug: T180842
Bug: T187690
Bug: T189118
Change-Id: Ieb404db788bd9ff743f00131458c44f01deac466
This happens to work correctly because we depend on 'mediawiki.user',
and that depends on 'mediawiki.storage'. This is just an implementation
detail though and could change.
Change-Id: Ia23c83ae73bfbcc65b4a169bddf861d83691822e
It's possible for some load failure states to cause this teardown at a point
without a surface. I observed it in MobileFrontend, when restbase can't be
contacted.
Change-Id: I13489640759c73dad5730d0bbadbfb2a38cb8e53
The new version has many improvements, including not breaking when the file exists and upating file
description.
Bug: T189122
Change-Id: Ib4b42c9f663bafbbfb0c96e5fb4d9d5f162d2265
Overriding ve.ce.BranchNode#onSplice seems pretty scary, some bug
could cause two captions to be inserted and it wouldn't even be
visible in the editor.
Instead, allow normal splice handling to happen when the caption is
added/removed, and only override the position where it is inserted
(to account for the image node this.$a).
The caption node is already removed from DM/CE if the image type is
changed to one that doesn't have captions, and even if that failed it
is also hidden in CSS, so we don't need to handle this.
Change-Id: I54f52b288118d692708311512dd674cc85d5d9e3
New changes:
01609bfaa Follow-up Icf2d948bc9: Only reset lastStoredChange in storeDocState if using latest HTML
Change-Id: I9d70f9827cb84d01f7e172e444fa33cf7921ddfd
5f6664e2 in VE core changed the specificity for some of the rules this
expected to override.
Bug: T189267
Change-Id: I510e151cc431c321d1d45fde9030d56f059d84ab
Various checks didn't think a rel attribute could contain multiple values.
Mostly they don't, but to play it safe let's adjust the checks.
Change-Id: I29823b7c8c65ef6b2ff41ce9a801840000972e9c
Depends-On: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
New changes:
e10e2c0b6 Remove gecko-specific paste tests, add copy test
c555b6567 Complete test coverage of autosave methods
fc02e085e Localisation updates from https://translatewiki.net.
08a55658e CE Surface tests: Add missing </tbody> tags
ff5a766bb CE Surface tests: Avoid execCommand on tests failing in Firefox
46160f796 Run and make voting the Firefox tests in CI
Bug: T182626
Bug: T189201
Change-Id: Iee50ddf350e4a3312024b280cdeded08d325ea06
We have a Jenkins job to take screenshots of VisualEditor and upload the
result to commons.wikimedia.org. That roughly does:
npm install
node_modules/.bin/grunt screenshots-all
bundle install
bundle exec upload
However on CI, the Docker container only accepts 'npm run-script XXX' or
'bundle exec rake YYY'.
Add a npm script 'screenshots-all' invoking 'grunt screenshots-all'.
Add a rake task 'commons_upload'. I have added a basic check to make
sure environment variables are properly set before invoking the upload
script.
Thus on CI the usage will become:
npm install
npm run-script screenshots-all
bundle install
bundle exec rake commons_upload
Which match the CI convention.
Bug: T189122
Change-Id: I221ed8d6178dd036eac287f0f811834a6d4ffd22
