Commit graph

21402 commits

Author SHA1 Message Date
David Lynch 099e7a80c4 Exclude node_modules directories from phpcs
The `flatted` module in lib/ve/node_modules includes some php files that
keep causing errors.

Add the --cache just because it seems to be common practice in other MW
extensions.

Change-Id: Ia791e569587d76e991711b93011cb1df3796f532
2023-10-12 16:52:22 -05:00
Bartosz Dziewoński a60b3719f6 Don't try to update tab text if a custom message is incompatible
Some wikis customize messages, e.g. 'skin-view-create-local', in ways
that are not compatible with the client-side message parser.

Bug: T306807
Change-Id: Ie2f2ba4bba3b5b6f4fd6dbed6773d87f096a8944
2023-10-12 21:01:39 +02:00
Bartosz Dziewoński fa889154c2 Fix handling of 'edit-local' and 'create-local' messages
* Remove incorrect overrides in VisualEditorTabMessages. Since
  I44bd632682d5cc52b2660ad72a492f95a04be36e, the interface should use
  'skin-view-edit-local' and 'skin-view-create-local' respectively.

* Fix the fallback mechanism in DesktopArticleTarget.init.js
  to handle these keys correctly.

Change-Id: I7dad7e3a6fb920c5caf175e0e7500fd0c4b4d0ae
2023-10-12 20:05:06 +02:00
Translation updater bot e485fa0a6c Localisation updates from https://translatewiki.net.
Change-Id: Id34913501f7cd45264f9021594b8bea9e61a8433
2023-10-12 09:30:12 +02:00
Translation updater bot f40a487360 Localisation updates from https://translatewiki.net.
Change-Id: Ia2b9ab188d30ef3ee1953774c054470dc3ae2bd8
2023-10-11 08:46:30 +02:00
Translation updater bot d54f6459e1 Localisation updates from https://translatewiki.net.
Change-Id: If46b98030d4a01ec5646a4f6ab6e5710fdfdc629
2023-10-10 08:53:08 +02:00
Bartosz Dziewoński 137914de28 Change icon for supported skins for section edit links, too
Bug: T346944
Change-Id: I4653671ccb2bba2da3940897371d7dfac4bbd0f2
2023-10-09 20:13:24 +02:00
jenkins-bot 9ac3b2cff5 Merge "Edit check: avoid a hardcoded "continue" in the rejection dialog" 2023-10-09 16:50:47 +00:00
jenkins-bot 69d124756c Merge "Disable $wgVisualEditorUseSingleEditTab on mobile site" 2023-10-09 15:34:52 +00:00
David Lynch 9ed539235c Edit check: avoid a hardcoded "continue" in the rejection dialog
Change-Id: I6a771dd6a7508fc44c1d8c67812d6b4b6111cb7a
2023-10-09 10:02:19 -05:00
Translation updater bot 4e1e1cb994 Localisation updates from https://translatewiki.net.
Change-Id: I08e99c5a530327488be60205a97276660c6444b6
2023-10-09 08:57:21 +02:00
David Lynch 87145e818a Edit check: stop an error on save if no reference-needing content added
saveProcessDeferred will only exist if content was actually added. This
wasn't causing any functional issues, just an error in the console after
you save.

This issue was introduced via I1dccc3c.

Bug: T344382
Change-Id: Icb0c29b64d960308343ddbb3f9d2ee641552b814
2023-10-07 17:47:53 +00:00
Jon Robson bc4c367bba Disable $wgVisualEditorUseSingleEditTab on mobile site
Bug: T348353
Depends-On: I92f7c2c5f4691bd511219432c53379ddd928eae2
Change-Id: I3108f884173526f95d86d975d7421b4af1cff447
2023-10-06 16:29:48 -05:00
Umherirrender b8a85b50db build: Restore .phan/config.php
Got lost in c180c2f5

Change-Id: Ic30632604bb80d739f0913515a507b97ccbfa67f
2023-10-06 16:51:51 +02:00
Translation updater bot 5cdb12b5e1 Localisation updates from https://translatewiki.net.
Change-Id: Ib1ec48a074a132eb4ede3bcc88ed5ded51964fba
2023-10-06 09:21:57 +02:00
jenkins-bot d3b933726e Merge "config: Mention ecenable in edit check config" 2023-10-05 14:50:10 +00:00
jenkins-bot 61f3414a49 Merge "DesktopArticleTarget.init: Remove code for updating edit links" 2023-10-05 13:44:34 +00:00
Translation updater bot 1ff766d01d Localisation updates from https://translatewiki.net.
Change-Id: Id5c359aed309d9a1bdacf705e9e64ed3ee9bd500
2023-10-05 09:12:43 +02:00
Bartosz Dziewoński be36f1fab1 DesktopArticleTarget.init: Remove code for updating edit links
This JS code duplicates the PHP implementation in VisualEditorHooks
in order to allow changes to the configuration of edit tabs
(e.g. wgVisualEditorUseSingleEditTab and wgVisualEditorTabPosition)
to take effect for logged-out users immediately, without waiting
for the HTML caches to clear.

It was worthwhile 10 years ago when VisualEditor was being rolled out
to new wikis or reconfigured daily, but it is not today when we hardly
ever change these settings.

It proved difficult to maintain as the skins change, it has several
known bugs (T292125, T306807, T346944), and probably several more
unknown ones, given that it hasn't been tested in about 10 years.

Let's remove it and save ourselves the headache. (Also also reduce the
amount of code we ship on all page views by almost a kilobyte.)

Bug: T292125
Bug: T306807
Bug: T346944
Change-Id: Ib82f5402872a2429445463a1e1ef92806d3326f9
2023-10-05 03:11:40 +02:00
jenkins-bot 86fb65ba90 Merge "Change icon for supported skins when both VE and source edit icons are present" 2023-10-04 23:20:19 +00:00
Jon Robson 47815e9d2b Change icon for supported skins when both VE and source edit icons are present
This introduces an extension attribute EditIconSkins which allows extensions
or skins to request the rendering of edit icons.

This will be used by Minerva in I3c9d59f49f1b939981a7b2b450448db6736d5958

Bug: T346944
Change-Id: I401805224c0f387ac85b52b50c1f298b83c03a91
2023-10-04 22:16:13 +00:00
Translation updater bot c066dc745a Localisation updates from https://translatewiki.net.
Change-Id: I6f6c46192e404a30cbf8a103eac20383f91330b2
2023-10-04 09:09:22 +02:00
jenkins-bot 8c21352cd5 Merge "Fix wikitext mixed toggling" 2023-10-03 21:31:20 +00:00
hmonroy 3e223bdf52 Fix wikitext mixed toggling
Allow Core to handle the toggling for Wikitext when the inline switch is
present to avoid duplicated functionality.

Bug: T345836
Bug: T346213
Bug: T346299
Depends-On: Ib88836f13cdb5cd2344e3ba12f6c942baa0fc1f1
Change-Id: I3bb9fcabe17a20c9934274766e3335f63d51aac4
2023-10-03 16:15:37 +00:00
Ed Sanders 70c116a17a Edit check: Simplify "experience" config to "maximumEditcount"
There's no product need for anything other than an upper limit
on edit count. If one arises in the future we can adjust accordingly,
but better to keep the JSON, and any UI implementation, simple
for now.

Change-Id: I892847ad78b19695f0f0f664002d3c566f7806de
2023-10-03 16:20:51 +01:00
Translation updater bot 47dc22d6c0 Localisation updates from https://translatewiki.net.
Change-Id: I33a2510f8dcc7b2ff9f05867839b7e5ea1fe3d23
2023-10-03 09:33:33 +02:00
David Lynch 177f07a759 Update VE core submodule to master (ca5f6c26d)
New changes:
ff87fe63c TableNode: Remove hack for ancient browser (FF39)
45516acbd Remove ve.isPassiveEventsSupported
f1cc17fb3 ve.ce.Surface: Remove IE support in copy/paste code
59b572c89 Localisation updates from https://translatewiki.net.
ab2524e41 RebaserTarget toolbar: use findIndex
599ffff20 Localisation updates from https://translatewiki.net.
b6b0b2f01 Localisation updates from https://translatewiki.net.
1c5dce24a build: Update linters
64fa7d401 Localisation updates from https://translatewiki.net.
8e6468945 Localisation updates from https://translatewiki.net.
169f721fc Localisation updates from https://translatewiki.net.
81d298f58 Localisation updates from https://translatewiki.net.
22527ef88 Localisation updates from https://translatewiki.net.
5560459a3 Only log context-shows if they're on a non-null fragment
b8cab4086 .gitreview: Swap to track=1
629b48057 Localisation updates from https://translatewiki.net.
2a2665a0d Localisation updates from https://translatewiki.net.
506d4c01f ve.repeatString: Use native implementation
c6dcc87b3 Localisation updates from https://translatewiki.net.
8cf97e8c8 ChromeHeadless: Do not pass a spurious empty flag
61990513c Provide alternate keyboard shortcut for toolbar search for mac Firefox
ca5f6c26d Localisation updates from https://translatewiki.net.

Bug: T324735
Bug: T341603
Bug: T347380
Change-Id: Ic1172a3eee32f688f2fab32a3a8eaf6dc829e600
2023-10-02 16:46:25 -05:00
Translation updater bot d6e9e9af06 Localisation updates from https://translatewiki.net.
Change-Id: I4a17e4464c6d0fae1a737003dabb7d75408515a0
2023-10-02 10:58:37 +02:00
jenkins-bot 9ce1a1d44e Merge "build: Upgrade grunt-banana-checker from 0.11.0 to 0.11.1" 2023-09-28 07:27:22 +00:00
Translation updater bot 63d4d6966b Localisation updates from https://translatewiki.net.
Change-Id: I23a7e91c0da62b69512585da8ad4187e108a1309
2023-09-27 09:21:21 +02:00
jenkins-bot de9b3936b8 Merge "Update comment w/ rename of Article::getRedirectHeaderHtml()" 2023-09-26 19:35:23 +00:00
James D. Forrester c7ee116f07 build: Upgrade grunt-banana-checker from 0.11.0 to 0.11.1
Change-Id: I9390d6f36ef029b0a29126421b4647948bac7147
2023-09-26 14:39:59 -04:00
Translation updater bot aa645e7381 Localisation updates from https://translatewiki.net.
Change-Id: I34cce5cd5975157a7b45409abf0863343a90c29a
2023-09-26 08:45:13 +02:00
thiemowmde c581f0e3bc Favor jQuery's .toggleClass() to reduce code duplication
Change-Id: Ic616ffbfac410849413e8fad6dde260514884efb
2023-09-25 18:59:10 +00:00
Translation updater bot 112f7af925 Localisation updates from https://translatewiki.net.
Change-Id: I4739ba42495affb3ad1cf9476ae328ae6655e41d
2023-09-25 08:47:16 +02:00
Translation updater bot 8488367377 Localisation updates from https://translatewiki.net.
Change-Id: I55853ad501fa7e2a550f25aaf44e81c38c44fcad
2023-09-22 08:47:50 +02:00
jenkins-bot 8d40677037 Merge "Remove the BetaFeatures integration" 2023-09-21 15:29:34 +00:00
jenkins-bot 29689414d4 Merge "Update banana check to use config.MessagesDirs" 2023-09-21 15:07:35 +00:00
Ed Sanders 6730748707 Update banana check to use config.MessagesDirs
Add missing qqq strings so the tests will pass.

Bug: T346170
Change-Id: I7c43cb6db24d5c98341de2de4387689982b35e96
2023-09-21 09:18:30 -05:00
jenkins-bot 9c175e3788 Merge "ApiVisualEditor: Pass section to IntroMessageBuilder" 2023-09-21 11:50:44 +00:00
Translation updater bot 20028b695d Localisation updates from https://translatewiki.net.
Change-Id: I6e1e15e4661d1266b16b12cbd882e97244182356
2023-09-21 10:16:59 +02:00
Translation updater bot d50c8f6114 Localisation updates from https://translatewiki.net.
Change-Id: I5b63d0ffa75645593bb8bcc59d4e470bcd82e26f
2023-09-20 08:56:11 +02:00
Bartosz Dziewoński dcfe952a3f ApiVisualEditor: Pass section to IntroMessageBuilder
Depends-On: I58b90d8e70d538d897d3130ead114d2522ecb703
Change-Id: I205d18b65224acef4f76fb5625bff3bbf002ece6
2023-09-19 20:14:15 +00:00
jenkins-bot 7af308fbd1 Merge "Edit check: Handle the manual citation workflow" 2023-09-19 17:02:31 +00:00
Translation updater bot 879d6da1e2 Localisation updates from https://translatewiki.net.
Change-Id: Ida5a6392c695f9d9e249b5c8ba2006d4d1009c83
2023-09-19 09:26:24 +02:00
Ed Sanders 27c90dcf0a Edit check: Handle the manual citation workflow
Assume that the next window closing promise is from
the plain "Cite" dialog and use that data to resolve
the edit check promise, instead of resolving it
as soon as a manual type is selected.

Bug: T346405
Change-Id: I5b7f084269c9e870446529f63aed27f8ed995e8c
2023-09-18 18:42:01 +01:00
Translation updater bot 00ad2c5ab5 Localisation updates from https://translatewiki.net.
Change-Id: I75bf03b1e85865b55017052e2212e8d52451223e
2023-09-18 08:45:22 +02:00
C. Scott Ananian 43e4a3363b Update comment w/ rename of Article::getRedirectHeaderHtml()
Change-Id: I20f29af6856129bd952bbb003ae967376a203984
Depends-On: I4d0de0e72473ae039dca420a2733bc746d8c2951
2023-09-15 15:14:19 -04:00
jenkins-bot 22bca2a005 Merge "Don't offer visual diffs for non-wikitext pages" 2023-09-14 14:42:03 +00:00
Bartosz Dziewoński 0cfaaa5ff4 Don't offer visual diffs for non-wikitext pages
Bug: T346252
Change-Id: I1be1690b0414bb643f137f74c421ba1034563c7b
2023-09-14 14:22:32 +02:00