Commit graph

16966 commits

Author SHA1 Message Date
jenkins-bot 657d46eace Merge "getPreferredEditor() shouldn't return VisualEditor if it's disabled by the user" 2020-07-08 11:13:16 +00:00
Translation updater bot 04827ba357 Localisation updates from https://translatewiki.net.
Change-Id: I8d15bb25b641fa171e32083611f2d0e830be0343
2020-07-08 09:11:20 +02:00
Bartosz Dziewoński b819b8a657 getPreferredEditor() shouldn't return VisualEditor if it's disabled by the user
Bug: T257234
Change-Id: I68002cc7bf6935bad705497df6531e3611bd2ca6
2020-07-07 21:58:12 +02:00
Bartosz Dziewoński 4ea0cf0cab MobileArticleTarget: Double-check that section is not 'undefined'
It's supposed to be a string or null. The parent class sets
`this.section = null` for us by default.

Bug: T257355
Change-Id: I375a3f6724235f22888bb7f0cb77a7081153768e
2020-07-07 20:50:59 +02:00
Abijeet 24c8b2d2b6 Remove warning shown when editing a translatable page source
Translate itself will show an warning dialog when user tries to edit
a translatable page in visual mode. Editing in the source mode is
allowed.

Bug: T192052
Depends-On: I03ea64353b2d5b28d684f90936cab75ea4fd40d2
Change-Id: Ie4f3a6003c27773c6d0c5086c876fe424befe25a
2020-07-07 11:49:19 +05:30
jenkins-bot 93cc9bcdd6 Merge "Change default value of VisualEditorEnableVisualSectionEditing to 'mobile'" 2020-07-06 19:50:46 +00:00
Akinwale Alagbe 2a581819ec Fix: Adding accessibility labels to Visual Editor template elements
Bug: T245669
Change-Id: I3b792ffde571047d9900920188e92634b8f50298
2020-07-06 18:46:59 +00:00
Translation updater bot 6e749e1904 Localisation updates from https://translatewiki.net.
Change-Id: I73b22d231fdb8248e4b6d6c1afa98821edc135d6
2020-07-06 09:55:11 +02:00
Bartosz Dziewoński 36bd09c429 Also check for revid conflict when RESTBase says page doesn't exist
There used to be similar code here, but it was removed in 2015 in
85b745666f because it wasn't correct in
some cases. Restore it and instead separately check for those cases.

Bug: T257124
Change-Id: Id4a17266111d064805aa0ca865182bb2f4b019eb
2020-07-05 19:42:12 +02:00
Ed Sanders 4000d4fd78 Change default value of VisualEditorEnableVisualSectionEditing to 'mobile'
This is already the default WMF config.

Change-Id: If87e545dfb0d2eb97580c1f83d055d8066b4d9f0
2020-07-03 20:58:57 +01:00
Translation updater bot ed2cfe8fd2 Localisation updates from https://translatewiki.net.
Change-Id: I7f92f5e82fa55705e8bd118f628e7769958810f1
2020-07-03 08:34:25 +02:00
jenkins-bot e358865765 Merge "Replace uses of Revision constants" 2020-07-03 04:18:58 +00:00
Ed Sanders 3ec5e04a37 NWE: Pre-populate editor when editing system messages
This is the same behaviour as EditPage.php

Bug: T256999
Change-Id: Id33161982742c16222ba5d58d2e800ab04dccca2
2020-07-03 04:21:18 +02:00
DannyS712 5fb5bc3060 Replace uses of Revision constants
Bug: T257010
Change-Id: I20c7737d0d00b3f47c2781c1c968db6a74a68ad3
2020-07-03 00:40:59 +00:00
jenkins-bot 1eeab91220 Merge "Add notranslate template to documentation for JSON messages" 2020-07-02 10:48:56 +00:00
Ed Sanders a87939670c ArticleTargetSaver: Use request action to fetch data from response
In DiscussionTools we will use a different action in the save API.

Change-Id: I587ffe2ead1b0706f6ba04947c55630ab1bb6bda
2020-07-02 11:25:26 +01:00
Translation updater bot 27466d6616 Localisation updates from https://translatewiki.net.
Change-Id: I4dcbf07b5b551fc3200ea4a4b1afed5d9a167c47
2020-07-02 08:43:10 +02:00
Translation updater bot 86c6a39225 Localisation updates from https://translatewiki.net.
Change-Id: I30f825b554b8f21fb29ea9e41f1a5ce90c291206
2020-07-01 08:44:20 +02:00
jenkins-bot b5cadac82c Merge "Use standard WikimediaUI theme styles" 2020-06-30 21:57:18 +00:00
Volker E 9c9c86613d Use standard WikimediaUI theme styles
Follow-up to change in OOUI v0.39.2.

Bug: T256713
Change-Id: I09e990222b0068b07f59cc4b6449451b9e5df3d2
2020-06-30 20:37:01 +00:00
Thalia cc4701ecf2 Add notranslate template to documentation for JSON messages
Some of the messages are used for holding JSON objects that are
edited on the wiki, with a default value of "null" in en.json.
Document that this should not be translated.

Change-Id: I0592c63a73dfb583c35e8cbff4f44f2dc3afab55
2020-06-30 18:15:28 +01:00
Translation updater bot 93afcd9ef0 Localisation updates from https://translatewiki.net.
Change-Id: I5130e43b16a584bc2807549b2af53f15d149ab7c
2020-06-30 08:35:21 +02:00
Bartosz Dziewoński c73953a5f7 Fix switching to visual with changes in non-RESTBase mode
Bug: T253467
Change-Id: I02a524a539530f1907f276ef80b666dd446ae6b3
2020-06-29 16:23:02 +00:00
Translation updater bot 5d9f995340 Localisation updates from https://translatewiki.net.
Change-Id: I2260e2ecc6d314aae93c5bd132b9aeb75b512e81
2020-06-29 16:26:51 +02:00
Bartosz Dziewoński b4ae27b82c Update VE core submodule to master (4e1435871)
New changes:
f482cff91 Completion: bugs related to the current input
d1271b362 Completion: Fix exact match logic
21f79b491 Add option to sequences to trigger when deleting content

Bug: T232601
Change-Id: I12bce2478652fa41215ff1c146764a3d2f33fab9
2020-06-29 15:22:24 +02:00
Ed Sanders 458775cc94 screenshots: Run on Windows 10, try to fix resolution
T141369 still applies apparently, so switch back to Windows 10.

Switching to Linux did fix the screen resolution, so try setting
one manually instead.

Change-Id: I3d42fd972f1dbad4302cac1e7e5f052b6cfdb600
2020-06-27 17:42:41 +01:00
Ed Sanders a6d0ca80cf screenshots: Put try catch inside jimp promise
Change-Id: I3c72f024f740a2af882a7651c77ba017ad2e2e97
2020-06-26 21:44:31 +01:00
Ed Sanders 57faec4353 screenshots: Warp jimp call in try/catch
It seems to very occasionally fail, could be a memory exception.

Change-Id: Id2008783872af59348cc43fae8556e671dce4c43
2020-06-26 17:48:27 +01:00
Ed Sanders 3dab0f8339 Follow-up I238632e: Allow etag to be null
Change-Id: I45fec02c3d3560ac10d179e59e75cb5f8210ba14
2020-06-26 17:03:31 +01:00
jenkins-bot aa113a5acf Merge "ApiParsoidTrait: Add typehints" 2020-06-26 13:12:55 +00:00
jenkins-bot 74dc12ccbf Merge "Factor out revision fetching and validation logic to ApiParsoidTrait" 2020-06-26 13:12:51 +00:00
Ed Sanders afc22db25d ApiParsoidTrait: Add typehints
Suggests redundant checks that can be removed.

Change-Id: I238632e0a9af568f7c7a9897c43e4143dc9ebce8
2020-06-26 14:45:16 +02:00
Ed Sanders 703fbaa6a2 Factor out revision fetching and validation logic to ApiParsoidTrait
Change-Id: I7707b419afac2c11d7d0ca91a597ffc68e5e3fe4
2020-06-26 14:44:47 +02:00
jenkins-bot e679ea1e94 Merge "Adds focus visualization to parameter result widget" 2020-06-26 12:40:23 +00:00
bkudiess-msft 748cdffd0b Adds focus visualization to parameter result widget
Bug: T253665
Change-Id: Ie7109375a0d61fb4f8e7b4f6ad54484582c47194
2020-06-26 14:14:57 +02:00
Ed Sanders 9a99bb2ea8 screenshots: Update jimp
Change-Id: I32f663219f9c907d90329b198b962763a6a6a96b
2020-06-26 12:33:23 +01:00
Translation updater bot 343cb4586e Localisation updates from https://translatewiki.net.
Change-Id: I4e971c706aff02a568bae624ed054e7ea5c6fbf8
2020-06-26 09:21:39 +02:00
jenkins-bot dfe642af10 Merge "screenshots: Use Linux instead of Windows" 2020-06-25 18:56:09 +00:00
jenkins-bot e7ec740c74 Merge "screenshots: If setup fails, don't generate a screenshot" 2020-06-25 18:56:06 +00:00
jenkins-bot 5e67eb5cd0 Merge "screenshots: Remove unused beforeEach arg" 2020-06-25 18:56:03 +00:00
jenkins-bot f6f060ce0f Merge "screenshots: Only scale button in citoid button test" 2020-06-25 18:56:00 +00:00
jenkins-bot 15fd62216d Merge "screenshots: Use windowManager promises for save and specialChars" 2020-06-25 18:55:51 +00:00
Ed Sanders 430f32300a screenshots: Use Linux instead of Windows
I suspect this will run faster and be more reliable.

Also hoping it will fix the window size issue.

Change-Id: Iffe7c0d9ef056f98366dfd7f5d0c5e8e32682aa7
2020-06-25 19:04:04 +01:00
Ed Sanders 10a06eb312 screenshots: If setup fails, don't generate a screenshot
Change-Id: I7bd88e3e5d39d92703cdff37cb8e67ecabfb477e
2020-06-25 18:58:46 +01:00
Ed Sanders 56b7844cce screenshots: Remove unused beforeEach arg
Change-Id: I7e12438b030f90eefa29740d21555feb54f795ad
2020-06-25 18:46:29 +01:00
Ed Sanders b559b3adf5 screenshots: Only scale button in citoid button test
Change-Id: I3c41e70053873bc6dd559736e41eb49e735f1749
2020-06-25 18:39:52 +01:00
Ed Sanders 1871ac58ec screenshots: Use windowManager promises for save and specialChars
We already use these for other dialog tests

Change-Id: I24a9a6e5fe2c4cf711b8bc67c8d9bfe23d23041a
2020-06-25 18:36:21 +01:00
jenkins-bot 85ce0a6741 Merge "screenshots: Suppress welcome dialog with query string" 2020-06-25 15:58:10 +00:00
Ed Sanders 085d2443d2 screenshots: Suppress welcome dialog with query string
The code approach appears to suffer from a race condition.

Change-Id: I1328907b8fb55265275493b3b0d2a9288afea53c
2020-06-25 16:10:23 +01:00
Translation updater bot ad8c54ffcb Localisation updates from https://translatewiki.net.
Change-Id: I026c355f40deb577b4df199d222e2c76fb3e273a
2020-06-25 08:59:20 +02:00