wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 08:10:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "screenshots: If setup fails, don't generate a screenshot"

Browse source
This commit is contained in:
jenkins-bot 2020-06-25 18:56:06 +00:00 committed by Gerrit Code Review
parent 5e67eb5cd0 10a06eb312
commit e7ec740c74
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
build/screenshots.js
View file

@ -43,6 +43,8 @@ function createScreenshotEnvironment( test ) {
}, function ( e ) {
// Log error (timeout)
console.error( e.message );
// Setup failed, set clientSize to null so no screenshots are generated
clientSize = null;
} )
);
} );
@ -72,6 +74,11 @@ function createScreenshotEnvironment( test ) {
}
function runScreenshotTest( name, lang, clientScript, padding ) {
if ( !clientSize ) {
// Setup failed, don't generated a broken screenshot
return;
}
const filename = './screenshots/' + name + '-' + lang + '.png';
driver.manage().timeouts().setScriptTimeout( TIMEOUT );